[Bug 1306945] Review Request: ohc - Java large off heap cache

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1306945



--- Comment #11 from jiri vanek <jvanek at redhat.com> ---
Hello! The launchers seems not to be working.
The  ohc-batch-bench is misisng dependences. You have put just main jar to
classapth. You need all dependencies to..
Also I think that you can drop `which java` and just keep java. (but I may miss
why you did it)
I changed : 
....
jar=/usr/share/java/guava.jar:/usr/share/java/jmh/jmh-core.jar:/usr/share/java/slf4j/nop.jar:/usr/share/java/slf4j/api.jar:/usr/share/java/slf4j/simple.jar:/usr/share/java/slf4j/slf4j-api.jar:/usr/share/java/slf4j/slf4j-nop.jar:/usr/share/java/slf4j/slf4j-simple.jar:/usr/share/java/metrics/metrics-core.jar:/usr/share/java/commons-math3.jar:/usr/share/java/log4j.jar:/usr/share/java/jna.jar:/usr/share/java/commons-cli.jar:/usr/share/java/apache-commons-cli.jar:/usr/share/java/apache-commons-math.jar:/usr/share/java/log4j/log4j-to-slf4j.jar:/usr/share/java/log4j/log4j-slf4j-impl.jar:/usr/share/java/log4j/log4j-iostreams.jar:/usr/share/java/log4j/log4j-jul.jar:/usr/share/java/log4j/log4j-core.jar:/usr/share/java/log4j/log4j-api.jar:/usr/share/java/log4j/log4j-1.2-api.jar:/usr/share/java/jopt-simple/jopt-simple.jar:/usr/share/java/ohc/ohc-benchmark.jar:/usr/share/java/ohc/ohc-jmh.jar:/usr/share/java/ohc/ohc-core.jar:/usr/share/java/ohc/ohc-core-j8.jar

#if [ ! -f $jar ] ; then
#    echo "Executable jar file $jar does not exist" > /dev/stderr
#    exit 1
#fi
java -cp $jar org.caffinitas.ohc.benchmark.BenchmarkOHC -h > /dev/null
if [ ! $? ] ; then
    echo "Cannot execute ohc-benchmark jar file $jar" > /dev/stderr
    exit 1
fi
...
To make it work. Please dont copypaste my chnagehs, they may nto be enough
(best is to generate launcher for ohc-benchmark.jar package, and then copypaste
generated classpath :)
Also you need to require "time" package , as the script is calling "time" (dont
confuse it with embedded shell function time)

After that I had quite a lot of cvs files to tes second launcher, and that
worked fine


One fatal issue I overlooked in first iteration
 - you have main classes in jar:
  - ohc-benchmark.jar have org.caffinitas.ohc.benchmark.BenchmarkOHC
  - thats forbidden by guidelines


Also there is:
Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory

But I was nto able to reproduce it.

Please fix the launcher and the main class ( I guess you need to remove maven
attribute which is setting it)

Few more notes -
%jpackage_script - maybe prefix the launcher by ohc too?
chmod 755  - its better to specifi this in filles like
http://pkgs.fedoraproject.org/cgit/rpms/java-1.8.0-openjdk.git/tree/java-1.8.0-openjdk.spec#n516
(just without ghosts :) )

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component