[Bug 1270357] Review Request: nacl-gcc - Various compilers (C, C++) for nacl

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1270357



--- Comment #3 from Tom "spot" Callaway <tcallawa at redhat.com> ---
I'm not a fan of the "super macros" you've suggested, with the exception of
%license. I'd rather know exactly what's going on there and be able to tweak
it. Also, autosetup doesn't allow for the use of patch specific suffixes, which
makes it very easy to rediff patches when upstream changes.

As to %check, I'm not sure that Google has bothered to add nacl specific
checks. They seem to only be supporting nacl in a legacy state at this point,
despite pNacl depending on it.

New SPEC: https://spot.fedorapeople.org/nacl-gcc.spec
New SRPM:
https://spot.fedorapeople.org/nacl-gcc-4.4.3-16.20150504gitf80d6b9.fc24.src.rpm

- fix versioning
- remove ancient conditionals
- fix ExclusiveArch to be only for x86_64
- use license tag for COPYING files
- improve summary and description
- add smp_mflags to make invocations in build

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component