<html>
<head>
<base href="https://bugzilla.redhat.com/" />
</head>
<body><span class="vcard "><a class="email" href="mailto:misc@zarb.org" title="Michael Scherer <misc@zarb.org>"> <span class="fn">Michael Scherer</span></a>
</span>
changed <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Review Request: opennebula - Cloud computing tool to manage a distributed virtual data center to build private, public and hybrid IaaS clouds"
href="https://bugzilla.redhat.com/show_bug.cgi?id=815001">Bug 815001</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>misc@zarb.org
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - Review Request: opennebula - Cloud computing tool to manage a distributed virtual data center to build private, public and hybrid IaaS clouds"
href="https://bugzilla.redhat.com/show_bug.cgi?id=815001#c5">Comment # 5</a>
from <span class="vcard "><a class="email" href="mailto:misc@zarb.org" title="Michael Scherer <misc@zarb.org>"> <span class="fn">Michael Scherer</span></a>
</span></b>
<pre>A few comment
- I think the spec layout is rather difficult. While I know everybody has
specific preference, I think it would be better to group various %post/%pre
script together ( as I missed the one creating oneadmin )
- patches should be commented
<a href="https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment">https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment</a>
- is it required to have mysql server on the same computer ? If not, I think
the requires could be relaxed.
- %setup -q -n opennebula-3.2.1
You should reuse %version, so this is easier to upgrade later
- why is the whole .ssh populated in %post, would it better to do it like any
other file, with rpm ? ( at least the .ssh/config ), and using %ghost so rpm
can manage and check the permission of all file ?
- apg is used in a %post script, but the requires is missing ( Requires(post):
)
- why do the documentation requires the main packages ?
- why do sunstone requires the main package ? According to
<a href="http://opennebula.org/documentation:archives:rel2.2:sunstone">http://opennebula.org/documentation:archives:rel2.2:sunstone</a> , they can be
separated, and I would surely see good reason to deploy them on 2 differents
server, for security reason.
- From a quick check in open nebula doc, it is not clear why openssh server
should be installed on the main hypervisor, could you explain why it is
required ?
- a oneadmin user is needed on the frontend, but also on the host. So I would
suggest to create a package to be used on host that would create the user.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>