<html>
<head>
<base href="https://bugzilla.redhat.com/" />
</head>
<body><span class="vcard redhat_user"><a class="email" href="mailto:hdegoede@redhat.com" title="Hans de Goede <hdegoede@redhat.com>"> <span class="fn">Hans de Goede</span></a>
</span>
changed <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED --- - Review Request: mingw-usbredir - MinGW USB network redirection protocol libraries"
href="https://bugzilla.redhat.com/show_bug.cgi?id=823641">Bug 823641</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>ASSIGNED
</td>
</tr>
<tr>
<td style="text-align:right;">Assignee</td>
<td>nobody@fedoraproject.org
</td>
<td>hdegoede@redhat.com
</td>
</tr>
<tr>
<td style="text-align:right;">Flags</td>
<td>
</td>
<td>fedora-review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED --- - Review Request: mingw-usbredir - MinGW USB network redirection protocol libraries"
href="https://bugzilla.redhat.com/show_bug.cgi?id=823641#c1">Comment # 1</a>
from <span class="vcard redhat_user"><a class="email" href="mailto:hdegoede@redhat.com" title="Hans de Goede <hdegoede@redhat.com>"> <span class="fn">Hans de Goede</span></a>
</span></b>
<pre>Full review done:
Good:
--------
- rpmlint checks return:
mingw32-usbredir-debuginfo.noarch: E: debuginfo-without-sources
mingw32-usbredir-static.noarch: W: no-documentation
mingw64-usbredir-debuginfo.noarch: E: debuginfo-without-sources
mingw64-usbredir-static.noarch: W: no-documentation
7 packages and 0 specfiles checked; 2 errors, 2 warnings.
^^These are all expected for mingw packages, so no problem here ^^
- package meets naming guidelines
- package meets packaging guidelines
- license (LGPLv2+) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- locales properly handled
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
Should fix:
---------------
- There is a "rm -rf $RPM_BUILD_ROOT" in your %install, this is not needed with
modern rpm versions, and
should not be there unless you also manually specify a buildroot and have a
manual %clean section
- BuildRequires: mingw*-libusb1 likely needs to become BuildRequires:
mingw*-libusbx see the
mingw-libusb1 review.
Please fix both of these before building for the first time.
No blockers -> Approved!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>