[Fedora-packaging] Use of dos2unix in %prep
Denis Leroy
denis at poolshark.org
Fri Jan 23 10:39:37 UTC 2009
Toshio Kuratomi wrote:
> Nicolas Mailhot wrote:
>> Le Jeu 22 janvier 2009 00:53, Toshio Kuratomi a écrit :
>>
>>> This discussion has ranged far afield of the original post.
>>>
>>> So, does anyone know of a reason to keep the dos2unix warning?
>> Is there anything dos2unix does which can not be done by standard
>> tools like sed?
>>
>> for txt in *.txt ; do
>> iconv -f WINDOWS-1252 -t UTF-8 -o $txt.1 $txt
>> fold -s $txt.1 > $txt.2
>> sed -i 's/\r//' $txt.2
>> touch -r $txt $txt.2
>> mv $txt.2 $txt
>> rm $txt.1
>> done
>>
> I don't know of any.
The whole point is to replace those 8 confusing lines of scripting with
a simple call. It makes the spec file easier to read.
> But we shouldn't be telling people they must not
> use dos2unix (with a proper BuildRequires) if there's no actual problem.
+1
More information about the packaging
mailing list