[perl-Module-Manifest/el6] Minor spec file clean-ups

Paul Howarth pghmcfc at fedoraproject.org
Mon Aug 8 12:44:29 UTC 2011


commit 74b686b2d9ef9b6db79aead5bee2cc458b5299f1
Author: Paul Howarth <paul at city-fan.org>
Date:   Mon Aug 8 13:33:29 2011 +0100

    Minor spec file clean-ups
    
    - Don't use macros for commands
    - Make %files list more explicit

 perl-Module-Manifest.spec |   19 +++++++++----------
 1 files changed, 9 insertions(+), 10 deletions(-)
---
diff --git a/perl-Module-Manifest.spec b/perl-Module-Manifest.spec
index c016f5d..1544b81 100644
--- a/perl-Module-Manifest.spec
+++ b/perl-Module-Manifest.spec
@@ -6,7 +6,7 @@ License:        GPL+ or Artistic
 Group:          Development/Libraries
 URL:            http://search.cpan.org/dist/Module-Manifest/
 Source0:        http://www.cpan.org/authors/id/A/AD/ADAMK/Module-Manifest-%{version}.tar.gz
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
 BuildArch:      noarch
 BuildRequires:  perl >= 0:5.005
 BuildRequires:  perl(ExtUtils::MakeMaker)
@@ -16,7 +16,7 @@ BuildRequires:  perl(Test::More) >= 0.42
 BuildRequires:  perl(Test::Warn) >= 0.11
 Requires:       perl(File::Spec) >= 0.80
 Requires:       perl(Params::Util) >= 0.10
-Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 
 %description
 Module::Manifest is a simple utility module created originally for use in
@@ -29,18 +29,15 @@ Module::Inspector.
 chmod -c -x examples/difference.pl
 
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+perl Makefile.PL INSTALLDIRS=vendor
 make %{?_smp_mflags}
 
 %install
 rm -rf $RPM_BUILD_ROOT
-
 make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
-
 find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;
-find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
-
-%{_fixperms} $RPM_BUILD_ROOT/*
+find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} \; 2>/dev/null
+%{_fixperms} $RPM_BUILD_ROOT
 
 %check
 make test
@@ -51,14 +48,16 @@ rm -rf $RPM_BUILD_ROOT
 %files
 %defattr(-,root,root,-)
 %doc Changes LICENSE README examples
-%{perl_vendorlib}/*
-%{_mandir}/man3/*
+%{perl_vendorlib}/Module/
+%{_mandir}/man3/Module::Manifest.3pm*
 
 %changelog
 * Mon Aug  8 2011 Paul Howarth <paul at city-fan.org> - 1.08-5
 - Fix sample script permissions in %%prep rather than %%install
 - Drop Test::Exception version requirement to 0.26 for EPEL-4/5 compatibility
   (test suite still passes)
+- Don't use macros for commands
+- Make %%files list more explicit
 
 * Wed Jul 20 2011 Petr Sabata <contyk at redhat.com> - 1.08-4
 - Perl mass rebuild



More information about the perl-devel mailing list