<div dir="ltr"><a href="https://bugzilla.redhat.com/show_bug.cgi?id=1276933">https://bugzilla.redhat.com/show_bug.cgi?id=1276933</a><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Oct 31, 2015 at 10:38 AM, Zbigniew Jędrzejewski-Szmek <span dir="ltr"><<a href="mailto:zbyszek@in.waw.pl" target="_blank">zbyszek@in.waw.pl</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Fri, Oct 30, 2015 at 01:33:49PM -0400, Neal Becker wrote:<br>
> An initial srpm is here:<br>
><br>
> <a href="https://nbecker.fedorapeople.org/python-cycler-0.9.0-1.fc22.src.rpm" rel="noreferrer" target="_blank">https://nbecker.fedorapeople.org/python-cycler-0.9.0-1.fc22.src.rpm</a><br>
</span>This is so simple, let's get this done quickly.<br>
<br>
1. Please change Source to <a href="https://github.com/matplotlib/%{srcname}/archive/v%{version}.tar.gz#/python-%{srcname}.tar.gz" rel="noreferrer" target="_blank">https://github.com/matplotlib/%{srcname}/archive/v%{version}.tar.gz#/python-%{srcname}.tar.gz</a><br>
<br>
The archive on pypi is missing license. It seems more reasonable to use<br>
github directly than to fight around that.<br>
<br>
2. I think the summary should be something less cute. "Composable style<br>
cycles" only works if you already know what the package does.<br>
<br>
(I think that this package shows the power of the new Python macros from<br>
bkabrda and others... The spec file is very readable and maintainable.)<br>
<br>
If you submit a Review Request, I promise to hit the fedora-review+ button<br>
promptly.<br>
<br>
Zbyszek<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><i>Those who don't understand recursion are doomed to repeat it</i></div></div>
</div>