Review Request 23: Bugzilla Faults During Proposal are not logged, lead to http 500 errors

Tim Flink fedoraqa.devel at gmail.com
Mon Apr 29 17:50:54 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/23/#review30
-----------------------------------------------------------


Code looks good but I'd like to see some test cases for this as well

- Tim Flink


On April 24, 2013, 10:38 a.m., Martin Krizek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/23/
> -----------------------------------------------------------
> 
> (Updated April 24, 2013, 10:38 a.m.)
> 
> 
> Review request for blockerbugs.
> 
> 
> Bugs: 372
>     https://fedorahosted.org/fedora-qa/ticket/372
> 
> 
> Repository: blockerbugs
> 
> 
> Description
> -------
> 
> This patch wraps bugzilla faults in a BugzillaError and prevents them from not being logged and generating http 500 server error.
> 
> 
> Diffs
> -----
> 
>   blockerbugs/util/bz_interface.py 0579b2455b57a03e3bee570b8cd97aac0eeaf1a4 
>   blockerbugs/controllers/main.py 6d32e5de91900cda33f5e0342c7854adb24fc8b6 
> 
> Diff: http://reviewboard-tflink.rhcloud.com/r/23/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Krizek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.fedoraproject.org/pipermail/qa-devel/attachments/20130429/8d79a65b/attachment.html>


More information about the qa-devel mailing list