Review Request 36: improve update syncs

[Tim Flink]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/36/#review57
-----------------------------------------------------------



blockerbugs/controllers/main.py
<http://reviewboard-tflink.rhcloud.com/r/36/#comment88>

    minor phrasing nit: which are 'pending stable' in bodhi and are marked as fixing any non-rejected blocker/fe bug



blockerbugs/controllers/main.py
<http://reviewboard-tflink.rhcloud.com/r/36/#comment89>

    similar phrasing nit: which are 'updates testing' in bodhi (not updates testing pending) and are marked as fixing any non-rejected blocker/fe bug



blockerbugs/util/update_sync.py
<http://reviewboard-tflink.rhcloud.com/r/36/#comment90>

    I don't understand the reason for this change - it seems purely stylistic



blockerbugs/util/update_sync.py
<http://reviewboard-tflink.rhcloud.com/r/36/#comment91>

    good catch



testing/testfunc_update_sync.py
<http://reviewboard-tflink.rhcloud.com/r/36/#comment92>

    I'd rather keep these on separate lines - it make the data much easier to read



testing/testfunc_update_sync.py
<http://reviewboard-tflink.rhcloud.com/r/36/#comment93>

    I don't understand why all this update data is being defined statically - couldn't you get the same effect by generating almost identical updates and just changing the bits that you need to change?


Found a few other things, looks good functionally, though. I think most of this is minor stuff

- Tim Flink


On July 19, 2013, 7:05 p.m., Ilgiz Islamgulov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/36/
> -----------------------------------------------------------
> 
> (Updated July 19, 2013, 7:05 p.m.)
> 
> 
> Review request for blockerbugs.
> 
> 
> Repository: blockerbugs
> 
> 
> Description
> -------
> 
> Add partial updates sync.
> Display proposed/accepted fe/blocker bugs list associated with update on update list web page.
> 
> 
> Diffs
> -----
> 
>   testing/testfunc_update_sync.py 69f6bf8a459c71a9325cd633e7e33ce29354d7cd 
>   testing/test_updatesync_extract_information.py 1fc701ef79a74e27cf8223b56a04d63025b6509f 
>   testing/test_controllers.py f351832ad4350fcff3d67c0137ff62892639e908 
>   blockerbugs/util/update_sync.py d664839ec1c5979dce980e7baad58154f4622e11 
>   blockerbugs/util/bug_sync.py 49cce49740cd6f5b1f430f58c8d1b522e1f0b7e3 
>   blockerbugs/templates/update_list.html a83dd9a422e51ea58e04ae58acd8fefe6eb1f79f 
>   blockerbugs/models/update.py 2ee3ca7ee62bd55bbd71555c13fecfab504c4f07 
>   blockerbugs/controllers/main.py 4f23e35558ac3f8ed2ccc5d897b2219e449e7277 
>   blockerbugs/cli.py 694736d098b6285c53db91f91350360d478c4229 
> 
> Diff: http://reviewboard-tflink.rhcloud.com/r/36/diff/
> 
> 
> Testing
> -------
> 
> Wrote test suites.
> I've tested on my develop instance.
> 
> 
> Thanks,
> 
> Ilgiz Islamgulov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.fedoraproject.org/pipermail/qa-devel/attachments/20130802/fedc200c/attachment-0001.html>