Review Request 41: Login cleanup + redirect fix
Tim Flink
fedoraqa.devel at gmail.com
Fri Aug 2 15:02:56 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/41/#review58
-----------------------------------------------------------
Ship it!
Looks good to me
- Tim Flink
On Aug. 1, 2013, 9:26 a.m., Martin Krizek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/41/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2013, 9:26 a.m.)
>
>
> Review request for blockerbugs.
>
>
> Repository: blockerbugs
>
>
> Description
> -------
>
> commit 5d646f767451cdc5c544b2c5b9bdbbf572628bf3
> Author: Martin Krizek <mkrizek at redhat.com>
> Date: Thu Aug 1 11:21:21 2013 +0200
>
> Redirect to the previous url after login from the main page
>
> The patch also cleans up a login form that is no longer used.
>
>
> Diffs
> -----
>
> blockerbugs/templates/layout.html 8dc6deacd5e7a71757ed2564fb224b3cd92bfad5
> blockerbugs/controllers/users.py e14c6c5f0f73404a3a61949c554815f89c2e028d
>
> Diff: http://reviewboard-tflink.rhcloud.com/r/41/diff/
>
>
> Testing
> -------
>
> Logging in via the button in the header works and redirects to the previous page according to my testing.
>
>
> Thanks,
>
> Martin Krizek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.fedoraproject.org/pipermail/qa-devel/attachments/20130802/6af88353/attachment.html>
More information about the qa-devel
mailing list