Review Request 45: Improve asset management

Martin Krizek fedoraqa.devel at gmail.com
Mon Aug 19 14:54:15 UTC 2013



> On Aug. 15, 2013, 4:06 p.m., Tim Flink wrote:
> > The problem here is how to deploy this in production - there is a python-flask-assets package but it is at 0.7 instead of upstream's 0.8 and there does not appear to be an el6 build either way (branch exists but it's empty).
> > 
> > Once the dep is figured out and the spec updated, we can talk about getting this code in but right now it can't be deployed to production

I sent an e-mail to the author of the package asking about the state of the package. We'll see...


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/45/#review65
-----------------------------------------------------------


On Aug. 12, 2013, 2:46 p.m., Martin Krizek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/45/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2013, 2:46 p.m.)
> 
> 
> Review request for blockerbugs.
> 
> 
> Bugs: 357
>     https://fedorahosted.org/fedora-qa/ticket/357
> 
> 
> Repository: blockerbugs
> 
> 
> Description
> -------
> 
> commit d86f88d7f9da899ffef44ad617a8a831327b7d80
> Author: Martin Krizek <mkrizek at redhat.com>
> Date:   Mon Aug 12 16:40:16 2013 +0200
> 
>     Improve asset management
>     
>     Fixes: #357
> 
> 
> I have not minified two js files in milestone_stats.html template as I am not sure it's worth it, any objections?
> 
> 
> Diffs
> -----
> 
>   requirements.txt 09e0318bc189512f5d324bda8879ad74c4763f95 
>   blockerbugs/templates/layout.html 49cdbd70ef8347965dfca93971449688f9cd6cb0 
>   blockerbugs/__init__.py bd9973579e80fc859f3e8d22c35753fbd024c5f0 
> 
> Diff: http://reviewboard-tflink.rhcloud.com/r/45/diff/
> 
> 
> Testing
> -------
> 
> Loaded pages, seems like css and js work as expected after being minified.
> 
> 
> Thanks,
> 
> Martin Krizek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.fedoraproject.org/pipermail/qa-devel/attachments/20130819/bf07fcc1/attachment.html>


More information about the qa-devel mailing list