Review Request 42: Indicate bugs that are needinfo

[Tim Flink]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/42/#review82
-----------------------------------------------------------



blockerbugs/static/css/app.css
<http://reviewboard-tflink.rhcloud.com/r/42/#comment130>

    I think that not using the same yellow would be better here - color is an easy way to differentiate between the two icons in most cases. Either way, could you make this a constant in _settings.scss instead of a hardcoded value?
    
    maybe darken($fedoraPurple, 10%) or something that isn't that yellow or blue.


still some nitpicking on the color :-/

- Tim Flink


On Aug. 26, 2013, 11:28 a.m., Martin Krizek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/42/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2013, 11:28 a.m.)
> 
> 
> Review request for blockerbugs.
> 
> 
> Bugs: 316
>     https://fedorahosted.org/fedora-qa/ticket/316
> 
> 
> Repository: blockerbugs
> 
> 
> Description
> -------
> 
> This patch adds a needinfo field into the Bug table. The field is filed with the name of a user that the info is needed from, or empty string if needinfo is not set. If needinfo is set, an icon is displayed in bug list in the same way as the 'recently modified' icon -- any ideas on how to display the information better?
> 
> 
> Diffs
> -----
> 
>   sass/app.scss 061016495d9c46aef0efb5dcfc9e3a5eab43f72c 
>   blockerbugs/util/bug_sync.py 49cce49740cd6f5b1f430f58c8d1b522e1f0b7e3 
>   blockerbugs/templates/blocker_list.html 17cdc74d5cac7be3d3843196eeda9e01f1c91ff3 
>   blockerbugs/static/css/app.css 99b6fbc81b231c7f876f1365cfc63f6eade1217e 
>   blockerbugs/static/css/app-foundation.css 852272bf1bd1c629b30933b451daceec31812de7 
>   blockerbugs/models/bug.py 095cf7294a5b0a5b3fb9979abf9e669e4acd157c 
>   alembic/versions/23cc8daafea8_add_needinfo_to_bug.py PRE-CREATION 
> 
> Diff: http://reviewboard-tflink.rhcloud.com/r/42/diff/
> 
> 
> Testing
> -------
> 
> Run db sync, one of the bugs had needinfo flag set, everything worked as expected.
> 
> 
> Thanks,
> 
> Martin Krizek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.fedoraproject.org/pipermail/qa-devel/attachments/20130827/eb12f7db/attachment.html>