Review Request 52: Clean leftovers missed in reviews

Tim Flink fedoraqa.devel at gmail.com
Thu Sep 19 19:47:23 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/52/#review96
-----------------------------------------------------------


I'm OK with removing the --logfile option from the CLI parser but let's hold off on the user changes since ilgiz has already addressed those issues. I'd rather not be fixing that in multiple places at the same time - it's a great recipe for confusion and merge issues

- Tim Flink


On Sept. 13, 2013, 11:08 a.m., Martin Krizek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-tflink.rhcloud.com/r/52/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2013, 11:08 a.m.)
> 
> 
> Review request for blockerbugs.
> 
> 
> Repository: blockerbugs
> 
> 
> Description
> -------
> 
> While going through documentation and commits since last release I found some leftovers missed in reviews.
> 
> 
> Diffs
> -----
> 
>   blockerbugs/controllers/main.py a41627485a77daecc07c8d33f41dc5a17e2ebb97 
>   blockerbugs/cli.py 7151337aa1e16e571d0cf165c87c3c6f50276b90 
> 
> Diff: http://reviewboard-tflink.rhcloud.com/r/52/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Krizek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.fedoraproject.org/pipermail/qa-devel/attachments/20130919/05eccf68/attachment.html>


More information about the qa-devel mailing list