<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard-tflink.rhcloud.com/r/23/">http://reviewboard-tflink.rhcloud.com/r/23/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 2nd, 2013, 5:09 a.m. UTC, <b>Tim Flink</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://reviewboard-tflink.rhcloud.com/r/23/diff/2/?file=371#file371line85" style="color: black; font-weight: bold; text-decoration: underline;">testing/test_bugchange.py</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">85</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">test_bz</span><span class="o">.</span><span class="n">_do_proposal</span> <span class="o">=</span> <span class="n">exception_raiser</span><span class="p">(</span><span class="n">Fault</span><span class="p">(</span><span class="mi">50</span><span class="p">,</span> <span class="s">'not 51 exception'</span><span class="p">))</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I realize that I'm being picky here but why are you effectively monkeypatching the do_proposal method and creating a Dingus that effectively does nothing in this case?
Wouldn't it be closer to actual behavior to have the Dingus throw a fault instead of swapping out the do_proposal method?
Either way, I'd rather see one approach or the other - creating mock-ish objects that aren't actually used is not a good practice to get into</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good point. Patch updated.</pre>
<br />
<p>- Martin</p>
<br />
<p>On May 2nd, 2013, 10:27 a.m. UTC, Martin Krizek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-tflink.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for blockerbugs.</div>
<div>By Martin Krizek.</div>
<p style="color: grey;"><i>Updated May 2, 2013, 10:27 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://fedorahosted.org/fedora-qa/ticket/372">372</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
blockerbugs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch wraps bugzilla faults in a BugzillaError and prevents them from not being logged and generating http 500 server error.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>testing/test_bugchange.py <span style="color: grey">(596e922283bfd20fc0ac6811aa1eef3ef45378ea)</span></li>
<li>blockerbugs/util/bz_interface.py <span style="color: grey">(0579b2455b57a03e3bee570b8cd97aac0eeaf1a4)</span></li>
<li>blockerbugs/controllers/main.py <span style="color: grey">(6d32e5de91900cda33f5e0342c7854adb24fc8b6)</span></li>
</ul>
<p><a href="http://reviewboard-tflink.rhcloud.com/r/23/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>