<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard-tflink.rhcloud.com/r/39/">http://reviewboard-tflink.rhcloud.com/r/39/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 17th, 2013, 5:19 a.m. UTC, <b>Tim Flink</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Don't python-openid-cla and python-openid-teams need to be added to the requirements.txt file? Does the python-fedora stuff really need to be added to site-packages by hand with the bump in required python fedora version?
What all of that list is going to be required above and beyond the changes shown here? I'm not crazy about the idea of releasing like that but I'm suspecting that most of it would go away once a new python-fedora release is done</pre>
</blockquote>
<p>On July 17th, 2013, 9:45 a.m. UTC, <b>Martin Krizek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Exactly, this is only temporary since python-fedora containing flask_fas_openid.py hasn't been released yet (to my knowledge, at least). Sorry for not pointing that out.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">since the fas-openid stuff has been hotfixed into the infra hosts and it might be a bit before we see a new python-fedora release, let's get this into develop. I'd like to get testing on our dev host soon and am planning to hotfix the flask-fas-openid stuff into our dev host</pre>
<br />
<p>- Tim</p>
<br />
<p>On July 16th, 2013, 12:43 p.m. UTC, Martin Krizek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-tflink.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for blockerbugs.</div>
<div>By Martin Krizek.</div>
<p style="color: grey;"><i>Updated July 16, 2013, 12:43 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://fedorahosted.org/fedora-qa/ticket/383">383</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
blockerbugs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">commit 211eafe3e90012dce2e99e0fb2f89fbb900062b7
Author: Patrick Uiterwijk <puiterwijk@gmail.com>
Date: Thu May 2 10:33:05 2013 +0200
Port blockerbugs to OpenID</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To make this work, following things need to be done:
wget https://raw.github.com/fedora-infra/python-fedora/develop/flask_fas_openid.py
# apply http://mkrizek.fedorapeople.org/0001-flask_fas_openid.py-fix-imports.patch (sent to Patrick Uiterwijk)
cp flask_fas_openid.py site-packages
pip install python-openid-cla
pip install python-openid-teams</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>requirements.txt <span style="color: grey">(e5aeb0dfeeadb5637ddd7f6aafd9fe07ef576c23)</span></li>
<li>blockerbugs/templates/login.html <span style="color: grey">(6023c25e3436257c1c6a1027a9b37ec21f62cee9)</span></li>
<li>blockerbugs/controllers/users.py <span style="color: grey">(6f89a0b29143a9c09fcf25d97d875a01b9955fa4)</span></li>
<li>blockerbugs/__init__.py <span style="color: grey">(798fc6ecd562d1e13fbba26f804f74e6da670120)</span></li>
</ul>
<p><a href="http://reviewboard-tflink.rhcloud.com/r/39/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>