<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard-tflink.rhcloud.com/r/38/">http://reviewboard-tflink.rhcloud.com/r/38/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Overall looks pretty good. if we can get the traceback figured out (either fix it or determine that there's something off in my dev env) let's get it merged into develop. We don't have a lot of time before F20 branches, and we did commit to moving over to fas-openid.
It might be a while before a new python-fedora release is made, but the fas-openid code is already hotfixed into infra hosts and I'm planning to do the same to our dev host</pre>
<br />
<p>- Tim Flink</p>
<br />
<p>On July 18th, 2013, 9:35 a.m. UTC, Martin Krizek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-tflink.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for blockerbugs.</div>
<div>By Martin Krizek.</div>
<p style="color: grey;"><i>Updated July 18, 2013, 9:35 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
blockerbugs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">commit e08c8ee1085bb0beb71b4a5c98c9d2e2497773cb
Author: Martin Krizek <mkrizek@redhat.com>
Date: Mon Jul 15 11:28:09 2013 +0200
Use fake login only in DEV environment
commit 8f175a28ae43b764e52435d174d73e2dc384bd6b
Author: Martin Krizek <mkrizek@redhat.com>
Date: Thu Jul 4 11:14:40 2013 +0200
Add developer login
This patch allows a fake login when DEV or TEST is set so we don't
access FAS server each time we log in.
TODO this will be merged with changes made in other review request dealing with fas-openid migrations.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>blockerbugs/util/login.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>blockerbugs/templates/layout.html <span style="color: grey">(8dc6deacd5e7a71757ed2564fb224b3cd92bfad5)</span></li>
<li>blockerbugs/controllers/users.py <span style="color: grey">(6f89a0b29143a9c09fcf25d97d875a01b9955fa4)</span></li>
<li>blockerbugs/controllers/main.py <span style="color: grey">(a8082121576015a86c31bc76ebc17e982062a08b)</span></li>
<li>blockerbugs/__init__.py <span style="color: grey">(798fc6ecd562d1e13fbba26f804f74e6da670120)</span></li>
</ul>
<p><a href="http://reviewboard-tflink.rhcloud.com/r/38/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>