<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard-tflink.rhcloud.com/r/36/">http://reviewboard-tflink.rhcloud.com/r/36/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me - it's now working in my dev env with that last change.
For future code, can you not make arbitrary stylistic changes to logic unless you're in that code? I'm not going to say "back the changes out" this time but it adds churn when it's not really needed.</pre>
<br />
<p>- Tim Flink</p>
<br />
<p>On August 16th, 2013, 1:58 p.m. UTC, Ilgiz Islamgulov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-tflink.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for blockerbugs.</div>
<div>By Ilgiz Islamgulov.</div>
<p style="color: grey;"><i>Updated Aug. 16, 2013, 1:58 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
blockerbugs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add partial updates sync.
Display proposed/accepted fe/blocker bugs list associated with update on update list web page.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wrote test suites.
I've tested on my develop instance.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>testing/testfunc_update_sync.py <span style="color: grey">(69f6bf8a459c71a9325cd633e7e33ce29354d7cd)</span></li>
<li>testing/test_updatesync_extract_information.py <span style="color: grey">(1fc701ef79a74e27cf8223b56a04d63025b6509f)</span></li>
<li>testing/test_controllers.py <span style="color: grey">(f351832ad4350fcff3d67c0137ff62892639e908)</span></li>
<li>blockerbugs/util/update_sync.py <span style="color: grey">(d664839ec1c5979dce980e7baad58154f4622e11)</span></li>
<li>blockerbugs/util/bug_sync.py <span style="color: grey">(49cce49740cd6f5b1f430f58c8d1b522e1f0b7e3)</span></li>
<li>blockerbugs/templates/update_list.html <span style="color: grey">(a83dd9a422e51ea58e04ae58acd8fefe6eb1f79f)</span></li>
<li>blockerbugs/models/update.py <span style="color: grey">(2ee3ca7ee62bd55bbd71555c13fecfab504c4f07)</span></li>
<li>blockerbugs/controllers/main.py <span style="color: grey">(e00593a6835d8d679ee155d7da02c452ce4827d1)</span></li>
<li>blockerbugs/cli.py <span style="color: grey">(694736d098b6285c53db91f91350360d478c4229)</span></li>
<li>.gitignore <span style="color: grey">(c5f8d92163a31685a35109eb4847315d9ebcd220)</span></li>
</ul>
<p><a href="http://reviewboard-tflink.rhcloud.com/r/36/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>