<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard-tflink.rhcloud.com/r/46/">http://reviewboard-tflink.rhcloud.com/r/46/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 30th, 2013, 8:18 a.m. UTC, <b>Martin Krizek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://reviewboard-tflink.rhcloud.com/r/46/diff/4-5/?file=966#file966line21" style="color: black; font-weight: bold; text-decoration: underline;">alembic/versions/1162fb4d4358_added_build_table.py</a>
<span style="font-weight: normal;">
(Diff revisions 4 - 5)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">21</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">sa</span><span class="o">.</span><span class="n">Column</span><span class="p">(</span><span class="s">'pkg_name'</span><span class="p">,</span> <span class="n">sa</span><span class="o">.</span><span class="n"><span class="hl">String</span></span><span class="p">(),</span> <span class="n">nullable</span><span class="o">=</span><span class="bp">True</span><span class="p">),</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">21</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">sa</span><span class="o">.</span><span class="n">Column</span><span class="p">(</span><span class="s">'pkg_name'</span><span class="p">,</span> <span class="n">sa</span><span class="o">.</span><span class="n"><span class="hl">Text</span></span><span class="p">(),</span> <span class="n">nullable</span><span class="o">=</span><span class="bp">True</span><span class="p">),</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, I wasn't probably being clear, I meant whether we should change e.g. sa.Column('version', sa.String(), nullable=True), to sa.Column('version', sa.String(50), nullable=True), and so on.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I found that koji use Text type for this columns. So as for me we should not limit a length.</pre>
<br />
<p>- Ilgiz</p>
<br />
<p>On August 29th, 2013, 12:31 p.m. UTC, Ilgiz Islamgulov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-tflink.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for blockerbugs.</div>
<div>By Ilgiz Islamgulov.</div>
<p style="color: grey;"><i>Updated Aug. 29, 2013, 12:31 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
blockerbugs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implement new admin interface with flask-admin
Add build support
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've tested on my develop instance.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>testing/testfunc_update_sync.py <span style="color: grey">(70c600515ccc5e97ed17b4cadd40d76277794b67)</span></li>
<li>testing/testfunc_bugsync.py <span style="color: grey">(496f2994dda81bc82f2e270944a3fb2b391d9d91)</span></li>
<li>testing/testfunc_bugmodel.py <span style="color: grey">(a50f3458b2154f13736ab1f93cb3d1a86a48fcb1)</span></li>
<li>testing/test_spinmodel.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>testing/test_controllers.py <span style="color: grey">(702d2a5390e42910176d327461ef628e6bf8b849)</span></li>
<li>testing/test_api.py <span style="color: grey">(e92dda539117f94f3283f6ce262d65295a5e32c1)</span></li>
<li>setup.py <span style="color: grey">(89621b0debb5d368a027a4801de7da62fa961eab)</span></li>
<li>sass/admin_layout.scss <span style="color: grey">(PRE-CREATION)</span></li>
<li>requirements.txt <span style="color: grey">(98eab5da9306a101a41dd13708df1900e9fd1018)</span></li>
<li>blockerbugs/util/koji_interface.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>blockerbugs/templates/spin_list.html <span style="color: grey">(c455ff4edec0991a453a94cd0e38d959e1757672)</span></li>
<li>blockerbugs/templates/admin_layout.html <span style="color: grey">(PRE-CREATION)</span></li>
<li>blockerbugs/templates/admin/modify_release.html <span style="color: grey">(a3bb0d95c49414ff977e82f828ffdd111e105cc6)</span></li>
<li>blockerbugs/templates/admin/main.html <span style="color: grey">(251b1df1647e307e89bcda365422f1cee59b9a35)</span></li>
<li>blockerbugs/templates/admin/admin_nav.html <span style="color: grey">(34a0c2a966c265ab66166b3170f5f6d507014149)</span></li>
<li>blockerbugs/templates/admin/add_spin.html <span style="color: grey">(be44830da436e4e87700fe940a7c5197b32d1e82)</span></li>
<li>blockerbugs/templates/admin/add_release.html <span style="color: grey">(931001b23f52dd1b75fe0feb8d0311b76fcc907e)</span></li>
<li>blockerbugs/static/js/admin.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>blockerbugs/models/update.py <span style="color: grey">(9660d038720bcecae8e4f7401e09e26bd6589189)</span></li>
<li>blockerbugs/models/spin.py <span style="color: grey">(fa8e0e9a887f269cf31e850baa90678ff7055b78)</span></li>
<li>blockerbugs/models/release.py <span style="color: grey">(cca27cff41875528c1ee13d95194de5f237f31d4)</span></li>
<li>blockerbugs/models/milestone.py <span style="color: grey">(31667f6467ed111c3594cdd86d1c933f73b7dfc2)</span></li>
<li>blockerbugs/models/build.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>blockerbugs/models/__init__.py <span style="color: grey">(0223fff2996290005bd50412c844979304ce38a2)</span></li>
<li>blockerbugs/controllers/users.py <span style="color: grey">(7b6954adc39b23c997033916e1adc17639451fdd)</span></li>
<li>blockerbugs/controllers/main.py <span style="color: grey">(44924e096803b5c448dbd84dc5fe0405a97ebc50)</span></li>
<li>blockerbugs/controllers/api/utils.py <span style="color: grey">(38144dd48f3190f709a9bafa3a5a425dfdfffbdf)</span></li>
<li>blockerbugs/controllers/api/api.py <span style="color: grey">(d6df7d34170da05bd817b12545596f34b43b9da6)</span></li>
<li>blockerbugs/controllers/admin/spin.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>blockerbugs/controllers/admin/build.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>blockerbugs/controllers/admin/auth.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>blockerbugs/controllers/admin/__init__.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>blockerbugs/controllers/admin.py <span style="color: grey">(4ce6c9f58b5513c280312c8d1dd92c341d259d0a)</span></li>
<li>blockerbugs/config.py <span style="color: grey">(03e8b2a92aaaf7328b68c3fa4eb585a189f52186)</span></li>
<li>blockerbugs/__init__.py <span style="color: grey">(b9d7a40e4e9b47624795958212025428e7788b0f)</span></li>
<li>blockerbugs.spec <span style="color: grey">(cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce)</span></li>
<li>alembic/versions/f9e369bf00d_added_spin_type_cons.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>alembic/versions/1162fb4d4358_added_build_table.py <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://reviewboard-tflink.rhcloud.com/r/46/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>