<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard-tflink.rhcloud.com/r/45/">http://reviewboard-tflink.rhcloud.com/r/45/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 24th, 2013, 3:44 p.m. UTC, <b>Tim Flink</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I attempted to test this on an el6 machine, got a traceback when doing sync. tb added to trac ticket</pre>
</blockquote>
<p>On October 1st, 2013, 1:13 p.m. UTC, <b>Martin Krizek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah, python-webassets needs to be installed, it's missing in Requires (and in epel repo, it's present in Fedora though), I filed a bug -- https://bugzilla.redhat.com/show_bug.cgi?id=1014147. Also I went ahead and created spec files for jsmin and cssmin (http://mkrizek.fedorapeople.org/) as they were easy enough to package.</pre>
</blockquote>
<p>On October 1st, 2013, 1:14 p.m. UTC, <b>Martin Krizek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can probably fix issues in python-flask-assets and python-webassets so we can have this working until it is officially fixed...</pre>
</blockquote>
<p>On October 1st, 2013, 2:35 p.m. UTC, <b>Tim Flink</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not sure I understand what's required with python-webassets, that bzid shows up as invalid and I can't find anything filed against python-webassets that talks about epel. Any of the required packages would need to be in epel or at least epel-testing before we deploy to production, though. That's why builds for develop have been slow - I keep hoping that the last build will get done.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">https://bugzilla.redhat.com/show_bug.cgi?id=1014147 -- there was a dot in the link above.
It's reported against python-flask-assets. So what needs to be done is to push python-webassets to epel and put it as Requires in the python-flask-assets spec file. Another thing is to send python-jsmin and python-cssmin for a package review.</pre>
<br />
<p>- Martin</p>
<br />
<p>On August 29th, 2013, 10:23 a.m. UTC, Martin Krizek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-tflink.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for blockerbugs.</div>
<div>By Martin Krizek.</div>
<p style="color: grey;"><i>Updated Aug. 29, 2013, 10:23 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://fedorahosted.org/fedora-qa/ticket/357">357</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
blockerbugs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">commit d86f88d7f9da899ffef44ad617a8a831327b7d80
Author: Martin Krizek <mkrizek@redhat.com>
Date: Mon Aug 12 16:40:16 2013 +0200
Improve asset management
Fixes: #357
I have not minified two js files in milestone_stats.html template as I am not sure it's worth it, any objections?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Loaded pages, seems like css and js work as expected after being minified.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>requirements.txt <span style="color: grey">(98eab5da9306a101a41dd13708df1900e9fd1018)</span></li>
<li>blockerbugs/templates/layout.html <span style="color: grey">(49cdbd70ef8347965dfca93971449688f9cd6cb0)</span></li>
<li>blockerbugs/__init__.py <span style="color: grey">(b9d7a40e4e9b47624795958212025428e7788b0f)</span></li>
<li>blockerbugs.spec <span style="color: grey">(cda6d4e4c56cce5b3ab37665b4f1988fc62f29ce)</span></li>
</ul>
<p><a href="http://reviewboard-tflink.rhcloud.com/r/45/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>