[PATCH 1/2] Fallback the remote on 'origin'
Pavol Babincak
pbabinca at redhat.com
Wed Jul 16 11:52:30 UTC 2014
On 07/01/2014 03:19 PM, Mathieu Bridon wrote:
> - except git.GitCommandError, e:
> - raise rpkgError('Unable to find remote name: %s' % e)
> + except Exception as e:
Is there a reason to catch general Exception instead of specific
GitCommandError which is raised by git module on errors?
Rest of the patch & second patch (De-hardcode 'origin' as the remote
name) looks fine with me.
--
Pavol Babincak
Release Engineering, Red Hat
More information about the rel-eng
mailing list