[PATCHES] os-release: Populate VARIANT and VARIANT_ID values

[Stephen Gallagher]

----- Original Message -----
> From: "Colin Walters" <walters at verbum.org>
> To: rel-eng at lists.fedoraproject.org
> Sent: Friday, May 8, 2015 9:33:22 AM
> Subject: Re: [PATCHES] os-release: Populate VARIANT and VARIANT_ID values
> 
> 
> 
> On Tue, May 5, 2015, at 03:38 PM, Stephen Gallagher wrote:
> > The systemd upstream project has accepted VARIANT as a cross-distribution
> > feature, but with a minor change[1] from our original approach: they
> > wanted a human-presentable VARIANT and a separate lower-case-only
> > VARIANT_ID value. This patch implements this in Fedora to keep us aligned
> > with systemd upstream[2].
> 
> It looks like this also adds the text "Edition"?  Is there a rationale for
> this?  I'm not objecting, just wondering.
> 

Well, this variable is meant for presentation, whereas the old version was only meant for parsing.

"Server Edition", "Workstation Edition", etc. is what the council settled on for how to address them. I figured that since we now had both representations here, I'd make this more verbose. I have no particular problem with striking the "Edition" component if people prefer that.


> Otherwise :+1: from me.

Thanks.