[sssd/f13/master] Resolves: CVE-2010-2940
Stephen Gallagher
sgallagh at fedoraproject.org
Tue Aug 24 16:20:27 UTC 2010
commit 1975bfc6556eaef629ecc86028ddfe7960da708c
Author: Stephen Gallagher <sgallagh at redhat.com>
Date: Tue Aug 24 11:59:21 2010 -0400
Resolves: CVE-2010-2940
...Treat-a-zero-length-password-as-a-failure.patch | 32 ++++++++++++++++++++
sssd.spec | 9 ++++-
2 files changed, 39 insertions(+), 2 deletions(-)
---
diff --git a/0002-Treat-a-zero-length-password-as-a-failure.patch b/0002-Treat-a-zero-length-password-as-a-failure.patch
new file mode 100644
index 0000000..24c1570
--- /dev/null
+++ b/0002-Treat-a-zero-length-password-as-a-failure.patch
@@ -0,0 +1,32 @@
+From 8eeb47279a5a4559d9d7f911250d6164ab120897 Mon Sep 17 00:00:00 2001
+From: Stephen Gallagher <sgallagh at redhat.com>
+Date: Wed, 18 Aug 2010 12:57:43 -0400
+Subject: [PATCH 9/9] Treat a zero-length password as a failure
+
+Some LDAP servers allow binding with blank passwords. We should
+not allow a blank password to authenticate the SSSD.
+---
+ src/providers/ldap/ldap_auth.c | 7 +++++++
+ 1 files changed, 7 insertions(+), 0 deletions(-)
+
+diff --git a/src/providers/ldap/ldap_auth.c b/src/providers/ldap/ldap_auth.c
+index b05e3075ce117fad17b87ffde257c80fc035b8c4..1a959d4cc45980fe5dd12db3460cc23f341466fd 100644
+--- a/src/providers/ldap/ldap_auth.c
++++ b/src/providers/ldap/ldap_auth.c
+@@ -557,6 +557,13 @@ static struct tevent_req *auth_send(TALLOC_CTX *memctx,
+ req = tevent_req_create(memctx, &state, struct auth_state);
+ if (!req) return NULL;
+
++ /* Treat a zero-length password as a failure */
++ if (password.length == 0) {
++ state->result = SDAP_AUTH_FAILED;
++ tevent_req_done(req);
++ return tevent_req_post(req, ev);
++ }
++
+ state->ev = ev;
+ state->ctx = ctx;
+ state->username = username;
+--
+1.7.2.1
+
diff --git a/sssd.spec b/sssd.spec
index c52b620..6f47a32 100644
--- a/sssd.spec
+++ b/sssd.spec
@@ -7,7 +7,7 @@ Name: sssd
Version: 1.2.2
#Never reset the Release, always increment it
#Otherwise we can have issues if library versions do not change
-Release: 20%{?dist}
+Release: 21%{?dist}
Group: Applications/System
Summary: System Security Services Daemon
License: GPLv3+
@@ -23,6 +23,7 @@ BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
### Patches ###
Patch0001: 0001-Fix-chpass-operations-with-LDAP-provider.patch
+Patch0002: 0002-Treat-a-zero-length-password-as-a-failure.patch
### Dependencies ###
@@ -201,8 +202,8 @@ A dynamically-growing, reference-counted array
%prep
%setup -q
-
%patch0001 -p1
+%patch0002 -p1
%build
%configure \
@@ -462,6 +463,10 @@ fi
%postun -n libref_array -p /sbin/ldconfig
%changelog
+* Tue Aug 24 2010 Stephen Gallagher <sgallagh at redhat.com> - 1.2.2-21
+- Resolves: CVE-2010-2940 - sssd allows null password entry to authenticate
+- against LDAP
+
* Wed Aug 04 2010 Stephen Gallagher <sgallagh at redhat.com> - 1.2.2-20
- Resolves: rhbz#621307 - Password changes are broken on LDAP
More information about the scm-commits
mailing list