rpms/abrt/F-12 abrt-1.0.9-crash-function-detect.patch, NONE, 1.1 abrt.spec, 1.29, 1.30

Karel Klíč kklic at fedoraproject.org
Mon May 3 09:27:29 UTC 2010


Author: kklic

Update of /cvs/pkgs/rpms/abrt/F-12
In directory cvs01.phx2.fedoraproject.org:/tmp/cvs-serv9604

Modified Files:
	abrt.spec 
Added Files:
	abrt-1.0.9-crash-function-detect.patch 
Log Message:
Fixed crash function detection

abrt-1.0.9-crash-function-detect.patch:
 CCpp.cpp |    9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

--- NEW FILE abrt-1.0.9-crash-function-detect.patch ---
commit f05c9b25335c84c7b5861fce80fd941ec81212f3
Author: Karel Klic <kklic at redhat.com>
Date:   Thu Apr 15 12:12:59 2010 +0200

    Crash function is now detected even for threads without an abort frame.

diff --git a/lib/Plugins/CCpp.cpp b/lib/Plugins/CCpp.cpp
index 9bdcda9..cf25c73 100644
--- a/lib/Plugins/CCpp.cpp
+++ b/lib/Plugins/CCpp.cpp
@@ -761,13 +761,12 @@ void CAnalyzerCCpp::CreateReport(const char *pDebugDumpDir, int force)
         /* Get the function name from the crash frame. */
         if (crash_thread)
         {
+            struct frame *crash_frame = crash_thread->frames;
             struct frame *abort_frame = thread_find_abort_frame(crash_thread);
             if (abort_frame)
-            {
-                struct frame *crash_frame = abort_frame->next;
-                if (crash_frame && crash_frame->function && 0 != strcmp(crash_frame->function, "??"))
-                    dd.SaveText(FILENAME_CRASH_FUNCTION, crash_frame->function);
-            }
+                crash_frame = abort_frame->next;
+            if (crash_frame && crash_frame->function && 0 != strcmp(crash_frame->function, "??"))
+                dd.SaveText(FILENAME_CRASH_FUNCTION, crash_frame->function);
         }
 
         backtrace_free(backtrace);


Index: abrt.spec
===================================================================
RCS file: /cvs/pkgs/rpms/abrt/F-12/abrt.spec,v
retrieving revision 1.29
retrieving revision 1.30
diff -u -p -r1.29 -r1.30
--- abrt.spec	15 Apr 2010 12:52:34 -0000	1.29
+++ abrt.spec	3 May 2010 09:27:29 -0000	1.30
@@ -4,7 +4,7 @@
 Summary: Automatic bug detection and reporting tool
 Name: abrt
 Version: 1.0.9
-Release: 1%{?dist}
+Release: 2%{?dist}
 License: GPLv2+
 Group: Applications/System
 URL: https://fedorahosted.org/abrt/
@@ -14,6 +14,7 @@ Patch0: abrt-1.0.9-hideprefs.patch
 Patch1: abrt-localizedyum.patch
 Patch2: abrt-1.0.9-better-bz-summary.patch
 Patch3: abrt-1.0.9-ignore_user_scripts.patch
+Patch4: abrt-1.0.9-crash-function-detect.patch
 BuildRequires: dbus-devel
 BuildRequires: gtk2-devel
 BuildRequires: curl-devel
@@ -240,6 +241,7 @@ Virtual package to make easy default ins
 %patch1 -p1 -b ~localizedyum
 %patch2 -p1 -b ~better_bz
 %patch3 -p1 -b ~ingore_unp_scripts
+%patch4 -p1 -b .crash_function_detect
 
 %build
 %configure
@@ -464,6 +466,9 @@ fi
 %defattr(-,root,root,-)
 
 %changelog
+* Mon May 03 2010 Karel Klic <kklic at redhat.com> 1.0.9-2
+- fixed crash function detection (a part of duplication detection)
+
 * Thu Apr 15 2010  Jiri Moskovcak <jmoskovc at redhat.com> 1.0.9-1
 - fixed problem with localized yum messages rhbz#581804
 - better bugzilla summary (napjkovs at redhat.com)



More information about the scm-commits mailing list