[kde-plasma-networkmanagement/f14] * Wed Jun 08 2011 Kevin Kofler <Kevin at tigcc.ticalc.org> 1:0.9-0.40.20110323.1 - fix missing NULL che
Kevin Kofler
kkofler at fedoraproject.org
Wed Jun 8 12:25:12 UTC 2011
commit ea6b31ee46a16bbcaf39966c8c5367f412ee74a6
Author: Kevin Kofler <Kevin at tigcc.ticalc.org>
Date: Wed Jun 8 14:23:05 2011 +0200
* Wed Jun 08 2011 Kevin Kofler <Kevin at tigcc.ticalc.org> 1:0.9-0.40.20110323.1
- fix missing NULL checks (#710996, backported from upstream git)
kde-plasma-networkmanagement.spec | 9 ++++++++-
networkmanagement-0.9-20110323-#710996.patch | 23 +++++++++++++++++++++++
2 files changed, 31 insertions(+), 1 deletions(-)
---
diff --git a/kde-plasma-networkmanagement.spec b/kde-plasma-networkmanagement.spec
index 8f1fbfc..4a0561d 100644
--- a/kde-plasma-networkmanagement.spec
+++ b/kde-plasma-networkmanagement.spec
@@ -4,7 +4,7 @@
Name: kde-plasma-networkmanagement
Epoch: 1
Version: 0.9
-Release: 0.40.%{snap}%{?dist}
+Release: 0.40.%{snap}%{?dist}.1
Summary: NetworkManager KDE 4 integration
Group: Applications/Internet
@@ -23,6 +23,9 @@ Source10: 00-fedora-networkmanagement.js
## upstreamable patches
## upstream patches
+# fix missing NULL checks (#710996)
+# backported from upstream git (rev ff9076fe85f31b0cfa388d92a0c6d288ad07f396)
+Patch100: networkmanagement-0.9-20110323-#710996.patch
BuildRequires: kdelibs4-devel >= 4.5.0
BuildRequires: kdebase-workspace-devel
@@ -99,6 +102,7 @@ Provides: knetworkmanager-vpnc = %{?epoch:%{epoch}:}%{version}-%{release}
%prep
%setup -q -n networkmanagement-%{version}
+%patch100 -p1 -b .#710996
# nuke monolithic knm bits
rm -rfv monolithic po/*/knetworkmanager.po
@@ -213,6 +217,9 @@ gtk-update-icon-cache %{_kde4_iconsdir}/oxygen &> /dev/null || :
%changelog
+* Wed Jun 08 2011 Kevin Kofler <Kevin at tigcc.ticalc.org> 1:0.9-0.40.20110323.1
+- fix missing NULL checks (#710996, backported from upstream git)
+
* Wed Mar 23 2011 Rex Dieter <rdieter at fedoraproject.org> 1:0.9-0.40.20110323
- 20110323 snapshot
- BR: mobile-broadband-provider-info-devel
diff --git a/networkmanagement-0.9-20110323-#710996.patch b/networkmanagement-0.9-20110323-#710996.patch
new file mode 100644
index 0000000..891c281
--- /dev/null
+++ b/networkmanagement-0.9-20110323-#710996.patch
@@ -0,0 +1,23 @@
+diff -ur networkmanagement-0.9/applet/nmpopup.cpp networkmanagement-0.9-#710996/applet/nmpopup.cpp
+--- networkmanagement-0.9/applet/nmpopup.cpp 2011-03-23 19:15:35.000000000 +0100
++++ networkmanagement-0.9-#710996/applet/nmpopup.cpp 2011-06-08 14:00:47.000000000 +0200
+@@ -533,7 +533,7 @@
+
+ foreach (InterfaceItem* ifaceitem, m_interfaces) {
+ Solid::Control::NetworkInterface* iface = ifaceitem->interface();
+- if (iface->type() == Solid::Control::NetworkInterface::Ieee80211) {
++ if (iface && iface->type() == Solid::Control::NetworkInterface::Ieee80211) {
+ //kDebug() << "there's a wifi iface" << ifaceitem->connectionName() << iface->interfaceName();
+ m_hasWirelessInterface = true; // at least one interface is wireless. We're happy.
+ m_wifiCheckBox->show();
+@@ -554,8 +554,8 @@
+ bool hasWwan = false;
+ foreach (InterfaceItem* ifaceitem, m_interfaces) {
+ Solid::Control::NetworkInterface* iface = ifaceitem->interface();
+- if (iface->type() == Solid::Control::NetworkInterface::Gsm ||
+- iface->type() == Solid::Control::NetworkInterface::Cdma) {
++ if (iface && (iface->type() == Solid::Control::NetworkInterface::Gsm ||
++ iface->type() == Solid::Control::NetworkInterface::Cdma)) {
+ hasWwan = true;
+ break;
+ }
More information about the scm-commits
mailing list