[soundconverter/f16] Fix tracebacks after installing missing GStreamer plugins (#809404).

Michael Schwendt mschwendt at fedoraproject.org
Tue Apr 3 19:34:52 UTC 2012


commit a7db1b19a6ac21e6525cac37955e0576b0726599
Author: Michael Schwendt <mschwendt at fedoraproject.org>
Date:   Tue Apr 3 21:34:38 2012 +0200

    Fix tracebacks after installing missing GStreamer plugins (#809404).

 soundconverter-1.5.4-plugin-install.patch |   30 +++++++++++++++++++++++++++++
 soundconverter.spec                       |    8 ++++++-
 2 files changed, 37 insertions(+), 1 deletions(-)
---
diff --git a/soundconverter-1.5.4-plugin-install.patch b/soundconverter-1.5.4-plugin-install.patch
new file mode 100644
index 0000000..2a1966d
--- /dev/null
+++ b/soundconverter-1.5.4-plugin-install.patch
@@ -0,0 +1,30 @@
+diff -Nur soundconverter-1.5.4-pl7/src/soundconverter.py soundconverter-1.5.4-pl8/src/soundconverter.py
+--- soundconverter-1.5.4-pl7/src/soundconverter.py	2012-04-03 21:22:16.615517493 +0200
++++ soundconverter-1.5.4-pl8/src/soundconverter.py	2012-04-03 21:24:39.497642337 +0200
+@@ -921,6 +921,7 @@
+ 	def finished(self):
+ 		for element, sid in self.connected_signals:
+ 			element.disconnect(sid)
++		self.connected_signals = []
+ 		self.stop_pipeline()
+ 
+ 	def abort(self):
+@@ -949,6 +950,7 @@
+ 		if result == gst.pbutils.INSTALL_PLUGINS_SUCCESS:
+ 			gst.update_registry()
+ 			self.parsed = False
++			self.finished()
+ 			self.play()
+ 			return
+ 		self.done()
+@@ -1015,8 +1017,8 @@
+ 					self.connected_signals.append((element, sid,))
+ 
+ 				self.parsed = True
+-				del self.command
+-				del self.signals
++				#del self.command
++				#del self.signals
+ 			except gobject.GError, e:
+ 				error.show('GStreamer error when creating pipeline', str(e))
+ 				self.eos = True # TODO
diff --git a/soundconverter.spec b/soundconverter.spec
index 937d0dd..d1a5132 100644
--- a/soundconverter.spec
+++ b/soundconverter.spec
@@ -1,6 +1,6 @@
 Name:           soundconverter
 Version:        1.5.4
-Release:        13%{?dist}
+Release:        14%{?dist}
 Summary:        Simple sound converter application for GNOME
 
 Group:          Applications/Multimedia
@@ -34,6 +34,8 @@ Patch5: soundconverter-1.5.4-gst-profile-bad.patch
 Patch6: soundconverter-1.5.4-last-used-folder.patch
 # Fedora bz 784791
 Patch7: soundconverter-1.5.4-resample-rate.patch
+# Fedora bz 809404, TODO: verify if fixed in 2.0.2
+Patch8: soundconverter-1.5.4-plugin-install.patch
 
 # enforce availability of this and its requirement "desktop-notification-daemon"
 Requires:       notify-python
@@ -79,6 +81,7 @@ writes anything the GStreamer library can.
 %patch5 -p1 -b .bz744596
 %patch6 -p1 -b .bz784413
 %patch7 -p1 -b .bz784791
+%patch8 -p1 -b .bz809404
 
 
 %build
@@ -126,6 +129,9 @@ update-desktop-database &> /dev/null ||:
 
 
 %changelog
+* Tue Apr  3 2012 Michael Schwendt <mschwendt at fedoraproject.org> - 1.5.4-14
+- Fix tracebacks after installing missing GStreamer plugins (#809404).
+
 * Thu Jan 26 2012 Michael Schwendt <mschwendt at fedoraproject.org> - 1.5.4-13
 - Fix traceback when enabling resampling without choosing a sample
   rate (#784791).


More information about the scm-commits mailing list