[kde-baseapps] dolphin keyboard search timeout improvement (kde#297458, kde#297488)
Rex Dieter
rdieter at fedoraproject.org
Mon Apr 16 14:40:06 UTC 2012
commit 7dcda483f4b591ac757c6c3adb658e925811fca4
Author: Rex Dieter <rdieter at fedoraproject.org>
Date: Mon Apr 16 09:42:15 2012 -0500
dolphin keyboard search timeout improvement (kde#297458, kde#297488)
kde-baseapps-4.8.2-dolphin_timeout.patch | 31 ++++++++++++++++++++++++++++++
kde-baseapps.spec | 9 +++++++-
2 files changed, 39 insertions(+), 1 deletions(-)
---
diff --git a/kde-baseapps-4.8.2-dolphin_timeout.patch b/kde-baseapps-4.8.2-dolphin_timeout.patch
new file mode 100644
index 0000000..45c830a
--- /dev/null
+++ b/kde-baseapps-4.8.2-dolphin_timeout.patch
@@ -0,0 +1,31 @@
+commit d8732a59d3b1f2d0bebf43f294df7e9f333abde4
+Author: Frank Reininghaus <frank78ac at googlemail.com>
+Date: Thu Apr 5 18:59:58 2012 +0200
+
+ Reduce the timeout in KItemListKeyboardSearchManager to 1 second
+
+ It turned out that the longer timeout, introduced recently in
+ 02eab49b2de51c31fe46a0d9501327b579b3648e, not only made multi-letter
+ keyboard searches easier, but also had some unwanted side effects. I
+ hope that 1 second, which is between the previous value of 5 seconds and
+ the pre-KDE 4.8.2 value of 0.4 seconds, is a compromise which will fit
+ most users' needs.
+ We will try to improve the situation further in future releases by
+ providing visual feedback about the keyboard search, but such a change
+ would not be suitable for a bug-fix release.
+ CCBUG:297458
+ CCBUG:297488
+
+diff --git a/dolphin/src/kitemviews/kitemlistkeyboardsearchmanager.cpp b/dolphin/src/kitemviews/kitemlistkeyboardsearchmanager.cpp
+index f4dc1a5..592605a 100644
+--- a/dolphin/src/kitemviews/kitemlistkeyboardsearchmanager.cpp
++++ b/dolphin/src/kitemviews/kitemlistkeyboardsearchmanager.cpp
+@@ -29,7 +29,7 @@
+
+ KItemListKeyboardSearchManager::KItemListKeyboardSearchManager(QObject* parent) :
+ QObject(parent),
+- m_timeout(5000)
++ m_timeout(1000)
+ {
+ m_keyboardInputTime.invalidate();
+ }
diff --git a/kde-baseapps.spec b/kde-baseapps.spec
index 786aa15..7e89cdc 100644
--- a/kde-baseapps.spec
+++ b/kde-baseapps.spec
@@ -1,7 +1,7 @@
Name: kde-baseapps
Summary: KDE Core Applications
Version: 4.8.2
-Release: 1%{?dist}
+Release: 2%{?dist}
License: GPLv2
URL: https://projects.kde.org/projects/kde/kde-baseapps
@@ -28,6 +28,8 @@ Patch3: kdebase-4.4.0-konqueror-kde#228593.patch
Patch4: kdebase-4.3.4-bz#609039-chfn-parse.patch
## upstream patches
+# https://projects.kde.org/projects/kde/kde-baseapps/repository/revisions/d8732a59d3b1f2d0bebf43f294df7e9f333abde4
+Patch100: kde-baseapps-4.8.2-dolphin_timeout.patch
%ifnarch s390 s390x
Requires: eject
@@ -113,6 +115,8 @@ Requires: kdelibs4-devel kdepimlibs4-devel
%patch2 -p2 -b .home-icon
%patch3 -p2 -b .kde#228593
%patch4 -p2 -b .bz#631481
+%patch100 -p1 -b .dolphin_timeout
+
%build
mkdir -p %{_target_platform}
@@ -263,6 +267,9 @@ fi
%changelog
+* Mon Apr 16 2012 Rex Dieter <rdieter at fedoraproject.org> 4.8.2-2
+- dolphin keyboard search timeout improvement (kde#297458, kde#297488)
+
* Fri Mar 30 2012 Rex Dieter <rdieter at fedoraproject.org> - 4.8.2-1
- 4.8.2
More information about the scm-commits
mailing list