[kexec-tools/f18] firstboot: fix gtk warning about non-zero page size

Dave Young yangrr at fedoraproject.org
Tue Aug 28 08:28:47 UTC 2012


commit dc5f48e90ae783f9c03034f982848db26ea2c89c
Author: Dave Young <dyoung at redhat.com>
Date:   Tue Aug 28 16:22:15 2012 +0800

    firstboot: fix gtk warning about non-zero page size
    
    Pygtk documentation says the page size field is not used, but actually
    there will be a gtk warning below:
    
    /usr/share/firstboot/modules/firstboot_kdump.py:216: GtkWarning: GtkSpinButton: setting an adjustment with non-zero page size is deprecated
      self.kdumpMemspin = gtk.SpinButton(self.memAdjustment, 0, 0)
    
    Fix it by setting the last field to 0.
    
    Signed-off-by: Dave Young <dyoung at redhat.com>
    Reviewed-by: Vivek Goyal <vgoyal at redhat.com>

 firstboot_kdump.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/firstboot_kdump.py b/firstboot_kdump.py
index 9dd1be7..9b7dc03 100755
--- a/firstboot_kdump.py
+++ b/firstboot_kdump.py
@@ -212,7 +212,7 @@ class moduleClass(Module):
 		self.labelTotal.set_width_chars(32)
 
 		# how much ram to reserve for kdump
-		self.memAdjustment = gtk.Adjustment(self.kdumpMem, lowerBound, upperBound, step, step, 64)
+		self.memAdjustment = gtk.Adjustment(self.kdumpMem, lowerBound, upperBound, step, step, 0)
 		self.kdumpMemspin = gtk.SpinButton(self.memAdjustment, 0, 0)
 		self.kdumpMemspin.set_update_policy(gtk.UPDATE_IF_VALID)
 		self.kdumpMemspin.set_numeric(True)


More information about the scm-commits mailing list