[lynx] fix specfile issues reported by the fedora-review script

Kamil Dudka kdudka at fedoraproject.org
Tue Aug 28 13:52:12 UTC 2012


commit 343199dc1ee353aac88df44e9c6f281c00e67676
Author: Kamil Dudka <kdudka at redhat.com>
Date:   Tue Aug 28 15:19:58 2012 +0200

    fix specfile issues reported by the fedora-review script

 lynx.spec |   11 ++++-------
 1 files changed, 4 insertions(+), 7 deletions(-)
---
diff --git a/lynx.spec b/lynx.spec
index e95ce52..89c607d 100644
--- a/lynx.spec
+++ b/lynx.spec
@@ -125,9 +125,9 @@ fi
 make %{?_smp_mflags}
 
 %install
-rm -rf $RPM_BUILD_ROOT
 chmod -x samples/mailto-form.pl
-%makeinstall mandir=$RPM_BUILD_ROOT%{_mandir}/man1 libdir=$RPM_BUILD_ROOT/etc
+make install DESTDIR=$RPM_BUILD_ROOT
+
 # Install Lang dependent resources
 mkdir -p $RPM_BUILD_ROOT/usr/share/locale/ja/LC_MESSAGES/
 
@@ -139,22 +139,19 @@ EOF
 
 %find_lang %{name}
 
-%clean
-rm -rf $RPM_BUILD_ROOT
-
 %files -f %{name}.lang
-%defattr(-,root,root,-)
 %doc docs README INSTALLATION samples
 %doc test lynx.hlp lynx_help
 %{_bindir}/lynx
 %{_mandir}/*/*
-%config %{_sysconfdir}/lynx.cfg
+%config(noreplace) %{_sysconfdir}/lynx.cfg
 %config(noreplace) %{_sysconfdir}/lynx.lss
 %config(noreplace,missingok) %{_sysconfdir}/lynx-site.cfg
 
 %changelog
 * Tue Aug 28 2012 Kamil Dudka <kdudka at redhat.com> - 2.8.7-10
 - sync the upstream tarball with the current upstream version
+- fix specfile issues reported by the fedora-review script
 
 * Thu Jul 19 2012 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 2.8.7-9
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild


More information about the scm-commits mailing list