[perl-Tie-EncryptedHash] Spec clean-up

Paul Howarth pghmcfc at fedoraproject.org
Tue Jun 12 12:10:55 UTC 2012


commit 8b6af65f1b78743f6ebde9ff0d0bf1e3ef30f055
Author: Paul Howarth <paul at city-fan.org>
Date:   Tue Jun 12 12:59:31 2012 +0100

    Spec clean-up
    
    - Don't use macros for system commands
    - Don't need to remove empty directories from the buildroot
    - Use DESTDIR rather than PERL_INSTALL_ROOT
    - Use %{_fixperms} macro rather than our own chmod incantation
    - Drop %defattr, redundant since rpm 4.4

 perl-Tie-EncryptedHash.spec |   44 ++++++++++++++++++++++++------------------
 1 files changed, 25 insertions(+), 19 deletions(-)
---
diff --git a/perl-Tie-EncryptedHash.spec b/perl-Tie-EncryptedHash.spec
index 3508ad4..ab8b154 100644
--- a/perl-Tie-EncryptedHash.spec
+++ b/perl-Tie-EncryptedHash.spec
@@ -1,23 +1,24 @@
 Summary:	Hashes (and objects based on hashes) with encrypting fields
 Name:		perl-Tie-EncryptedHash
 Version:	1.24
-Release:	9%{?dist}
+Release:	10%{?dist}
 License:	GPL+ or Artistic
 Group:		Development/Libraries
 Url:		http://search.cpan.org/dist/Tie-EncryptedHash/
 Source0:	http://search.cpan.org/CPAN/authors/id/V/VI/VIPUL/Tie-EncryptedHash-%{version}.tar.gz
-BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-Requires:	perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
 BuildArch:	noarch
 BuildRequires:	perl(ExtUtils::MakeMaker)
 # Run-time
-BuildRequires:  perl(Carp)
+BuildRequires:	perl(Carp)
 BuildRequires:	perl(Crypt::CBC)
-BuildRequires:  perl(Data::Dumper)
-BuildRequires:  perl(Digest::MD5)
+BuildRequires:	perl(Crypt::DES)
+BuildRequires:	perl(Data::Dumper)
+BuildRequires:	perl(Digest::MD5)
 # Tests
 BuildRequires:	perl(Crypt::Blowfish)
-BuildRequires:  perl(lib)
+BuildRequires:	perl(lib)
+Requires:	perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 
 %description
 Tie::EncryptedHash augments Perl hash semantics to build secure, encrypting
@@ -39,32 +40,37 @@ default, but can be instructed to employ any cipher supported by Crypt::CBC(3).
 
 %prep
 %setup -q -n Tie-EncryptedHash-%{version}
-%{__sed} -i -e '/^#! *\/usr\/bin\/perl /d' lib/Tie/EncryptedHash.pm
+sed -i -e '/^#! *\/usr\/bin\/perl /d' lib/Tie/EncryptedHash.pm
 
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
-%{__make} %{?_smp_mflags}
+perl Makefile.PL INSTALLDIRS=vendor
+make %{?_smp_mflags}
 
 %check
-%{__make} test
+make test
 
 %install
-%{__rm} -rf %{buildroot}
-%{__make} pure_install PERL_INSTALL_ROOT=%{buildroot}
-/usr/bin/find %{buildroot} -type f -name .packlist -exec %{__rm} -f {} ';'
-/usr/bin/find %{buildroot} -depth -type d -exec /bin/rmdir {} 2>/dev/null ';'
-%{__chmod} -R u+w %{buildroot}/*
+rm -rf %{buildroot}
+make pure_install DESTDIR=%{buildroot}
+find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
+%{_fixperms} %{buildroot}
 
 %clean
-%{__rm} -rf %{buildroot}
+rm -rf %{buildroot}
 
 %files
-%defattr(-,root,root,-)
 %doc Changes LICENSE README.html TODO
 %{perl_vendorlib}/Tie/
 %{_mandir}/man3/Tie::EncryptedHash.3pm*
 
 %changelog
+* Tue Jun 12 2012 Paul Howarth <paul at city-fan.org> - 1.24-10
+- Don't use macros for system commands
+- Don't need to remove empty directories from the buildroot
+- Use DESTDIR rather than PERL_INSTALL_ROOT
+- Use %%{_fixperms} macro rather than our own chmod incantation
+- Drop %%defattr, redundant since rpm 4.4
+
 * Tue Jun 12 2012 Petr Pisar <ppisar at redhat.com> - 1.24-9
 - Perl 5.16 rebuild
 - Specify all dependencies
@@ -76,7 +82,7 @@ default, but can be instructed to employ any cipher supported by Crypt::CBC(3).
 - Perl mass rebuild
 
 * Thu Dec 23 2010 Marcela Maslanova <mmaslano at redhat.com> - 1.24-6
-- 661697 rebuild for fixing problems with vendorach/lib
+- Rebuild to fix problems with vendorarch/lib (#661697)
 
 * Fri May 07 2010 Marcela Maslanova <mmaslano at redhat.com> - 1.24-5
 - Mass rebuild with perl-5.12.0


More information about the scm-commits mailing list