[libkolab/el6: 14/18] Fix some review issues (#833853)

Jeroen van Meeuwen kanarip at fedoraproject.org
Thu Jun 28 12:31:53 UTC 2012


commit e33c4faf613f79d5a982f30592aa38ff7ad1c6f9
Author: Jeroen van Meeuwen (Kolab Systems) <vanmeeuwen at kolabsys.com>
Date:   Tue Jun 26 19:57:46 2012 +0100

    Fix some review issues (#833853)

 libkolab.spec |   23 ++++++-----------------
 1 files changed, 6 insertions(+), 17 deletions(-)
---
diff --git a/libkolab.spec b/libkolab.spec
index 4cf9bc9..ab112a6 100644
--- a/libkolab.spec
+++ b/libkolab.spec
@@ -1,33 +1,25 @@
 Name:           libkolab
 Version:        0.3
-Release:        4%{?dist}
+Release:        5%{?dist}
 Summary:        Kolab Object Handling Library
 
-Group:          System Environment/Libraries
 License:        LGPLv3+
-URL:            http://www.kolab.org
+URL:            http://git.kolab.org/libkolab
 
 # From http://git.kolab.org/libkolab/snapshot/54d11d067951ddedd8b28aa7eb54e4f68bc81218.tar.gz
 Source0:        http://git.kolab.org/%{name}/snapshot/%{name}-%{version}.tar.gz
 
-BuildRoot:      %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
-
-BuildRequires:  cmake >= 2.6
 BuildRequires:  kdepimlibs-devel >= 4.8
 BuildRequires:  libkolabxml-devel >= 0.6
-BuildRequires:  qt-devel >= 4.7
 
 %description
 The libkolab library is an advanced library to  handle Kolab objects.
 
 %package devel
 Summary:        Kolab library development headers
-Group:          Development/Libraries
 Requires:       %{name}%{?_isa} = %{version}-%{release}
-Requires:       cmake >= 2.6
 Requires:       kdepimlibs-devel >= 4.8
 Requires:       libkolabxml-devel >= 0.6
-Requires:       qt-devel >= 4.7
 Requires:       pkgconfig
 
 %description devel
@@ -41,9 +33,6 @@ rm -rf build
 mkdir -p build
 pushd build
 %{cmake} -Wno-fatal-errors -Wno-errors \
-    -DCMAKE_SKIP_RPATH=ON \
-    -DCMAKE_INSTALL_PREFIX=%{_prefix} \
-    -DLIB_INSTALL_DIR=%{_libdir} \
     -DINCLUDE_INSTALL_DIR=%{_includedir}/kolab \
     ..
 make
@@ -63,8 +52,7 @@ rm -rf %{buildroot}
 %postun -p /sbin/ldconfig
 
 %files
-%defattr(-,root,root,-)
-%{_libdir}/%{name}.so.*
+%{_libdir}/%{name}.so.0.3
 
 %files devel
 %{_libdir}/%{name}.so
@@ -72,8 +60,9 @@ rm -rf %{buildroot}
 %{_includedir}/kolab
 
 %changelog
-* Tue Jun 26 2012 Jeroen van Meeuwen <vanmeeuwen at kolabsys.com> - 0.3-4
-- Rebuild after some packaging fixes
+* Tue Jun 26 2012 Jeroen van Meeuwen <vanmeeuwen at kolabsys.com> - 0.3-5
+- Fix some review issues (#833853)
+- Rebuild after some packaging fixes (4)
 
 * Sat Jun  9 2012 Jeroen van Meeuwen <vanmeeuwen at kolabsys.com> - 0.3-3
 - Check in latest snapshot


More information about the scm-commits mailing list