[star/f18] Fix man page to note that 'crc' format uses Sum32

Pavel Raiskup praiskup at fedoraproject.org
Thu Oct 18 07:54:52 UTC 2012


commit 2165805ab6052a1cace4c3e2424f23641ff45374
Author: Pavel Raiskup <praiskup at redhat.com>
Date:   Thu Oct 18 09:45:58 2012 +0200

    Fix man page to note that 'crc' format uses Sum32

 star-1.5.1-crc.patch |   31 +++++++++++++++++++++++++++++++
 star.spec            |    4 ++++
 2 files changed, 35 insertions(+), 0 deletions(-)
---
diff --git a/star-1.5.1-crc.patch b/star-1.5.1-crc.patch
new file mode 100644
index 0000000..5ab42ad
--- /dev/null
+++ b/star-1.5.1-crc.patch
@@ -0,0 +1,31 @@
+diff --git a/star/cpiohdr.c b/star/cpiohdr.c
+index 9c7a774..2785661 100644
+--- a/star/cpiohdr.c
++++ b/star/cpiohdr.c
+@@ -536,7 +536,9 @@ cpio_checkswab(ptb)
+ }
+ 
+ /*
+- * This simple sum is used for the SYSvr4 file content CRC
++ * This simple sum is used for the SYSvr4 file content checksum.  This is
++ * implemented like Sum32 algorithm.
++ *
+  * Use Int32_t to implement the same behavior as the AT&T cpio command.
+  */
+ LOCAL Int32_t
+diff --git a/star/star.1 b/star/star.1
+index 95b202c..a931a6f 100644
+--- a/star/star.1
++++ b/star/star.1
+@@ -913,9 +913,9 @@ archive format because of its limited portability.
+ .B crc
+ This format is similar to the
+ .B asc
+-cpio format but in addition uses a simple byte based checksum called
++cpio format but in addition uses a simple byte based checksum called here as
+ .BR CRC .
+-Try to avoid the
++This algorithm is simple Sum32 -- not a polynomial CRC.  Try to avoid the
+ .B crc
+ archive format because of its limited portability.
+ 
diff --git a/star.spec b/star.spec
index 2861ece..10745e4 100644
--- a/star.spec
+++ b/star.spec
@@ -24,6 +24,8 @@ Patch6: star-1.5.1-manpagereferences.patch
 Patch7: star-1.5.1-multivolsigsegv.patch
 # do not crash when xattrs are not set on all files (#861848)
 Patch8: star-1.5.1-selinux-segfault.patch
+# note that the H=crc format uses Sum32 algorithm, not CRC
+Patch9: star-1.5.1-crc.patch
 
 License: CDDL
 Group: Applications/Archiving
@@ -47,6 +49,7 @@ and can restore individual files from the archive. Star supports ACL.
 %patch6 -p1 -b .references
 %patch7 -p1 -b .multivol
 %patch8 -p1 -b .selinux-segfault
+%patch9 -p1 -b .crc
 cp -a star/all.mk star/Makefile
 iconv -f iso_8859-1 -t utf-8 AN-1.5 >AN-1.5_utf8
 mv AN-1.5_utf8 AN-1.5
@@ -128,6 +131,7 @@ rm -rf ${RPM_BUILD_ROOT}
 * Thu Oct 18 2012 Pavel Raiskup <praiskup at redhat.com> - 1.5.1-10
 - do not crash during extracting if extended attributes are not set on all
   archived files (#861848)
+- note in man page that H=crc format uses Sum32 algorithm (FIPS refuses CRC)
 
 * Sat Jul 21 2012 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 1.5.1-9
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild


More information about the scm-commits mailing list