[sblim-cmpi-fsvol] Fix issues found by fedora-review utility in the spec file

vcrhonek vcrhonek at fedoraproject.org
Tue Sep 4 14:18:42 UTC 2012


commit b871bcd7cd5c574942a6d9f32855c975936c830e
Author: Vitezslav Crhonek <vcrhonek at redhat.com>
Date:   Tue Sep 4 16:18:28 2012 +0200

    Fix issues found by fedora-review utility in the spec file

 sblim-cmpi-fsvol.spec |   17 ++++++-----------
 1 files changed, 6 insertions(+), 11 deletions(-)
---
diff --git a/sblim-cmpi-fsvol.spec b/sblim-cmpi-fsvol.spec
index 5ad2da6..d4f1962 100644
--- a/sblim-cmpi-fsvol.spec
+++ b/sblim-cmpi-fsvol.spec
@@ -3,10 +3,9 @@
 Summary:        SBLIM fsvol instrumentation
 Name:           sblim-cmpi-fsvol
 Version:        1.5.1
-Release:        4%{?dist}
+Release:        5%{?dist}
 License:        EPL
 Group:          Applications/System
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 URL:            http://sourceforge.net/projects/sblim/
 Source0:        http://downloads.sourceforge.net/project/sblim/%{name}/%{version}/%{name}-%{version}.tar.bz2
 Patch0:         sblim-cmpi-fsvol-1.5.0-ext4-support.patch
@@ -55,7 +54,6 @@ sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool
 make
 
 %install
-rm -rf $RPM_BUILD_ROOT
 make install DESTDIR=$RPM_BUILD_ROOT
 # remove unused libtool files
 rm -f $RPM_BUILD_ROOT/%{_libdir}/*a
@@ -65,7 +63,6 @@ mkdir -p $RPM_BUILD_ROOT/%{_sysconfdir}/ld.so.conf.d
 echo "%{_libdir}/cmpi" > $RPM_BUILD_ROOT/%{_sysconfdir}/ld.so.conf.d/%{name}-%{_arch}.conf
 
 %files
-%defattr(-,root,root,0755)
 %{_libdir}/libcmpiOSBase_CommonFsvol*.so.*
 %{provider_dir}/libcmpiOSBase_LocalFileSystemProvider.so
 %{provider_dir}/libcmpiOSBase_NFSProvider.so
@@ -78,12 +75,10 @@ echo "%{_libdir}/cmpi" > $RPM_BUILD_ROOT/%{_sysconfdir}/ld.so.conf.d/%{name}-%{_
 %config(noreplace) %{_sysconfdir}/ld.so.conf.d/%{name}-%{_arch}.conf
 
 %files devel
-%defattr(-,root,root,0755)
 %{_libdir}/libcmpiOSBase_CommonFsvol*.so
 %{_includedir}/sblim/*Fsvol.h
 
 %files test
-%defattr(-,root,root,0755)
 %{_datadir}/sblim-testsuite/test-cmpi-fsvol.sh
 %{_datadir}/sblim-testsuite/cim/*FileSystem.cim
 %{_datadir}/sblim-testsuite/cim/*FS.cim
@@ -91,8 +86,8 @@ echo "%{_libdir}/cmpi" > $RPM_BUILD_ROOT/%{_sysconfdir}/ld.so.conf.d/%{name}-%{_
 %{_datadir}/sblim-testsuite/system/linux/*FileSystem.*
 %{_datadir}/sblim-testsuite/system/linux/*FileSystemEntries.*
 
-%define SCHEMA %{_datadir}/%{name}/Linux_Fsvol.mof
-%define REGISTRATION %{_datadir}/%{name}/Linux_Fsvol.registration
+%global SCHEMA %{_datadir}/%{name}/Linux_Fsvol.mof
+%global REGISTRATION %{_datadir}/%{name}/Linux_Fsvol.registration
 
 %pre
 function unregister()
@@ -183,10 +178,10 @@ fi
 
 %postun -p /sbin/ldconfig
 
-%clean
-rm -rf $RPM_BUILD_ROOT
-
 %changelog
+* Tue Sep 04 2012 Vitezslav Crhonek <vcrhonek at redhat.com> - 1.5.1-5
+- Fix issues found by fedora-review utility in the spec file
+
 * Sat Jul 21 2012 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 1.5.1-4
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild
 


More information about the scm-commits mailing list