[sblim-cmpi-params] Fix issues found by fedora-review utility in the spec file

vcrhonek vcrhonek at fedoraproject.org
Wed Sep 5 14:01:00 UTC 2012


commit 9c9e8f68802ac565d077c136cee2dc32e81aabe2
Author: Vitezslav Crhonek <vcrhonek at redhat.com>
Date:   Wed Sep 5 16:00:51 2012 +0200

    Fix issues found by fedora-review utility in the spec file

 sblim-cmpi-params.spec |   20 ++++++++------------
 1 files changed, 8 insertions(+), 12 deletions(-)
---
diff --git a/sblim-cmpi-params.spec b/sblim-cmpi-params.spec
index 3cb36bb..f348c7c 100644
--- a/sblim-cmpi-params.spec
+++ b/sblim-cmpi-params.spec
@@ -1,8 +1,8 @@
-%define provider_dir %{_libdir}/cmpi
+%global provider_dir %{_libdir}/cmpi
 
 Name:           sblim-cmpi-params
 Version:        1.3.0
-Release:        5%{?dist}
+Release:        6%{?dist}
 Summary:        SBLIM params instrumentation
 
 Group:          Applications/System
@@ -10,7 +10,6 @@ License:        EPL
 URL:            http://sblim.wiki.sourceforge.net/
 Source0:        http://downloads.sourceforge.net/sblim/%{name}-%{version}.tar.bz2
 Patch0:         sblim-cmpi-params-1.2.4-no-abi-params.patch
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
 BuildRequires:  sblim-cmpi-devel sblim-cmpi-base-devel
 Requires:       sblim-cmpi-base cim-server cim-schema
@@ -39,29 +38,23 @@ SBLIM Base Params Testcase Files for SBLIM Testsuite
 make %{?_smp_mflags}
 
 %install
-rm -rf $RPM_BUILD_ROOT
 make install DESTDIR=$RPM_BUILD_ROOT
 # remove unused libtool files
 rm -f $RPM_BUILD_ROOT/%{_libdir}/*.la
 rm -f $RPM_BUILD_ROOT/%{provider_dir}/*.la
 
-%clean
-rm -rf $RPM_BUILD_ROOT
-
 %files
-%defattr(-,root,root,-)
 %{provider_dir}/*.so
 %{_datadir}/%{name}
 %docdir %{_datadir}/doc/%{name}-%{version}
 %{_datadir}/doc/%{name}-%{version}
 
 %files test
-%defattr(-,root,root,-)
 %{_datadir}/sblim-testsuite
 
-%define SCHEMA %{_datadir}/%{name}/*.mof
-%define REGISTRATION %{_datadir}/%{name}/*.registration
-%define PEGASUS_MOF CIM_UnixLocalFileSystem
+%global SCHEMA %{_datadir}/%{name}/*.mof
+%global REGISTRATION %{_datadir}/%{name}/*.registration
+%global PEGASUS_MOF CIM_UnixLocalFileSystem
 
 %pre
 function unregister()
@@ -158,6 +151,9 @@ fi
 %postun -p /sbin/ldconfig
 
 %changelog
+* Wed Sep 05 2012 Vitezslav Crhonek <vcrhonek at redhat.com> - 1.3.0-6
+- Fix issues found by fedora-review utility in the spec file
+
 * Sat Jul 21 2012 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 1.3.0-5
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild
 


More information about the scm-commits mailing list