[sblim-cmpi-sysfs] Fix issues found by fedora-review utility in the spec file

vcrhonek vcrhonek at fedoraproject.org
Thu Sep 6 08:55:13 UTC 2012


commit b4c68da55181df4f06a0bead00477d1d35b2015c
Author: Vitezslav Crhonek <vcrhonek at redhat.com>
Date:   Thu Sep 6 10:55:01 2012 +0200

    Fix issues found by fedora-review utility in the spec file

 sblim-cmpi-sysfs.spec |   18 +++++++-----------
 1 files changed, 7 insertions(+), 11 deletions(-)
---
diff --git a/sblim-cmpi-sysfs.spec b/sblim-cmpi-sysfs.spec
index d75539c..355db72 100644
--- a/sblim-cmpi-sysfs.spec
+++ b/sblim-cmpi-sysfs.spec
@@ -1,15 +1,14 @@
-%define provider_dir %{_libdir}/cmpi
+%global provider_dir %{_libdir}/cmpi
 
 Name:           sblim-cmpi-sysfs
 Version:        1.2.0
-Release:        5%{?dist}
+Release:        6%{?dist}
 Summary:        SBLIM sysfs instrumentation
 
 Group:          Applications/System
 License:        EPL
 URL:            http://sblim.wiki.sourceforge.net/
 Source0:        http://downloads.sourceforge.net/sblim/%{name}-%{version}.tar.bz2
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
 # Patch0: already upstream,
 #         see http://sourceforge.net/tracker/index.php?func=detail&aid=2818227&group_id=128809&atid=712784
@@ -57,7 +56,6 @@ make
 
 
 %install
-rm -rf $RPM_BUILD_ROOT
 make install DESTDIR=$RPM_BUILD_ROOT
 # remove unused libtool files
 rm -f $RPM_BUILD_ROOT/%{_libdir}/*a
@@ -68,12 +66,8 @@ echo "%{_libdir}/cmpi" > $RPM_BUILD_ROOT/%{_sysconfdir}/ld.so.conf.d/%{name}-%{_
 mv $RPM_BUILD_ROOT/%{_libdir}/libLinux_SysfsAttributeUtil.so $RPM_BUILD_ROOT/%{provider_dir}
 mv $RPM_BUILD_ROOT/%{_libdir}/libLinux_SysfsDeviceUtil.so $RPM_BUILD_ROOT/%{provider_dir}
 
-%clean
-rm -rf $RPM_BUILD_ROOT
-
 
 %files
-%defattr(-,root,root,0755)
 %dir %{provider_dir}
 %{provider_dir}/libLinux_Sysfs*
 %{_datadir}/sblim-cmpi-sysfs
@@ -83,14 +77,13 @@ rm -rf $RPM_BUILD_ROOT
 
 
 %files test
-%defattr(-,root,root,0755)
 %{_datadir}/sblim-testsuite/sblim-cmpi-sysfs-test.sh
 %{_datadir}/sblim-testsuite/cim/Linux_Sysfs*
 %{_datadir}/sblim-testsuite/system/linux/Linux_Sysfs*
 
 
-%define SCHEMA %{_datadir}/%{name}/Linux_SysfsAttribute.mof %{_datadir}/%{name}/Linux_SysfsBlockDevice.mof %{_datadir}/%{name}/Linux_SysfsBusDevice.mof %{_datadir}/%{name}/Linux_SysfsInputDevice.mof %{_datadir}/%{name}/Linux_SysfsNetworkDevice.mof %{_datadir}/%{name}/Linux_SysfsSCSIDevice.mof %{_datadir}/%{name}/Linux_SysfsSCSIHostDevice.mof %{_datadir}/%{name}/Linux_SysfsTTYDevice.mof
-%define REGISTRATION %{_datadir}/%{name}/Linux_SysfsAttribute.registration %{_datadir}/%{name}/Linux_SysfsBlockDevice.registration %{_datadir}/%{name}/Linux_SysfsBusDevice.registration %{_datadir}/%{name}/Linux_SysfsInputDevice.registration %{_datadir}/%{name}/Linux_SysfsNetworkDevice.registration %{_datadir}/%{name}/Linux_SysfsSCSIDevice.registration %{_datadir}/%{name}/Linux_SysfsSCSIHostDevice.registration %{_datadir}/%{name}/Linux_SysfsTTYDevice.registration
+%global SCHEMA %{_datadir}/%{name}/Linux_SysfsAttribute.mof %{_datadir}/%{name}/Linux_SysfsBlockDevice.mof %{_datadir}/%{name}/Linux_SysfsBusDevice.mof %{_datadir}/%{name}/Linux_SysfsInputDevice.mof %{_datadir}/%{name}/Linux_SysfsNetworkDevice.mof %{_datadir}/%{name}/Linux_SysfsSCSIDevice.mof %{_datadir}/%{name}/Linux_SysfsSCSIHostDevice.mof %{_datadir}/%{name}/Linux_SysfsTTYDevice.mof
+%global REGISTRATION %{_datadir}/%{name}/Linux_SysfsAttribute.registration %{_datadir}/%{name}/Linux_SysfsBlockDevice.registration %{_datadir}/%{name}/Linux_SysfsBusDevice.registration %{_datadir}/%{name}/Linux_SysfsInputDevice.registration %{_datadir}/%{name}/Linux_SysfsNetworkDevice.registration %{_datadir}/%{name}/Linux_SysfsSCSIDevice.registration %{_datadir}/%{name}/Linux_SysfsSCSIHostDevice.registration %{_datadir}/%{name}/Linux_SysfsTTYDevice.registration
 
 %pre
 function unregister()
@@ -183,6 +176,9 @@ fi
 
 
 %changelog
+* Thu Sep 06 2012 Vitezslav Crhonek <vcrhonek at redhat.com> - 1.2.0-6
+- Fix issues found by fedora-review utility in the spec file
+
 * Sat Jul 21 2012 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 1.2.0-5
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild
 


More information about the scm-commits mailing list