[sblim-indication_helper] Fix issues found by fedora-review utility in the spec file

vcrhonek vcrhonek at fedoraproject.org
Thu Sep 6 12:44:43 UTC 2012


commit d6d851b1175d2a9e30b08184d36d3bc7d406e553
Author: Vitezslav Crhonek <vcrhonek at redhat.com>
Date:   Thu Sep 6 14:44:24 2012 +0200

    Fix issues found by fedora-review utility in the spec file

 sblim-indication_helper.spec |   14 +++++---------
 1 files changed, 5 insertions(+), 9 deletions(-)
---
diff --git a/sblim-indication_helper.spec b/sblim-indication_helper.spec
index da859a3..933b529 100644
--- a/sblim-indication_helper.spec
+++ b/sblim-indication_helper.spec
@@ -1,13 +1,12 @@
 Name:		sblim-indication_helper
 Version:	0.4.2
-Release:	7%{?dist}
+Release:	8%{?dist}
 Summary:	Toolkit for CMPI indication providers
 
 Group:		Development/Libraries
 License:	CPL
 URL:		http://sblim.wiki.sourceforge.net/
 Source0:	http://downloads.sourceforge.net/sblim/%{name}-%{version}.tar.bz2
-BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 Patch0:		sblim-indication_helper-0.4.2_warnings.patch
 Patch1:         missing-stderr-def.patch
 BuildRequires:	sblim-cmpi-devel 
@@ -45,12 +44,8 @@ make %{?_smp_mflags}
 
 
 %install
-rm -rf $RPM_BUILD_ROOT
 make install DESTDIR=$RPM_BUILD_ROOT
-rm %{buildroot}/%{_libdir}/libind_helper.la
-
-%clean
-rm -rf $RPM_BUILD_ROOT
+rm $RPM_BUILD_ROOT/%{_libdir}/libind_helper.la
 
 %post -p /sbin/ldconfig
 
@@ -58,20 +53,21 @@ rm -rf $RPM_BUILD_ROOT
 
 
 %files
-%defattr(-,root,root,-)
 %doc README COPYING ChangeLog TODO
 %{_libdir}/libind_helper.so.*
 
 
 
 %files devel
-%defattr(-,root,root,-)
 %{_includedir}/sblim
 %{_libdir}/libind_helper.so
 %doc COPYING
 
 
 %changelog
+* Thu Sep 06 2012 Vitezslav Crhonek <vcrhonek at redhat.com> - 0.4.2-8
+- Fix issues found by fedora-review utility in the spec file
+
 * Sat Jul 21 2012 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 0.4.2-7
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild
 


More information about the scm-commits mailing list