[tix] Fix issues found by fedora-review utility in the spec file

vcrhonek vcrhonek at fedoraproject.org
Mon Sep 10 12:13:01 UTC 2012


commit c328c3b70275d02311f330987f026b0c240a3a56
Author: Vitezslav Crhonek <vcrhonek at redhat.com>
Date:   Mon Sep 10 14:12:49 2012 +0200

    Fix issues found by fedora-review utility in the spec file

 tix.spec |   23 +++++++++--------------
 1 files changed, 9 insertions(+), 14 deletions(-)
---
diff --git a/tix.spec b/tix.spec
index a2e568d..bc2f87d 100644
--- a/tix.spec
+++ b/tix.spec
@@ -1,21 +1,20 @@
-%{!?tcl_version: %define tcl_version %(echo 'puts $tcl_version' | tclsh)}
-%{!?tcl_sitearch: %define tcl_sitearch %{_libdir}/tcl%{tcl_version}}
-%{!?tcl_sitelib: %define tcl_sitelib %{_datadir}/tcl%{tcl_version}}
-%define tixmajor 8.4
-%define tcltkver 8.4.13
+%{!?tcl_version: %global tcl_version %(echo 'puts $tcl_version' | tclsh)}
+%{!?tcl_sitearch: %global tcl_sitearch %{_libdir}/tcl%{tcl_version}}
+%{!?tcl_sitelib: %global tcl_sitelib %{_datadir}/tcl%{tcl_version}}
+%global tixmajor 8.4
+%global tcltkver 8.4.13
 
 Summary: A set of extension widgets for Tk
 Name: tix
 Epoch: 1
 Version: %{tixmajor}.3
-Release: 8%{?dist}
+Release: 9%{?dist}
 License: BSD
 Group: Development/Languages
 URL: http://tix.sourceforge.net/
 Source0: http://downloads.sourceforge.net/project/%{name}/%{name}/%{version}/Tix%{version}-src.tar.gz
 #  0: Fixes BZ#81297 (soname of libraries)
 Patch0: tix-8.4.2-link.patch
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 Requires: tcl(abi) = 8.5
 Requires: tcl >= %{tcltkver}, tk >= %{tcltkver}
 Requires: /etc/ld.so.conf.d
@@ -71,7 +70,6 @@ sed -i 's/\r//' docs/Release-8.4.0.txt
 make all %{?_smp_mflags} PKG_LIB_FILE=libTix.so
 
 %install
-rm -rf $RPM_BUILD_ROOT
 make install DESTDIR=$RPM_BUILD_ROOT PKG_LIB_FILE=libTix.so
 
 # move shared lib to tcl sitearch
@@ -106,33 +104,30 @@ find docs -name .cvsignore -exec rm '{}' ';'
 rm -f $RPM_BUILD_ROOT%{_libdir}/Tix%{tixmajor}/README.txt
 rm -f $RPM_BUILD_ROOT%{_libdir}/Tix%{tixmajor}/license.terms
 
-%clean
-rm -rf $RPM_BUILD_ROOT
-
 %post -p /sbin/ldconfig
 
 %postun -p /sbin/ldconfig
 
 %files
-%defattr(-,root,root,-)
 %{tcl_sitearch}/libTix.so
 %{tcl_sitearch}/Tix%{version}
 %{_sysconfdir}/ld.so.conf.d/*
 %doc *.txt *.html license.terms
 
 %files devel
-%defattr(-,root,root,-)
 %{_includedir}/tix.h
 %{_libdir}/libtix.so
 %{_libdir}/libTix.so
 %{_mandir}/mann/*.n*
 
 %files doc
-%defattr(-,root,root,-)
 %doc docs/*
 %doc %{tcl_sitelib}/Tix%{tixmajor}
 
 %changelog
+* Mon Sep 10 2012 Vitezslav Crhonek <vcrhonek at redhat.com> - 1:8.4.3-9
+- Fix issues found by fedora-review utility in the spec file
+
 * Sat Jul 21 2012 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 1:8.4.3-8
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild
 


More information about the scm-commits mailing list