[gnome-abrt/f17] Fix pylint problems
Jakub Filak
jfilak at fedoraproject.org
Thu Mar 28 21:57:50 UTC 2013
commit 87ba1eafd316a106643595c8aafda39577974b90
Author: Jakub Filak <jfilak at redhat.com>
Date: Thu Mar 28 19:21:31 2013 +0100
Fix pylint problems
Signed-off-by: Jakub Filak <jfilak at redhat.com>
gnome-abrt-0.2.10-fix_pylint_problems.patch | 76 +++++++++++++++++++++++++++
gnome-abrt.spec | 8 +++-
2 files changed, 83 insertions(+), 1 deletions(-)
---
diff --git a/gnome-abrt-0.2.10-fix_pylint_problems.patch b/gnome-abrt-0.2.10-fix_pylint_problems.patch
new file mode 100644
index 0000000..d92a472
--- /dev/null
+++ b/gnome-abrt-0.2.10-fix_pylint_problems.patch
@@ -0,0 +1,76 @@
+diff -ur gnome-abrt-0.2.10/pylintrc gnome-abrt-0.2.10.new/pylintrc
+--- gnome-abrt-0.2.10/pylintrc 2013-03-24 13:57:36.000000000 +0100
++++ gnome-abrt-0.2.10.new/pylintrc 2013-03-28 22:18:27.239019989 +0100
+@@ -41,7 +41,7 @@
+ # Set the output format. Available formats are text, parseable, colorized, msvs
+ # (visual studio) and html. You can also give a reporter class, eg
+ # mypackage.mymodule.MyReporterClass.
+-output-format=colorized
++output-format=parseable
+
+ # Include message's id in output
+ include-ids=yes
+diff -ur gnome-abrt-0.2.10/src/gnome_abrt/Makefile.am gnome-abrt-0.2.10.new/src/gnome_abrt/Makefile.am
+--- gnome-abrt-0.2.10/src/gnome_abrt/Makefile.am 2013-03-26 13:18:34.000000000 +0100
++++ gnome-abrt-0.2.10.new/src/gnome_abrt/Makefile.am 2013-03-28 22:20:59.495985267 +0100
+@@ -41,3 +41,6 @@
+ DISTCLEANFILES = __init__.py controller.py gnome_abrt_glade.py
+
+ all-local: __init__.py controller.py gnome_abrt_glade.py
++
++check-local: $(gnome_abrtexec_PYTHON)
++ $(PYLINT) --rcfile=$(top_builddir)/pylintrc $(abs_builddir)
+diff -ur gnome-abrt-0.2.10/src/gnome_abrt/Makefile.in gnome-abrt-0.2.10.new/src/gnome_abrt/Makefile.in
+--- gnome-abrt-0.2.10/src/gnome_abrt/Makefile.in 2013-03-28 09:19:01.000000000 +0100
++++ gnome-abrt-0.2.10.new/src/gnome_abrt/Makefile.in 2013-03-28 22:31:00.031293572 +0100
+@@ -600,6 +600,7 @@
+ fi; \
+ done
+ check-am: all-am
++ $(MAKE) $(AM_MAKEFLAGS) check-local
+ check: check-recursive
+ all-am: Makefile all-local
+ installdirs: installdirs-recursive
+@@ -743,6 +744,9 @@
+
+ all-local: __init__.py controller.py gnome_abrt_glade.py
+
++check-local: $(gnome_abrtexec_PYTHON)
++ $(PYLINT) --rcfile=$(top_builddir)/pylintrc $(abs_builddir)
++
+ # Tell versions [3.59,3.63) of GNU make to not export all variables.
+ # Otherwise a system limit (for SysV at least) may be exceeded.
+ .NOEXPORT:
+diff -ur gnome-abrt-0.2.10/src/gnome-abrt gnome-abrt-0.2.10.new/src/gnome-abrt
+--- gnome-abrt-0.2.10/src/gnome-abrt 2013-03-26 13:28:58.000000000 +0100
++++ gnome-abrt-0.2.10.new/src/gnome-abrt 2013-03-28 22:18:02.339861968 +0100
+@@ -61,6 +61,8 @@
+ """A proxy for primary application
+ """
+
++ #Interface not implemented
++ #pylint: disable=R0923
+ class Service(dbus.service.Object):
+ """DBus service sitting on session bus
+ """
+diff -ur gnome-abrt-0.2.10/src/Makefile.am gnome-abrt-0.2.10.new/src/Makefile.am
+--- gnome-abrt-0.2.10/src/Makefile.am 2013-03-24 13:57:36.000000000 +0100
++++ gnome-abrt-0.2.10.new/src/Makefile.am 2013-03-28 22:19:01.602237993 +0100
+@@ -10,4 +10,4 @@
+ EXTRA_DIST = $(bin_SCRIPTS) $(desktop_in_files)
+
+ check-local: $(bin_SCRIPTS)
+- $(PYLINT) --rcfile=$(top_builddir)/pylintrc $^ ./gnome_abrt
++ $(PYLINT) --rcfile=$(top_builddir)/pylintrc $^
+diff -ur gnome-abrt-0.2.10/src/Makefile.in gnome-abrt-0.2.10.new/src/Makefile.in
+--- gnome-abrt-0.2.10/src/Makefile.in 2013-03-28 09:19:01.000000000 +0100
++++ gnome-abrt-0.2.10.new/src/Makefile.in 2013-03-28 22:20:49.680923087 +0100
+@@ -732,7 +732,7 @@
+ @INTLTOOL_DESKTOP_RULE@
+
+ check-local: $(bin_SCRIPTS)
+- $(PYLINT) --rcfile=$(top_builddir)/pylintrc $^ ./gnome_abrt
++ $(PYLINT) --rcfile=$(top_builddir)/pylintrc $^
+
+ # Tell versions [3.59,3.63) of GNU make to not export all variables.
+ # Otherwise a system limit (for SysV at least) may be exceeded.
diff --git a/gnome-abrt.spec b/gnome-abrt.spec
index ee753aa..b61c7c4 100644
--- a/gnome-abrt.spec
+++ b/gnome-abrt.spec
@@ -6,13 +6,15 @@
Name: gnome-abrt
Version: 0.2.10
-Release: 1%{?dist}
+Release: 2%{?dist}
Summary: A utility for viewing problems that have occurred with the system
Group: User Interface/Desktops
License: GPLv2+
URL: https://fedorahosted.org/abrt/
Source0: https://fedorahosted.org/released/abrt/%{name}-%{version}.tar.gz
+# remove the patch with version > 0.2.10
+Patch0: gnome-abrt-0.2.10-fix_pylint_problems.patch
BuildRequires: intltool
BuildRequires: gettext
@@ -41,6 +43,7 @@ provides them with convenient way for managing these problems.
%prep
%setup -q
+%patch0 -p1
%build
@@ -94,6 +97,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
%changelog
+* Thu Mar 28 2013 Jakub Filak <jfilak at redhat.com> 0.2.10-2
+- Fix pylint problems
+
* Wed Mar 27 2013 Jakub Filak <jfilak at redhat.com> 0.2.10-1
- Add the report dialog to the menu
- Add 'Report problem with ABRT' dialog
More information about the scm-commits
mailing list