[libsigrokdecode] Adresss recommendations from review
Alex G
mrnuke at fedoraproject.org
Fri Mar 29 20:13:46 UTC 2013
commit 52b4e3b74c409bfac0d834f2f3c16074ac53c749
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date: Fri Mar 29 15:12:37 2013 -0500
Adresss recommendations from review
libsigrokdecode.spec | 15 ++++++++-------
1 files changed, 8 insertions(+), 7 deletions(-)
---
diff --git a/libsigrokdecode.spec b/libsigrokdecode.spec
index 5d3ba68..8b90380 100644
--- a/libsigrokdecode.spec
+++ b/libsigrokdecode.spec
@@ -1,6 +1,6 @@
Name: libsigrokdecode
Version: 0.1.1
-Release: 2%{?dist}
+Release: 3%{?dist}
Summary: Basic API for running protocol decoders
# Combined GPLv3+ and GPLv2+
License: GPLv3+
@@ -45,7 +45,7 @@ The %{name}-doc package contains documentation for developing software
using %{name}.
# Turn off the brp-python-bytecompile script
-# The pyhton files are designed to work with a python module that only exists
+# The python files are designed to work with a python module that only exists
# when called from libsigrokdecode. Trying to bytecompile them will break our
# build
%global __os_install_post %(echo '%{__os_install_post}' | sed -e 's!/usr/lib[^[:space:]]*/brp-python-bytecompile[[:space:]].*$!!g')
@@ -57,14 +57,13 @@ using %{name}.
%build
%configure --disable-static
-make %{?_smp_mflags}
+V=1 make %{?_smp_mflags}
# This builds documentation for the -doc package
doxygen Doxyfile
%install
-rm -rf %{buildroot}
%make_install
find %{buildroot} -name '*.la' -exec rm -f {} ';'
@@ -74,23 +73,25 @@ find %{buildroot} -name '*.la' -exec rm -f {} ';'
%files
-%defattr(-,root,root,-)
%doc README NEWS COPYING
%{_libdir}/libsigrokdecode.so.0*
%{_datadir}/libsigrokdecode/
%files devel
-%defattr(-,root,root,-)
%{_includedir}/sigrokdecode*.h
%{_libdir}/libsigrokdecode.so
%{_libdir}/pkgconfig/libsigrokdecode.pc
%files doc
-%defattr(-,root,root,-)
%doc doxy/html/
%changelog
+* Fri Mar 29 2013 mr.nuke.me at gmail.com - 0.1.1-3
+- Fix typo in comment
+- Make verbose build (V=1 make)
+- Remove unneeded buildroot and defattr tags
+
* Tue Mar 19 2013 Alexandru Gagniuc <mr.nuke.me at gmail.com> - 0.1.1-2
- Remove README from -devel subpackage (already included in main package)
- Remove ChangeLog from -doc subpackage (only contains a 'git log')
More information about the scm-commits
mailing list