[gdb/f18] Fix crash on 'gdb ""' (BZ 951251)..

Jan Kratochvil jankratochvil at fedoraproject.org
Fri Apr 12 15:16:24 UTC 2013


commit 35b5e58fc46c6fce7c6a0249213757157a4880e3
Author: Jan Kratochvil <jan.kratochvil at redhat.com>
Date:   Fri Apr 12 17:16:17 2013 +0200

    Fix crash on 'gdb ""' (BZ 951251)..

 gdb-f18-open-emptyname.patch |   20 ++++++++++++++++++++
 gdb.spec                     |    9 ++++++++-
 2 files changed, 28 insertions(+), 1 deletions(-)
---
diff --git a/gdb-f18-open-emptyname.patch b/gdb-f18-open-emptyname.patch
new file mode 100644
index 0000000..65d0e40
--- /dev/null
+++ b/gdb-f18-open-emptyname.patch
@@ -0,0 +1,20 @@
+gdb ""
+SEGV
+From archer.patch probably from archer-tromey-dwz-multifile-rebase .
+
+--- gdb-7.5.1/gdb/exec.c-orig	2013-04-12 16:58:46.426785095 +0200
++++ gdb-7.5.1/gdb/exec.c	2013-04-12 17:10:18.566927513 +0200
+@@ -226,11 +226,11 @@ exec_file_attach (char *filename, int fr
+ 	     &scratch_pathname);
+ 	}
+ #endif
++      if (scratch_chan < 0)
++	perror_with_name (filename);
+ 
+       cleanups = make_cleanup (xfree, scratch_pathname);
+ 
+-      if (scratch_chan < 0)
+-	perror_with_name (filename);
+       exec_bfd = gdb_bfd_fopen (scratch_pathname, gnutarget,
+ 				write_files ? FOPEN_RUB : FOPEN_RB,
+ 				scratch_chan);
diff --git a/gdb.spec b/gdb.spec
index ba0c40c..fdd395c 100644
--- a/gdb.spec
+++ b/gdb.spec
@@ -34,7 +34,7 @@ Version: 7.5.1
 
 # The release always contains a leading reserved number, start it at 1.
 # `upstream' is not a part of `name' to stay fully rpm dependencies compatible for the testing.
-Release: 37%{?dist}
+Release: 38%{?dist}
 
 License: GPLv3+ and GPLv3+ with exceptions and GPLv2+ and GPLv2+ with exceptions and GPL+ and LGPLv2+ and BSD and Public Domain
 Group: Development/Debuggers
@@ -609,6 +609,9 @@ Patch819: gdb-implicitpointer-offset.patch
 Patch820: gdb-rhbz890900-ppc-dis-1of2.patch
 Patch821: gdb-rhbz890900-ppc-dis-2of2.patch
 
+# Fix crash on 'gdb ""' (BZ 951251)..
+Patch830: gdb-f18-open-emptyname.patch
+
 %if 0%{!?rhel:1} || 0%{?rhel} > 6
 # RL_STATE_FEDORA_GDB would not be found for:
 # Patch642: gdb-readline62-ask-more-rh.patch
@@ -951,6 +954,7 @@ find -name "*.info*"|xargs rm -f
 %patch819 -p1
 %patch820 -p1
 %patch821 -p1
+%patch830 -p1
 
 %patch393 -p1
 %if 0%{!?el5:1} || 0%{?scl:1}
@@ -1447,6 +1451,9 @@ fi
 %endif # 0%{!?el5:1} || "%{_target_cpu}" == "noarch"
 
 %changelog
+* Fri Apr 12 2013 Jan Kratochvil <jan.kratochvil at redhat.com> - 7.5.1-38.fc18
+- Fix crash on 'gdb ""' (BZ 951251)..
+
 * Thu Mar 21 2013 Jan Kratochvil <jan.kratochvil at redhat.com> - 7.5.1-37.fc18
 - Fix crash regression from the dlopen of libpthread.so fix (BZ 911712).
 


More information about the scm-commits mailing list