[libspatialite] Disable tests on ARM and solve BZ 914148

Volker Fröhlich volter at fedoraproject.org
Sun Apr 14 20:22:21 UTC 2013


commit b84c344b3e42b4c94422b198c436fcd637156a59
Author: Volker Fröhlich <volker27 at gmx.at>
Date:   Sun Apr 14 22:20:44 2013 +0200

    Disable tests on ARM and solve BZ 914148
    
    - Disable hexgrid22 test on 32 bit systems
    - Disable tests on ARM

 libspatialite.spec |   26 +++++++++++++++++++++-----
 1 files changed, 21 insertions(+), 5 deletions(-)
---
diff --git a/libspatialite.spec b/libspatialite.spec
index 270975d..3398371 100644
--- a/libspatialite.spec
+++ b/libspatialite.spec
@@ -19,13 +19,18 @@
 #TODO: Fails to build, reported by mail. If geosadvanced is disabled, linker flags miss geos_c
 %global _geosadvanced "--disable-geosadvanced"
 # Checks are known to fail if libspatialite is built without geosadvanced
-#%global _no_checks 1
 # TODO: Check if that's still true anywhere
 %endif
 
+# At least 20 tests fail due to precision issues on ARM
+# Contacted the author about the matter
+%ifarch armv7hl
+  %global _no_checks 1
+%endif
+
 Name:      libspatialite
 Version:   4.0.0
-Release:   2%{?dist}
+Release:   3%{?dist}
 Summary:   Enables SQLite to support spatial data
 Group:     System Environment/Libraries
 License:   MPLv1.1 or GPLv2+ or LGPLv2+
@@ -60,6 +65,13 @@ developing applications that use %{name}.
 %prep
 %setup -q
 
+# Remove test failing on 32 bit systems
+# Contacted the author about it
+%ifarch i386 ppc
+  sed -i '/hexgrid22/ d' test/Makefile.in test/Makefile.am
+  rm test/sql_stmt_geosadvanced_tests/hexgrid22.testcase
+%endif
+
 
 %build
 %configure \
@@ -78,11 +90,11 @@ make install DESTDIR=%{buildroot}
 # Delete undesired libtool archives
 rm -f %{buildroot}/%{_libdir}/%{name}.la
 
-#%if 0%{?_no_checks}
-#%else
 %check
+%if 0%{?_no_checks}
+%else
 make check
-#%endif
+%endif
 
 
 %clean
@@ -107,6 +119,10 @@ rm -rf %{buildroot}
 
 
 %changelog
+* Mon Apr  8 2013 Volker Fröhlich <volker27 at gmx.at> - 4.0.0-3
+- Disable hexgrid22 test on 32 bit systems
+- Disable tests on ARM
+
 * Thu Feb 14 2013 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 4.0.0-2
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_19_Mass_Rebuild
 


More information about the scm-commits mailing list