[fedora-virt] [mst at redhat.com: [PATCH master+0.12] pci: irq_state vmstate breakage]

[Justin M. Forbes]

On Tue, 2010-05-11 at 15:14 +0300, Michael S. Tsirkin wrote:
> This is needed for F13 as well.
> 
> ----- Forwarded message from "Michael S. Tsirkin" <mst at redhat.com> -----
> 
> Date: Sun, 9 May 2010 19:15:16 +0300
> From: "Michael S. Tsirkin" <mst at redhat.com>
> To: quintela at redhat.com, qemu-devel at nongnu.org,
> 	Anthony Liguori <anthony at codemonkey.ws>
> Subject: [PATCH master+0.12] pci: irq_state vmstate breakage
> Message-ID: <20100509161503.GA20492 at redhat.com>
> 
> Code for saving irq_state got vm_state
> macros wrong, passing in the wrong parameter.
> As a result, we both saved a wrong value
> and restored it to a wrong offset.
> 
> This leads to device and bus irq counts getting
> out of sync, which in turn leads to interrupts getting lost or
> never cleared, such as
> https://bugzilla.redhat.com/show_bug.cgi?id=588133
> 
> Signed-off-by: Michael S. Tsirkin <mst at redhat.com>
> ---
> 
> Juan, could you please take a look at this patch?
> I managed to catch this bug by looking at
> a savevm image which already has a wrong value,
> but I could not reproduce it locally so I don't know
> for sure whether patch is enough, or there are other bugs.
> 
> Anthony, this is a regression introduced in
> eea4acfa5c1ef26439a718375475fe468b7f2fba
> so we need the fix on 0.12 branch as well.

Applied for the next updates in Fedora.

Thanks,
Justin