[fedora-virt] [qemu RPM PATCH] use --with variables for build-time settings

[Daniel P. Berrange]

On Wed, Mar 28, 2012 at 11:30:17AM -0300, Eduardo Habkost wrote:
> This keeps the Fedora and RHEL defaults as-is, but makes the spec code
> clearer.
> 
> I would like to get some review before committing this to the fedpkg
> repository.

This looks ok to me. You'll have to rebase though, since I just pushed
a couple of fixes to master, related to the x86only conditional.

> 
> Signed-off-by: Eduardo Habkost <ehabkost at redhat.com>
> ---
>  qemu.spec |   66 +++++++++++++++++++++++++++++++++++++++++++++++-------------
>  1 files changed, 51 insertions(+), 15 deletions(-)
> 
> diff --git a/qemu.spec b/qemu.spec
> index 7ab15d7..e711e72 100644
> --- a/qemu.spec
> +++ b/qemu.spec
> @@ -1,3 +1,39 @@
> +# build-time settings that support --with or --without:
> +#
> +# = x86only =
> +# Build only x86 Qemu targets.
> +#
> +# Disabled by default.
> +#
> +# = exclusive_x86_64 =
> +# ExclusiveArch: x86_64
> +#
> +# Disabled by default, except on RHEL.
> +#
> +# = rbd =
> +# Enable rbd support.
> +#
> +# Enable by default, except on RHEL.
> +#
> +# = fdt =
> +# Enable fdt support.
> +#
> +# Enabled by default, except on RHEL.

Fdt is only used by the PPC emulators, so if x86only is set,
we should disable fdt too.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|