Technical Debt Fighters, Assemble!
by Ralph Bean
At Flock, we talked about scheduling some kind of regular
technical-debt-fighting week to happen every so often - some period of
time where we don't do any new features (and even try to de-prioritize
interrupt-driven stuff) and focus on shoring up, cleaning up,
tightening the bolts, etc[1].
Here are some things broadly to think about:
- Add unit tests where there are none. Increase "code coverage".
- Write docs (and make diagrams!) where there are none.
- Reduce code duplication, and increase code re-use where appropriate.
- Break up ultra long methods, classes, and files into more
understandable chunks.
- Remove half-implemented features!
- Remove dead code!!
- Add comments where there are none, and correct inaccurate comments.
- Deal with the existential questions facing the code that none of us
wants to touch.
- Increase happiness and general zest for life.
Time-wise, how about we try and schedule a week to try this on the
first week back from the holiday break -- a New Year, a New
Infrastructure(!) That would be January 4-8th[2].
Here's a question I have. It seems like we could approach this in two
different ways:
- We could select one or two projects we want to prioritize, and try
to do *all* of the best-practices things to them.
- We could select one or two of the best-practices things, and try to
do them to *all* of our projects.
Or.. something inbetween. If you have a preferences here, chime in on
the list, or we can take this up in our IRC meeting at the beginning
of December, too.
As an aside, it would be especially fun if we could keep track of our
collective damage on some kind of scoreboard (it doesn't have to be
automatic, even manual pen-and-paper would work) so we can produce a
nice summary blogpost at the end and thus herald in 2016, a year of
working code, less fires, and quiet mornings where we sip our coffee
and read email.
-Ralph
[1] - http://threebean.org/presentations/debt-services-flock15/
[2] - https://apps.fedoraproject.org/calendar/meeting/3183/
8 years, 4 months
How to deal with endoflife AT fedoraproject DOT org service account ?
by Jan Kurik
Hi infrastructure team,
I am in doubt how to deal with "endoflife" service account. In fact,
it is not really an account, it is just an email alias. This email
address has been used for maintaining and housekeeping of old bugs in
Bugzilla.
The background:
This email alias used to be forwarded to triage@ mailing list. Some
time ago password policy of Bugzilla has changed and this
email/account become unavailable due to a weak password. To make this
email/account available again I had to request password reset of the
Bugzilla account. The password reset in Bugzilla is made via email and
the email to confirm the password reset had been sent to the publicly
available triage@ mailing list. Then I have realized that anybody can
hijack the account, using the password reset. To avoid this, I
redirected the endoflife Bugzilla account to my private email address.
However I to not think this is a good solution and I would like to
find a way how to solve this problem properly.
Currently, the best way I see, is to make the "endoflife" email alias
as a full-blown account in FAS, instead of email alias only. However
as far as I know, we are using FAS for real people only. So, my
question is, whether there is a better way how to deal with this
service email/account ?
Thanks for pointing me to the right direction :)
Best Regards,
Jan
--
Jan Kuřík
Platform & Fedora Program Manager
Red Hat Czech s.r.o., Purkynova 99/71, 612 45 Brno, Czech Republic
8 years, 4 months
[release] bodhi: 2.1.5
by Luke Macken
Hi folks,
I just spun up a new bugfix release of bodhi and pushed it to production.
The last release contained a bug that caused a snowball effect and a number of
updates were ejected from the last couple of pushes. This issue should
hopefully be resolved.
2.1.5
-----
Pull Requests
- (@trishnaguha) #723, Sorts the list of test cases
https://github.com/fedora-infra/bodhi/pull/723
- (@lmacken) #728, updates: Disable the ability to set a request for an archived release…
https://github.com/fedora-infra/bodhi/pull/728
- (@lmacken) #731, overrides: Gracefully handle duplicate submissions (fixes #713)
https://github.com/fedora-infra/bodhi/pull/731
- (@lmacken) #733, models: Don't delete Bugs that have BugKarma
https://github.com/fedora-infra/bodhi/pull/733
- (@lmacken) #736, models: Query the wiki for tests with a limit of 500 instead of the default of 10
https://github.com/fedora-infra/bodhi/pull/736
- (@lmacken) #737, email: Send comment notifications to the update submitter
https://github.com/fedora-infra/bodhi/pull/737
- (@lmacken) #738, models: Obsolete unlocked updates, even if they have an open request …
https://github.com/fedora-infra/bodhi/pull/738
- (@cgwalters) #739, ini: Link to wiki page for how to get updates instead of inline cmd
https://github.com/fedora-infra/bodhi/pull/739
- (@ralphbean) #742, Remove unnecessary encoding of bug titles.
https://github.com/fedora-infra/bodhi/pull/742
Commits
- d801e07ff Sorts the list of test cases
https://github.com/fedora-infra/bodhi/commit/d801e07ff
- 6c4023390 updates: Disable the ability to set a request for an archived release (issue #725)
https://github.com/fedora-infra/bodhi/commit/6c4023390
- 6879f0d02 overrides: Gracefully handle duplicate submissions (fixes #713)
https://github.com/fedora-infra/bodhi/commit/6879f0d02
- 65794626b models: Don't delete Bugs that have BugKarma (fixes #732)
https://github.com/fedora-infra/bodhi/commit/65794626b
- b99c0f1a0 bootstrap: Add a hack for PIL to link the Pillow egg-info into our virtualenv
https://github.com/fedora-infra/bodhi/commit/b99c0f1a0
- c4ba820da models: Query the wiki for tests with a limit of 500 instead of the default of 10
https://github.com/fedora-infra/bodhi/commit/c4ba820da
- c1a2247a7 email: Send comment notifications to the update submitter (fixes #726)
https://github.com/fedora-infra/bodhi/commit/c1a2247a7
- 8ecf380a5 models: Obsolete unlocked updates, even if they have an open request (fixes #724)
https://github.com/fedora-infra/bodhi/commit/8ecf380a5
- da17ec271 ini: Link to wiki page for how to get updates instead of inline cmd
https://github.com/fedora-infra/bodhi/commit/da17ec271
- 05e992d46 tests: Fix up some bugs from PR#739
https://github.com/fedora-infra/bodhi/commit/05e992d46
- e7c363a41 tests: Fix the name of a unit test
https://github.com/fedora-infra/bodhi/commit/e7c363a41
- 5d2a2b14f Remove unnecessary encoding of bug titles.
https://github.com/fedora-infra/bodhi/commit/5d2a2b14f
- 1ca762d0e Fix test case.
https://github.com/fedora-infra/bodhi/commit/1ca762d0e
- d54c77b94 masher: Minor tweaks to the sync/async tagging
https://github.com/fedora-infra/bodhi/commit/d54c77b94
- d6300ae90 util: Ensure updates aren't listen in both the sync/async batches
https://github.com/fedora-infra/bodhi/commit/d6300ae90
- 5722929fe util: Clean up some logging output
https://github.com/fedora-infra/bodhi/commit/5722929fe
8 years, 5 months
Infrastructure Holiday Freeze now in effect
by Patrick Uiterwijk
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Hi all,
As agreed during last meeting, and as done in previous years, we are now
in an infrastructure soft-freeze until 2016-01-04.
This means that hosts that are marked as freezing should not have any
changes made to them except as part of a freeze break request
(see below).
We do this to make sure that our infrastructure is stable and prevent
unnecessary alerts to the sysadmins while they are off. This freeze will
end on the first working day of the new year (2016-01-04).
For soft freezes, freeze breaks should be discussed either on this list,
or discussed on IRC. Freeze breaks can be applied when either they got
a +1 from anyone in the sysadmin-main group, or an ack from one of the
main sysadmin people (nirik, smooge, puiterwijk).
You can see a list of hosts that do not freeze by checking out the
ansible repo and running the freezelist script:
git clone http://infrastructure.fedoraproject.org/infra/ansible.git
scripts/freezelist -i inventory
- --
With kind regards,
Patrick Uiterwijk
Fedora Infra
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCgAGBQJWeABQAAoJEIZXmA2atR5QJ9YQAI09YaS5N4aNI9yM7e1Xrwqd
Hu7QlMhvcOVcXeWrex0puzqCHnFOYbGXwuJlidK/sfsnQzh2rk4a3TWI8lM/aPq7
8GDbTpdecERjTC8hlaEUUbWFfMA2oGAyrGtn/h0ZrSZZQywBFZ+2rXM3er9U22Mn
u6+9NLGKxOZHrTx81cYdxq4EclUiNzVkiEu54oaujpp9r1btHKt3ULcEIw0QK9//
+QHWd6Zxn0VCqyJ+Dk/m5LTXCGAV0dzGnmZ0MvnOQDD0y2OjdnQQqKi+4fDPBFaF
5UfMtvOriXgUiTHF6/6IfyooQX4lFH2JtPVfdAW+OZ9w4fAy1ny0Bl26SYG+uUQ6
YQxc3PlNtatoVDr/wERxZm8L+pz0w3YIwC/6YE8zxaGnbXF6nJS2yByZxI8x3XpG
9Tfa4+g108fZN5+KjYEMRldTCiBwVZ+RrgbPaQupWJv7tNMaWMJeWa5bkaIO+XiU
q3sNdlw72ylxMaz16RaqDsAGozUneOeItmkuhbCnhZ5Y00FEbup4dBu8fOZmza7K
JpQseo+kzFLT93KZzAKvJD+5LJkRgqUeAqEZ+lyl7mTkvBTeUlnwC7ghhvvhbYi8
GK87uTlNSMQrQyEGB1tFJLmaWpYqf/VUZEf4CwQiKf+9ezNUv3V98jEH3i1/V3EC
UrZnI+Ibz0RwDc2Tqniq
=wYrq
-----END PGP SIGNATURE-----
8 years, 5 months
[release] pkgdb2: 2.0.2
by Pierre-Yves Chibon
Good Morning everyone,
I just cut a new pkgdb release: 2.0.2
Here is the changelog:
* Mon Dec 21 2015 Pierre-Yves Chibon <pingou(a)pingoured.fr> - 2.0.2-1
- Update to 2.0.2
- Fix the opensearch integration
I just really wanted to fix this one before the holidays as it kinda really
bothered me :)
Now I can finally type `pkgdb <foo>` in my web-browser and get the results I
want.
Happy packaging,
Pierre
8 years, 5 months
[release] pkgdb2: 2.0.1
by Pierre-Yves Chibon
Good morning everyone,
I just cut a new pkgdb release: 2.0.1, fixing bugs of the 2.0 release.
Here is the changelog:
* Fri Dec 18 2015 Pierre-Yves Chibon <pingou(a)pingoured.fr> - 2.0.1-1
- Update to 2.0.1
- Fix typo in a variable name that was making requesting a new package fail
(Patrick Uiterwijk)
- Fix giving ACLs to someone
- Fix editing a new package request (where the request is not associated to any
package)
All the changes were made with new unit-tests to prevent future regression.
Happy packaging,
Pierre
8 years, 5 months
[release] pkgdb2: 2.0
by Pierre-Yves Chibon
Good Morning everyone,
I just cut a new pkgdb2 release: 2.0
The changelog is short but the PR leading to it pretty large:
* Thu Dec 17 2015 Pierre-Yves Chibon <pingou(a)pingoured.fr> - 2.0-1
- Update to 2.0
- Add the concept of namespace to all the packages present in pkgdb2
And the PR (for the curious):
https://github.com/fedora-infra/pkgdb2/pull/293
This is currently happily running in stg and is scheduled to be updated in prod
later today.
Happy packaging,
Pierre
8 years, 5 months
[release] MirrorManager2: 0.6 and 0.6.1
by Pierre-Yves Chibon
Good morning everyone,
I just cut a new MirrorManager2 release: 0.6.1 which follows the 0.6 release of
yesterday.
Here is the changelog:
* Thu Dec 17 2015 Pierre-Yves Chibon <pingou(a)pingoured.fr> - 0.6.1-1
- Update to 0.6.1
- Fix mirrorlist to access info from the just loaded pickle (Patrick Uiterwijk)
* Wed Dec 16 2015 Pierre-Yves Chibon <pingou(a)pingoured.fr> - 0.6-1
- Update to 0.6
- Really ensure that new host is admin_active (Seth Jennings)
- Add the possibility to kill rsync after some time
- Add headers to the table listing the mirrors
- Cascade deletion and bring back the rsyncFilter endpoint
- Fix to the crawler (Adrian Reber)
- Improved documentation and validation
- Optionally exclude certain protocols from MM (Adrian Reber)
- Import generate-worldmap from MM1 (Adrian Reber)
- Optionally display mirrorlist statistics (Adrian Reber)
- mirrorlist: Remove --debug option (Adrian Reber)
- More mirrorlist statistics changes and spec file integration (Adrian Reber)
- Switch the MirrorList server to use threading rather than forking (Patrick
Uiterwijk)
0.6 is running in stg and Adrian is working on update it to 0.6.1.
Happy mirroring,
Pierre
8 years, 5 months
Plan for tomorrow's Fedora Infrastructure meeting - 2015-12-17
by Kevin Fenzi
The infrastructure team will be having it's weekly meeting tomorrow,
2015-12-17 at 18:00 UTC in #fedora-meeting on the freenode network.
We have a gobby document
(see: https://fedoraproject.org/wiki/Gobby )
fedora-infrastructure-meeting-next is the document.
Please try and review and edit that document before the meeting and we
will use it to have our agenda of things to discuss. A copy as of today
is included in this email.
If you have something to discuss, add the topic to the discussion area
with your name. If you would like to teach other folks about some
application or setup in our infrastructure, please add that topic and
your name to the learn about section.
kevin
--
= Introduction =
This shared document is for the next fedora infrastructure meeting.
We will use it over the week before the meeting to gather status and info and
discussion items and so forth, then use it in the irc meeting to transfer
information to the meetbot logs.
= Meeting start stuff =
#startmeeting Infrastructure (2015-12-17)
#meetingname infrastructure
#topic aloha
#chair smooge relrod nirik abadger1999 lmacken dgilmore mdomsch threebean pingou puiterwijk pbrobinson
#topic New folks introductions / Apprentice feedback
= Status / information / Trivia / Announcements =
(We put things here we want others on the team to know, but don't need to discuss)
(Please use #info <the thing> - your name)
#topic announcements and information
#info [release] pkgdb2: 1.33.3 - Pierre-Yves - http://lists.fedoraproject.org/archives/list/infrastructure@lists.fedorap...
#info [release] pagure: 0.1.36 - Pierre-Yves - http://lists.fedoraproject.org/archives/list/infrastructure@lists.fedorap...
#info [release] fedmsg_meta_fedora_infrastructure: 0.15.6 - Ralph - http://lists.fedoraproject.org/archives/list/infrastructure@lists.fedorap...
#info New fedmsg message types - nagios and pungi-koji - Ralph
#info Namespacing in pkgdb planned to go live on Thursday - Pierre-Yves/Ralph - http://lists.fedoraproject.org/archives/list/infrastructure@lists.fedorap...
#info more work on ansible 2.0 compatibility. Will likely switch to it full time once callback_plugins are working - kevin
#info more work on making playbooks idempotent - kevin
#info Many people on vacation next few weeks, check the vacation calendar before you look for someone - kevin
#info No meetings on 24th and 31st.
#info Smooge and Kevin at phx2 second week in jan - kevin/smooge
= Things we should discuss =
We use this section to bring up discussion topics. Things we want to talk about
as a group and come up with some consensus or decision or just brainstorm a
problem or issue. If there are none of these we skip this section.
(Use #topic your discussion topic - your username)
#topic Technical Debt-Fighting Week 2016-01-05 through 2016-01-08 - Ralph
#link https://fedoraproject.org/wiki/Infrastructure/Debt
Just wanted to give another chance here to brainstorm things we want to work on.
#topic
= Learn about some application or setup in infrastructure =
(This section, each week we get 1 person to talk about an application or setup
that we have. Just going over what it is, how to contribute, ideas for improvement,
etc. Whoever would like to do this, just add the info in this section. In the
event we don't find someone to teach about something, we skip this section
and just move on to open floor.)
Schedule:
2015-12-18 - ????
2015-12-24 - no meeting
2015-12-31 - no meeting
#topic Learn about:
= Meeting end stuff =
#topic Open Floor
#endmeeting
8 years, 5 months