389-commits February 2012

389-commits@lists.fedoraproject.org

4 participants
68 discussions

ldap/servers
by Richard Allen Megginson 16 Feb '12

16 Feb '12

ldap/servers/plugins/dna/dna.c | 2 +- ldap/servers/plugins/referint/referint.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) New commits: commit 144af5987dad38152e61f2e056ced3aa19eaa532 Author: Rich Megginson <rmeggins(a)redhat.com> Date: Thu Feb 16 08:14:43 2012 -0700 coverity uninit var and resource leak 12550 Uninitialized pointer read In dna_update_config_event(): Reads an uninitialized pointer or its target 12549 Resource leak In referint_thread_func(): Leak of memory or pointers to system resources Reviewed by: mreynolds (Thanks!) diff --git a/ldap/servers/plugins/dna/dna.c b/ldap/servers/plugins/dna/dna.c index fedfa50..efb2de4 100644 --- a/ldap/servers/plugins/dna/dna.c +++ b/ldap/servers/plugins/dna/dna.c @@ -1271,7 +1271,7 @@ dna_load_host_port() static void dna_update_config_event(time_t event_time, void *arg) { - Slapi_PBlock *pb; + Slapi_PBlock *pb = NULL; struct configEntry *config_entry = NULL; PRCList *list = NULL; char *binddn = (char *)arg; diff --git a/ldap/servers/plugins/referint/referint.c b/ldap/servers/plugins/referint/referint.c index 775da59..ee7c781 100644 --- a/ldap/servers/plugins/referint/referint.c +++ b/ldap/servers/plugins/referint/referint.c @@ -920,6 +920,7 @@ referint_thread_func(void *arg) if(plugin_argv == NULL){ slapi_log_error( SLAPI_LOG_FATAL, REFERINT_PLUGIN_SUBSYSTEM, "referint_thread_func not get args \n" ); + slapi_pblock_destroy(pb); return; }

1 0

ldap/schema ldap/servers
by Mark Reynolds 15 Feb '12

15 Feb '12

ldap/schema/01core389.ldif | 2 ldap/servers/plugins/automember/automember.c | 16 +-- ldap/servers/plugins/dna/dna.c | 107 ++++++++++++------------ ldap/servers/plugins/linkedattrs/fixup_task.c | 22 +++- ldap/servers/plugins/linkedattrs/linked_attrs.c | 36 ++++---- ldap/servers/plugins/linkedattrs/linked_attrs.h | 1 ldap/servers/plugins/memberof/memberof.c | 51 +++++++---- ldap/servers/plugins/mep/mep.c | 24 ++--- ldap/servers/plugins/referint/referint.c | 41 ++++++--- ldap/servers/slapd/add.c | 41 ++++++++- ldap/servers/slapd/config.c | 17 +++ ldap/servers/slapd/libglobs.c | 17 +++ ldap/servers/slapd/modify.c | 20 +++- ldap/servers/slapd/modrdn.c | 12 ++ ldap/servers/slapd/opshared.c | 23 ++++- ldap/servers/slapd/pblock.c | 73 ++++++++++++++-- ldap/servers/slapd/plugin_internal_op.c | 17 ++- ldap/servers/slapd/proto-slap.h | 2 ldap/servers/slapd/slap.h | 3 ldap/servers/slapd/slapi-plugin.h | 14 +++ 20 files changed, 381 insertions(+), 158 deletions(-) New commits: commit f7b882a8eebf62f15a7802ae4048c8153575d11e Author: Mark Reynolds <mareynol(a)redhat.com> Date: Wed Feb 15 16:33:06 2012 -0500 Ticket #111 - ability to control behavior of modifyTimestamp/modifiersName Bug Description: Currently, the modifiersname/creatorsname is set to the plugin name, if the plugin performed the add or modification. There is no way to track the original bind dn that trigger the update. Fix Description: Added a new config setting(nsslapd-plugin-binddn-tracking) that will update a set of new operational attributes: internalModifiersname & internalCreatorsname These attributes will store the plugin dn that made the update, while modifiersname/creatorsname will now be the bind dn that initiated the operation. https://fedorahosted.org/389/ticket/111 Reviewed by: richm (Thanks Rich!) diff --git a/ldap/schema/01core389.ldif b/ldap/schema/01core389.ldif index cf30ab0..a4d71e0 100644 --- a/ldap/schema/01core389.ldif +++ b/ldap/schema/01core389.ldif @@ -128,6 +128,8 @@ attributeTypes: ( 2.16.840.1.113730.3.1.2091 NAME 'nsslapd-suffix' DESC 'Netscap attributeTypes: ( 2.16.840.1.113730.3.1.2092 NAME 'nsslapd-ldapiautodnsuffix' DESC 'Netscape defined attribute type' SYNTAX 1.3.6.1.4.1.1466.115.121.1.12 X-ORIGIN 'Netscape' ) attributeTypes: ( 2.16.840.1.113730.3.1.2095 NAME 'connection' DESC 'Netscape defined attribute type' SYNTAX 1.3.6.1.4.1.1466.115.121.1.15 X-ORIGIN 'Netscape' ) attributeTypes: ( 2.16.840.1.113730.3.1.2096 NAME 'entryusn' DESC 'Netscape defined attribute type' SYNTAX 1.3.6.1.4.1.1466.115.121.1.27 SINGLE-VALUE NO-USER-MODIFICATION USAGE directoryOperation X-ORIGIN 'Netscape' ) +attributeTypes: ( 2.16.840.1.113730.3.1.2113 NAME 'internalModifiersName' DESC 'plugin dn' SYNTAX 1.3.6.1.4.1.1466.115.121.1.12 SINGLE-VALUE NO-USER-MODIFICATION USAGE directoryOperation X-ORIGIN '389 Directory Server' ) +attributeTypes: ( 2.16.840.1.113730.3.1.2114 NAME 'internalCreatorsName' DESC 'plugin dn' SYNTAX 1.3.6.1.4.1.1466.115.121.1.12 SINGLE-VALUE NO-USER-MODIFICATION USAGE directoryOperation X-ORIGIN '389 Directory Server' ) attributeTypes: ( 2.16.840.1.113730.3.1.2111 NAME 'tombstoneNumSubordinates' DESC 'count of immediate subordinates for tombstone entries' EQUALITY integerMatch diff --git a/ldap/servers/plugins/automember/automember.c b/ldap/servers/plugins/automember/automember.c index 92d5ae6..06f27bd 100644 --- a/ldap/servers/plugins/automember/automember.c +++ b/ldap/servers/plugins/automember/automember.c @@ -103,8 +103,8 @@ static struct automemberRegexRule *automember_parse_regex_rule(char *rule_string static void automember_free_regex_rule(struct automemberRegexRule *rule); static int automember_parse_grouping_attr(char *value, char **grouping_attr, char **grouping_value); -static void automember_update_membership(struct configEntry *config, Slapi_Entry *e, void *txn); -static void automember_add_member_value(Slapi_Entry *member_e, const char *group_dn, +static void automember_update_membership(Slapi_PBlock *pb, struct configEntry *config, Slapi_Entry *e, void *txn); +static void automember_add_member_value(Slapi_PBlock *pb, Slapi_Entry *member_e, const char *group_dn, char *grouping_attr, char *grouping_value, void *txn); /* @@ -1347,7 +1347,7 @@ automember_parse_grouping_attr(char *value, char **grouping_attr, char **groupin * the rules in config, then performs the updates. */ static void -automember_update_membership(struct configEntry *config, Slapi_Entry *e, void *txn) +automember_update_membership(Slapi_PBlock *pb, struct configEntry *config, Slapi_Entry *e, void *txn) { PRCList *rule = NULL; struct automemberRegexRule *curr_rule = NULL; @@ -1500,14 +1500,14 @@ automember_update_membership(struct configEntry *config, Slapi_Entry *e, void *t if (PR_CLIST_IS_EMPTY(&targets)) { /* Add to each default group. */ for (i = 0; config->default_groups && config->default_groups[i]; i++) { - automember_add_member_value(e, config->default_groups[i], + automember_add_member_value(pb, e, config->default_groups[i], config->grouping_attr, config->grouping_value, txn); } } else { /* Update the target groups. */ dnitem = (struct automemberDNListItem *)PR_LIST_HEAD(&targets); while ((PRCList *)dnitem != &targets) { - automember_add_member_value(e, slapi_sdn_get_dn(dnitem->dn), + automember_add_member_value(pb, e, slapi_sdn_get_dn(dnitem->dn), config->grouping_attr, config->grouping_value, txn); dnitem = (struct automemberDNListItem *)PR_NEXT_LINK((PRCList *)dnitem); } @@ -1535,10 +1535,10 @@ automember_update_membership(struct configEntry *config, Slapi_Entry *e, void *t * Adds a member entry to a group. */ static void -automember_add_member_value(Slapi_Entry *member_e, const char *group_dn, +automember_add_member_value(Slapi_PBlock *pb, Slapi_Entry *member_e, const char *group_dn, char *grouping_attr, char *grouping_value, void *txn) { - Slapi_PBlock *mod_pb = slapi_pblock_new(); + Slapi_PBlock *mod_pb = slapi_pblock_new_by_pb(pb); int result = LDAP_SUCCESS; LDAPMod mod; LDAPMod *mods[2]; @@ -1826,7 +1826,7 @@ automember_add_post_op(Slapi_PBlock *pb) if (slapi_dn_issuffix(slapi_sdn_get_dn(sdn), config->scope) && (slapi_filter_test_simple(e, config->filter) == 0)) { /* Find out what membership changes are needed and make them. */ - automember_update_membership(config, e, txn); + automember_update_membership(pb, config, e, txn); } list = PR_NEXT_LINK(list); diff --git a/ldap/servers/plugins/dna/dna.c b/ldap/servers/plugins/dna/dna.c index a422055..fedfa50 100644 --- a/ldap/servers/plugins/dna/dna.c +++ b/ldap/servers/plugins/dna/dna.c @@ -216,7 +216,7 @@ static int dna_exop_init(Slapi_PBlock * pb); * Local operation functions * */ -static int dna_load_plugin_config(); +static int dna_load_plugin_config(Slapi_PBlock *pb); static int dna_parse_config_entry(Slapi_Entry * e, int apply); static void dna_delete_config(); static void dna_free_config_entry(struct configEntry ** entry); @@ -230,26 +230,26 @@ static int dna_load_host_port(); static char *dna_get_dn(Slapi_PBlock * pb); static Slapi_DN *dna_get_sdn(Slapi_PBlock * pb); static int dna_dn_is_config(char *dn); -static int dna_get_next_value(struct configEntry * config_entry, +static int dna_get_next_value(Slapi_PBlock *pb, struct configEntry * config_entry, char **next_value_ret, void *txn); static int dna_first_free_value(struct configEntry *config_entry, PRUint64 *newval, void *txn); -static int dna_fix_maxval(struct configEntry *config_entry, void *txn); -static void dna_notice_allocation(struct configEntry *config_entry, +static int dna_fix_maxval(Slapi_PBlock *pb, struct configEntry *config_entry, void *txn); +static void dna_notice_allocation(Slapi_PBlock *pb, struct configEntry *config_entry, PRUint64 new, PRUint64 last, int fix, void *txn); -static int dna_update_shared_config(struct configEntry * config_entry, void *txn); +static int dna_update_shared_config(Slapi_PBlock *pb, struct configEntry * config_entry, void *txn); static void dna_update_config_event(time_t event_time, void *arg); static int dna_get_shared_servers(struct configEntry *config_entry, PRCList **servers, void *txn); static void dna_free_shared_server(struct dnaServer **server); static void dna_delete_shared_servers(PRCList **servers); -static int dna_release_range(char *range_dn, PRUint64 *lower, PRUint64 *upper); +static int dna_release_range(Slapi_PBlock *pb, char *range_dn, PRUint64 *lower, PRUint64 *upper); static int dna_request_range(struct configEntry *config_entry, struct dnaServer *server, PRUint64 *lower, PRUint64 *upper); static struct berval *dna_create_range_request(char *range_dn); -static int dna_update_next_range(struct configEntry *config_entry, +static int dna_update_next_range(Slapi_PBlock *pb, struct configEntry *config_entry, PRUint64 lower, PRUint64 upper, void *txn); -static int dna_activate_next_range(struct configEntry *config_entry, void *txn); +static int dna_activate_next_range(Slapi_PBlock *pb, struct configEntry *config_entry, void *txn); static int dna_is_replica_bind_dn(char *range_dn, char *bind_dn); static int dna_get_replica_bind_creds(char *range_dn, struct dnaServer *server, char **bind_dn, char **bind_passwd, @@ -589,7 +589,7 @@ dna_start(Slapi_PBlock * pb) slapi_ch_calloc(1, sizeof(struct configEntry)); PR_INIT_CLIST(dna_global_config); - if (dna_load_plugin_config() != DNA_SUCCESS) { + if (dna_load_plugin_config(pb) != DNA_SUCCESS) { slapi_log_error(SLAPI_LOG_FATAL, DNA_PLUGIN_SUBSYSTEM, "dna_start: unable to load plug-in configuration\n"); return DNA_FAILURE; @@ -657,7 +657,7 @@ done: * ------ cn=etc etc */ static int -dna_load_plugin_config() +dna_load_plugin_config(Slapi_PBlock *pb) { int status = DNA_SUCCESS; int result; @@ -665,13 +665,14 @@ dna_load_plugin_config() time_t now; Slapi_PBlock *search_pb; Slapi_Entry **entries = NULL; + char *dn = NULL; slapi_log_error(SLAPI_LOG_TRACE, DNA_PLUGIN_SUBSYSTEM, "--> dna_load_plugin_config\n"); dna_write_lock(); dna_delete_config(); - + slapi_pblock_get(pb, SLAPI_REQUESTOR_DN, &dn); search_pb = slapi_pblock_new(); slapi_search_internal_set_pb(search_pb, getPluginDN(), @@ -704,8 +705,9 @@ dna_load_plugin_config() * performing the operation at this point when * starting up would cause the change to not * get changelogged. */ + time(&now); - slapi_eq_once(dna_update_config_event, NULL, now + 30); + slapi_eq_once(dna_update_config_event, (void *)slapi_ch_strdup(dn), now + 30); cleanup: slapi_free_search_results_internal(search_pb); @@ -1269,9 +1271,10 @@ dna_load_host_port() static void dna_update_config_event(time_t event_time, void *arg) { - Slapi_PBlock *pb = NULL; + Slapi_PBlock *pb; struct configEntry *config_entry = NULL; PRCList *list = NULL; + char *binddn = (char *)arg; /* Get read lock to prevent config changes */ dna_read_lock(); @@ -1288,9 +1291,11 @@ dna_update_config_event(time_t event_time, void *arg) /* Create the pblock. We'll reuse this for all * shared config updates. */ - if ((pb = slapi_pblock_new()) == NULL) + if ((pb = slapi_pblock_new_by_pb(NULL)) == NULL) goto bail; + slapi_pblock_set(pb, SLAPI_REQUESTOR_DN, binddn); + while (list != dna_global_config) { config_entry = (struct configEntry *) list; @@ -1308,7 +1313,7 @@ dna_update_config_event(time_t event_time, void *arg) slapi_delete_internal_pb(pb); /* Now force the entry to be recreated */ - dna_update_shared_config(config_entry, NULL); + dna_update_shared_config(pb, config_entry, NULL); slapi_unlock_mutex(config_entry->lock); slapi_pblock_init(pb); @@ -1320,6 +1325,7 @@ dna_update_config_event(time_t event_time, void *arg) bail: dna_unlock(); + slapi_ch_free((void **)&binddn); slapi_pblock_destroy(pb); } @@ -1336,7 +1342,7 @@ bail: * The lock for configEntry should be obtained * before calling this function. */ -static int dna_fix_maxval(struct configEntry *config_entry, void *txn) +static int dna_fix_maxval(Slapi_PBlock *pb, struct configEntry *config_entry, void *txn) { PRCList *servers = NULL; PRCList *server = NULL; @@ -1351,7 +1357,7 @@ static int dna_fix_maxval(struct configEntry *config_entry, void *txn) /* If we already have a next range we only need * to activate it. */ if (config_entry->next_range_lower != 0) { - ret = dna_activate_next_range(config_entry, txn); + ret = dna_activate_next_range(pb, config_entry, txn); if (ret != 0) { slapi_log_error(SLAPI_LOG_FATAL, DNA_PLUGIN_SUBSYSTEM, "dna_fix_maxval: Unable to activate the " @@ -1375,7 +1381,7 @@ static int dna_fix_maxval(struct configEntry *config_entry, void *txn) } else { /* Someone provided us with a new range. Attempt * to update the config. */ - if ((ret = dna_update_next_range(config_entry, lower, upper, txn)) == 0) { + if ((ret = dna_update_next_range(pb, config_entry, lower, upper, txn)) == 0) { break; } } @@ -1406,7 +1412,7 @@ bail: * The lock for configEntry should be obtained before calling * this function. */ static void -dna_notice_allocation(struct configEntry *config_entry, PRUint64 new, +dna_notice_allocation(Slapi_PBlock *pb, struct configEntry *config_entry, PRUint64 new, PRUint64 last, int fix, void *txn) { /* update our cached config entry */ @@ -1421,7 +1427,7 @@ dna_notice_allocation(struct configEntry *config_entry, PRUint64 new, * new active range. */ if (config_entry->next_range_lower != 0) { /* Make the next range active */ - if (dna_activate_next_range(config_entry, txn) != 0) { + if (dna_activate_next_range(pb, config_entry, txn) != 0) { slapi_log_error(SLAPI_LOG_FATAL, DNA_PLUGIN_SUBSYSTEM, "dna_notice_allocation: Unable to activate " "the next range for range %s.\n", config_entry->dn); @@ -1429,7 +1435,7 @@ dna_notice_allocation(struct configEntry *config_entry, PRUint64 new, } else { config_entry->remaining = 0; /* update the shared configuration */ - dna_update_shared_config(config_entry, txn); + dna_update_shared_config(pb, config_entry, txn); } } else { if (config_entry->next_range_lower != 0) { @@ -1442,7 +1448,7 @@ dna_notice_allocation(struct configEntry *config_entry, PRUint64 new, } /* update the shared configuration */ - dna_update_shared_config(config_entry, txn); + dna_update_shared_config(pb, config_entry, txn); } /* Check if we passed the threshold and try to fix maxval if so. We @@ -1454,7 +1460,7 @@ dna_notice_allocation(struct configEntry *config_entry, PRUint64 new, config_entry->threshold, config_entry->dn, config_entry->remaining); /* Only attempt to fix maxval if the fix flag is set. */ if (fix != 0) { - dna_fix_maxval(config_entry, txn); + dna_fix_maxval(pb, config_entry, txn); } } @@ -2053,7 +2059,7 @@ cleanup: * Perform ldap operationally atomic increment * Return the next value to be assigned */ -static int dna_get_next_value(struct configEntry *config_entry, +static int dna_get_next_value(Slapi_PBlock *origpb, struct configEntry *config_entry, char **next_value_ret, void *txn) { Slapi_PBlock *pb = NULL; @@ -2079,7 +2085,7 @@ static int dna_get_next_value(struct configEntry *config_entry, /* check if we overflowed the configured range */ if (setval > config_entry->maxval) { /* try for a new range or fail */ - ret = dna_fix_maxval(config_entry, txn); + ret = dna_fix_maxval(pb, config_entry, txn); if (LDAP_SUCCESS != ret) { slapi_log_error(SLAPI_LOG_FATAL, DNA_PLUGIN_SUBSYSTEM, "dna_get_next_value: no more values available!!\n"); @@ -2115,7 +2121,7 @@ static int dna_get_next_value(struct configEntry *config_entry, mods[0] = &mod_replace; mods[1] = 0; - pb = slapi_pblock_new(); + pb = slapi_pblock_new_by_pb(origpb); if (NULL == pb) { ret = LDAP_OPERATIONS_ERROR; goto done; @@ -2139,7 +2145,7 @@ static int dna_get_next_value(struct configEntry *config_entry, } /* update our cached config */ - dna_notice_allocation(config_entry, nextval, setval, 1, txn); + dna_notice_allocation(pb, config_entry, nextval, setval, 1, txn); } done: @@ -2165,7 +2171,7 @@ static int dna_get_next_value(struct configEntry *config_entry, * before calling this function. * */ static int -dna_update_shared_config(struct configEntry * config_entry, void *txn) +dna_update_shared_config(Slapi_PBlock *origpb, struct configEntry * config_entry, void *txn) { int ret = LDAP_SUCCESS; @@ -2191,7 +2197,7 @@ dna_update_shared_config(struct configEntry * config_entry, void *txn) mods[0] = &mod_replace; mods[1] = 0; - pb = slapi_pblock_new(); + pb = slapi_pblock_new_by_pb(origpb); if (NULL == pb) { ret = LDAP_OPERATIONS_ERROR; } else { @@ -2240,7 +2246,6 @@ dna_update_shared_config(struct configEntry * config_entry, void *txn) } slapi_pblock_destroy(pb); - pb = NULL; } } @@ -2257,7 +2262,7 @@ dna_update_shared_config(struct configEntry * config_entry, void *txn) * before calling this function. */ static int -dna_update_next_range(struct configEntry *config_entry, +dna_update_next_range(Slapi_PBlock *origpb, struct configEntry *config_entry, PRUint64 lower, PRUint64 upper, void *txn) { Slapi_PBlock *pb = NULL; @@ -2281,7 +2286,7 @@ dna_update_next_range(struct configEntry *config_entry, mods[0] = &mod_replace; mods[1] = 0; - pb = slapi_pblock_new(); + pb = slapi_pblock_new_by_pb(origpb); if (NULL == pb) { ret = LDAP_OPERATIONS_ERROR; goto bail; @@ -2295,7 +2300,6 @@ dna_update_next_range(struct configEntry *config_entry, slapi_pblock_get(pb, SLAPI_PLUGIN_INTOP_RESULT, &ret); slapi_pblock_destroy(pb); - pb = NULL; if (ret != LDAP_SUCCESS) { slapi_log_error(SLAPI_LOG_FATAL, DNA_PLUGIN_SUBSYSTEM, @@ -2305,7 +2309,7 @@ dna_update_next_range(struct configEntry *config_entry, /* update the cached config and the shared config */ config_entry->next_range_lower = lower; config_entry->next_range_upper = upper; - dna_notice_allocation(config_entry, 0, 0, 0, txn); + dna_notice_allocation(pb, config_entry, 0, 0, 0, txn); } bail: @@ -2322,9 +2326,9 @@ bail: * be obtained before calling this function. */ static int -dna_activate_next_range(struct configEntry *config_entry, void *txn) +dna_activate_next_range(Slapi_PBlock *pb, struct configEntry *config_entry, void *txn) { - Slapi_PBlock *pb = NULL; + Slapi_PBlock *mod_pb = NULL; LDAPMod mod_maxval; LDAPMod mod_nextval; LDAPMod mod_nextrange; @@ -2363,21 +2367,20 @@ dna_activate_next_range(struct configEntry *config_entry, void *txn) mods[3] = 0; /* Update the config entry first */ - pb = slapi_pblock_new(); - if (NULL == pb) { + mod_pb = slapi_pblock_new_by_pb(pb); + if (NULL == mod_pb) { ret = LDAP_OPERATIONS_ERROR; goto bail; } - slapi_modify_internal_set_pb(pb, config_entry->dn, + slapi_modify_internal_set_pb(mod_pb, config_entry->dn, mods, 0, 0, getPluginID(), 0); - slapi_pblock_set(pb, SLAPI_TXN, txn); - slapi_modify_internal_pb(pb); + slapi_pblock_set(mod_pb, SLAPI_TXN, txn); + slapi_modify_internal_pb(mod_pb); - slapi_pblock_get(pb, SLAPI_PLUGIN_INTOP_RESULT, &ret); + slapi_pblock_get(mod_pb, SLAPI_PLUGIN_INTOP_RESULT, &ret); - slapi_pblock_destroy(pb); - pb = NULL; + slapi_pblock_destroy(mod_pb); if (ret != LDAP_SUCCESS) { slapi_log_error(SLAPI_LOG_FATAL, DNA_PLUGIN_SUBSYSTEM, @@ -2392,7 +2395,7 @@ dna_activate_next_range(struct configEntry *config_entry, void *txn) config_entry->remaining = ((config_entry->maxval - config_entry->nextval + 1) / config_entry->interval); /* update the shared configuration */ - dna_update_shared_config(config_entry, txn); + dna_update_shared_config(pb, config_entry, txn); } bail: @@ -3102,7 +3105,7 @@ static int dna_pre_op(Slapi_PBlock * pb, int modtype) int len; /* create the value to add */ - ret = dna_get_next_value(config_entry, &value, txn); + ret = dna_get_next_value(pb, config_entry, &value, txn); if (DNA_SUCCESS != ret) { errstr = slapi_ch_smprintf("Allocation of a new value for range" " %s failed! Unable to proceed.", @@ -3226,7 +3229,7 @@ static int dna_config_check_post_op(Slapi_PBlock * pb) if ((dn = dna_get_dn(pb))) { if (dna_dn_is_config(dn)) - dna_load_plugin_config(); + dna_load_plugin_config(pb); } slapi_log_error(SLAPI_LOG_TRACE, DNA_PLUGIN_SUBSYSTEM, @@ -3299,7 +3302,7 @@ static int dna_extend_exop(Slapi_PBlock *pb) /* See if we have the req. range configured. * If so, we need to see if we have range to provide. */ - ret = dna_release_range(shared_dn, &lower, &upper); + ret = dna_release_range(pb, shared_dn, &lower, &upper); if (ret == LDAP_SUCCESS) { /* We have range to give away, so construct @@ -3371,7 +3374,7 @@ static int dna_extend_exop(Slapi_PBlock *pb) * for the range specified by range_dn. */ static int -dna_release_range(char *range_dn, PRUint64 *lower, PRUint64 *upper) +dna_release_range(Slapi_PBlock *origpb, char *range_dn, PRUint64 *lower, PRUint64 *upper) { int ret = 0; int match = 0; @@ -3474,7 +3477,7 @@ dna_release_range(char *range_dn, PRUint64 *lower, PRUint64 *upper) *lower = *upper - release + 1; /* Try to set the new next range in the config */ - ret = dna_update_next_range(config_entry, config_entry->next_range_lower, + ret = dna_update_next_range(pb, config_entry, config_entry->next_range_lower, *lower - 1, NULL); } else { /* We release up to half of our remaining values, @@ -3504,7 +3507,7 @@ dna_release_range(char *range_dn, PRUint64 *lower, PRUint64 *upper) mods[0] = &mod_replace; mods[1] = 0; - pb = slapi_pblock_new(); + pb = slapi_pblock_new_by_pb(origpb); if (NULL == pb) { ret = LDAP_OPERATIONS_ERROR; goto bail; @@ -3522,7 +3525,7 @@ dna_release_range(char *range_dn, PRUint64 *lower, PRUint64 *upper) if (ret == LDAP_SUCCESS) { /* Adjust maxval in our cached config and shared config */ config_entry->maxval = *lower - 1; - dna_notice_allocation(config_entry, config_entry->nextval, 0, 0, NULL); + dna_notice_allocation(pb, config_entry, config_entry->nextval, 0, 0, NULL); } } diff --git a/ldap/servers/plugins/linkedattrs/fixup_task.c b/ldap/servers/plugins/linkedattrs/fixup_task.c index c1af2f2..4b82002 100644 --- a/ldap/servers/plugins/linkedattrs/fixup_task.c +++ b/ldap/servers/plugins/linkedattrs/fixup_task.c @@ -48,7 +48,7 @@ */ static void linked_attrs_fixup_task_destructor(Slapi_Task *task); static void linked_attrs_fixup_task_thread(void *arg); -static void linked_attrs_fixup_links(struct configEntry *config, void *txn); +static void linked_attrs_fixup_links(Slapi_PBlock *pb, struct configEntry *config, void *txn); static int linked_attrs_remove_backlinks_callback(Slapi_Entry *e, void *callback_data); static int linked_attrs_add_backlinks_callback(Slapi_Entry *e, void *callback_data); static const char *fetch_attr(Slapi_Entry *e, const char *attrname, @@ -91,6 +91,7 @@ linked_attrs_fixup_task_add(Slapi_PBlock *pb, Slapi_Entry *e, if (linkdn) { mytaskdata->linkdn = slapi_dn_normalize(slapi_ch_strdup(linkdn)); } + mytaskdata->pb = pb; /* allocate new task now */ task = slapi_new_task(slapi_entry_get_ndn(e)); @@ -139,10 +140,12 @@ linked_attrs_fixup_task_thread(void *arg) Slapi_Task *task = (Slapi_Task *)arg; task_data *td = NULL; PRCList *main_config = NULL; + Slapi_PBlock *pb; int found_config = 0; /* Fetch our task data from the task */ td = (task_data *)slapi_task_get_data(task); + pb = slapi_pblock_new_by_pb(td->pb); /* Log started message. */ slapi_task_begin(task, 1); @@ -170,7 +173,7 @@ linked_attrs_fixup_task_thread(void *arg) slapi_log_error(SLAPI_LOG_FATAL, LINK_PLUGIN_SUBSYSTEM, "Fixing up linked attribute pair (%s)\n", config_entry->dn); - linked_attrs_fixup_links(config_entry, NULL); + linked_attrs_fixup_links(pb, config_entry, NULL); break; } } else { @@ -180,7 +183,7 @@ linked_attrs_fixup_task_thread(void *arg) slapi_log_error(SLAPI_LOG_FATAL, LINK_PLUGIN_SUBSYSTEM, "Fixing up linked attribute pair (%s)\n", config_entry->dn); - linked_attrs_fixup_links(config_entry, NULL); + linked_attrs_fixup_links(pb, config_entry, NULL); } list = PR_NEXT_LINK(list); @@ -205,24 +208,27 @@ linked_attrs_fixup_task_thread(void *arg) /* this will queue the destruction of the task */ slapi_task_finish(task, rc); + slapi_pblock_destroy(pb); } struct fixup_cb_data { char *attrtype; void *txn; struct configEntry *config; + Slapi_PBlock *pb; }; static void -linked_attrs_fixup_links(struct configEntry *config, void *txn) +linked_attrs_fixup_links(Slapi_PBlock *origpb, struct configEntry *config, void *txn) { - Slapi_PBlock *pb = slapi_pblock_new(); + Slapi_PBlock *pb = slapi_pblock_new_by_pb(origpb); char *del_filter = NULL; char *add_filter = NULL; - struct fixup_cb_data cb_data = {NULL, NULL, NULL}; + struct fixup_cb_data cb_data = {NULL, NULL, NULL, NULL}; del_filter = slapi_ch_smprintf("%s=*", config->managedtype); add_filter = slapi_ch_smprintf("%s=*", config->linktype); + cb_data.pb = pb; /* Lock the attribute pair. */ slapi_lock_mutex(config->lock); @@ -309,7 +315,7 @@ linked_attrs_remove_backlinks_callback(Slapi_Entry *e, void *callback_data) Slapi_DN *sdn = slapi_entry_get_sdn(e); struct fixup_cb_data *cb_data = (struct fixup_cb_data *)callback_data; char *type = cb_data->attrtype; - Slapi_PBlock *pb = slapi_pblock_new(); + Slapi_PBlock *pb = slapi_pblock_new_by_pb(cb_data->pb); char *val[1]; LDAPMod mod; LDAPMod *mods[2]; @@ -346,7 +352,7 @@ linked_attrs_add_backlinks_callback(Slapi_Entry *e, void *callback_data) char *linkdn = slapi_entry_get_dn(e); struct fixup_cb_data *cb_data = (struct fixup_cb_data *)callback_data; struct configEntry *config = cb_data->config; - Slapi_PBlock *pb = slapi_pblock_new(); + Slapi_PBlock *pb = slapi_pblock_new_by_pb(cb_data->pb); int i = 0; char **targets = NULL; char *val[2]; diff --git a/ldap/servers/plugins/linkedattrs/linked_attrs.c b/ldap/servers/plugins/linkedattrs/linked_attrs.c index c00c896..63cae9f 100644 --- a/ldap/servers/plugins/linkedattrs/linked_attrs.c +++ b/ldap/servers/plugins/linkedattrs/linked_attrs.c @@ -106,13 +106,13 @@ static int linked_attrs_config_exists_reverse(struct configEntry *entry); static int linked_attrs_oktodo(Slapi_PBlock *pb); void linked_attrs_load_array(Slapi_Value **array, Slapi_Attr *attr); int linked_attrs_compare(const void *a, const void *b); -static void linked_attrs_add_backpointers(char *linkdn, struct configEntry *config, +static void linked_attrs_add_backpointers(Slapi_PBlock *pb, char *linkdn, struct configEntry *config, Slapi_Mod *smod, void *txn); static void linked_attrs_del_backpointers(Slapi_PBlock *pb, char *linkdn, struct configEntry *config, Slapi_Mod *smod); static void linked_attrs_replace_backpointers(Slapi_PBlock *pb, char *linkdn, struct configEntry *config, Slapi_Mod *smod); -static void linked_attrs_mod_backpointers(char *linkdn, char *type, char *scope, +static void linked_attrs_mod_backpointers(Slapi_PBlock *pb, char *linkdn, char *type, char *scope, int modop, Slapi_ValueSet *targetvals, void *txn); /* @@ -557,7 +557,7 @@ linked_attrs_parse_config_entry(Slapi_Entry * e, int apply) "linked_attrs_parse_config_entry: The %s config " "setting must be set to an attribute with the " "Distinguished Name syntax for linked attribute " - "pair \"%s\".\n", LINK_LINK_TYPE, entry->dn); + "pair \"%s\" attribute \"%s\".\n", LINK_LINK_TYPE, entry->dn, value); } } else { slapi_log_error(SLAPI_LOG_FATAL, LINK_PLUGIN_SUBSYSTEM, @@ -1254,13 +1254,13 @@ linked_attrs_compare(const void *a, const void *b) * by the values in smod. */ static void -linked_attrs_add_backpointers(char *linkdn, struct configEntry *config, +linked_attrs_add_backpointers(Slapi_PBlock *origpb, char *linkdn, struct configEntry *config, Slapi_Mod *smod, void *txn) { Slapi_ValueSet *vals = slapi_valueset_new(); slapi_valueset_set_from_smod(vals, smod); - linked_attrs_mod_backpointers(linkdn, config->managedtype, config->scope, + linked_attrs_mod_backpointers(origpb, linkdn, config->managedtype, config->scope, LDAP_MOD_ADD, vals, txn); slapi_valueset_free(vals); @@ -1295,7 +1295,7 @@ linked_attrs_del_backpointers(Slapi_PBlock *pb, char *linkdn, } slapi_pblock_get(pb, SLAPI_TXN, &txn); - linked_attrs_mod_backpointers(linkdn, config->managedtype, config->scope, + linked_attrs_mod_backpointers(pb,linkdn, config->managedtype, config->scope, LDAP_MOD_DELETE, vals, txn); slapi_valueset_free(vals); @@ -1414,13 +1414,13 @@ linked_attrs_replace_backpointers(Slapi_PBlock *pb, char *linkdn, /* Perform the actual updates to the target entries. */ if (delvals) { - linked_attrs_mod_backpointers(linkdn, config->managedtype, + linked_attrs_mod_backpointers(pb, linkdn, config->managedtype, config->scope, LDAP_MOD_DELETE, delvals, txn); slapi_valueset_free(delvals); } if (addvals) { - linked_attrs_mod_backpointers(linkdn, config->managedtype, + linked_attrs_mod_backpointers(pb, linkdn, config->managedtype, config->scope, LDAP_MOD_ADD, addvals, txn); slapi_valueset_free(addvals); } @@ -1436,12 +1436,12 @@ linked_attrs_replace_backpointers(Slapi_PBlock *pb, char *linkdn, * Performs backpointer management. */ static void -linked_attrs_mod_backpointers(char *linkdn, char *type, +linked_attrs_mod_backpointers(Slapi_PBlock *origpb, char *linkdn, char *type, char *scope, int modop, Slapi_ValueSet *targetvals, void *txn) { char *val[2]; int i = 0; - Slapi_PBlock *mod_pb = slapi_pblock_new(); + Slapi_PBlock *mod_pb = slapi_pblock_new_by_pb(origpb); LDAPMod mod; LDAPMod *mods[2]; Slapi_Value *targetval = NULL; @@ -1684,7 +1684,7 @@ linked_attrs_mod_post_op(Slapi_PBlock *pb) case LDAP_MOD_ADD: /* Find the entries pointed to by the new * values and add the backpointers. */ - linked_attrs_add_backpointers(dn, config, smod, txn); + linked_attrs_add_backpointers(pb, dn, config, smod, txn); break; case LDAP_MOD_DELETE: /* Find the entries pointed to by the deleted @@ -1779,7 +1779,7 @@ linked_attrs_add_post_op(Slapi_PBlock *pb) slapi_lock_mutex(config->lock); - linked_attrs_mod_backpointers(dn, config->managedtype, + linked_attrs_mod_backpointers(pb, dn, config->managedtype, config->scope, LDAP_MOD_ADD, vals, txn); slapi_unlock_mutex(config->lock); @@ -1860,7 +1860,7 @@ linked_attrs_del_post_op(Slapi_PBlock *pb) slapi_lock_mutex(config->lock); - linked_attrs_mod_backpointers(dn, config->managedtype, + linked_attrs_mod_backpointers(pb, dn, config->managedtype, config->scope, LDAP_MOD_DELETE, vals, txn); slapi_unlock_mutex(config->lock); @@ -1889,7 +1889,7 @@ linked_attrs_del_post_op(Slapi_PBlock *pb) slapi_lock_mutex(config->lock); /* Delete forward link value. */ - linked_attrs_mod_backpointers(dn, config->linktype, + linked_attrs_mod_backpointers(pb, dn, config->linktype, config->scope, LDAP_MOD_DELETE, vals, txn); slapi_unlock_mutex(config->lock); @@ -1990,7 +1990,7 @@ linked_attrs_modrdn_post_op(Slapi_PBlock *pb) slapi_lock_mutex(config->lock); /* Delete old dn value. */ - linked_attrs_mod_backpointers(old_dn, config->managedtype, + linked_attrs_mod_backpointers(pb, old_dn, config->managedtype, config->scope, LDAP_MOD_DELETE, vals, txn); slapi_unlock_mutex(config->lock); @@ -2013,7 +2013,7 @@ linked_attrs_modrdn_post_op(Slapi_PBlock *pb) slapi_lock_mutex(config->lock); /* Add new dn value. */ - linked_attrs_mod_backpointers(new_dn, config->managedtype, + linked_attrs_mod_backpointers(pb, new_dn, config->managedtype, config->scope, LDAP_MOD_ADD, vals, txn); slapi_unlock_mutex(config->lock); @@ -2042,11 +2042,11 @@ linked_attrs_modrdn_post_op(Slapi_PBlock *pb) slapi_lock_mutex(config->lock); /* Delete old dn value. */ - linked_attrs_mod_backpointers(old_dn, config->linktype, + linked_attrs_mod_backpointers(pb, old_dn, config->linktype, config->scope, LDAP_MOD_DELETE, vals, txn); /* Add new dn value. */ - linked_attrs_mod_backpointers(new_dn, config->linktype, + linked_attrs_mod_backpointers(pb, new_dn, config->linktype, config->scope, LDAP_MOD_ADD, vals, txn); slapi_unlock_mutex(config->lock); diff --git a/ldap/servers/plugins/linkedattrs/linked_attrs.h b/ldap/servers/plugins/linkedattrs/linked_attrs.h index 137e317..89318e1 100644 --- a/ldap/servers/plugins/linkedattrs/linked_attrs.h +++ b/ldap/servers/plugins/linkedattrs/linked_attrs.h @@ -100,6 +100,7 @@ struct configIndex { typedef struct _task_data { char *linkdn; + Slapi_PBlock *pb; } task_data; diff --git a/ldap/servers/plugins/memberof/memberof.c b/ldap/servers/plugins/memberof/memberof.c index 5100b1a..6699e22 100644 --- a/ldap/servers/plugins/memberof/memberof.c +++ b/ldap/servers/plugins/memberof/memberof.c @@ -92,6 +92,7 @@ typedef struct _memberof_get_groups_data MemberOfConfig *config; Slapi_Value *memberdn_val; Slapi_ValueSet **groupvals; + Slapi_PBlock *pb; void *txn; } memberof_get_groups_data; @@ -148,7 +149,7 @@ static int memberof_call_foreach_dn(Slapi_PBlock *pb, char *dn, static int memberof_is_direct_member(MemberOfConfig *config, Slapi_Value *groupdn, Slapi_Value *memberdn, void *txn); static int memberof_is_grouping_attr(char *type, MemberOfConfig *config); -static Slapi_ValueSet *memberof_get_groups(MemberOfConfig *config, char *memberdn, void *txn); +static Slapi_ValueSet *memberof_get_groups(Slapi_PBlock *pb, MemberOfConfig *config, char *memberdn, void *txn); static int memberof_get_groups_r(MemberOfConfig *config, char *memberdn, memberof_get_groups_data *data, void *txn); static int memberof_get_groups_callback(Slapi_Entry *e, void *callback_data); @@ -169,7 +170,7 @@ static void memberof_task_destructor(Slapi_Task *task); static const char *fetch_attr(Slapi_Entry *e, const char *attrname, const char *default_val); static void memberof_fixup_task_thread(void *arg); -static int memberof_fix_memberof(MemberOfConfig *config, char *dn, char *filter_str, void *txn); +static int memberof_fix_memberof(Slapi_PBlock *pb, MemberOfConfig *config, char *dn, char *filter_str, void *txn); static int memberof_fix_memberof_callback(Slapi_Entry *e, void *callback_data); @@ -448,6 +449,7 @@ int memberof_postop_del(Slapi_PBlock *pb) typedef struct _memberof_del_dn_data { + Slapi_PBlock *pb; char *dn; char *type; void *txn; @@ -465,7 +467,7 @@ memberof_del_dn_from_groups(Slapi_PBlock *pb, MemberOfConfig *config, char *dn, * same grouping attribute. */ for (i = 0; config->groupattrs[i]; i++) { - memberof_del_dn_data data = {dn, config->groupattrs[i], txn}; + memberof_del_dn_data data = {pb, dn, config->groupattrs[i], txn}; groupattrs[0] = config->groupattrs[i]; @@ -482,7 +484,7 @@ int memberof_del_dn_type_callback(Slapi_Entry *e, void *callback_data) char *val[2]; Slapi_PBlock *mod_pb = 0; - mod_pb = slapi_pblock_new(); + mod_pb = slapi_pblock_new_by_pb(((memberof_del_dn_data *)callback_data)->pb); mods[0] = &mod; mods[1] = 0; @@ -521,7 +523,7 @@ int memberof_call_foreach_dn(Slapi_PBlock *pb, char *dn, char **types, plugin_search_entry_callback callback, void *callback_data, void *txn) { int rc = 0; - Slapi_PBlock *search_pb = slapi_pblock_new(); + Slapi_PBlock *search_pb = slapi_pblock_new_by_pb(pb); Slapi_Backend *be = 0; Slapi_DN *sdn = 0; Slapi_DN *base_sdn = 0; @@ -693,6 +695,7 @@ int memberof_postop_modrdn(Slapi_PBlock *pb) typedef struct _replace_dn_data { + Slapi_PBlock *pb; char *pre_dn; char *post_dn; char *type; @@ -714,7 +717,7 @@ memberof_replace_dn_from_groups(Slapi_PBlock *pb, MemberOfConfig *config, * using the same grouping attribute. */ for (i = 0; config->groupattrs[i]; i++) { - replace_dn_data data = {pre_dn, post_dn, config->groupattrs[i], txn}; + replace_dn_data data = {pb, pre_dn, post_dn, config->groupattrs[i], txn}; groupattrs[0] = config->groupattrs[i]; @@ -734,7 +737,7 @@ int memberof_replace_dn_type_callback(Slapi_Entry *e, void *callback_data) char *addval[2]; Slapi_PBlock *mod_pb = 0; - mod_pb = slapi_pblock_new(); + mod_pb = slapi_pblock_new_by_pb(((replace_dn_data *)callback_data)->pb); mods[0] = &delmod; mods[1] = &addmod; @@ -1091,6 +1094,7 @@ int memberof_modop_one_r(Slapi_PBlock *pb, MemberOfConfig *config, int mod_op, } struct fix_memberof_callback_data { + Slapi_PBlock *pb; MemberOfConfig *config; void *txn; }; @@ -1309,11 +1313,11 @@ int memberof_modop_one_replace_r(Slapi_PBlock *pb, MemberOfConfig *config, if(LDAP_MOD_DELETE == mod_op || LDAP_MOD_ADD == mod_op) { /* find parent groups and replace our member attr */ - struct fix_memberof_callback_data cb_data = {config, txn}; + struct fix_memberof_callback_data cb_data = {pb, config, txn}; memberof_fix_memberof_callback(e, &cb_data); } else { /* single entry - do mod */ - mod_pb = slapi_pblock_new(); + mod_pb = slapi_pblock_new_by_pb(pb); mods[0] = &mod; if(LDAP_MOD_REPLACE == mod_op) @@ -1641,11 +1645,11 @@ int memberof_moddn_attr_list(Slapi_PBlock *pb, MemberOfConfig *config, * A Slapi_ValueSet* is returned. It is up to the caller to * free it. */ -Slapi_ValueSet *memberof_get_groups(MemberOfConfig *config, char *memberdn, void *txn) +Slapi_ValueSet *memberof_get_groups(Slapi_PBlock *pb, MemberOfConfig *config, char *memberdn, void *txn) { Slapi_Value *memberdn_val = slapi_value_new_string(memberdn); Slapi_ValueSet *groupvals = slapi_valueset_new(); - memberof_get_groups_data data = {config, memberdn_val, &groupvals, txn}; + memberof_get_groups_data data = {config, memberdn_val, &groupvals, pb, txn}; memberof_get_groups_r(config, memberdn, &data, txn); @@ -1658,7 +1662,7 @@ int memberof_get_groups_r(MemberOfConfig *config, char *memberdn, memberof_get_g { /* Search for any grouping attributes that point to memberdn. * For each match, add it to the list, recurse and do same search */ - return memberof_call_foreach_dn(NULL, memberdn, config->groupattrs, + return memberof_call_foreach_dn(data->pb, memberdn, config->groupattrs, memberof_get_groups_callback, data, txn); } @@ -2224,6 +2228,7 @@ typedef struct _task_data { char *dn; char *filter_str; + char *binddn; } task_data; void memberof_fixup_task_thread(void *arg) @@ -2231,11 +2236,14 @@ void memberof_fixup_task_thread(void *arg) MemberOfConfig configCopy = {0, 0, 0, 0}; Slapi_Task *task = (Slapi_Task *)arg; task_data *td = NULL; + Slapi_PBlock *pb = slapi_pblock_new_by_pb(NULL); int rc = 0; /* Fetch our task data from the task */ td = (task_data *)slapi_task_get_data(task); + /* construct our pblock for plugin bind tracking */ + slapi_pblock_set(pb, SLAPI_REQUESTOR_DN, td->binddn); slapi_task_begin(task, 1); slapi_task_log_notice(task, "Memberof task starts (arg: %s) ...\n", td->filter_str); @@ -2252,7 +2260,7 @@ void memberof_fixup_task_thread(void *arg) memberof_lock(); /* do real work */ - rc = memberof_fix_memberof(&configCopy, td->dn, td->filter_str, NULL /* no txn? */); + rc = memberof_fix_memberof(pb, &configCopy, td->dn, td->filter_str, NULL /* no txn? */); /* release the memberOf operation lock */ memberof_unlock(); @@ -2262,6 +2270,7 @@ void memberof_fixup_task_thread(void *arg) slapi_task_log_notice(task, "Memberof task finished."); slapi_task_log_status(task, "Memberof task finished."); slapi_task_inc_progress(task); + slapi_pblock_destroy(pb); /* this will queue the destruction of the task */ slapi_task_finish(task, rc); @@ -2330,6 +2339,9 @@ int memberof_task_add(Slapi_PBlock *pb, Slapi_Entry *e, mytaskdata->dn = slapi_ch_strdup(dn); mytaskdata->filter_str = slapi_ch_strdup(filter); + slapi_pblock_get(pb,SLAPI_REQUESTOR_DN, &dn); + mytaskdata->binddn = slapi_ch_strdup(dn); + /* allocate new task now */ task = slapi_new_task(slapi_entry_get_ndn(e)); @@ -2366,17 +2378,18 @@ memberof_task_destructor(Slapi_Task *task) if (mydata) { slapi_ch_free_string(&mydata->dn); slapi_ch_free_string(&mydata->filter_str); + slapi_ch_free_string(&mydata->binddn); /* Need to cast to avoid a compiler warning */ slapi_ch_free((void **)&mydata); } } } -int memberof_fix_memberof(MemberOfConfig *config, char *dn, char *filter_str, void *txn) +int memberof_fix_memberof(Slapi_PBlock *pb, MemberOfConfig *config, char *dn, char *filter_str, void *txn) { int rc = 0; - struct fix_memberof_callback_data cb_data = {config, txn}; - Slapi_PBlock *search_pb = slapi_pblock_new(); + struct fix_memberof_callback_data cb_data = {pb, config, txn}; + Slapi_PBlock *search_pb = slapi_pblock_new_by_pb(pb); slapi_search_internal_set_pb(search_pb, dn, LDAP_SCOPE_SUBTREE, filter_str, 0, 0, @@ -2409,17 +2422,17 @@ int memberof_fix_memberof_callback(Slapi_Entry *e, void *callback_data) Slapi_DN *sdn = slapi_entry_get_sdn(e); struct fix_memberof_callback_data *cb_data = (struct fix_memberof_callback_data *)callback_data; MemberOfConfig *config = cb_data->config; - memberof_del_dn_data del_data = {0, config->memberof_attr, cb_data->txn}; + memberof_del_dn_data del_data = {cb_data->pb, 0, config->memberof_attr, cb_data->txn}; Slapi_ValueSet *groups = 0; /* get a list of all of the groups this user belongs to */ - groups = memberof_get_groups(config, dn, cb_data->txn); + groups = memberof_get_groups(cb_data->pb, config, dn, cb_data->txn); /* If we found some groups, replace the existing memberOf attribute * with the found values. */ if (groups && slapi_valueset_count(groups)) { - Slapi_PBlock *mod_pb = slapi_pblock_new(); + Slapi_PBlock *mod_pb = slapi_pblock_new_by_pb(cb_data->pb); Slapi_Value *val = 0; Slapi_Mod *smod; LDAPMod **mods = (LDAPMod **) slapi_ch_malloc(2 * sizeof(LDAPMod *)); diff --git a/ldap/servers/plugins/mep/mep.c b/ldap/servers/plugins/mep/mep.c index 303d9b3..6161c16 100644 --- a/ldap/servers/plugins/mep/mep.c +++ b/ldap/servers/plugins/mep/mep.c @@ -107,9 +107,9 @@ static int mep_oktodo(Slapi_PBlock *pb); static int mep_isrepl(Slapi_PBlock *pb); static Slapi_Entry *mep_create_managed_entry(struct configEntry *config, Slapi_Entry *origin); -static void mep_add_managed_entry(struct configEntry *config, +static void mep_add_managed_entry(Slapi_PBlock *pb, struct configEntry *config, Slapi_Entry *origin, void *txn); -static void mep_rename_managed_entry(Slapi_Entry *origin, +static void mep_rename_managed_entry(Slapi_PBlock *pb, Slapi_Entry *origin, Slapi_DN *new_dn, Slapi_DN *old_dn, void *txn); static Slapi_Mods *mep_get_mapped_mods(struct configEntry *config, Slapi_Entry *origin, char **mapped_dn); @@ -1422,12 +1422,12 @@ mep_create_managed_entry(struct configEntry *config, Slapi_Entry *origin) * newly created managed entry. */ static void -mep_add_managed_entry(struct configEntry *config, +mep_add_managed_entry(Slapi_PBlock *pb, struct configEntry *config, Slapi_Entry *origin, void *txn) { Slapi_Entry *managed_entry = NULL; char *managed_dn = NULL; - Slapi_PBlock *mod_pb = slapi_pblock_new(); + Slapi_PBlock *mod_pb = slapi_pblock_new_by_pb(pb); int result = LDAP_SUCCESS; /* Create the managed entry */ @@ -1523,11 +1523,11 @@ mep_add_managed_entry(struct configEntry *config, * origin entry. */ static void -mep_rename_managed_entry(Slapi_Entry *origin, +mep_rename_managed_entry(Slapi_PBlock *pb, Slapi_Entry *origin, Slapi_DN *new_dn, Slapi_DN *old_dn, void *txn) { Slapi_RDN *srdn = slapi_rdn_new(); - Slapi_PBlock *mep_pb = slapi_pblock_new(); + Slapi_PBlock *mep_pb = slapi_pblock_new_by_pb(pb); LDAPMod mod; LDAPMod *mods[2]; char *vals[2]; @@ -2392,7 +2392,7 @@ mep_mod_post_op(Slapi_PBlock *pb) smods = mep_get_mapped_mods(config, e, &mapped_dn); if (smods) { /* Clear out the pblock for reuse. */ - mep_pb = slapi_pblock_new(); + mep_pb = slapi_pblock_new_by_pb(pb); /* Perform the modify operation. */ slapi_log_error(SLAPI_LOG_PLUGIN, MEP_PLUGIN_SUBSYSTEM, @@ -2423,7 +2423,7 @@ mep_mod_post_op(Slapi_PBlock *pb) managed_sdn = slapi_sdn_new_normdn_byref(managed_dn); if (slapi_sdn_compare(managed_sdn, mapped_sdn) != 0) { - mep_rename_managed_entry(e, mapped_sdn, managed_sdn, txn); + mep_rename_managed_entry(pb, e, mapped_sdn, managed_sdn, txn); } slapi_sdn_free(&mapped_sdn); @@ -2499,7 +2499,7 @@ mep_add_post_op(Slapi_PBlock *pb) mep_find_config(e, &config); if (config) { - mep_add_managed_entry(config, e, txn); + mep_add_managed_entry(pb, config, e, txn); } mep_config_unlock(); @@ -2646,7 +2646,7 @@ mep_modrdn_post_op(Slapi_PBlock *pb) LDAPMod *mods[3]; char *vals[2]; int result = LDAP_SUCCESS; - Slapi_PBlock *mep_pb = slapi_pblock_new(); + Slapi_PBlock *mep_pb = slapi_pblock_new_by_pb(pb); Slapi_Entry *new_managed_entry = NULL; Slapi_DN *managed_sdn = NULL; Slapi_Mods *smods = NULL; @@ -2775,7 +2775,7 @@ mep_modrdn_post_op(Slapi_PBlock *pb) "entry \"%s\".\n ", managed_dn, slapi_entry_get_dn(new_managed_entry), slapi_sdn_get_dn(old_sdn)); - mep_rename_managed_entry(post_e, + mep_rename_managed_entry(pb, post_e, slapi_entry_get_sdn(new_managed_entry), managed_sdn, txn); } @@ -2838,7 +2838,7 @@ bailmod: mep_find_config(post_e, &config); if (config) { - mep_add_managed_entry(config, post_e, txn); + mep_add_managed_entry(pb, config, post_e, txn); } mep_config_unlock(); diff --git a/ldap/servers/plugins/referint/referint.c b/ldap/servers/plugins/referint/referint.c index 195ff2b..775da59 100644 --- a/ldap/servers/plugins/referint/referint.c +++ b/ldap/servers/plugins/referint/referint.c @@ -77,10 +77,10 @@ int referint_postop_del( Slapi_PBlock *pb ); int referint_postop_modrdn( Slapi_PBlock *pb ); int referint_postop_start( Slapi_PBlock *pb); int referint_postop_close( Slapi_PBlock *pb); -int update_integrity(char **argv, Slapi_DN *sDN, char *newrDN, Slapi_DN *newsuperior, int logChanges, void *txn); +int update_integrity(Slapi_PBlock *pb, char **argv, Slapi_DN *sDN, char *newrDN, Slapi_DN *newsuperior, int logChanges, void *txn); void referint_thread_func(void *arg); int GetNextLine(char *dest, int size_dest, PRFileDesc *stream); -void writeintegritylog(char *logfilename, Slapi_DN *sdn, char *newrdn, Slapi_DN *newsuperior); +void writeintegritylog(Slapi_PBlock *pb, char *logfilename, Slapi_DN *sdn, char *newrdn, Slapi_DN *newsuperior); int my_fgetc(PRFileDesc *stream); /* global thread control stuff */ @@ -215,10 +215,10 @@ referint_postop_del( Slapi_PBlock *pb ) }else if(delay == 0){ /* no delay */ /* call function to update references to entry */ - rc = update_integrity(argv, sdn, NULL, NULL, logChanges, txn); + rc = update_integrity(pb, argv, sdn, NULL, NULL, logChanges, txn); }else{ /* write the entry to integrity log */ - writeintegritylog(argv[1], sdn, NULL, NULL); + writeintegritylog(pb, argv[1], sdn, NULL, NULL); rc = 0; } } else { @@ -300,11 +300,11 @@ referint_postop_modrdn( Slapi_PBlock *pb ) }else if(delay == 0){ /* no delay */ /* call function to update references to entry */ - rc = update_integrity(argv, sdn, newrdn, + rc = update_integrity(pb, argv, sdn, newrdn, newsuperior, logChanges, txn); }else{ /* write the entry to integrity log */ - writeintegritylog(argv[1], sdn, newrdn, newsuperior); + writeintegritylog(pb, argv[1], sdn, newrdn, newsuperior); rc = 0; } @@ -674,12 +674,12 @@ bail: } int -update_integrity(char **argv, Slapi_DN *origSDN, +update_integrity(Slapi_PBlock *pb, char **argv, Slapi_DN *origSDN, char *newrDN, Slapi_DN *newsuperior, int logChanges, void *txn) { Slapi_PBlock *search_result_pb = NULL; - Slapi_PBlock *mod_pb = slapi_pblock_new(); + Slapi_PBlock *mod_pb = slapi_pblock_new_by_pb(pb); Slapi_Entry **search_entries = NULL; int search_result; Slapi_DN *sdn = NULL; @@ -912,8 +912,10 @@ referint_thread_func(void *arg) Slapi_DN *sdn = NULL; char *tmprdn; Slapi_DN *tmpsuperior = NULL; + Slapi_DN *binddn = NULL; int logChanges=0; char * iter = NULL; + Slapi_PBlock *pb = slapi_pblock_new_by_pb(NULL); if(plugin_argv == NULL){ slapi_log_error( SLAPI_LOG_FATAL, REFERINT_PLUGIN_SUBSYSTEM, @@ -972,6 +974,7 @@ referint_thread_func(void *arg) while( GetNextLine(thisline, MAX_LINE, prfd) ){ ptoken = ldap_utf8strtok_r(thisline, delimiter, &iter); sdn = slapi_sdn_new_normdn_byref(ptoken); + slapi_pblock_init(pb); ptoken = ldap_utf8strtok_r (NULL, delimiter, &iter); if(!strcasecmp(ptoken, "NULL")) { @@ -986,8 +989,16 @@ referint_thread_func(void *arg) } else { tmpsuperior = slapi_sdn_new_normdn_byref(ptoken); } + + /* this should be the bind DN that performed the original delete */ + ptoken = ldap_utf8strtok_r (NULL, delimiter, &iter); + if (!strcasecmp(ptoken, "NULL")) { + binddn = NULL; + } else { + slapi_pblock_set(pb, SLAPI_REQUESTOR_DN, ptoken); + } - update_integrity(plugin_argv, sdn, tmprdn, + update_integrity(pb, plugin_argv, sdn, tmprdn, tmpsuperior, logChanges, NULL); slapi_sdn_free(&sdn); @@ -1025,7 +1036,7 @@ referint_thread_func(void *arg) PR_DestroyCondVar(keeprunning_cv); } - + slapi_pblock_destroy(pb); } int my_fgetc(PRFileDesc *stream) @@ -1105,11 +1116,12 @@ GetNextLine(char *dest, int size_dest, PRFileDesc *stream) { } void -writeintegritylog(char *logfilename, Slapi_DN *sdn, +writeintegritylog(Slapi_PBlock *pb, char *logfilename, Slapi_DN *sdn, char *newrdn, Slapi_DN *newsuperior) { PRFileDesc *prfd; char buffer[MAX_LINE]; + char *dn = NULL; int len_to_write = 0; int rc; /* write this record to the file */ @@ -1161,11 +1173,12 @@ writeintegritylog(char *logfilename, Slapi_DN *sdn, " line length exceeded. It will not be able" " to update references to this entry.\n"); }else{ - PR_snprintf(buffer, MAX_LINE, "%s\t%s\t%s\t\n", + slapi_pblock_get(pb, SLAPI_REQUESTOR_DN, &dn); + PR_snprintf(buffer, MAX_LINE, "%s\t%s\t%s\t%s\t\n", slapi_sdn_get_dn(sdn), (newrdn != NULL) ? newrdn : "NULL", - (newsuperior != NULL) ? slapi_sdn_get_dn(newsuperior) : - "NULL"); + (newsuperior != NULL) ? slapi_sdn_get_dn(newsuperior) : "NULL", + dn ); if (PR_Write(prfd,buffer,strlen(buffer)) < 0){ slapi_log_error(SLAPI_LOG_FATAL,REFERINT_PLUGIN_SUBSYSTEM, " writeintegritylog: PR_Write failed : The disk" diff --git a/ldap/servers/slapd/add.c b/ldap/servers/slapd/add.c index 0304578..434901e 100644 --- a/ldap/servers/slapd/add.c +++ b/ldap/servers/slapd/add.c @@ -73,7 +73,7 @@ /* Forward declarations */ static int add_internal_pb (Slapi_PBlock *pb); static void op_shared_add (Slapi_PBlock *pb); -static int add_created_attrs(Operation *op, Slapi_Entry *e); +static int add_created_attrs(Slapi_PBlock *pb, Slapi_Entry *e); static int check_rdn_for_created_attrs(Slapi_Entry *e); static void handle_fast_add(Slapi_PBlock *pb, Slapi_Entry *entry); static int add_uniqueid (Slapi_Entry *e); @@ -390,8 +390,15 @@ void slapi_add_entry_internal_set_pb (Slapi_PBlock *pb, Slapi_Entry *e, LDAPCont return; } - op = internal_operation_new(SLAPI_OPERATION_ADD,operation_flags); - slapi_pblock_set(pb, SLAPI_OPERATION, op); + /* if the operation is not NULL, then it was already set */ + if(pb->pb_op == NULL){ + op = internal_operation_new(SLAPI_OPERATION_ADD,operation_flags); + slapi_pblock_set(pb, SLAPI_OPERATION, op); + } else { + /* we still want to set the flags & type though */ + operation_set_flag(pb->pb_op, operation_flags); + operation_set_type(pb->pb_op, SLAPI_OPERATION_ADD); + } slapi_pblock_set(pb, SLAPI_ADD_ENTRY, e); slapi_pblock_set(pb, SLAPI_CONTROLS_ARG, controls); slapi_pblock_set(pb, SLAPI_PLUGIN_IDENTITY, plugin_identity); @@ -632,7 +639,7 @@ static void op_shared_add (Slapi_PBlock *pb) /* can get lastmod only after backend is selected */ slapi_pblock_get(pb, SLAPI_BE_LASTMOD, &lastmod); - if (lastmod && add_created_attrs(operation, e) != 0) + if (lastmod && add_created_attrs(pb, e) != 0) { send_ldap_result(pb, LDAP_UNWILLING_TO_PERFORM, NULL, "cannot insert computed attributes", 0, NULL); @@ -738,19 +745,43 @@ done: } static int -add_created_attrs(Operation *op, Slapi_Entry *e) +add_created_attrs(Slapi_PBlock *pb, Slapi_Entry *e) { char buf[20]; struct berval bv; struct berval *bvals[2]; time_t curtime; struct tm ltm; + Operation *op; + char *plugin_dn = NULL; + struct slapdplugin *plugin = NULL; + struct slapi_componentid *cid = NULL; + slapdFrontendConfig_t *slapdFrontendConfig = getFrontendConfig(); LDAPDebug(LDAP_DEBUG_TRACE, "add_created_attrs\n", 0, 0, 0); + slapi_pblock_get(pb, SLAPI_OPERATION, &op); bvals[0] = &bv; bvals[1] = NULL; + if(slapdFrontendConfig->plugin_track && !slapi_sdn_isempty(&op->o_sdn)){ + /* write the bind dn and plugin name to the new attributes */ + slapi_pblock_get (pb, SLAPI_PLUGIN_IDENTITY, &cid); + if (cid) + plugin=(struct slapdplugin *) cid->sci_plugin; + if(plugin) + plugin_dn = plugin_get_dn(plugin); + if(plugin_dn){ + bv.bv_val = plugin_dn; + bv.bv_len = strlen(bv.bv_val); + } else { + bv.bv_val = (char*)slapi_sdn_get_dn(&op->o_sdn); + bv.bv_len = strlen(bv.bv_val); + } + slapi_entry_attr_replace(e, "internalCreatorsName", bvals); + slapi_entry_attr_replace(e, "internalModifiersName", bvals); + } + if (slapi_sdn_isempty(&op->o_sdn)) { bv.bv_val = ""; bv.bv_len = strlen(bv.bv_val); diff --git a/ldap/servers/slapd/config.c b/ldap/servers/slapd/config.c index f1df7ba..d97a575 100644 --- a/ldap/servers/slapd/config.c +++ b/ldap/servers/slapd/config.c @@ -241,13 +241,14 @@ slapd_bootstrap_config(const char *configdir) char schemacheck[BUFSIZ]; char syntaxcheck[BUFSIZ]; char syntaxlogging[BUFSIZ]; + char plugintracking[BUFSIZ]; char dn_validate_strict[BUFSIZ]; Slapi_DN plug_dn; workpath[0] = loglevel[0] = maxdescriptors[0] = '\0'; val[0] = logenabled[0] = schemacheck[0] = syntaxcheck[0] = '\0'; syntaxlogging[0] = _localuser[0] = '\0'; - dn_validate_strict[0] = '\0'; + plugintracking [0] = dn_validate_strict[0] = '\0'; /* Convert LDIF to entry structures */ slapi_sdn_init_ndn_byref(&plug_dn, PLUGIN_BASE_DN); @@ -464,6 +465,20 @@ slapd_bootstrap_config(const char *configdir) } } + /* see if we need to enable plugin binddn tracking */ + if (!plugintracking[0] && + entry_has_attr_and_value(e, CONFIG_PLUGIN_BINDDN_TRACKING_ATTRIBUTE, + plugintracking, sizeof(plugintracking))) + { + if (config_set_plugin_tracking(CONFIG_PLUGIN_BINDDN_TRACKING_ATTRIBUTE, + plugintracking, errorbuf, CONFIG_APPLY) + != LDAP_SUCCESS) + { + LDAPDebug(LDAP_DEBUG_ANY, "%s: %s: %s\n", configfile, + CONFIG_PLUGIN_BINDDN_TRACKING_ATTRIBUTE, errorbuf); + } + } + /* see if we need to enable syntax checking */ if (!syntaxcheck[0] && entry_has_attr_and_value(e, CONFIG_SYNTAXCHECK_ATTRIBUTE, diff --git a/ldap/servers/slapd/libglobs.c b/ldap/servers/slapd/libglobs.c index aafbd7e..b6c0c1f 100644 --- a/ldap/servers/slapd/libglobs.c +++ b/ldap/servers/slapd/libglobs.c @@ -532,6 +532,9 @@ static struct config_get_and_set { {CONFIG_RESULT_TWEAK_ATTRIBUTE, config_set_result_tweak, NULL, 0, (void**)&global_slapdFrontendConfig.result_tweak, CONFIG_ON_OFF, NULL}, + {CONFIG_PLUGIN_BINDDN_TRACKING_ATTRIBUTE, config_set_plugin_tracking, + NULL, 0, + (void**)&global_slapdFrontendConfig.plugin_track, CONFIG_ON_OFF, NULL}, {CONFIG_ATTRIBUTE_NAME_EXCEPTION_ATTRIBUTE, config_set_attrname_exceptions, NULL, 0, (void**)&global_slapdFrontendConfig.attrname_exceptions, CONFIG_ON_OFF, NULL}, @@ -957,6 +960,7 @@ FrontendConfig_init () { cfg->anon_limits_dn = slapi_ch_strdup(""); cfg->schemacheck = LDAP_ON; cfg->syntaxcheck = LDAP_OFF; + cfg->plugin_track = LDAP_OFF; cfg->syntaxlogging = LDAP_OFF; cfg->dn_validate_strict = LDAP_OFF; cfg->ds4_compatible_schema = LDAP_OFF; @@ -2466,6 +2470,19 @@ config_set_result_tweak( const char *attrname, char *value, char *errorbuf, int return retVal; } +int +config_set_plugin_tracking( const char *attrname, char *value, char *errorbuf, int apply ) { + int retVal = LDAP_SUCCESS; + slapdFrontendConfig_t *slapdFrontendConfig = getFrontendConfig(); + + retVal = config_set_onoff ( attrname, + value, + &(slapdFrontendConfig->plugin_track), + errorbuf, + apply); + + return retVal; +} int config_set_security( const char *attrname, char *value, char *errorbuf, int apply ) { diff --git a/ldap/servers/slapd/modify.c b/ldap/servers/slapd/modify.c index c346a6a..869eb27 100644 --- a/ldap/servers/slapd/modify.c +++ b/ldap/servers/slapd/modify.c @@ -489,8 +489,14 @@ slapi_modify_internal_set_pb (Slapi_PBlock *pb, const char *dn, return; } - op= internal_operation_new(SLAPI_OPERATION_MODIFY,operation_flags); - slapi_pblock_set(pb, SLAPI_OPERATION, op); + /* if we're tracking the plugin bind dn, then just set the type/flags */ + if(pb->plugin_tracking){ + operation_set_flag(pb->pb_op, operation_flags); + operation_set_type(pb->pb_op, SLAPI_OPERATION_MODIFY); + } else { + op = internal_operation_new(SLAPI_OPERATION_MODIFY,operation_flags); + slapi_pblock_set(pb, SLAPI_OPERATION, op); + } slapi_pblock_set(pb, SLAPI_ORIGINAL_TARGET, (void*)dn); slapi_pblock_set(pb, SLAPI_MODIFY_MODS, mods); slapi_pblock_set(pb, SLAPI_CONTROLS_ARG, controls); @@ -518,8 +524,14 @@ slapi_modify_internal_set_pb_ext(Slapi_PBlock *pb, const Slapi_DN *sdn, return; } - op= internal_operation_new(SLAPI_OPERATION_MODIFY,operation_flags); - slapi_pblock_set(pb, SLAPI_OPERATION, op); + /* if we're tracking the plugin bind dn, then just set the type/flags */ + if(pb->plugin_tracking){ + operation_set_flag(pb->pb_op, operation_flags); + operation_set_type(pb->pb_op, SLAPI_OPERATION_MODIFY); + } else { + op = internal_operation_new(SLAPI_OPERATION_MODIFY,operation_flags); + slapi_pblock_set(pb, SLAPI_OPERATION, op); + } slapi_pblock_set(pb, SLAPI_ORIGINAL_TARGET, (void *)slapi_sdn_get_dn(sdn)); slapi_pblock_set(pb, SLAPI_TARGET_SDN, (void *)sdn); slapi_pblock_set(pb, SLAPI_MODIFY_MODS, mods); diff --git a/ldap/servers/slapd/modrdn.c b/ldap/servers/slapd/modrdn.c index a7bb1a6..7cd88ce 100644 --- a/ldap/servers/slapd/modrdn.c +++ b/ldap/servers/slapd/modrdn.c @@ -252,7 +252,7 @@ do_modrdn( Slapi_PBlock *pb ) } LDAPDebug( LDAP_DEBUG_ARGS, - "do_moddn: dn (%s) newrdn (%s) deloldrdn (%d)\n", dn, newrdn, + "do_modrdn: dn (%s) newrdn (%s) deloldrdn (%d)\n", dn, newrdn, deloldrdn ); slapi_pblock_set( pb, SLAPI_REQUESTOR_ISROOT, &pb->pb_op->o_isroot ); @@ -359,8 +359,14 @@ slapi_rename_internal_set_pb_ext(Slapi_PBlock *pb, return; } - op = internal_operation_new(SLAPI_OPERATION_MODRDN,operation_flags); - slapi_pblock_set(pb, SLAPI_OPERATION, op); + /* if we're tracking the plugin bind dn, then just set the type/flags */ + if(pb->plugin_tracking){ + operation_set_flag(pb->pb_op, operation_flags); + operation_set_type(pb->pb_op, SLAPI_OPERATION_MODRDN); + } else { + op = internal_operation_new(SLAPI_OPERATION_MODRDN,operation_flags); + slapi_pblock_set(pb, SLAPI_OPERATION, op); + } slapi_pblock_set(pb, SLAPI_ORIGINAL_TARGET, (void*)slapi_sdn_get_dn(olddn)); slapi_pblock_set(pb, SLAPI_MODRDN_TARGET_SDN, (void*)olddn); diff --git a/ldap/servers/slapd/opshared.c b/ldap/servers/slapd/opshared.c index ff17cd9..12f7fdf 100644 --- a/ldap/servers/slapd/opshared.c +++ b/ldap/servers/slapd/opshared.c @@ -136,19 +136,40 @@ do_ps_service(Slapi_Entry *e, Slapi_Entry *eprev, ber_int_t chgtype, ber_int_t c void modify_update_last_modified_attr(Slapi_PBlock *pb, Slapi_Mods *smods) { char buf[20]; + char *plugin_dn = NULL; struct berval bv; struct berval *bvals[2]; time_t curtime; struct tm utm; Operation *op; + struct slapdplugin *plugin = NULL; + struct slapi_componentid *cid = NULL; + slapdFrontendConfig_t *slapdFrontendConfig = getFrontendConfig(); LDAPDebug(LDAP_DEBUG_TRACE, "modify_update_last_modified_attr\n", 0, 0, 0); slapi_pblock_get(pb, SLAPI_OPERATION, &op); - bvals[0] = &bv; bvals[1] = NULL; + if(slapdFrontendConfig->plugin_track && !slapi_sdn_isempty(&op->o_sdn)){ + /* write to the new attribute the bind dn and plugin name */ + slapi_pblock_get (pb, SLAPI_PLUGIN_IDENTITY, &cid); + if (cid) + plugin=(struct slapdplugin *) cid->sci_plugin; + if(plugin) + plugin_dn = plugin_get_dn (plugin); + if(plugin_dn){ + bv.bv_val = plugin_dn; + bv.bv_len = strlen(bv.bv_val); + } else { + bv.bv_val = (char*)slapi_sdn_get_dn(&op->o_sdn); + bv.bv_len = strlen(bv.bv_val); + } + slapi_mods_add_modbvps(smods, LDAP_MOD_REPLACE | LDAP_MOD_BVALUES, + "internalModifiersName", bvals); + } + /* fill in modifiersname */ if (slapi_sdn_isempty(&op->o_sdn)) { bv.bv_val = ""; diff --git a/ldap/servers/slapd/pblock.c b/ldap/servers/slapd/pblock.c index 6b3de8e..f3df0f6 100644 --- a/ldap/servers/slapd/pblock.c +++ b/ldap/servers/slapd/pblock.c @@ -96,13 +96,50 @@ slapi_pblock_new() return pb; } +/* Use for internal operations by plugins, where we need to track the bind dn */ +Slapi_PBlock * +slapi_pblock_new_by_pb(Slapi_PBlock *origpb) +{ + Slapi_PBlock *pb; + + pb = (Slapi_PBlock *) slapi_ch_calloc( 1, sizeof(Slapi_PBlock) ); + pb->pb_op = operation_new(OP_FLAG_INTERNAL); + pb->plugin_tracking = 1; + + if(origpb == NULL){ + return pb; + } + + if(origpb->pb_op != NULL){ + slapi_sdn_set_normdn_byval((&pb->pb_op->o_sdn), slapi_sdn_get_dn(&origpb->pb_op->o_sdn)); + } else { + /* No operation? Have to use the plugin name */ + if(origpb->pb_plugin->plg_name){ + slapi_sdn_set_normdn_byval((&pb->pb_op->o_sdn), origpb->pb_plugin->plg_name); + } + } + + return pb; +} + void slapi_pblock_init( Slapi_PBlock *pb ) { + Slapi_Operation *op; + if(pb!=NULL) { - pblock_done(pb); - pblock_init(pb); + if(pb->plugin_tracking){ + /* preserve the op, and then reset everything */ + op = pb->pb_op; + pblock_done_by_pb(pb); + pblock_init(pb); + pb->pb_op = op; + pb->plugin_tracking = 1; + } else { + pblock_done(pb); + pblock_init(pb); + } } } @@ -118,6 +155,14 @@ pblock_done( Slapi_PBlock *pb ) } void +pblock_done_by_pb( Slapi_PBlock *pb ) +{ + /* don't free the operation because we still want to use it */ + slapi_ch_free((void**)&(pb->pb_vattr_context)); + slapi_ch_free((void**)&(pb->pb_result_text)); +} + +void slapi_pblock_destroy( Slapi_PBlock* pb ) { if(pb!=NULL) @@ -2068,14 +2113,26 @@ slapi_pblock_set( Slapi_PBlock *pblock, int arg, void *value ) pblock->pb_plugin->plg_desc = *((Slapi_PluginDesc *)value); break; case SLAPI_PLUGIN_INTOP_RESULT: - pblock->pb_internal_op_result = *((int *) value); - break; + pblock->pb_internal_op_result = *((int *) value); + break; case SLAPI_PLUGIN_INTOP_SEARCH_ENTRIES: - pblock->pb_plugin_internal_search_op_entries = (Slapi_Entry **) value; - break; + pblock->pb_plugin_internal_search_op_entries = (Slapi_Entry **) value; + break; case SLAPI_PLUGIN_INTOP_SEARCH_REFERRALS: - pblock->pb_plugin_internal_search_op_referrals = (char **) value; - break; + pblock->pb_plugin_internal_search_op_referrals = (char **) value; + break; + case SLAPI_REQUESTOR_DN: + if(pblock->pb_op == NULL){ + return (-1); + } + slapi_sdn_set_dn_byval((&pblock->pb_op->o_sdn),(char *)value); + break; + case SLAPI_REQUESTOR_SDN: + if(pblock->pb_op == NULL){ + return (-1); + } + slapi_sdn_set_dn_byval((&pblock->pb_op->o_sdn),slapi_sdn_get_dn((Slapi_DN *)value)); + break; /* database plugin functions */ case SLAPI_PLUGIN_DB_BIND_FN: if ( pblock->pb_plugin->plg_type != SLAPI_PLUGIN_DATABASE ) { diff --git a/ldap/servers/slapd/plugin_internal_op.c b/ldap/servers/slapd/plugin_internal_op.c index 9654780..1ac2447 100644 --- a/ldap/servers/slapd/plugin_internal_op.c +++ b/ldap/servers/slapd/plugin_internal_op.c @@ -854,7 +854,8 @@ void set_config_params (Slapi_PBlock *pb) Slapi_Operation *operation; struct slapdplugin *plugin = NULL; char *dn; - struct slapi_componentid * cid=NULL; + struct slapi_componentid * cid=NULL; + slapdFrontendConfig_t *slapdFrontendConfig = getFrontendConfig(); slapi_pblock_get (pb, SLAPI_PLUGIN_IDENTITY, &cid); if (cid) @@ -870,10 +871,16 @@ void set_config_params (Slapi_PBlock *pb) operation_clear_flag(operation, OP_FLAG_ACTION_LOG_AUDIT | OP_FLAG_ACTION_LOG_CHANGES); } - /* set name to be used for creator's and modifiers attributes */ - dn = plugin_get_dn (plugin); - if (dn) - slapi_sdn_init_dn_passin(&operation->o_sdn, dn); + /* + * if we are not tracking the bind dn, then use the plugin name as the + * modifiersname, otherwise, we have already set the op dn as the bind dn + */ + if(!slapdFrontendConfig->plugin_track || slapi_sdn_isempty(&operation->o_sdn)){ + /* set name to be used for creator's and modifiers attributes */ + dn = plugin_get_dn (plugin); + if (dn) + slapi_sdn_init_dn_passin(&operation->o_sdn, dn); + } } /* set parameters common for all internal operations */ diff --git a/ldap/servers/slapd/proto-slap.h b/ldap/servers/slapd/proto-slap.h index e60d1a8..6b868f5 100644 --- a/ldap/servers/slapd/proto-slap.h +++ b/ldap/servers/slapd/proto-slap.h @@ -289,6 +289,7 @@ int config_set_readonly( const char *attrname, char *value, char *errorbuf, int int config_set_schemacheck( const char *attrname, char *value, char *errorbuf, int apply ); int config_set_syntaxcheck( const char *attrname, char *value, char *errorbuf, int apply ); int config_set_syntaxlogging( const char *attrname, char *value, char *errorbuf, int apply ); +int config_set_plugin_tracking( const char *attrname, char *value, char *errorbuf, int apply ); int config_set_dn_validate_strict( const char *attrname, char *value, char *errorbuf, int apply ); int config_set_ds4_compatible_schema( const char *attrname, char *value, char *errorbuf, int apply ); int config_set_schema_ignore_trailing_spaces( const char *attrname, char *value, char *errorbuf, int apply ); @@ -1082,6 +1083,7 @@ void do_unbind( Slapi_PBlock *pb ); void pblock_init( Slapi_PBlock *pb ); void pblock_init_common( Slapi_PBlock *pb, Slapi_Backend *be, Connection *conn, Operation *op ); void pblock_done( Slapi_PBlock *pb ); +void pblock_done_by_pb( Slapi_PBlock *pb ); void bind_credentials_set( Connection *conn, char *authtype, char *normdn, char *extauthtype, char *externaldn, CERTCertificate *clientcert , Slapi_Entry * binded); diff --git a/ldap/servers/slapd/slap.h b/ldap/servers/slapd/slap.h index b855ff0..3e63f11 100644 --- a/ldap/servers/slapd/slap.h +++ b/ldap/servers/slapd/slap.h @@ -1501,6 +1501,7 @@ typedef struct slapi_pblock { int pb_config_lineno; int pb_config_argc; char **pb_config_argv; + int plugin_tracking; /* [pre|post]add arguments */ struct slapi_entry *pb_target_entry; /* JCM - Duplicated */ @@ -1953,6 +1954,7 @@ typedef struct _slapdEntryPoints { #define CONFIG_ERRORLOG_LIST_ATTRIBUTE "nsslapd-errorlog-list" #define CONFIG_AUDITLOG_LIST_ATTRIBUTE "nsslapd-auditlog-list" #define CONFIG_REWRITE_RFC1274_ATTRIBUTE "nsslapd-rewrite-rfc1274" +#define CONFIG_PLUGIN_BINDDN_TRACKING_ATTRIBUTE "nsslapd-plugin-binddn-tracking" #define CONFIG_CONFIG_ATTRIBUTE "nsslapd-config" #define CONFIG_INSTDIR_ATTRIBUTE "nsslapd-instancedir" @@ -2078,6 +2080,7 @@ typedef struct _slapdFrontendConfig { char **backendconfig; char **include; char **plugin; + int plugin_track; struct pw_scheme *pw_storagescheme; int pwpolicy_local; diff --git a/ldap/servers/slapd/slapi-plugin.h b/ldap/servers/slapd/slapi-plugin.h index 36683a4..cd9fcab 100644 --- a/ldap/servers/slapd/slapi-plugin.h +++ b/ldap/servers/slapd/slapi-plugin.h @@ -607,6 +607,19 @@ typedef void (*TaskCallbackFn)(Slapi_Task *task); Slapi_PBlock *slapi_pblock_new( void ); /* allocate and initialize */ /** + * Creates a new parameter block. + * + * \return This function returns a pointer to the new parameter block. + * \warning This function takes the original operation struct, and adds it the + * the new pb. This is so we can track the original bind dn + * \warning The pblock pointer allocated with this function must always be freed by + * slapi_pblock_destroy(). The use of other memory deallocators (for example, + * <tt>free()</tt>) is not supported and may lead to crashes or memory leaks. + * \see slapi_pblock_destroy() + */ +Slapi_PBlock *slapi_pblock_new_by_pb( Slapi_PBlock *pb ); /* allocate and initialize */ + +/** * Initializes an existing parameter block for re-use. * * \param pb The parameter block to initialize. @@ -6166,6 +6179,7 @@ time_t slapi_current_time( void ); /* operation */ #define SLAPI_OPINITIATED_TIME 140 #define SLAPI_REQUESTOR_DN 141 +#define SLAPI_REQUESTOR_SDN 852 #define SLAPI_REQUESTOR_NDN 156 #define SLAPI_OPERATION_PARAMETERS 138 #define SLAPI_OPERATION_TYPE 590

1 0

Branch '389-ds-base-1.2.10' - ldap/servers
by Noriko Hosoi 15 Feb '12

15 Feb '12

ldap/servers/slapd/configdse.c | 23 ---------------- ldap/servers/slapd/libglobs.c | 56 ++++++++++++++++++++++++++++++++-------- ldap/servers/slapd/proto-slap.h | 2 + 3 files changed, 48 insertions(+), 33 deletions(-) New commits: commit f676eb16398958f376efaee72596d00fa4fbd8c3 Author: Noriko Hosoi <nhosoi(a)redhat.com> Date: Tue Feb 14 18:15:51 2012 -0800 Trac Ticket #26 - Please support setting defaultNamingContext in the rootdse. https://fedorahosted.org/389/ticket/26 Fix description: If a config param is set to nsslapd-allowed-to-delete-attrs, the value is allowed to delete. nsslapd-defaultnamingcontext is set to the value, by default. The config set API is not designed to allow deleting a param. Instead, it sets NULL to represent the deletion. But it turned out it was not allowed, either. This patch allows to the config params set in the nsslapd-allowed-to-delete-attrs to pass NULL value. diff --git a/ldap/servers/slapd/configdse.c b/ldap/servers/slapd/configdse.c index faf1560..d6dddb2 100644 --- a/ldap/servers/slapd/configdse.c +++ b/ldap/servers/slapd/configdse.c @@ -123,27 +123,6 @@ ignore_attr_type(const char *attr_type) return 0; } -/* these attr types are allowed to delete */ -static int -allowed_to_delete_attrs(const char *attr_type) -{ - int rc = 0; - if (attr_type) { - char *delattrs = config_get_allowed_to_delete_attrs(); - char **allowed = slapi_str2charray_ext(delattrs, " ", 0); - char **ap; - for (ap = allowed; ap && *ap; ap++) { - if (strcasecmp (attr_type, *ap) == 0) { - rc = 1; - break; - } - } - slapi_ch_array_free(allowed); - slapi_ch_free_string(&delattrs); - } - return rc; -} - int read_config_dse (Slapi_PBlock *pb, Slapi_Entry* e, Slapi_Entry* entryAfter, int *returncode, char *returntext, void *arg) { @@ -436,7 +415,7 @@ modify_config_dse(Slapi_PBlock *pb, Slapi_Entry* entryBefore, Slapi_Entry* e, in } } else if (SLAPI_IS_MOD_DELETE(mods[i]->mod_op)) { /* Need to allow deleting some configuration attrs */ - if (allowed_to_delete_attrs(config_attr)) { + if (config_allowed_to_delete_attrs(config_attr)) { rc = config_set(config_attr, mods[i]->mod_bvalues, returntext, apply_mods); if (apply_mods) { /* log warning once */ diff --git a/ldap/servers/slapd/libglobs.c b/ldap/servers/slapd/libglobs.c index 3e8a615..aafbd7e 100644 --- a/ldap/servers/slapd/libglobs.c +++ b/ldap/servers/slapd/libglobs.c @@ -1315,11 +1315,7 @@ int config_set_listenhost( const char *attrname, char *value, char *errorbuf, int apply ) { int retVal = LDAP_SUCCESS; slapdFrontendConfig_t *slapdFrontendConfig = getFrontendConfig(); - - if ( config_value_is_null( attrname, value, errorbuf, 0 )) { - return LDAP_OPERATIONS_ERROR; - } - + if ( apply) { CFG_LOCK_WRITE(slapdFrontendConfig); @@ -1530,17 +1526,12 @@ int config_set_securelistenhost( const char *attrname, char *value, char *errorbuf, int apply ) { int retVal = LDAP_SUCCESS; slapdFrontendConfig_t *slapdFrontendConfig = getFrontendConfig(); - - if ( config_value_is_null( attrname, value, errorbuf, 0 )) { - return LDAP_OPERATIONS_ERROR; - } if ( apply ) { CFG_LOCK_WRITE(slapdFrontendConfig); slapi_ch_free ( (void **) &(slapdFrontendConfig->securelistenhost) ); slapdFrontendConfig->securelistenhost = slapi_ch_strdup ( value ); - CFG_UNLOCK_WRITE(slapdFrontendConfig); } return retVal; @@ -1551,7 +1542,6 @@ config_set_srvtab( const char *attrname, char *value, char *errorbuf, int apply int retVal = LDAP_SUCCESS; slapdFrontendConfig_t *slapdFrontendConfig = getFrontendConfig(); - if ( config_value_is_null( attrname, value, errorbuf, 0 )) { return LDAP_OPERATIONS_ERROR; } @@ -5804,6 +5794,10 @@ config_set_entryusn_import_init( const char *attrname, char *value, int retVal = LDAP_SUCCESS; slapdFrontendConfig_t *slapdFrontendConfig = getFrontendConfig(); + if ( config_value_is_null( attrname, value, errorbuf, 1 )) { + return LDAP_OPERATIONS_ERROR; + } + if (apply) { CFG_LOCK_WRITE(slapdFrontendConfig); slapi_ch_free_string(&(slapdFrontendConfig->entryusn_import_init)); @@ -5833,6 +5827,10 @@ config_set_allowed_to_delete_attrs( const char *attrname, char *value, int retVal = LDAP_SUCCESS; slapdFrontendConfig_t *slapdFrontendConfig = getFrontendConfig(); + if ( config_value_is_null( attrname, value, errorbuf, 1 )) { + return LDAP_OPERATIONS_ERROR; + } + if (apply) { CFG_LOCK_WRITE(slapdFrontendConfig); slapi_ch_free_string(&(slapdFrontendConfig->allowed_to_delete_attrs)); @@ -5963,6 +5961,20 @@ config_set(const char *attr, struct berval **values, char *errorbuf, int apply) break; default: + if ((NULL == values) && + config_allowed_to_delete_attrs(cgas->attr_name)) { + if (cgas->setfunc) { + retval = (cgas->setfunc)(cgas->attr_name, NULL, + errorbuf, apply); + } else if (cgas->logsetfunc) { + retval = (cgas->logsetfunc)(cgas->attr_name, NULL, + cgas->whichlog, errorbuf, apply); + } else { + LDAPDebug1Arg(LDAP_DEBUG_ANY, + "config_set: the attribute %s is read only; " + "ignoring setting NULL value\n", attr); + } + } for (ii = 0; !retval && values && values[ii]; ++ii) { if (cgas->setfunc) @@ -6230,3 +6242,25 @@ config_set_entry(Slapi_Entry *e) return 1; } + +/* these attr types are allowed to delete */ +int +config_allowed_to_delete_attrs(const char *attr_type) +{ + int rc = 0; + if (attr_type) { + char *delattrs = config_get_allowed_to_delete_attrs(); + char **allowed = slapi_str2charray_ext(delattrs, " ", 0); + char **ap; + for (ap = allowed; ap && *ap; ap++) { + if (strcasecmp (attr_type, *ap) == 0) { + rc = 1; + break; + } + } + slapi_ch_array_free(allowed); + slapi_ch_free_string(&delattrs); + } + return rc; +} + diff --git a/ldap/servers/slapd/proto-slap.h b/ldap/servers/slapd/proto-slap.h index f3e85c9..e60d1a8 100644 --- a/ldap/servers/slapd/proto-slap.h +++ b/ldap/servers/slapd/proto-slap.h @@ -526,6 +526,8 @@ char *config_get_allowed_to_delete_attrs(void); char *config_get_entryusn_import_init(void); char *config_get_default_naming_context(void); +int config_allowed_to_delete_attrs(const char *attr_type); + int is_abspath(const char *); char* rel2abspath( char * ); char* rel2abspath_ext( char *, char * );

1 0

ldap/servers
by Noriko Hosoi 14 Feb '12

14 Feb '12

ldap/servers/slapd/configdse.c | 23 ---------------- ldap/servers/slapd/libglobs.c | 56 ++++++++++++++++++++++++++++++++-------- ldap/servers/slapd/proto-slap.h | 2 + 3 files changed, 48 insertions(+), 33 deletions(-) New commits: commit d664d546be0cf31b73689624010c22df2a29ea2c Author: Noriko Hosoi <nhosoi(a)redhat.com> Date: Tue Feb 14 18:15:51 2012 -0800 Trac Ticket #26 - Please support setting defaultNamingContext in the rootdse. https://fedorahosted.org/389/ticket/26 Fix description: If a config param is set to nsslapd-allowed-to-delete-attrs, the value is allowed to delete. nsslapd-defaultnamingcontext is set to the value, by default. The config set API is not designed to allow deleting a param. Instead, it sets NULL to represent the deletion. But it turned out it was not allowed, either. This patch allows to the config params set in the nsslapd-allowed-to-delete-attrs to pass NULL value. diff --git a/ldap/servers/slapd/configdse.c b/ldap/servers/slapd/configdse.c index faf1560..d6dddb2 100644 --- a/ldap/servers/slapd/configdse.c +++ b/ldap/servers/slapd/configdse.c @@ -123,27 +123,6 @@ ignore_attr_type(const char *attr_type) return 0; } -/* these attr types are allowed to delete */ -static int -allowed_to_delete_attrs(const char *attr_type) -{ - int rc = 0; - if (attr_type) { - char *delattrs = config_get_allowed_to_delete_attrs(); - char **allowed = slapi_str2charray_ext(delattrs, " ", 0); - char **ap; - for (ap = allowed; ap && *ap; ap++) { - if (strcasecmp (attr_type, *ap) == 0) { - rc = 1; - break; - } - } - slapi_ch_array_free(allowed); - slapi_ch_free_string(&delattrs); - } - return rc; -} - int read_config_dse (Slapi_PBlock *pb, Slapi_Entry* e, Slapi_Entry* entryAfter, int *returncode, char *returntext, void *arg) { @@ -436,7 +415,7 @@ modify_config_dse(Slapi_PBlock *pb, Slapi_Entry* entryBefore, Slapi_Entry* e, in } } else if (SLAPI_IS_MOD_DELETE(mods[i]->mod_op)) { /* Need to allow deleting some configuration attrs */ - if (allowed_to_delete_attrs(config_attr)) { + if (config_allowed_to_delete_attrs(config_attr)) { rc = config_set(config_attr, mods[i]->mod_bvalues, returntext, apply_mods); if (apply_mods) { /* log warning once */ diff --git a/ldap/servers/slapd/libglobs.c b/ldap/servers/slapd/libglobs.c index 3e8a615..aafbd7e 100644 --- a/ldap/servers/slapd/libglobs.c +++ b/ldap/servers/slapd/libglobs.c @@ -1315,11 +1315,7 @@ int config_set_listenhost( const char *attrname, char *value, char *errorbuf, int apply ) { int retVal = LDAP_SUCCESS; slapdFrontendConfig_t *slapdFrontendConfig = getFrontendConfig(); - - if ( config_value_is_null( attrname, value, errorbuf, 0 )) { - return LDAP_OPERATIONS_ERROR; - } - + if ( apply) { CFG_LOCK_WRITE(slapdFrontendConfig); @@ -1530,17 +1526,12 @@ int config_set_securelistenhost( const char *attrname, char *value, char *errorbuf, int apply ) { int retVal = LDAP_SUCCESS; slapdFrontendConfig_t *slapdFrontendConfig = getFrontendConfig(); - - if ( config_value_is_null( attrname, value, errorbuf, 0 )) { - return LDAP_OPERATIONS_ERROR; - } if ( apply ) { CFG_LOCK_WRITE(slapdFrontendConfig); slapi_ch_free ( (void **) &(slapdFrontendConfig->securelistenhost) ); slapdFrontendConfig->securelistenhost = slapi_ch_strdup ( value ); - CFG_UNLOCK_WRITE(slapdFrontendConfig); } return retVal; @@ -1551,7 +1542,6 @@ config_set_srvtab( const char *attrname, char *value, char *errorbuf, int apply int retVal = LDAP_SUCCESS; slapdFrontendConfig_t *slapdFrontendConfig = getFrontendConfig(); - if ( config_value_is_null( attrname, value, errorbuf, 0 )) { return LDAP_OPERATIONS_ERROR; } @@ -5804,6 +5794,10 @@ config_set_entryusn_import_init( const char *attrname, char *value, int retVal = LDAP_SUCCESS; slapdFrontendConfig_t *slapdFrontendConfig = getFrontendConfig(); + if ( config_value_is_null( attrname, value, errorbuf, 1 )) { + return LDAP_OPERATIONS_ERROR; + } + if (apply) { CFG_LOCK_WRITE(slapdFrontendConfig); slapi_ch_free_string(&(slapdFrontendConfig->entryusn_import_init)); @@ -5833,6 +5827,10 @@ config_set_allowed_to_delete_attrs( const char *attrname, char *value, int retVal = LDAP_SUCCESS; slapdFrontendConfig_t *slapdFrontendConfig = getFrontendConfig(); + if ( config_value_is_null( attrname, value, errorbuf, 1 )) { + return LDAP_OPERATIONS_ERROR; + } + if (apply) { CFG_LOCK_WRITE(slapdFrontendConfig); slapi_ch_free_string(&(slapdFrontendConfig->allowed_to_delete_attrs)); @@ -5963,6 +5961,20 @@ config_set(const char *attr, struct berval **values, char *errorbuf, int apply) break; default: + if ((NULL == values) && + config_allowed_to_delete_attrs(cgas->attr_name)) { + if (cgas->setfunc) { + retval = (cgas->setfunc)(cgas->attr_name, NULL, + errorbuf, apply); + } else if (cgas->logsetfunc) { + retval = (cgas->logsetfunc)(cgas->attr_name, NULL, + cgas->whichlog, errorbuf, apply); + } else { + LDAPDebug1Arg(LDAP_DEBUG_ANY, + "config_set: the attribute %s is read only; " + "ignoring setting NULL value\n", attr); + } + } for (ii = 0; !retval && values && values[ii]; ++ii) { if (cgas->setfunc) @@ -6230,3 +6242,25 @@ config_set_entry(Slapi_Entry *e) return 1; } + +/* these attr types are allowed to delete */ +int +config_allowed_to_delete_attrs(const char *attr_type) +{ + int rc = 0; + if (attr_type) { + char *delattrs = config_get_allowed_to_delete_attrs(); + char **allowed = slapi_str2charray_ext(delattrs, " ", 0); + char **ap; + for (ap = allowed; ap && *ap; ap++) { + if (strcasecmp (attr_type, *ap) == 0) { + rc = 1; + break; + } + } + slapi_ch_array_free(allowed); + slapi_ch_free_string(&delattrs); + } + return rc; +} + diff --git a/ldap/servers/slapd/proto-slap.h b/ldap/servers/slapd/proto-slap.h index f3e85c9..e60d1a8 100644 --- a/ldap/servers/slapd/proto-slap.h +++ b/ldap/servers/slapd/proto-slap.h @@ -526,6 +526,8 @@ char *config_get_allowed_to_delete_attrs(void); char *config_get_entryusn_import_init(void); char *config_get_default_naming_context(void); +int config_allowed_to_delete_attrs(const char *attr_type); + int is_abspath(const char *); char* rel2abspath( char * ); char* rel2abspath_ext( char *, char * );

1 0

ldap/admin
by Noriko Hosoi 14 Feb '12

14 Feb '12

ldap/admin/src/scripts/DSCreate.pm.in | 11 ++++++++--- ldap/admin/src/scripts/remove-ds.pl.in | 6 ++++-- 2 files changed, 12 insertions(+), 5 deletions(-) New commits: commit c013442930d30e81bb30fea22fe007b6645ecf62 Author: Noriko Hosoi <nhosoi(a)redhat.com> Date: Mon Feb 13 15:45:45 2012 -0800 Trac Ticket #34 - remove-ds.pl does not remove everything https://fedorahosted.org/389/ticket/34 Fix description: Introduce an option "--all | -a", with which all the generated files and directories are removed. diff --git a/ldap/admin/src/scripts/DSCreate.pm.in b/ldap/admin/src/scripts/DSCreate.pm.in index 00d290c..7bb4595 100644 --- a/ldap/admin/src/scripts/DSCreate.pm.in +++ b/ldap/admin/src/scripts/DSCreate.pm.in @@ -1224,6 +1224,7 @@ sub stopServer { sub removeDSInstance { my $inst = shift; my $force = shift; + my $all = shift; my $initconfig_dir = shift || get_initconfigdir(); my $baseconfigdir = $ENV{DS_CONFIG_DIR} || "@instconfigdir@"; my $instname = "slapd-$inst"; @@ -1314,8 +1315,8 @@ sub removeDSInstance { push @errs, remove_tree($dbentry, "nsslapd-db-logdirectory", $instname, 1); } if ($entry) { - push @errs, remove_tree($entry, "nsslapd-lockdir", $instname); - push @errs, remove_tree($entry, "nsslapd-tmpdir", $instname); + push @errs, remove_tree($entry, "nsslapd-lockdir", $instname, 0); + push @errs, remove_tree($entry, "nsslapd-tmpdir", $instname, 0); push @errs, remove_tree($entry, "nsslapd-bakdir", $instname, 1); push @errs, remove_tree($entry, "nsslapd-errorlog", $instname, 1); } @@ -1335,7 +1336,11 @@ sub removeDSInstance { } } # Finally, config dir - push @errs, remove_tree($entry, "nsslapd-schemadir", $instname, 1, "\.db\$"); + if ($all) { + push @errs, remove_tree($entry, "nsslapd-schemadir", $instname, 1); + } else { + push @errs, remove_tree($entry, "nsslapd-schemadir", $instname, 1, "\.db\$"); + } # Remove the instance specific initconfig script if ( -f $initconfig ) { diff --git a/ldap/admin/src/scripts/remove-ds.pl.in b/ldap/admin/src/scripts/remove-ds.pl.in index 5eee37d..5f42615 100755 --- a/ldap/admin/src/scripts/remove-ds.pl.in +++ b/ldap/admin/src/scripts/remove-ds.pl.in @@ -43,12 +43,14 @@ sub usage { my $force = ""; my $instname = ""; my $initconfig_dir = ""; +my $all = ""; GetOptions('help|h|?' => sub { &usage; exit(1); }, 'debug|d+' => \$DSUtil::debuglevel, 'instance|i=s' => \$instname, 'initconfig_dir|c=s' => \$initconfig_dir, - 'force|f' => \$force + 'force|f' => \$force, + 'all|a' => \$all ); # Make sure the instance name option was provided. @@ -63,7 +65,7 @@ unless ($inst) { exit 1; } -my @errs = removeDSInstance($inst, $force, $initconfig_dir); +my @errs = removeDSInstance($inst, $force, $all, $initconfig_dir); if (@errs) { print STDERR "The following errors occurred during removal:\n"; for (@errs) {

1 0

Branch '389-ds-base-1.2.10' - ldap/servers
by Richard Allen Megginson 14 Feb '12

14 Feb '12

ldap/servers/slapd/back-ldbm/ldbm_entryrdn.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) New commits: commit 7373fbf0b5dd0901bdbb57184cf6946a38f5a1be Author: Rich Megginson <rmeggins(a)redhat.com> Date: Mon Feb 13 20:14:12 2012 -0700 Ticket #294 - 389 DS Segfaults during replica install in FreeIPA https://fedorahosted.org/389/ticket/294 Resolves: Ticket #294 Bug Description: 389 DS Segfaults during replica install in FreeIPA Reviewed by: mreynolds (Thanks!) Branch: 389-ds-base-1.2.10 Fix Description: Have to check for NULL childnrdn return from slapi_rdn_get_prev_ext(). Platforms tested: RHEL6 x86_64 Flag Day: no Doc impact: no (cherry picked from commit 9e65c7a35c425d93b2459aea5d249692ffb1eed4) diff --git a/ldap/servers/slapd/back-ldbm/ldbm_entryrdn.c b/ldap/servers/slapd/back-ldbm/ldbm_entryrdn.c index d793705..a0aaa80 100644 --- a/ldap/servers/slapd/back-ldbm/ldbm_entryrdn.c +++ b/ldap/servers/slapd/back-ldbm/ldbm_entryrdn.c @@ -2314,9 +2314,10 @@ _entryrdn_insert_key(backend *be, goto bail; } else { int tmpidx = slapi_rdn_get_prev_ext(srdn, rdnidx, - &childnrdn, FLAG_ALL_NRDNS); - if (0 == strncasecmp(childnrdn, SLAPI_ATTR_UNIQUEID, - sizeof(SLAPI_ATTR_UNIQUEID) - 1)) { + &childnrdn, FLAG_ALL_NRDNS); + if (childnrdn && + (0 == strncasecmp(childnrdn, SLAPI_ATTR_UNIQUEID, + sizeof(SLAPI_ATTR_UNIQUEID) - 1))) { rdnidx = tmpidx; } } @@ -2824,9 +2825,10 @@ _entryrdn_index_read(backend *be, goto bail; } else { int tmpidx = slapi_rdn_get_prev_ext(srdn, rdnidx, - &childnrdn, FLAG_ALL_NRDNS); - if (0 == strncasecmp(childnrdn, SLAPI_ATTR_UNIQUEID, - sizeof(SLAPI_ATTR_UNIQUEID) - 1)) { + &childnrdn, FLAG_ALL_NRDNS); + if (childnrdn && + (0 == strncasecmp(childnrdn, SLAPI_ATTR_UNIQUEID, + sizeof(SLAPI_ATTR_UNIQUEID) - 1))) { rdnidx = tmpidx; } }

1 0

ldap/servers
by Richard Allen Megginson 14 Feb '12

14 Feb '12

ldap/servers/slapd/back-ldbm/ldbm_entryrdn.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) New commits: commit 9e65c7a35c425d93b2459aea5d249692ffb1eed4 Author: Rich Megginson <rmeggins(a)redhat.com> Date: Mon Feb 13 20:14:12 2012 -0700 Ticket #294 - 389 DS Segfaults during replica install in FreeIPA https://fedorahosted.org/389/ticket/294 Resolves: Ticket #294 Bug Description: 389 DS Segfaults during replica install in FreeIPA Reviewed by: mreynolds (Thanks!) Branch: master Fix Description: Have to check for NULL childnrdn return from slapi_rdn_get_prev_ext(). Platforms tested: RHEL6 x86_64 Flag Day: no Doc impact: no diff --git a/ldap/servers/slapd/back-ldbm/ldbm_entryrdn.c b/ldap/servers/slapd/back-ldbm/ldbm_entryrdn.c index d793705..a0aaa80 100644 --- a/ldap/servers/slapd/back-ldbm/ldbm_entryrdn.c +++ b/ldap/servers/slapd/back-ldbm/ldbm_entryrdn.c @@ -2314,9 +2314,10 @@ _entryrdn_insert_key(backend *be, goto bail; } else { int tmpidx = slapi_rdn_get_prev_ext(srdn, rdnidx, - &childnrdn, FLAG_ALL_NRDNS); - if (0 == strncasecmp(childnrdn, SLAPI_ATTR_UNIQUEID, - sizeof(SLAPI_ATTR_UNIQUEID) - 1)) { + &childnrdn, FLAG_ALL_NRDNS); + if (childnrdn && + (0 == strncasecmp(childnrdn, SLAPI_ATTR_UNIQUEID, + sizeof(SLAPI_ATTR_UNIQUEID) - 1))) { rdnidx = tmpidx; } } @@ -2824,9 +2825,10 @@ _entryrdn_index_read(backend *be, goto bail; } else { int tmpidx = slapi_rdn_get_prev_ext(srdn, rdnidx, - &childnrdn, FLAG_ALL_NRDNS); - if (0 == strncasecmp(childnrdn, SLAPI_ATTR_UNIQUEID, - sizeof(SLAPI_ATTR_UNIQUEID) - 1)) { + &childnrdn, FLAG_ALL_NRDNS); + if (childnrdn && + (0 == strncasecmp(childnrdn, SLAPI_ATTR_UNIQUEID, + sizeof(SLAPI_ATTR_UNIQUEID) - 1))) { rdnidx = tmpidx; } }

1 0

VERSION.sh
by Richard Allen Megginson 13 Feb '12

13 Feb '12

VERSION.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit f98310cc0440005be6803c133c3a32579638ed58 Author: Rich Megginson <rmeggins(a)redhat.com> Date: Mon Feb 13 13:43:57 2012 -0700 bump version to 1.2.11.a1 diff --git a/VERSION.sh b/VERSION.sh index 2cf2ac1..ca25d1c 100644 --- a/VERSION.sh +++ b/VERSION.sh @@ -10,11 +10,11 @@ vendor="389 Project" # PACKAGE_VERSION is constructed from these VERSION_MAJOR=1 VERSION_MINOR=2 -VERSION_MAINT=10 +VERSION_MAINT=11 # if this is a PRERELEASE, set VERSION_PREREL # otherwise, comment it out # be sure to include the dot prefix in the prerel -VERSION_PREREL=.rc2 +VERSION_PREREL=.a1 # NOTES on VERSION_PREREL # use aN for an alpha release e.g. a1, a2, etc. # use rcN for a release candidate e.g. rc1, rc2, etc.

1 0

Changes to 'refs/tags/389-ds-base-1.2.10.0'
by Richard Allen Megginson 13 Feb '12

13 Feb '12

Changes since 389-ds-base-1.2.6.a1: Endi S. Dewata (168): Bug 545620 - Password cannot start with minus sign Bug 538525 - Ability to create instance as non-root user Bug 570542 - Root password cannot contain matching curly braces Bug 470684 - Pam_passthru plugin doesn't verify account activation Bug 573375 - MODRDN operation not logged Bug 520151 - Error when modifying userPassword with proxy user Bug 455489 - Address compiler warnings about strict-aliasing rules Bug 566320 - RFE: add exception to removal of attributes in cn=config for aci Bug 566043 - startpid file is only cleaned by initscript runs Bug 584109 - Slapd crashes while parsing DNA configuration Bug 542570 - Directory Server port number is not validated in the beginning. Bug 145181 - Plugin target/bind subtrees only take 1 value. Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093 Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093 Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093 Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093 Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093 Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093 Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093 Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093 Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093 Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093 Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093 Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093 Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093 Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093 Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093 Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093 Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093 Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093 Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093 Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093 Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093 Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136 Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136 Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136 Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136 Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136 Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136 Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136 Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136 Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136 Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136 Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136 Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136 Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136 Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136 Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136 Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136 Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136 Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166 Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166 Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166 Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166 Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166 Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166 Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166 Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166 Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166 Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166 Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166 Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166 Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166 Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166 Bug 628096 - spurious error message from /sbin/service when doing a stop on no instances Bug 573889 - Migration does not remove deprecated schema Bug 606545 - core schema should include numSubordinates Bug 643979 - Strange byte sequence for attribute with no values (nsslapd-referral) Endi Sukma Dewata (16): Bug 630092 - Coverity #12117: Resource leaks issues Bug 630092 - Coverity #15478: Resource leaks issues Bug 630092 - Coverity #15479: Resource leaks issues Bug 630092 - Coverity #15481: Resource leaks issues Bug 630092 - Coverity #15482: Resource leaks issues Bug 630092 - Coverity #15483: Resource leaks issues Bug 630092 - Coverity #15484: Resource leaks issues Bug 630092 - Coverity #15485: Resource leaks issues Bug 630092 - Coverity #15487: Resource leaks issues Bug 630092 - Coverity #15490: Resource leaks issues Bug 630092 - Coverity #15497: Resource leaks issues Bug 630092 - Coverity #11991: Resource leaks issues Bug 630092 - Coverity #12000: Resource leaks issues Bug 630092 - Coverity #12003: Resource leaks issues Bug 630092 - Coverity #11985: Resource leaks issues Bug 630092 - Coverity #11992,11993: Resource leaks issues Mark Reynolds (17): Ticket #71 - unable to delete managed entry config Ticket #159 - Managed Entry Plugin runs against managed entries upon any update without validating Ticket #177 - logconv.pl doesn't detect restarts Merge branch 'ticket159' Ticket #49 - better handling for server shutdown while long running tasks are active Ticket #50 - server should not call a plugin after the plugin close function is calle Updated for ticket#50 Ticket #55 - Limit of 1024 characters for nsMatchingRule Ticket #140 - incorrect memset parameters Revert "Ticket #140 - incorrect memset parameters" Revert "Ticket #55 - Limit of 1024 characters for nsMatchingRule" Ticket #38 - nisDomain schema is incorrect Ticket #6 - protocol error from proxied auth operation Ticket #55 - Limit of 1024 characters for nsMatchingRule Ticket #39 - Account Policy Plugin does not work for simple binds when PAM Pass Through Auth plugin is enabled Ticket 175 - logconv.pl improvements Ticket 175 - minor fixes Nathan Kinder (188): Bug 549554 - Trim single-valued attributes before sending to AD Improve search for pcre header file Bug 434735 - Allow SASL ANONYMOUS mech to work Bug 570912 - Avoid selinux context conflict with httpd Allow instance name to be parsed from start-slapd Add managed entries plug-in Bug 572355 - Label instance files and ports during upgrade. Bug 578863 - Password modify extop needs to send referrals on replicas Bug 584156 - Remove ldapi socket file during upgrade Fix rsearch usage of name files for random filters Bug 584497 - Allow DNA plugin to set same value on multiple attributes Add replication session hooks Correct function prototype for repl session hook Bug 592389 - Set anonymous resource limits properly Bug 601433 - Add man pages for start-dirsrv and related commands Bug 604263 - Fix memory leak when password change is rejected Bug 612242 - membership change on DS does not show on AD Bug 613833 - Allow dirsrv_t to bind to rpc ports Bug 594745 - Get rid of dirsrv_lib_t label Bug 620927 - Allow multiple membership attributes in memberof plugin Bug 612264 - ACI issue with (targetattr='userPassword') Bug 630098 - fix coverity Defect Type: Code maintainability issues Bug 630098 - fix coverity Defect Type: Code maintainability issues Bug 630093 - (cov#15511) Don't use unintialized search_results in refint plugin Bug 630093 - (cov#15518) Need to intialize fd in ldbm2ldif code Bug 630096 - (cov#11778) check return value of ldap_parse_result Bug 630096 - (cov#15446) check return value of ber_scanf() Bug 630096 - (cov#15449,15450) Check return value of stat() Bug 630096 - (cov#15448) Check return value of cache_replace() Bug 630096 - (cov#15447) - Check return value of idl_append_extend() Bug 630090 - (cov#11974) Remove unused ACL functions Bug 630090 - (cov#15445) Fix illegal free in archive code Bug 630094 - (cov#11818) Fix unreachable return in snmp subagent Bug 630094 - (cov#15451) Get rid of unreachable free statements Bug 630094 - (cov#15452) Remove NULL checking for op_string Bug 630094 - (cov#15453) Eliminate NULL check for local_newentry Bug 630094 - (cov#15454) Fix deadcode issue in mapping tree code Bug 630094 - (cov#15455) Remove deadcode in attr_index_config() Bug 630094 - (cov#15456) Remove NULL check for srdn in import code Bug 630094 - (cov#15457) Remove deadcode in import code Bug 630094 - (cov#15458) Fix deadcode issue in moddn code Bug 630094 - (cov#15459) Remove NULL check for srdn in ldif2ldbm code Bug 630094 - (cov#15520) Fix unreachable code issue if perfctrs code Bug 630094 - (cov#15581) Add missing breaks in agt_mopen_stats() Bug 690090 - (cov#11974) Remove additional unused ACL functions Bug 630091 - (cov#15512) Fix usage of uninitialized bervals Bug 630091 - (cov#15513) Fix usage of uninitialized bervals Bug 630091 - (cov#15514) Initialize DBT in entryrdn_get_parent() Bug 630091 - (cov#15515) Use of uninitialized array in index config code Bug 630091 - (cov#15516,15517) Initialize pointers before attempting to free Bug 630091 - (cov#15519) Initialize bervals in search_easter_egg() Bug 630091 - (cov#15582) Free of uninitialized pointer in attr_index_config() Bug 630097 - (cov#11933) Fix NULL dereference in schema code Bug 630097 - (cov#11938) NULL dereference in mmldif Bug 630097 - (cov#11946) NULL dereference in ResHashCreate() Bug 630097 - (cov#11964) Remove dead code from libaccess Bug 630097 - (cov#12143) NULL dereference in cos cache code Bug 630097 - (cov#12148) NULL dereference in ruvInit() Bug 630097 - (cov#12182,12183) NULL dereference in import code Bug 630097 - (cov#15460) NULL deference in ACL URL code Bug 630097 - (cov#15461) Remove unnecessary NULL check in DNA Bug 630097 - (cov#15462) NULL dereference in mep_modrdn_post_op() Bug 630097 - (cov#15463) Remove NULL check in referint plugin Bug 630097 - (cov#15464) NULL dereference in repl code Bug 630097 - (cov#15465) Null dereference in USN code Bug 630097 - (cov#15473) NULL dereference in ResHashCreate() Bug 630097 - (cov#15505) NULL dereference in memberOf code Bug 630097 - (cov#15506) NULL dereference in dblayer code Bug 630097 - (cov#15507,15508) NULL dereference in entryrdn code Bug 630097 - (cov#15509) NULL dereference in idsktune Bug 630097 - (cov#11938) NULL dereference in mmldif Bug 630097 - (cov#15477) NULL dereference in ACL plug-in code Bug 630091 - (cov#12209) Use of uninitialized pointer in libaccess Bug 630092 - (cov#12116) Resource leak in ldclt code Bug 630092 - (cov#12105) Resource leak in pwdscheme config code Bug 630092 - (cov#12068) Resource leak in certmap code Bug 630091 - (cov#11973) Array overrun in libaccess Bug 522055 - Scope check for managed attribute fails Bug 625335 - Self-write aci has permission to invalid attribute Bug 631993 - Log authzid when proxy auth control is used Cov #16300 - Unused variable in account policy plugin Bug 544321 - remove-ds.pl should not throw error unlabelling port Bug 555955 - Allow CoS values to be merged Bug 643937 - Initialize replication version flags Bug 305131 - Allow empty modify operation Bug 619633 - Make attribute uniqueness obey requiredObjectClass Bug 619623 - attr-unique-plugin ignores requiredObjectClass on modrdn operations Bug 189985 - Improve attribute uniqueness error message Bug 647932 - multiple memberOf configuration adding memberOf where there is no member Bug 521088 - DNA should check ACLs before getting a value from the range Bug 635009 - Add one-way AD sync capability Bump VERSION.sh to 1.2.8.a1 Bug 648949 - Move selinux policy into base OS Bug 648949 - Update configure Roll back VERSION.sh for 1.2.7 release Bug 625950 - hash nsslapd-rootpw changes in audit log Bug 656392 - Remove calls to ber_err_print() Bug 656515 - Allow Name and Optional UID syntax for grouping attributes Bug 197886 - Avoid overflow of UUID generator Bug 658312 - Allow mapped attribute types to be quoted Bug 197886 - Initialize return value for UUID generation code Bug 658309 - Process escaped characters in managed entry mappings Bug 659456 - Incorrect usage of ber_printf() in winsync code Bug 641944 - Don't normalize non-DN RDN values Bug 658312 - Invalid free in Managed Entry plug-in Bug 661792 - Valid managed entry config rejected Bug 588791 - Allow anonymous rootDSE access only Bug 606439 - Creating server instance with LDAPI takes too long Bug 632670 - Chain-on-update logs managed-entries-plugin errors Bug 621008 - parsing purge RUV from changelog at startup fails Bug 663191 - Don't use $USER in DSCreate.pm Bug 663597 - Memory leaks in normalization code Bug 659131 - Incorrect RDN values added with multi-valued RDN Bug 661102 - Rename of managed entries not handled correctly Bug 193297 - Call pre-bind plug-ins for all SASL bind steps Bug 201652 - LDAPv2 bind with expired password doesn't unbind correctly Bug 470576 - Migration could do addition checks before commiting actions Bug 481195 - Missing op type in log when password change required Bug 509897 - Validate dnaScope to ensure it is a legal DN Bug 505722 - Allow ntGroup to have mail attribute present Bug 543633 - replication problems if supplier is killed under update load Bug 671033 - range sharing between server breaks with SASL/GSSAPI auth Bug 527912 - setup-ds.pl appears to hang when DNS is unreachable Bug 252249 - Add pkg-config file for plug-in developers Bug 670616 - Allow SSF to be set for local (ldapi) connections Bug 668862 - init scripts return wrong error code Bug 674430 - Improve error messages for attribute uniqueness Bug 675853 - dirsrv crash segfault in need_new_pw() Bug 678646 - Ignore tombstone operations in managed entry plug-in Bug 671199 - Don't allow other to write to rundir Bug 672468 - Don't use empty path elements in LD_LIBRARY_PATH Bug 674852 - crash in ldap-agent when using OpenLDAP Bug 681345 - setup-ds.pl should set SuiteSpotGroup automatically Bug 680558 - Winsync plugin fails to restrain itself to the configured subtree Bug 504803 - Allow maxlogsize to be set if logmaxdiskspace is -1 Bug 687974 - (cov#10715) Fix Coverity uninitialized variables issues Bug 688341 - (cov#10709) Fix Coverity code maintainability issues Bug 688341 - (cov#10708) Fix Coverity code maintainability issues Bug 688341 - (cov#10706,10707) Fix Coverity code maintainability issues Bug 688341 - (cov#10704,10705) Fix Coverity code maintainability issues Bug 688341 - (cov#10703) Fix Coverity code maintainability issues Bug 688341 - (cov#10702) Fix Coverity code maintainability issues Bug 688341 - (cov#10709) Fix Coverity code maintainability issues Bug 689537 - (cov#10699) Fix Coverity NULL pointer dereferences Bug 689537 - (cov#10610) Fix Coverity NULL pointer dereferences Bug 689537 - (cov#10608) Fix Coverity NULL pointer dereferences Bug 689952 - (cov#10581) Incorrect bit check in replication connection code Bug 690526 - (cov#10734) Double free in dse_add() Bug 690649 - (cov#10731) Use of free'd pointer in indexing code Bug 690882 - (cov#10571) Incorrect sizeof use in uuid code Bug 690882 - (cov#10636,10637) Useless comparison in attrcrypt Bug 690882 - (cov#10703) Incorrect sizeof use in vattr code Bug 690882 - (cov#10572,10710) Incorrect sizeof use in uuid code Bug 691574 - (cov#10579) Check return value of ber_scanf() in sort code Bug 691574 - (cov#10577) Check return types when adding RDN CSNs Bug 691574 - (cov#10573) check return value in GER code Bug 691574 - (cov#10575) Check return value of ldap_get_option Bug 691574 - (cov#10573) Fix syntax error Bug 693868 - Add managed entry config during in-place upgrade Add Auto Membership Plug-in Bug 698428 - Make auto membership use Slapi_DN for DN comparisons Bug 695779 - windows sync can lose old values when a new value is added Bug 700557 - Linked attrs callbacks access free'd pointers after close Bug 700557 - Leak at shutdown in DNA plug-in Bug 703304 - Auto membership alternate config area should override default area Bug 703304 - Auto membership alternate config area should override default area Bug 703530 - Allow Managed Entry config to be relocated Bug 697961 - memberOf needs to be triggered by internal operations Bug 710377 - Import with chain-on-update crashes ns-slapd Split automember regex rules into separate entries Bug 713209 - Update sudo schema Bug 691313 - Need TLS/SSL error messages in repl status and errors log Bug 723937 - Slapi_Counter API broken on 32-bit F15 Bug 725743 - Make memberOf use PRMonitor for it's operation lock Bug 729717 - Fatal error messages when syncing deletes from AD Bug 728510 - Run dirsync after sending updates to AD Bug 730387 - Add slapi_rwlock API and use POSIX rwlocks Bug 611438 - Add Account Usability Control support Bug 728592 - Allow ns-slapd to start with an invalid server cert Bug 732541 - Ignore error 32 when adding automember config Bug 722292 - Entries in DS are not updated properly when using WinSync API Bug 722292 - (cov#11030) Leak of mapped_sdn in winsync rename code Bug 735114 - renaming a managed entry does not update mepmanagedby Bug 739172 - Allow separate fractional attrs for incremental and total protocols Bug 743966 - Compiler warnings in account usability plugin Bug 744946 - (cov#11046) NULL dereference in IDL code Bug 752155 - Use restorecon after creating init script lock file Ticket 284 - Remove unnecessary SNMP MIB files Noriko Hosoi (299): 544089 - Referential Integrity Plugin does not take into account the attribute 557224 - subtree rename breaks the referential integrity plug-in 247413 - Incorrect error on multiple identical value add 559016 - Attempting to rename suffix returns inappropriate errors 555577 - Syntax validation fails for "ou=NetscapeRoot" tree Undo - 555577 - Syntax validation fails for "ou=NetscapeRoot" tree 560827 - Admin Server templates: DistinguishName validation fails 548535 - memory leak in attrcrypt 563365 - Error handling problems in the backend functions 565664 - Incorrect parameter for CACHE_RETURN() 565987 - redhat-ds-base fails to build due to undefined struct 527848 - make sure db upgrade to 4.7 and later works correctly 539618 - Replication bulk import reports Invalid read/write 567370 - dncache: assertion failure in id2entry_delete 548115 - memory leak in schema reload 555970 - missing read lock in the combination of cos and nsview 539618 - Replication bulk import reports Invalid read/write 570667 - MMR: simultaneous total updates on the masters cause Merge branch '547503' Revert "Merge branch '547503'" Bug 554573 - ACIs use bind DN from bind req rather than cert mapped DN from sasl/external 199923 - subtree search fails to find items under a db 570107 - The import of LDIFs with base-64 encoded DNs fails, 572649 - DS8.2 crashes on RHEL 4 (corresponding to bob, ber_2 test case) 573060 - DN normalizer: ESC HEX HEX is not normalized ( 573896 - initializing subtree with invalid syntax crashes ns-slapd 515805 - Stop "initialize Database" crashes the server 548533 - memory leak in Repl_5_Inc_Protocol_new Fixing a syntax error Update to New DN Format 585905 - ACL with targattrfilters error crashes the server 574167 - An escaped space at the end of the RDN value is not 590931 - rhds81 import - hardcoded pages_limit for nsslapd-import-cache-autosize 591336 - Implementing upgrade DN format tool 593453 - Creating password policy with ns-newpolicy.pl on Replicated 593110 - backup-restore does not ALWAYS work 593899 - adding specific ACI causes very large mem allocate request 588867 - entryusn plugin fails on solaris 593899 - adding specific ACI causes very large mem allocate request 595893 - Base DN in SASL mapping is not normalized 511112 - Password history limited to 25 values 597375 - Deleting LDBM database causes backup/restore problem 574101 - MODRDN request never returns - possible deadlock 606920 - anonymous resource limit - nstimelimit - 605827 - In-place upgrade: upgrade dn format should not run in setup-ds-admin.pl 578296 - Attribute type entrydn needs to be added when subtree 609256 - Selinux: pwdhash fails if called via Admin Server CGI 609255 - fix coverity Defect Type: Memory - illegal accesses issues 609255 - fix coverity Defect Type: Memory - illegal accesses issues 609255 - fix coverity Defect Type: Memory - illegal accesses issues 609255 - fix coverity Defect Type: Memory - illegal accesses issues 609255 - fix coverity Defect Type: Memory - illegal accesses issues 609255 - fix coverity Defect Type: Memory - illegal accesses issues 609255 - fix coverity Defect Type: Memory - illegal accesses issues 609255 - fix coverity Defect Type: Memory - illegal accesses issues 609255 - fix coverity Defect Type: Memory - illegal accesses issues 609255 - fix coverity Defect Type: Memory - illegal accesses issues 609255 - fix coverity Defect Type: Memory - illegal accesses issues 609255 - fix coverity Defect Type: Memory - illegal accesses issues 609255 - fix coverity Defect Type: Memory - illegal accesses issues 609255 - fix coverity Defect Type: Memory - illegal accesses issues 609255 - fix coverity Defect Type: Memory - illegal accesses issues 609255 - fix coverity Defect Type: Memory - illegal accesses issues 616618 - 389 v1.2.5 accepts 2 identical entries with different DN formats 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 610281 - fix coverity Defect Type: Control flow issues 616608 - SIGBUS in RDN index reads on platforms with strict alignments 619595 - Upgrading sub suffix under non-normalized suffix disappears 513166 - Simple Paged result doesn't provide the server's estimate 621928 - Unable to enable replica (rdn problem?) on 1.2.6 rc6 Bug 194531 - db2bak is too noisy Bug 622628 - fix coverity Defect Type: Integer handling issues Bug 622628 - fix coverity Defect Type: Integer handling issues Bug 622628 - fix coverity Defect Type: Integer handling issues Bug 622903 - fix coverity Defect Type: Code maintainability issues Bug 622903 - fix coverity Defect Type: Code maintainability issues Bug 622903 - fix coverity Defect Type: Code maintainability issues Bug 622903 - fix coverity Defect Type: Code maintainability issues Bug 622903 - fix coverity Defect Type: Code maintainability issues Bug 622903 - fix coverity Defect Type: Code maintainability issues Bug 622903 - fix coverity Defect Type: Code maintainability issues Bug 622903 - fix coverity Defect Type: Code maintainability issues Bug 622903 - fix coverity Defect Type: Code maintainability issues Bug 622903 - fix coverity Defect Type: Code maintainability issues Bug 622903 - fix coverity Defect Type: Code maintainability issues Bug 622903 - fix coverity Defect Type: Code maintainability issues Bug 622903 - fix coverity Defect Type: Code maintainability issues Bug 622903 - fix coverity Defect Type: Code maintainability issues Bug 622903 - fix coverity Defect Type: Code maintainability issues Bug 623118 - Simplepaged results going in infinite loop Bug 614511 - fix coverity Defect Type: Null pointer dereferences issues 11846 - 11891 Bug 619122 - fix coverity Defect Type: Resource leaks issues CID 11975 - 12051 Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093 Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093 Bug 617630 - fix coverity Defect Type: Resource leaks issues CID 12052 - 12093 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 616500 - fix coverity Defect Type: Resource leaks issues CID 12094 - 12136 Bug 616500 - fix coverity Defect Type: Resource leaks issues CID 12094 - 12136 Bug 616500 - fix coverity Defect Type: Resource leaks issues CID 12094 - 12136 Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 Bug 616500 - fix coverity Defect Type: Resource leaks issues Bug 623507 - fix coverity Defect Type: Incorrect expression issues Bug 623507 - fix coverity Defect Type: Incorrect expression issues Bug 613056 - fix coverify Defect Type: Null pointer dereferences Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166 Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166 Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166 Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166 Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166 Removed redundant code in agmt_new_from_entry Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093 Bug 628300 - DN is not normalized in dn/entry cache when an entry is added, entrydn is not present in search results Bug 531642 - EntryUSN: RFE: a configuration option to make entryusn "global" Bug 627738 - The cn=monitor statistics entries for the dnentry cache do not change or change very rarely DN normalizer should check the invalid type Bug 627738 - The cn=monitor statistics entries for the dnentry cache Bug 629710 - escape_string does not check '\<HEX><HEX>' agmtlist_shutdown (repl5_agmtlist.c) had an illegal access defect. Bug 633168 - Share backend dbEnv with the replication changelog Bug 633168 - Share backend dbEnv with the replication changelog Bug 631862 - crash - delete entries not in cache + referint Bug 625014 - SubTree Renames: ModRDN operation fails and the server hangs if the entry is moved to "under" the same DN. Bug 558099 - Enhancement request: Log more information about the search result being a paged one Bug 635987 - Incorrect sub scope search result with Bug 606920 - anonymous resource limit- nstimelimit - Bug 635987 - Incorrect sub scope search result with ACL containing ldap:///self Bug 639289 - Adding a new CN entry with UpperCase UTF-8 Character Bug 640027 - Naming attribute with a special char sequence parsing bug Bug 640854 - changelog db: _cl5WriteOperation: failed to Bug 637852 - sasl_io_start_packet: failed - read only 3 bytes Bug 586966 - Sample update script has syntax errors Bug 586973 - Sample update ldif points to non-existent directory Bug 602456 - Allow to add any cn=config attributes; Bug 244229 - targetattr not verified against schema when setting an aci Bug 643532 - Incorrect DNs sometimes returned on searches Bug 592397 - Upgrade tool dn2rdn: it does not clean up Bug 645061 - Upgrade: 06inetorgperson.ldif and 05rfc4524.ldif Bug 629681 - Retro Changelog trimming does not behave as expected Bug 644608 - RHDS 8.1->8.2 upgrade fails to properly migrate ACIs Bug 644608 - RHDS 8.1->8.2 upgrade fails to properly migrate ACIs Bug 644608 - RHDS 8.1->8.2 upgrade fails to properly migrate ACIs Bug 638773 - permissions too loose on pid and lock files Bug 491733 - dbtest crashes Bug 329751 - "nested" filtered roles searches candidates more Bug 567282 - server can not abandon searchRequest of "simple paged results" Bug 572018 - Upgrading from 1.2.5 to 1.2.6.a2 deletes userRoot Bug 651571 - When attrcrypt is on, entrydn is stored in the backend db Bug 661918 - 389-ds MMR plugin's changelogdb path logic is incorrect Bug 182507 - clear-password mod from replica is discarded before changelogged Bug 602456 - Allow to add any cn=config attributes; Bug 489379 - passwordExpirationTime in entry being added Bug 663484 - Entry usn plugin fails to properly tag entries on initialization Bug 664563 - GER: ger for non-present entry is not correct Bug 653007 - db2ldif export of clear text passwords lacks storage scheme Bug 667488 - Cannot recreate numsubordinates index with db2index Bug 663752 - Cert renewal for attrcrypt and encchangelog Bug 615100 - log rotationinfo always recreated at startup, Bug 624442 - MMR: duplicate replica ID Bug 669205 - db2bak: backed up changelog should include RUVs Bug 616850 - ldapmodify failed to reject the replace operation Bug 627993 - Inconsistent storage of password expiry times Bug 627993 - Inconsistent storage of password expiry times dn2rdn should respect the DB version info Bug 646381 - Faulty password for nsmultiplexorcredentials does not give any error message in logs Bug 624547 - attrcrypt should query the given slot/token for Bug 668619 - slapd stops responding Bug 151705 - Need to update Console Cipher Preferences with new ciphers Bug 615052 - intrinsics and 64-bit atomics code fails to compile Bug 616213 - insufficient stack size for HP-UX on PA-RISC Bug 675265 - preventryusn gets added to entries on a failed delete Bug 604881 - admin server log files have incorrect permissions/ownerships Bug 676053 - export task followed by import task causes cache assertion Bug 676053 - export task followed by import task causes cache assertion Bug 676053 - export task followed by import task causes cache assertion Bug 450016 - RFE- Console display values in KB/MB/GB Cancelling commit aef19508c4f618285116d2068655183658f564d9 Bug 625424 - repl-monitor.pl doesn't work in hub node Bug 679978 - modifying attr value crashes the server, which is supposed to Bug 681015 - RFE: allow fine grained password policy duration attributes in days, hours, minutes, as well Bug 668909 - Can't modify replication agreement in some cases Bug 684996 - Exported tombstone cannot be imported correctly Bug 681015 - RFE: allow fine grained password policy duration attributes in days, hours, minutes, as well Bug 689866 - ns-newpwpolicy.pl needs to use the new DN format Bug 690955 - Mrclone fails due to the replica generation id mismatch Bug 696407 - If an entry with a mixed case RDN is turned to be Bug 697027 - 1 - minor memory leaks found by Valgrind + TET Bug 697027 - 2 - minor memory leaks found by Valgrind + TET Bug 697027 - 3 - minor memory leaks found by Valgrind + TET Bug 697027 - 4 - minor memory leaks found by Valgrind + TET Bug 697027 - 5 - minor memory leaks found by Valgrind + TET Bug 697027 - 6 - minor memory leaks found by Valgrind + TET Bug 697027 - 7 - minor memory leaks found by Valgrind + TET Bug 697027 - 8 - minor memory leaks found by Valgrind + TET Bug 697027 - 9 - minor memory leaks found by Valgrind + TET Bug 697027 - 10 - minor memory leaks found by Valgrind + TET Bug 697027 - 11 - minor memory leaks found by Valgrind + TET Bug 697027 - 12 - minor memory leaks found by Valgrind + TET Bug 697027 - 13 - minor memory leaks found by Valgrind + TET Bug 697027 - 14 - minor memory leaks found by Valgrind + TET Bug 697027 - 15 - minor memory leaks found by Valgrind + TET Bug 697027 - 16 - minor memory leaks found by Valgrind + TET Bug 697027 - 3 - minor memory leaks found by Valgrind + TET Bug 697027 - 3 - minor memory leaks found by Valgrind + TET Bug 700215 - ldclt core dumps Bug 668619 - slapd stops responding Bug 709826 - Memory leak: when extra referrals configured Bug 706179 - DS can not restart after create a new objectClass has entryusn attribute Bug 663752 - Cert renewal for attrcrypt and encchangelog Bug 663752 - Cert renewal for attrcrypt and encchangelog Bug 711679 - unresponsive LDAP service when deleting vlv on replica Bug 711679 - unresponsive LDAP service when deleting vlv on replica Bug 718303 - Intensive updates on masters could break the consumer's cache Merge branch '718303' Bug 719069 - clean up compiler warnings in 389-ds-base 1.2.9 Bug 712855 - Directory Server 8.2 logs "Netscape Portable Bug 663752 - Cert renewal for attrcrypt and encchangelog Bug 732153 - subtree and user account lockout policies implemented? Introducing an environment variable USE_VALGRIND to clean up the entry cache and dn cache on exit. Bug 744945 - nsslapd-counters attribute value cannot be set to "off" Keep unhashed password psuedo-attribute in the adding entry Reduce the number of DN normalization Bug 745259 - Incorrect entryUSN index under high load Bug 750622 - Fix Coverity (11104) Resource leak: Bug 750624 - Fix Coverity (11053) Explicit null dereferenced: Bug 750625 - Fix Coverity (11066) Unused pointer value Bug 750625 - Fix Coverity (11065) Uninitialized pointer read Bug 750625 - Fix Coverity (11064) Dereference before null check Bug 750625 - Fix Coverity (11061) Resource leak Bug 750625 - Fix Coverity (11060) Dereference null return value Bug 750625 - Fix Coverity (11058, 11059) Dereference null return value Bug 750625 - Fix Coverity (11057) Dereference null return value Bug 750625 - Fix Coverity (11055) Explicit null dereferenced Bug 750625 - Fix Coverity (11054) Dereference after null check Bug 750625 - Fix Coverity (11117) Uninitialized pointer read Bug 750625 - Fix Coverity (11116) Uninitialized pointer read Bug 750625 - Fix Coverity (11114, 11115) Uninitialized value use Bug 750625 - Fix Coverity (11113) Uninitialized pointer read Bug 750625 - Fix Coverity (11112) Uninitialized pointer read Bug 750625 - Fix Coverity (11109, 11110, 11111) Uninitialized pointer read Bug 750625 - Fix Coverity (11108) Sizeof not portable Bug 750625 - Fix Coverity (11107) Dereference before null check Bug 750625 - Fix Coverity (11096) Explicit null dereferenced Bug 750625 - Fix Coverity (11095) Explicit null dereferenced Bug 750625 - Fix Coverity (11094) Dereference after null check Bug 750625 - Fix Coverity (11091) Unchecked return value Bug 750625 - Fix Coverity (11055-2) Explicit null dereferenced Bug 750625 - Fix Coverity (11062) Resource leak Bug 750625 - Fix Coverity (11066-2) Unused pointer value Bug 750625 - Fix Coverity (12195) Dereference after null check Bug 750625 - Fix Coverity (12196) Dereference before null check Bug 750625 - Fix Coverity (11066-3) Unused pointer value Bug 745259 - Incorrect entryUSN index under high load in Trac Ticket 2 - If node entries are tombstone'd, Trac Ticket 2 - If node entries are tombstone'd, Trac Ticket 26 - Please support setting Trac Ticket 75 - Unconfigure plugin opperations are being called. Trac Ticket 168 - minssf should not apply to rootdse Trac Ticket #18 - Data inconsitency during replication Trac Ticket #52 - FQDN set to nsslapd-listenhost Trac Ticket 139 - eliminate the use of char *dn in favor of Slapi_DN *dn Trac Ticket 35 - Log not clear enough on schema errors Trac Ticket #274 - Reindexing entryrdn fails if Trac Ticket #275 - Invalid read reported by valgrind Trac Ticket 51 - memory leaks in 389-ds-base-1.2.8.2-1.el5? Rich Megginson (301): Net::LDAP password modify extop breaks; msgid in response is 0xFF Clean up assert for entrydn Bug 543080 - Bitwise plugin fails to return the exact matched entries for Bitwise search filter Bug 537466 - nsslapd-distribution-plugin should not require plugin name to begin with "lib" bump version to 1.2.6.a2 Do not use syntax plugins directly for filters, indexing wrap new style matching rule plugins for use in old style indexing code change extensible filter code to use new syntax function style mr funcs change syntax plugins to register required matching rule plugins crash looking up compat syntax; numeric string syntax using integer; make octet string ordering work correctly fix memory leak in attr replace when replacement fails fix dso linking issues found by fedora 13 linking problems linking with -z defs 389 DS segfaults on libsyntax-plugin.so - part 1 389 DS segfaults on libsyntax-plugin.so - part 2 389 DS segfaults on libsyntax-plugin.so - part 3 Bug 460162 - FedoraDS "with-FHS" installs init.d StartupScript in wrong location on non-RHEL/Fedora OS Bug 568196 - Install DS8.2 on Solaris fails Bug 568196 - Install DS8.2 on Solaris fails - part 2 Bug 551198 - LDAPI: incorrect logging to access log bump version to 1.2.6.a3 fix various memory leaks Bug 551198 - LDAPI: incorrect logging to access log - part 2 Bug 554573 - ACIs use bind DN from bind req rather than cert mapped DN from sasl/external cleanup build warnings Bug 571514 - upgrade to 1.2.6 should upgrade 05rfc4523.ldif (cert schema) Bug 570905 - postalAddress syntax should allow empty lines (should allow $$) Add support for additional schema/matching rules included with 389 Bug 572677 - Memory leak in searches including GER control Bug 571677 - Busy replica on consumers when directly deleting a replication conflict Bug 576074 - search filters with parentheses fail Bug 567429 - slapd didn't close connection and get into CLOSE_WAIT state Bug 578167 - repl. of mod/replace deletes multi-valued attrs Bug 561575 - setup-ds-admin fails to supply nsds5ReplicaName when configuring via ConfigFile Bug 572162 - the string "|*" within a search filter on a non-indexed attribute returns all elements. Bug 576644 - segfault while multimaster replication (paired node won't find deleted entries) start of 1.2.6.a4 Bug 572018 - Upgrading from 1.2.5 to 1.2.6.a2 deletes userRoot Fix too few args for format warning in acllas Bug 586571 - DS Console shows escaped DNs Bug 591685 - Server instances Fail to Start on Solaris due to Library Path and pcre bump console version to 1.2.3 Repl Session API needs to check for NULL api before init Bug 593392 - setup-ds-admin.pl -k creates world readable file Bug 595874 - 99user.ldif getting overpopulated bump version to 1.2.6.a5 bump version to 1.2.6.rc1 bump version to 1.2.6.rc2 bump version to 1.2.6.rc3 Bug 604453 - SASL Stress and Server crash: Program quits with the assertion failure in PR_Poll Bug 604453 - SASL Stress and Server crash: Program quits with the assertion failure in PR_Poll Bug 603942 - null deref in _ger_parse_control() for subjectdn bump version to 1.2.6.rc4 Bug 609590 - fix coverity Defect Type: Memory - corruptions issues Bug 609590 - fix coverity Defect Type: Memory - corruptions issues Bug 609590 - fix coverity Defect Type: Memory - corruptions issues Bug 609590 - fix coverity Defect Type: Memory - corruptions issues Bug 609590 - fix coverity Defect Type: Memory - corruptions issues Bug 609590 - fix coverity Defect Type: Memory - corruptions issues Bug 609590 - fix coverity Defect Type: Memory - corruptions issues Bug 609590 - fix coverity Defect Type: Memory - corruptions issues Bug 609590 - fix coverity Defect Type: Memory - corruptions issues Bug 602530 - coverity: op_shared_modify: compare pre, post and original entries before freeing them Bug 602531 - coverity: op_shared_delete: compare preop entry and GLUE_PARENT_ENTRY before freeing them Bug 609590 - fix coverity Defect Type: Memory - corruptions issues Bug 610177 - fix coverity Defect Type: Uninitialized variables issues Bug 610276 - fix coverity Defect Type: API usage errors issues Bug 611850 - fix coverity Defect Type: Error handling issues Bug 614242 - C99/ANSI C++ related compile errors on HP-UX Bug 547503 - replication broken again, with 389 MMR replication and TCP errors Bug 617013 - repl-monitor.pl use cpu upto 90% fix build failures due to libtool problems Bug 617629 - Missing aliases in new schema files Bug 617862 - Replication: Unable to delete tombstone errors bump version to 1.2.7.a1 Bug 610281 - fix coverity Defect Type: Control flow issues - daemon.c:write_function() Bug 610281 - fix coverity Defect Type: Control flow issues - last repl init status postalAddress syntax does not accept empty values ger should support both "dn" and "distinguishedName" openldap - ldap_url_parse_ext is not part of the public api fix memleak in ldbm_config_read_instance_entries Add -x option to ldap tools when using openldap openldap - add support for missing controls, add ldif api, fix NSS usage port client tools to use openldap API use the mozldap versions of the proxy auth control create function document slapi wrappers for openldap/mozldap functions that differ fix some compiler warnings use strcasecmp with ptype and type->bv_val ber_printf 'o' cannot handle NULL bv_val fix the url_parse logic when looking for a missing suffix DN openldap ldapsearch uses -LLL to suppress # version: N add ldaptool_opts for the non BUNDLE case in Makefile.am openldap ldapsearch returns empty line at end of LDIF output have to use LDAP_OPT_X_TLS_NEVER to defeat cert hostname checking openldap_read_function needs to set EWOULDBLOCK if the buffer is empty do not terminate unwrapped LDIF line with another newline slapi_ldap_url_parse must handle multiple host:port in url convert mozldap host list to openldap uri list move the out pointer back if continuation lines were removed check src < *out only; only check for \nspace if src < *out - 2 use slapi_ldap_url_parse in the acl code do not un-null-terminate normalized DN until new url is constructed implement slapi_ldap_explode_dn and slapi_ldap_explode_rdn use slapi_pblock_set to set the ldap result code for the be postop plugins pass the string copy to slapi_dn_normalize_original bug 614511 - fix coverity null reference - revert macro aci $dn logic fix compiler warnings - unused vars/funcs, invalid casts use slapi_mods_init_passin/get_ldapmods_passout if modifying the smods Have to explicitly set protocol version to 3 Only check modrdn ops for backend/suffix correctness if not the default backend Bug 634561 - Server crushes when using Windows Sync Agreement openldap ber_init will assert if the bv->bv_val is NULL add the account policy plugin and related server code, schema, and config fix pblock memory leak do not register pre/post op plugins if disabled add support for global inactivity limit fix typos in Makefile.am, acctpolicy schema bump version to 1.2.7.a2 remove extra format argument; use %lu for size_t printf format Bug 644013 - uniqueness plugin segfault bug bump version to 1.2.7.a3 bump to 1.2.7.a4 bump version to 1.2.7.a5 put replication config entries in separate file bump version to 1.2.7.a6 bump version to 1.2.7.1 bump version to 1.2.7.2 bump version to 1.2.7.3 bump version to 1.2.7.4 Bug 515329 - Multiple mods in one operation can result in an inconsistent replica bump version to 1.2.8.a1 Bug 642046 - Segfault when using SASL/GSSAPI multimaster replication, possible krb5_creds doublefree Bug 624485 - setup dsktune check step should default to "yes" if no problems found Bug 622907 - support piped passwords to perl-based maintenance commands Bug 624485 - setup dsktune check step should default to "yes" if no problems found Bug 576534 - Password displayed on console when entered in command-line utilities Bug 667935 - DS pipe log script's logregex.py plugin is not redirecting the log output to the text file bump version to 1.2.8.a2 Bug 668385 - DS pipe log script is executed as many times as the dirsrv service is restarted Bug 676689 - crash while adding a new user to be synced to windows Bug 675113 - ns-slapd core dump in windows_tot_run if oneway sync is used Bug 677440 - clean up compiler warnings in 389-ds-base 1.2.8 Bug 677774 - DS fails to start after reboot Bug 666076 - dirsrv crash (1.2.7.5) with multiple simple paged result searches Bug 675320 - empty modify operation with repl on or lastmod off will crash server bump version to 1.2.9.a1 - console version to 1.2.4 Bug 677705 - ds-logpipe.py script is failing to validate "-s" and "--serverpid" options with "-t". Bug 676655 - winsync stops working after server restart Bug 680555 - ns-slapd segfaults if I have more than 100 DBs Bug 514190 - setup-ds-admin.pl --debug does not log to file Bug 518890 - setup-ds-admin.pl - improve hostname validation Bug 644784 - Memory leak in "testbind.c" plugin Bug 683250 - slapd crashing when traffic replayed Bug 690584 - #10691 ldbm_back_init() - fix coverity resource leak issues Bug 690584 - #10690 #10689 attrcrypt_get_ssl_cert_name() - fix coverity resource leak issues Bug 690584 - #10688 - dblayer_make_env - fix coverity resource leak issues Bug 690584 - #10669 #10668 cl5ImportLDIF - fix coverity resource leak issues Bug 690584 - #10658 linked_attrs_pre_op - fix coverity resource leak issues Bug 690584 - #10655 acllas__handle_group_entry - fix coverity resource leak issues Bug 690584 - #10654 #10653 str2entry_dupcheck - fix coverity resource leak issues Bug 690584 - #10652 #10651 #10650 #10649 #10648 #10647 send_specific_attrs send_all_attrs - fix coverity resource leak issues Bug 690584 - #10643 hash_rootpw - fix coverity resource leak issues Bug 690584 - #10641 reslimit_bv2int - fix coverity resource leak issues Bug 691422 - sdt_destroy - fix coverity control flow issues Bug 691422 - ldbm_back_upgradedb - fix coverity control flow issues Bug 691422 - csnplFree - fix coverity control flow issues Bug 691422 - SetUnicodeStringFromUTF_8 - fix coverity control flow issues Bug 691422 - cl5DeleteRUV - fix coverity control flow issues Bug 691422 - acl_read_access_allowed_on_entry - fix coverity control flow issues Bug 691422 - search_internal_callback_pb - fix coverity control flow issues Bug 691422 - cl5WriteRUV - fix coverity control flow issues Bug 691422 - windows_replay_update - fix coverity control flow issues Bug 690584 - #10691 ldbm_back_init() - fix coverity resource leak issues Bug 690584 - #10652 #10651 #10650 #10649 #10648 #10647 send_specific_attrs send_all_attrs - fix coverity resource leak issues Bug 668385 - DS pipe log script is executed as many times as the dirsrv service is restarted Bug 692937 - Replica install fails after step for "enable GSSAPI for replication" Bug 692331 - Segfault on index update during full replication push on 1.2.7.5 Bug 693451 - cannot use localized matching rules Bug 693455 - nsMatchingRule does not work with multiple values Bug 693503 - matching rules do not inherit from superior attribute type Bug 693466 - Unable to change schema online Bug 692991 - rhds82 - windows_tot_run: failed to obtain data to send to the consumer; LDAP error - -1 Bug 693473 - rhds82 rfe - windows_tot_run to log Sizelimit exceeded instead of LDAP error - -1 Bug 693962 - Full replica push loses some entries with multi-valued RDNs Bug 694336 - Group sync hangs Windows initial Sync Bug 700145 - userpasswd not replicating Bug 703990 - Support upgrade from Red Hat Directory Server bump console version to 1.2.5 Bug 703990 - Support upgrade from Red Hat Directory Server Bug 703990 - Support upgrade from Red Hat Directory Server Bug 707015 - Cannot disable SSLv3 and use TLS only bump version to 1.2.9.a2 Bug 707384 - only allow FIPS approved cipher suites in FIPS mode Bug 711906 - ns-slapd segfaults using suffix referrals Bug 706209 - LEGAL: RHEL6.1 License issue for 389-ds-base package Bug 703703 - setup-ds-admin.pl asks for legal agreement to a non-existant file Bug 711679 - unresponsive LDAP service when deleting vlv on replica bump console version to 1.2.6 Bug 697694 - rhds82 - incr update state stop_fatal_error "requires administrator action", with extop_result: 9 Bug 716980 - winsync uses old AD entry if new one not found add support for ldif files with changetype: add writing Inf file shows SchemaFile = ARRAY(0xhexnum) look for separate openldap ldif library bump version to 1.2.9.a3 Bug 709468 - RSA Authentication Server timeouts when using simple paged results on RHDS 8.2. Bug 720059 - RDN with % can cause crashes or missing entries bump version to 1.2.9.0 Bug 725542 - Instance upgrade fails when upgrading 389-ds-base package Bug 725953 - Winsync: DS entries fail to sync to AD, if the User's CN entry contains a comma Bug 723937 - replication failing on RUV errors bump version to 1.2.9.1 Bug 727511 - ldclt SSL search requests are failing with "illegal error number -1" error bump version to 1.2.9.2 Bug 727511 - ldclt SSL search requests are failing with "illegal error numbe bump version to 1.2.9.3 Bug 727511 - ldclt SSL search requests are failing with "illegal error number -1" error bump version to 1.2.9.4 Bug 727511 - ldclt SSL search requests are failing with "illegal error number -1" error bump version to 1.2.9.5 Bug 729378 - delete user subtree container in AD + modify password in DS == DS crash Bug 723937 - replication failing on RUV errors Bug 729369 - upgrade DB to upgrade from entrydn to entryrdn format is not working. make sure the DBVERSION file ends in a newline bump version to 1.2.10.a1 Bug 633803 - passwordisglobalpolicy attribute brakes TLS chaining Bug 733103 - large targetattr list with syntax errors cause server to crash or hang Bug 703990 - cross-platform - Support upgrade from Red Hat Directory Server Bug 735121 - simple paged search + ip/dns based ACI hangs server Bug 695736 - Providing native systemd file for upcoming F15 Feature Systemd Bug 590826 - Reloading database from ldif causes changelog to emit "data no longer matches" errors Bug 736712 - Modifying ruv entry deadlocks server Add support for pre/post db transaction plugins Make all backend operations transaction aware Bug 741744 - MOD operations with chained delete/add get back error 53 on backend config Bug 742324 - allow nsslapd-idlistscanlimit to be set dynamically and per-user Bug 741744 - part2 - MOD operations with chained delete/add get back error 53 on backend config Bug 740942 - allow resource limits to be set for paged searches independently of limits for other searches/operations bump version to 1.2.10.a2 bump version to 1.2.10.a3 fix transaction support in ldbm_delete bump version to 1.2.10.a4 set the ENTRY_POST_OP for modrdn betxnpostoperation plugins pass the plugin config entry to the plugin init function make memberof transaction aware and able to be a betxnpostoperation plugin Bug 741744 - part3 - MOD operations with chained delete/add get back error 53 bump version to 1.2.10.a5 Change referential integrity to be a betxnpostoperation plugin Use new PLUGIN_CONFIG_ENTRY feature to allow switching between txn and regular Bug 748575 - rhds81 modrn operation and 100% cpu use in replication Bug 748575 - part 2 - rhds81 modrdn operation and 100% cpu use in replication Bug 751495 - 'setup-ds.pl -u' fails with undefined routine 'updateSystemD' bump version to 1.2.10.a6 Bug 751645 - crash when simple paged fails to send entry to client csn_as_string - use slapi_uN_to_hex instead of sprintf uniqueid formatting - use slapi_u8_to_hex instead of sprintf fix member variable name error in slapi_uniqueIDFormat reduce calls to csn_as_string and slapi_log_error csn_init_as_string should not use sscanf use slapi_hexchar2int and slapi_str_to_u8 everywhere Bug 755754 - Unable to start dirsrv service using systemd Bug 755725 - 389 programs linked against openldap crash during shutdown Ticket 1 - pre-normalize filter and pre-compile substring regex - and other optimizations Ticket #162 - Infinite loop / spin inside strcmpi_fast, acl_read_access_allowed_on_attr, server DoS bak2db gets stuck in infinite loop Ticket #256 - debug build assertion in ACL_EvalDestroy() bump version to 1.2.10.a7 Ticket #167 - Mixing transaction and non-transaction plugins can cause deadlock fix mep sdn compiler warnings add a hack to disable sasl hostname canonicalization - helps with testing when you don't want to set up correct host name resolution and/or cannot set the default system hostname Ticket #12 - 389 DS DNA Plugin / Replication failing on GSSAPI Ticket #257 - repl-monitor doesn't work if leftmost hostnames are the same fix recent compiler warnings Ticket #15 - Get rid of rwlock.h/rwlock.c and just use slapi_rwlock instead fix compiler warnings Remove redundant code - make a global into a static Ticket #262 - pid file not removed with systemd fix mozldap build issues Ticket #264 - upgrade needs better check for "server is running" Ticket #263 - add systemd include directive bump version to 1.2.10.rc1 change version to 1.2.10.a8 Ticket #272 - add tombstonenumsubordinates to schema bump version to 1.2.10.rc1 Ticket #161 - Review and address latest Coverity issues Ticket #22 - RFE: Support sendmail LDAP routing schema Ticket #29 - Samba3-schema is missing sambaTrustedDomainPassword Ticket #273 - ruv tombstone searches don't work after reindex entryrdn Ticket #273 - ruv tombstone searches don't work after reindex entryrdn fix a couple of minor coverity issues Ticket #87 - Manpages fixes Ticket #13 - slapd process exits when put the database on read only mode while updates are coming to the server Ticket #55 - Limit of 1024 characters for nsMatchingRule Ticket #277 - cannot set repl referrals or state Ticket #278 - Schema replication update failed: Invalid syntax Ticket #277 - cannot set repl referrals or state Ticket #279 - filter normalization does not use matching rules Ticket #280 - extensible binary filters do not work Ticket #281 - TLS not working with latest openldap coverity 12488 Resource leak In attr_index_config(): Leak of memory or pointers to system resources bump version to 1.2.10.rc2 bump version to 1.2.10.0 nturpin (1): Ticket #3: acl cache overflown problem root (1): Bug 480787 - Autoconf parameter --with and --without --- .gitignore | 1 Makefile.am | 261 Makefile.in | 5215 - README | 11 VERSION.sh | 7 aclocal.m4 | 6996 -- compile | 21 config.guess | 302 config.h.in | 22 config.sub | 232 configure |41932 +++++------- configure.ac | 176 depcomp | 172 dirsrv.pc.in | 7 include/base/dbtbase.h | 2 include/base/file.h | 3 include/base/lexer.h | 126 include/base/rwlock.h | 91 include/i18n.h | 115 include/ldaputil/ldaputil.h | 10 include/libaccess/aclerror.h | 1 include/libaccess/aclproto.h | 15 include/libaccess/aclstruct.h | 2 include/libaccess/dbtlibaccess.h | 3 include/public/nsacl/aclapi.h | 7 install-sh | 517 ldap/admin/src/base-initconfig.in | 44 ldap/admin/src/initconfig.in | 37 ldap/admin/src/logconv.pl | 639 ldap/admin/src/scripts/10cleanupldapi.pl | 23 ldap/admin/src/scripts/10fixrundir.pl | 11 ldap/admin/src/scripts/50acctusabilityplugin.ldif | 21 ldap/admin/src/scripts/50automemberplugin.ldif | 15 ldap/admin/src/scripts/50fixNsState.pl | 240 ldap/admin/src/scripts/50managedentriesplugin.ldif | 16 ldap/admin/src/scripts/50refintprecedence.ldif | 4 ldap/admin/src/scripts/50smd5pwdstorageplugin.ldif | 5 ldap/admin/src/scripts/60upgradeschemafiles.pl | 2 ldap/admin/src/scripts/70upgradefromldif.pl | 108 ldap/admin/src/scripts/80upgradednformat.pl | 206 ldap/admin/src/scripts/81changelog.pl | 34 ldap/admin/src/scripts/90subtreerename.pl | 21 ldap/admin/src/scripts/91subtreereindex.pl | 148 ldap/admin/src/scripts/DSCreate.pm.in | 323 ldap/admin/src/scripts/DSDialogs.pm | 4 ldap/admin/src/scripts/DSMigration.pm.in | 47 ldap/admin/src/scripts/DSUpdate.pm.in | 50 ldap/admin/src/scripts/DSUtil.pm.in | 247 ldap/admin/src/scripts/DialogManager.pm | 241 ldap/admin/src/scripts/DialogManager.pm.in | 241 ldap/admin/src/scripts/Inf.pm | 67 ldap/admin/src/scripts/Migration.pm.in | 20 ldap/admin/src/scripts/Setup.pm.in | 20 ldap/admin/src/scripts/SetupDialogs.pm.in | 31 ldap/admin/src/scripts/SetupLog.pm | 8 ldap/admin/src/scripts/ds-logpipe.py | 221 ldap/admin/src/scripts/exampleupdate.ldif | 2 ldap/admin/src/scripts/exampleupdate.sh | 10 ldap/admin/src/scripts/logregex.py | 16 ldap/admin/src/scripts/migrate-ds.pl.in | 13 ldap/admin/src/scripts/remove-ds.pl.in | 28 ldap/admin/src/scripts/repl-monitor.pl.in | 86 ldap/admin/src/scripts/restart-dirsrv.in | 25 ldap/admin/src/scripts/setup-ds.pl.in | 7 ldap/admin/src/scripts/setup-ds.res.in | 35 ldap/admin/src/scripts/start-dirsrv.in | 43 ldap/admin/src/scripts/stop-dirsrv.in | 27 ldap/admin/src/scripts/template-bak2db.in | 49 ldap/admin/src/scripts/template-bak2db.pl.in | 29 ldap/admin/src/scripts/template-db2bak.in | 53 ldap/admin/src/scripts/template-db2bak.pl.in | 29 ldap/admin/src/scripts/template-db2index.in | 14 ldap/admin/src/scripts/template-db2index.pl.in | 33 ldap/admin/src/scripts/template-db2ldif.in | 15 ldap/admin/src/scripts/template-db2ldif.pl.in | 29 ldap/admin/src/scripts/template-dbverify.in | 15 ldap/admin/src/scripts/template-dn2rdn.in | 25 ldap/admin/src/scripts/template-fixup-linkedattrs.pl.in | 29 ldap/admin/src/scripts/template-fixup-memberof.pl.in | 29 ldap/admin/src/scripts/template-ldif2db.in | 15 ldap/admin/src/scripts/template-ldif2db.pl.in | 29 ldap/admin/src/scripts/template-ldif2ldap.in | 19 ldap/admin/src/scripts/template-monitor.in | 19 ldap/admin/src/scripts/template-ns-accountstatus.pl.in | 33 ldap/admin/src/scripts/template-ns-activate.pl.in | 33 ldap/admin/src/scripts/template-ns-inactivate.pl.in | 33 ldap/admin/src/scripts/template-ns-newpwpolicy.pl.in | 47 ldap/admin/src/scripts/template-restart-slapd.in | 2 ldap/admin/src/scripts/template-restoreconfig.in | 15 ldap/admin/src/scripts/template-saveconfig.in | 15 ldap/admin/src/scripts/template-schema-reload.pl.in | 29 ldap/admin/src/scripts/template-start-slapd.in | 3 ldap/admin/src/scripts/template-stop-slapd.in | 2 ldap/admin/src/scripts/template-suffix2instance.in | 15 ldap/admin/src/scripts/template-syntax-validate.pl.in | 29 ldap/admin/src/scripts/template-upgradedb.in | 15 ldap/admin/src/scripts/template-upgradednformat.in | 63 ldap/admin/src/scripts/template-usn-tombstone-cleanup.pl.in | 29 ldap/admin/src/scripts/template-verify-db.pl.in | 19 ldap/admin/src/scripts/template-vlvindex.in | 15 ldap/admin/src/slapd.inf.in | 2 ldap/admin/src/template-initconfig.in | 18 ldap/docs/LICENSE.txt | 132 ldap/docs/README.txt | 11 ldap/include/ldaplog.h | 32 ldap/ldif/50replication-plugins.ldif | 26 ldap/ldif/template-baseacis.ldif.in | 2 ldap/ldif/template-bitwise.ldif.in | 6 ldap/ldif/template-dse.ldif.in | 96 ldap/ldif/template-suffix-db.ldif.in | 1 ldap/schema/00core.ldif | 72 ldap/schema/01core389.ldif | 19 ldap/schema/02common.ldif | 12 ldap/schema/05rfc4523.ldif | 14 ldap/schema/05rfc4524.ldif | 30 ldap/schema/06inetorgperson.ldif | 5 ldap/schema/10automember-plugin.ldif | 123 ldap/schema/10mep-plugin.ldif | 104 ldap/schema/30ns-common.ldif | 4 ldap/schema/50ns-directory.ldif | 4 ldap/schema/60acctpolicy.ldif | 47 ldap/schema/60nis.ldif | 2 ldap/schema/60qmail.ldif | 4 ldap/schema/60samba3.ldif | 34 ldap/schema/60sendmail.ldif | 54 ldap/schema/60sudo.ldif | 58 ldap/servers/plugins/acct_usability/acct_usability.c | 464 ldap/servers/plugins/acct_usability/acct_usability.h | 63 ldap/servers/plugins/acctpolicy/acct_config.c | 143 ldap/servers/plugins/acctpolicy/acct_init.c | 191 ldap/servers/plugins/acctpolicy/acct_plugin.c | 316 ldap/servers/plugins/acctpolicy/acct_util.c | 257 ldap/servers/plugins/acctpolicy/acctpolicy.h | 81 ldap/servers/plugins/acctpolicy/sampleconfig.ldif | 40 ldap/servers/plugins/acctpolicy/samplepolicy.ldif | 27 ldap/servers/plugins/acl/acl.c | 195 ldap/servers/plugins/acl/acl.h | 43 ldap/servers/plugins/acl/acl_ext.c | 152 ldap/servers/plugins/acl/aclanom.c | 13 ldap/servers/plugins/acl/acleffectiverights.c | 116 ldap/servers/plugins/acl/aclgroup.c | 19 ldap/servers/plugins/acl/aclinit.c | 2 ldap/servers/plugins/acl/acllas.c | 400 ldap/servers/plugins/acl/acllist.c | 77 ldap/servers/plugins/acl/aclparse.c | 610 ldap/servers/plugins/acl/aclplugin.c | 37 ldap/servers/plugins/acl/aclproxy.c | 232 ldap/servers/plugins/acl/aclutil.c | 110 ldap/servers/plugins/automember/automember.c | 1930 ldap/servers/plugins/automember/automember.h | 134 ldap/servers/plugins/bitwise/bitwise.c | 23 ldap/servers/plugins/chainingdb/cb.h | 8 ldap/servers/plugins/chainingdb/cb_add.c | 105 ldap/servers/plugins/chainingdb/cb_bind.c | 196 ldap/servers/plugins/chainingdb/cb_compare.c | 101 ldap/servers/plugins/chainingdb/cb_config.c | 37 ldap/servers/plugins/chainingdb/cb_conn_stateless.c | 102 ldap/servers/plugins/chainingdb/cb_controls.c | 36 ldap/servers/plugins/chainingdb/cb_delete.c | 125 ldap/servers/plugins/chainingdb/cb_init.c | 6 ldap/servers/plugins/chainingdb/cb_instance.c | 325 ldap/servers/plugins/chainingdb/cb_modify.c | 133 ldap/servers/plugins/chainingdb/cb_modrdn.c | 174 ldap/servers/plugins/chainingdb/cb_monitor.c | 6 ldap/servers/plugins/chainingdb/cb_schema.c | 4 ldap/servers/plugins/chainingdb/cb_search.c | 219 ldap/servers/plugins/chainingdb/cb_utils.c | 15 ldap/servers/plugins/collation/collate.c | 24 ldap/servers/plugins/collation/orfilter.c | 19 ldap/servers/plugins/cos/cos_cache.c | 773 ldap/servers/plugins/deref/deref.c | 12 ldap/servers/plugins/dna/dna.c | 900 ldap/servers/plugins/http/http_impl.c | 81 ldap/servers/plugins/linkedattrs/fixup_task.c | 154 ldap/servers/plugins/linkedattrs/linked_attrs.c | 284 ldap/servers/plugins/linkedattrs/linked_attrs.h | 8 ldap/servers/plugins/memberof/memberof.c | 841 ldap/servers/plugins/memberof/memberof.h | 8 ldap/servers/plugins/memberof/memberof_config.c | 242 ldap/servers/plugins/mep/mep.c | 2861 ldap/servers/plugins/mep/mep.h | 130 ldap/servers/plugins/pam_passthru/pam_passthru.h | 2 ldap/servers/plugins/pam_passthru/pam_ptconfig.c | 2 ldap/servers/plugins/pam_passthru/pam_ptimpl.c | 32 ldap/servers/plugins/pam_passthru/pam_ptpreop.c | 9 ldap/servers/plugins/passthru/passthru.h | 4 ldap/servers/plugins/passthru/ptbind.c | 6 ldap/servers/plugins/passthru/ptconfig.c | 43 ldap/servers/plugins/passthru/ptconn.c | 8 ldap/servers/plugins/passthru/ptpreop.c | 17 ldap/servers/plugins/pwdstorage/smd5_pwd.c | 9 ldap/servers/plugins/referint/referint.c | 761 ldap/servers/plugins/replication/cl4_api.c | 2 ldap/servers/plugins/replication/cl5.h | 1 ldap/servers/plugins/replication/cl5_api.c | 2655 ldap/servers/plugins/replication/cl5_api.h | 111 ldap/servers/plugins/replication/cl5_clcache.c | 55 ldap/servers/plugins/replication/cl5_clcache.h | 2 ldap/servers/plugins/replication/cl5_config.c | 247 ldap/servers/plugins/replication/cl5_init.c | 2 ldap/servers/plugins/replication/cl5_test.c | 2 ldap/servers/plugins/replication/cl_crypt.c | 203 ldap/servers/plugins/replication/cl_crypt.h | 53 ldap/servers/plugins/replication/csnpl.c | 44 ldap/servers/plugins/replication/legacy_consumer.c | 31 ldap/servers/plugins/replication/repl-session-plugin.h | 119 ldap/servers/plugins/replication/repl.h | 2 ldap/servers/plugins/replication/repl5.h | 65 ldap/servers/plugins/replication/repl5_agmt.c | 304 ldap/servers/plugins/replication/repl5_agmtlist.c | 106 ldap/servers/plugins/replication/repl5_connection.c | 155 ldap/servers/plugins/replication/repl5_inc_protocol.c | 92 ldap/servers/plugins/replication/repl5_init.c | 49 ldap/servers/plugins/replication/repl5_mtnode_ext.c | 13 ldap/servers/plugins/replication/repl5_plugins.c | 193 ldap/servers/plugins/replication/repl5_prot_private.h | 4 ldap/servers/plugins/replication/repl5_protocol.c | 107 ldap/servers/plugins/replication/repl5_protocol_util.c | 509 ldap/servers/plugins/replication/repl5_replica.c | 308 ldap/servers/plugins/replication/repl5_replica_config.c | 365 ldap/servers/plugins/replication/repl5_replica_dnhash.c | 26 ldap/servers/plugins/replication/repl5_replica_hash.c | 30 ldap/servers/plugins/replication/repl5_ruv.c | 419 ldap/servers/plugins/replication/repl5_ruv.h | 18 ldap/servers/plugins/replication/repl5_tot_protocol.c | 32 ldap/servers/plugins/replication/repl5_total.c | 22 ldap/servers/plugins/replication/repl5_updatedn_list.c | 2 ldap/servers/plugins/replication/repl_bind.c | 6 ldap/servers/plugins/replication/repl_compare.c | 18 ldap/servers/plugins/replication/repl_connext.c | 2 ldap/servers/plugins/replication/repl_controls.c | 2 ldap/servers/plugins/replication/repl_extop.c | 291 ldap/servers/plugins/replication/repl_globals.c | 2 ldap/servers/plugins/replication/repl_init.c | 1 ldap/servers/plugins/replication/repl_objset.c | 9 ldap/servers/plugins/replication/repl_session_plugin.c | 188 ldap/servers/plugins/replication/repl_shared.h | 17 ldap/servers/plugins/replication/replutil.c | 107 ldap/servers/plugins/replication/test_repl_session_plugin.c | 335 ldap/servers/plugins/replication/urp.c | 152 ldap/servers/plugins/replication/urp.h | 10 ldap/servers/plugins/replication/urp_glue.c | 14 ldap/servers/plugins/replication/urp_tombstone.c | 18 ldap/servers/plugins/replication/windows_connection.c | 166 ldap/servers/plugins/replication/windows_inc_protocol.c | 55 ldap/servers/plugins/replication/windows_private.c | 128 ldap/servers/plugins/replication/windows_protocol_util.c | 677 ldap/servers/plugins/replication/windows_tot_protocol.c | 125 ldap/servers/plugins/replication/windowsrepl.h | 14 ldap/servers/plugins/replication/winsync-plugin.h | 2 ldap/servers/plugins/retrocl/retrocl.c | 3 ldap/servers/plugins/retrocl/retrocl.h | 2 ldap/servers/plugins/retrocl/retrocl_create.c | 13 ldap/servers/plugins/retrocl/retrocl_po.c | 23 ldap/servers/plugins/retrocl/retrocl_trim.c | 20 ldap/servers/plugins/rever/des.c | 72 ldap/servers/plugins/rever/rever.c | 8 ldap/servers/plugins/roles/roles_cache.c | 128 ldap/servers/plugins/schema_reload/schema_reload.c | 5 ldap/servers/plugins/shared/plugin-utils.h | 112 ldap/servers/plugins/shared/utils.c | 508 ldap/servers/plugins/statechange/statechange.c | 26 ldap/servers/plugins/syntaxes/bin.c | 142 ldap/servers/plugins/syntaxes/bitstring.c | 68 ldap/servers/plugins/syntaxes/ces.c | 172 ldap/servers/plugins/syntaxes/cis.c | 321 ldap/servers/plugins/syntaxes/deliverymethod.c | 32 ldap/servers/plugins/syntaxes/dn.c | 72 ldap/servers/plugins/syntaxes/facsimile.c | 32 ldap/servers/plugins/syntaxes/guide.c | 32 ldap/servers/plugins/syntaxes/int.c | 96 ldap/servers/plugins/syntaxes/nameoptuid.c | 72 ldap/servers/plugins/syntaxes/numericstring.c | 148 ldap/servers/plugins/syntaxes/sicis.c | 32 ldap/servers/plugins/syntaxes/string.c | 402 ldap/servers/plugins/syntaxes/syntax.h | 61 ldap/servers/plugins/syntaxes/syntax_common.c | 118 ldap/servers/plugins/syntaxes/tel.c | 94 ldap/servers/plugins/syntaxes/teletex.c | 32 ldap/servers/plugins/syntaxes/telex.c | 31 ldap/servers/plugins/syntaxes/validate.c | 17 ldap/servers/plugins/syntaxes/value.c | 120 ldap/servers/plugins/uiduniq/7bit.c | 48 ldap/servers/plugins/uiduniq/plugin-utils.h | 96 ldap/servers/plugins/uiduniq/uid.c | 326 ldap/servers/plugins/uiduniq/utils.c | 256 ldap/servers/plugins/usn/usn.c | 179 ldap/servers/plugins/usn/usn.h | 3 ldap/servers/plugins/usn/usn_cleanup.c | 31 ldap/servers/plugins/views/views.c | 27 ldap/servers/slapd/abandon.c | 7 ldap/servers/slapd/add.c | 173 ldap/servers/slapd/agtmmap.c | 56 ldap/servers/slapd/attr.c | 84 ldap/servers/slapd/attrlist.c | 7 ldap/servers/slapd/attrsyntax.c | 143 ldap/servers/slapd/auditlog.c | 69 ldap/servers/slapd/auth.c | 59 ldap/servers/slapd/ava.c | 2 ldap/servers/slapd/back-ldbm/ancestorid.c | 104 ldap/servers/slapd/back-ldbm/archive.c | 91 ldap/servers/slapd/back-ldbm/back-ldbm.h | 96 ldap/servers/slapd/back-ldbm/backentry.c | 2 ldap/servers/slapd/back-ldbm/cache.c | 83 ldap/servers/slapd/back-ldbm/dbhelp.c | 12 ldap/servers/slapd/back-ldbm/dblayer.c | 1614 ldap/servers/slapd/back-ldbm/dblayer.h | 14 ldap/servers/slapd/back-ldbm/dbtest.c | 349 ldap/servers/slapd/back-ldbm/dbversion.c | 52 ldap/servers/slapd/back-ldbm/dn2entry.c | 63 ldap/servers/slapd/back-ldbm/filterindex.c | 244 ldap/servers/slapd/back-ldbm/findentry.c | 147 ldap/servers/slapd/back-ldbm/id2entry.c | 175 ldap/servers/slapd/back-ldbm/idl.c | 35 ldap/servers/slapd/back-ldbm/idl_common.c | 7 ldap/servers/slapd/back-ldbm/idl_new.c | 50 ldap/servers/slapd/back-ldbm/idl_shim.c | 17 ldap/servers/slapd/back-ldbm/import-merge.c | 28 ldap/servers/slapd/back-ldbm/import-threads.c | 1364 ldap/servers/slapd/back-ldbm/import.c | 398 ldap/servers/slapd/back-ldbm/import.h | 21 ldap/servers/slapd/back-ldbm/index.c | 246 ldap/servers/slapd/back-ldbm/init.c | 89 ldap/servers/slapd/back-ldbm/instance.c | 174 ldap/servers/slapd/back-ldbm/ldbm_add.c | 242 ldap/servers/slapd/back-ldbm/ldbm_attr.c | 392 ldap/servers/slapd/back-ldbm/ldbm_attrcrypt.c | 986 ldap/servers/slapd/back-ldbm/ldbm_attrcrypt_config.c | 2 ldap/servers/slapd/back-ldbm/ldbm_bind.c | 4 ldap/servers/slapd/back-ldbm/ldbm_compare.c | 4 ldap/servers/slapd/back-ldbm/ldbm_config.c | 309 ldap/servers/slapd/back-ldbm/ldbm_config.h | 9 ldap/servers/slapd/back-ldbm/ldbm_delete.c | 323 ldap/servers/slapd/back-ldbm/ldbm_entryrdn.c | 840 ldap/servers/slapd/back-ldbm/ldbm_index_config.c | 668 ldap/servers/slapd/back-ldbm/ldbm_instance_config.c | 262 ldap/servers/slapd/back-ldbm/ldbm_modify.c | 140 ldap/servers/slapd/back-ldbm/ldbm_modrdn.c | 361 ldap/servers/slapd/back-ldbm/ldbm_search.c | 411 ldap/servers/slapd/back-ldbm/ldbm_usn.c | 74 ldap/servers/slapd/back-ldbm/ldif2ldbm.c | 790 ldap/servers/slapd/back-ldbm/matchrule.c | 50 ldap/servers/slapd/back-ldbm/misc.c | 298 ldap/servers/slapd/back-ldbm/monitor.c | 14 ldap/servers/slapd/back-ldbm/nextid.c | 17 ldap/servers/slapd/back-ldbm/parents.c | 141 ldap/servers/slapd/back-ldbm/perfctrs.c | 24 ldap/servers/slapd/back-ldbm/proto-back-ldbm.h | 52 ldap/servers/slapd/back-ldbm/sort.c | 38 ldap/servers/slapd/back-ldbm/start.c | 61 ldap/servers/slapd/back-ldbm/vlv.c | 383 ldap/servers/slapd/back-ldbm/vlv_srch.c | 17 ldap/servers/slapd/back-ldbm/vlv_srch.h | 3 ldap/servers/slapd/back-ldif/back-ldif.h | 2 ldap/servers/slapd/back-ldif/modrdn.c | 12 ldap/servers/slapd/backend.c | 72 ldap/servers/slapd/backend_manager.c | 18 ldap/servers/slapd/bind.c | 320 ldap/servers/slapd/bulk_import.c | 39 ldap/servers/slapd/charray.c | 27 ldap/servers/slapd/compare.c | 41 ldap/servers/slapd/computed.c | 36 ldap/servers/slapd/config.c | 2 ldap/servers/slapd/configdse.c | 84 ldap/servers/slapd/connection.c | 196 ldap/servers/slapd/conntable.c | 3 ldap/servers/slapd/control.c | 26 ldap/servers/slapd/csn.c | 77 ldap/servers/slapd/csngen.c | 54 ldap/servers/slapd/csnset.c | 4 ldap/servers/slapd/daemon.c | 173 ldap/servers/slapd/delete.c | 127 ldap/servers/slapd/dn.c | 1561 ldap/servers/slapd/dse.c | 222 ldap/servers/slapd/dynalib.c | 29 ldap/servers/slapd/entry.c | 919 ldap/servers/slapd/entrywsi.c | 108 ldap/servers/slapd/eventq.c | 4 ldap/servers/slapd/extendop.c | 35 ldap/servers/slapd/factory.c | 1 ldap/servers/slapd/fe.h | 5 ldap/servers/slapd/fedse.c | 40 ldap/servers/slapd/filter.c | 141 ldap/servers/slapd/filter.h | 1 ldap/servers/slapd/filtercmp.c | 26 ldap/servers/slapd/filterentry.c | 36 ldap/servers/slapd/generation.c | 1 ldap/servers/slapd/index_subsystem.c | 28 ldap/servers/slapd/intrinsics.h | 7 ldap/servers/slapd/ldaputil.c | 719 ldap/servers/slapd/lenstr.c | 6 ldap/servers/slapd/libglobs.c | 586 ldap/servers/slapd/libslapd.def | 1 ldap/servers/slapd/log.c | 77 ldap/servers/slapd/log.h | 20 ldap/servers/slapd/main.c | 288 ldap/servers/slapd/mapping_tree.c | 478 ldap/servers/slapd/match.c | 96 ldap/servers/slapd/modify.c | 491 ldap/servers/slapd/modrdn.c | 357 ldap/servers/slapd/modutil.c | 14 ldap/servers/slapd/operation.c | 27 ldap/servers/slapd/opshared.c | 281 ldap/servers/slapd/pagedresults.c | 130 ldap/servers/slapd/passwd_extop.c | 203 ldap/servers/slapd/pblock.c | 559 ldap/servers/slapd/plugin.c | 328 ldap/servers/slapd/plugin_acl.c | 19 ldap/servers/slapd/plugin_internal_op.c | 176 ldap/servers/slapd/plugin_mr.c | 474 ldap/servers/slapd/plugin_syntax.c | 442 ldap/servers/slapd/protect_db.c | 24 ldap/servers/slapd/protect_db.h | 7 ldap/servers/slapd/proto-slap.h | 67 ldap/servers/slapd/proxyauth.c | 246 ldap/servers/slapd/psearch.c | 77 ldap/servers/slapd/pw.c | 519 ldap/servers/slapd/pw.h | 5 ldap/servers/slapd/pw_mgmt.c | 161 ldap/servers/slapd/pw_retry.c | 87 ldap/servers/slapd/rdn.c | 141 ldap/servers/slapd/referral.c | 29 ldap/servers/slapd/regex.c | 3 ldap/servers/slapd/resourcelimit.c | 80 ldap/servers/slapd/result.c | 81 ldap/servers/slapd/rootdse.c | 12 ldap/servers/slapd/rwlock.c | 257 ldap/servers/slapd/rwlock.h | 65 ldap/servers/slapd/sasl_io.c | 167 ldap/servers/slapd/sasl_map.c | 57 ldap/servers/slapd/saslbind.c | 160 ldap/servers/slapd/schema.c | 179 ldap/servers/slapd/schemaparse.c | 13 ldap/servers/slapd/search.c | 89 ldap/servers/slapd/security_wrappers.c | 36 ldap/servers/slapd/slap.h | 194 ldap/servers/slapd/slapi-plugin-compat4.h | 6 ldap/servers/slapd/slapi-plugin.h | 1258 ldap/servers/slapd/slapi-private.h | 57 ldap/servers/slapd/slapi2nspr.c | 79 ldap/servers/slapd/slapi_counter.c | 24 ldap/servers/slapd/snmp_collator.c | 19 ldap/servers/slapd/ssl.c | 323 ldap/servers/slapd/str2filter.c | 5 ldap/servers/slapd/task.c | 128 ldap/servers/slapd/test-plugins/testbind.c | 1 ldap/servers/slapd/test-plugins/testpostop.c | 1 ldap/servers/slapd/time.c | 91 ldap/servers/slapd/tools/dbscan.c | 76 ldap/servers/slapd/tools/ldclt/data.c | 70 ldap/servers/slapd/tools/ldclt/ldapfct.c | 1124 ldap/servers/slapd/tools/ldclt/ldclt.c | 48 ldap/servers/slapd/tools/ldclt/ldclt.h | 3 ldap/servers/slapd/tools/ldclt/ldcltU.c | 24 ldap/servers/slapd/tools/ldclt/parser.c | 19 ldap/servers/slapd/tools/ldclt/scalab01.c | 190 ldap/servers/slapd/tools/ldclt/threadMain.c | 6 ldap/servers/slapd/tools/ldif.c | 4 ldap/servers/slapd/tools/mmldif.c | 9 ldap/servers/slapd/tools/pwenc.c | 2 ldap/servers/slapd/tools/rsearch/addthread.c | 25 ldap/servers/slapd/tools/rsearch/sdattable.c | 4 ldap/servers/slapd/tools/rsearch/searchthread.c | 62 ldap/servers/slapd/uniqueid.c | 99 ldap/servers/slapd/utf8compare.c | 6 ldap/servers/slapd/util.c | 360 ldap/servers/slapd/uuid.c | 22 ldap/servers/slapd/value.c | 52 ldap/servers/slapd/valueset.c | 75 ldap/servers/slapd/vattr.c | 109 ldap/servers/snmp/NETWORK-SERVICES-MIB.txt | 650 ldap/servers/snmp/RFC-1215.txt | 38 ldap/servers/snmp/RFC1155-SMI.txt | 119 ldap/servers/snmp/SNMPv2-CONF.txt | 322 ldap/servers/snmp/SNMPv2-SMI.txt | 344 ldap/servers/snmp/SNMPv2-TC.txt | 772 ldap/servers/snmp/ldap-agent.c | 26 ldap/servers/snmp/main.c | 11 ldap/servers/snmp/netscape-ldap.mib | 759 ldap/systools/idsktune.c | 71 lib/base/crit.cpp | 6 lib/base/ereport.cpp | 2 lib/base/file.cpp | 24 lib/base/lexer.cpp | 1015 lib/base/plist.cpp | 3 lib/base/rwlock.cpp | 168 lib/base/util.cpp | 13 lib/ldaputil/cert.c | 4 lib/ldaputil/certmap.c | 409 lib/ldaputil/dbconf.c | 1 lib/ldaputil/utest/Makefile | 149 lib/ldaputil/utest/auth.cpp | 611 lib/ldaputil/utest/authtest | 138 lib/ldaputil/utest/certmap.conf | 68 lib/ldaputil/utest/dblist.conf | 47 lib/ldaputil/utest/example.c | 153 lib/ldaputil/utest/plugin.c | 152 lib/ldaputil/utest/plugin.h | 57 lib/ldaputil/utest/stubs.c | 144 lib/ldaputil/utest/stubs.cpp | 139 lib/ldaputil/utest/test.ref | 480 lib/ldaputil/vtable.c | 2 lib/libaccess/acl.tab.cpp | 25 lib/libaccess/aclcache.cpp | 105 lib/libaccess/aclflush.cpp | 1 lib/libaccess/aclpriv.h | 1 lib/libaccess/acltext.y | 4 lib/libaccess/acltools.cpp | 1896 lib/libaccess/aclutil.cpp | 13 lib/libaccess/authdb.cpp | 112 lib/libaccess/lasdns.cpp | 23 lib/libaccess/lasgroup.cpp | 10 lib/libaccess/lasip.cpp | 20 lib/libaccess/nseframe.cpp | 1 lib/libaccess/oneeval.cpp | 19 lib/libaccess/permhash.h | 11 lib/libaccess/register.cpp | 50 lib/libaccess/usrcache.cpp | 14 lib/libaccess/utest/.purify | 19 lib/libaccess/utest/Makefile | 147 lib/libaccess/utest/acl.dat | 44 lib/libaccess/utest/aclfile0 | 87 lib/libaccess/utest/aclfile1 | 43 lib/libaccess/utest/aclfile10 | 45 lib/libaccess/utest/aclfile11 | 43 lib/libaccess/utest/aclfile12 | 43 lib/libaccess/utest/aclfile13 | 43 lib/libaccess/utest/aclfile14 | 43 lib/libaccess/utest/aclfile15 | 43 lib/libaccess/utest/aclfile16 | 43 lib/libaccess/utest/aclfile17 | 43 lib/libaccess/utest/aclfile18 | 51 lib/libaccess/utest/aclfile19 | 46 lib/libaccess/utest/aclfile2 | 43 lib/libaccess/utest/aclfile3 | 43 lib/libaccess/utest/aclfile4 | 43 lib/libaccess/utest/aclfile5 | 43 lib/libaccess/utest/aclfile6 | 55 lib/libaccess/utest/aclfile7 | 43 lib/libaccess/utest/aclfile8 | 43 lib/libaccess/utest/aclfile9 | 43 lib/libaccess/utest/aclgrp0 | 42 lib/libaccess/utest/aclgrp1 | 42 lib/libaccess/utest/aclgrp2 | 42 lib/libaccess/utest/aclgrp3 | 42 lib/libaccess/utest/aclgrp4 | 42 lib/libaccess/utest/acltest.cpp | 794 lib/libaccess/utest/onetest.cpp | 77 lib/libaccess/utest/shexp.cpp | 331 lib/libaccess/utest/shexp.h | 168 lib/libaccess/utest/test.ref | 217 lib/libaccess/utest/testmain.cpp | 89 lib/libaccess/utest/twotest.cpp | 87 lib/libaccess/utest/ustubs.cpp | 331 lib/libadmin/error.c | 2 lib/libadmin/template.c | 2 lib/libadmin/util.c | 48 lib/libsi18n/coreres.c | 141 lib/libsi18n/coreres.h | 52 lib/libsi18n/getlang.c | 330 lib/libsi18n/getstrmem.c | 160 lib/libsi18n/getstrmem.h | 1 lib/libsi18n/getstrprop.c | 85 lib/libsi18n/makstrdb.c | 21 lib/libsi18n/propset.c | 442 lib/libsi18n/propset.h | 80 lib/libsi18n/reshash.c | 21 ltmain.sh |13199 ++- m4/db.m4 | 21 m4/fhs.m4 | 4 m4/icu.m4 | 25 m4/kerberos.m4 | 4 m4/mozldap.m4 | 38 m4/netsnmp.m4 | 15 m4/nspr.m4 | 17 m4/nss.m4 | 17 m4/openldap.m4 | 30 m4/pcre.m4 | 28 m4/sasl.m4 | 25 m4/selinux.m4 | 13 m4/svrcore.m4 | 41 man/man1/cl-dump.1 | 18 man/man1/dbgen.pl.1 | 4 man/man1/infadd.1 | 8 man/man1/migratecred.1 | 6 man/man1/mmldif.1 | 4 man/man1/pwdhash.1 | 4 man/man1/repl-monitor.1 | 16 man/man8/ns-slapd.8 | 10 man/man8/remove-ds.pl.8 | 6 man/man8/restart-dirsrv.8 | 50 man/man8/setup-ds.pl.8 | 4 man/man8/start-dirsrv.8 | 50 man/man8/stop-dirsrv.8 | 50 missing | 104 selinux/dirsrv.fc.in | 2 selinux/dirsrv.if | 41 selinux/dirsrv.te | 11 wrappers/cl-dump.in | 11 wrappers/dbscan.in | 10 wrappers/infadd.in | 12 wrappers/initscript.in | 244 wrappers/ldap-agent-initscript.in | 20 wrappers/ldap-agent.in | 12 wrappers/ldclt.in | 12 wrappers/ldif.in | 12 wrappers/migratecred.in | 14 wrappers/mmldif.in | 14 wrappers/pwdhash.in | 14 wrappers/repl-monitor.in | 11 wrappers/rsearch.in | 12 wrappers/systemd-snmp.service.in | 16 wrappers/systemd.group.in | 6 wrappers/systemd.template.service.in | 28 wrappers/systemd.template.sysconfig | 3 615 files changed, 79403 insertions(+), 67856 deletions(-) ---

1 0

Changes to '389-ds-base-1.2.10'
by Richard Allen Megginson 13 Feb '12

13 Feb '12

New branch '389-ds-base-1.2.10' available with the following commits: commit dc731e2fe79e4c616ee5d52b47c3d43bcf76f4d0 Author: Rich Megginson <rmeggins(a)redhat.com> Date: Wed Feb 8 11:12:11 2012 -0700 bump version to 1.2.10.0 commit ea9834b988ef8d95a66ae44a277dd4ea571cd724 Author: Nathan Kinder <nkinder(a)redhat.com> Date: Wed Feb 8 09:38:26 2012 -0800 Ticket 284 - Remove unnecessary SNMP MIB files We currently carry around some standard MIB files in our soruce tree and install them as well. Aside from our DS specific MIB file, these are all included as a part of the Net-SNMP distribution. We should not be carrying these files around as well. This patch removes the standard MIB files from our tree and updates the Makefile to avoid installing them. (cherry picked from commit ee320163c6b7913ddae41cb8954b237d1b99eadf)

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

389-commits February 2012