ldap/servers
by Noriko Hosoi
ldap/servers/slapd/tools/ldclt/ldapfct.c | 11 -----------
1 file changed, 11 deletions(-)
New commits:
commit 685607f63d52d54e8bd094bb0694986484a91e34
Author: Noriko Hosoi <nhosoi(a)redhat.com>
Date: Tue Sep 23 15:22:11 2014 -0700
Ticket #47907 - ldclt: assertion failure with -e "add,counteach" -e "object=<ldif file>,rdn=uid:test[A=INCRNNOLOOP(0;24
Bug Description: In case createMissingNodes is called from doAddEntry,
LDAP handle is unbound which makes the following operation such as
ldap_add fail since the handle is already released.
Fix Description: Rempoving ldap_unbind_ext from createMissingNodes.
Reviewed by rmeggins(a)redhat.com (Thank you, Rich!!)
https://fedorahosted.org/389/ticket/47907
diff --git a/ldap/servers/slapd/tools/ldclt/ldapfct.c b/ldap/servers/slapd/tools/ldclt/ldapfct.c
index 235e20c..26867a6 100644
--- a/ldap/servers/slapd/tools/ldclt/ldapfct.c
+++ b/ldap/servers/slapd/tools/ldclt/ldapfct.c
@@ -2308,17 +2308,6 @@ createMissingNodes (
if (freeAttrib (attrs) < 0)
return (-1);
- ret = ldap_unbind_ext (cnx, NULL, NULL);
- if (ret != LDAP_SUCCESS)
- {
- fprintf (stderr, "ldclt[%d]: T%03d: cannot ldap_unbind(), error=%d (%s)\n",
- mctx.pid, tttctx->thrdNum, ret, strerror (ret));
- fflush (stderr);
- if (addErrorStat (ret) < 0)
- return (-1);
- return (-1);
- }
-
/*
* Ouf ! End of this function.
*/
9 years, 7 months
- 1
- 0
Branch '389-ds-base-1.3.3' - ldap/servers
by Noriko Hosoi
ldap/servers/slapd/back-ldbm/back-ldbm.h | 1 -
ldap/servers/slapd/back-ldbm/cache.c | 10 ++++++----
2 files changed, 6 insertions(+), 5 deletions(-)
New commits:
commit ef766784ed7d09aa81e82316b621e8490a368dc6
Author: Noriko Hosoi <nhosoi(a)redhat.com>
Date: Mon Sep 22 14:34:58 2014 -0700
Ticket #47750 - Creating a glue fails if one above level is a conflict or missing
Description: Poring changes made to 1.2.11 branch to newer versions.
1) Enabiling cache lock in cache_is_in_cache and cache_has_otherref.
2) Removing unused field new_entry_in_cache from "struct _modify_context".
(cherry picked from commit 5ae13072330e9a769a5949b2e8a91085b38ac4e1)
diff --git a/ldap/servers/slapd/back-ldbm/back-ldbm.h b/ldap/servers/slapd/back-ldbm/back-ldbm.h
index 938d261..fd17453 100644
--- a/ldap/servers/slapd/back-ldbm/back-ldbm.h
+++ b/ldap/servers/slapd/back-ldbm/back-ldbm.h
@@ -705,7 +705,6 @@ typedef struct _import_subcount_stuff import_subcount_stuff;
/* Handy structures for modify operations */
struct _modify_context {
- int new_entry_in_cache;
struct backentry *old_entry;
struct backentry *new_entry;
Slapi_Mods *smods;
diff --git a/ldap/servers/slapd/back-ldbm/cache.c b/ldap/servers/slapd/back-ldbm/cache.c
index a98cf0c..4746204 100644
--- a/ldap/servers/slapd/back-ldbm/cache.c
+++ b/ldap/servers/slapd/back-ldbm/cache.c
@@ -1506,10 +1506,12 @@ int cache_add_tentative(struct cache *cache, struct backentry *e,
{
return entrycache_add_int(cache, e, ENTRY_STATE_CREATING, alt);
}
+
void cache_lock(struct cache *cache)
{
PR_EnterMonitor(cache->c_mutex);
}
+
void cache_unlock(struct cache *cache)
{
PR_ExitMonitor(cache->c_mutex);
@@ -2095,9 +2097,9 @@ cache_has_otherref(struct cache *cache, void *ptr)
return hasref;
}
bep = (struct backcommon *)ptr;
- /* slows down too much? PR_Lock(cache->c_mutex); */
+ cache_lock(cache);
hasref = bep->ep_refcnt;
- /* PR_Unlock(cache->c_mutex); */
+ cache_unlock(cache);
return (hasref>1)?1:0;
}
@@ -2111,8 +2113,8 @@ cache_is_in_cache(struct cache *cache, void *ptr)
return in_cache;
}
bep = (struct backcommon *)ptr;
- /* slows down too much? PR_Lock(cache->c_mutex); */
+ cache_lock(cache);
in_cache = (bep->ep_state & (ENTRY_STATE_DELETED|ENTRY_STATE_NOTINCACHE))?0:1;
- /* PR_Unlock(cache->c_mutex); */
+ cache_unlock(cache);
return in_cache;
}
9 years, 7 months
- 1
- 0
ldap/servers
by Noriko Hosoi
ldap/servers/slapd/back-ldbm/back-ldbm.h | 1 -
ldap/servers/slapd/back-ldbm/cache.c | 10 ++++++----
2 files changed, 6 insertions(+), 5 deletions(-)
New commits:
commit 5ae13072330e9a769a5949b2e8a91085b38ac4e1
Author: Noriko Hosoi <nhosoi(a)redhat.com>
Date: Mon Sep 22 14:34:58 2014 -0700
Ticket #47750 - Creating a glue fails if one above level is a conflict or missing
Description: Poring changes made to 1.2.11 branch to newer versions.
1) Enabiling cache lock in cache_is_in_cache and cache_has_otherref.
2) Removing unused field new_entry_in_cache from "struct _modify_context".
diff --git a/ldap/servers/slapd/back-ldbm/back-ldbm.h b/ldap/servers/slapd/back-ldbm/back-ldbm.h
index 938d261..fd17453 100644
--- a/ldap/servers/slapd/back-ldbm/back-ldbm.h
+++ b/ldap/servers/slapd/back-ldbm/back-ldbm.h
@@ -705,7 +705,6 @@ typedef struct _import_subcount_stuff import_subcount_stuff;
/* Handy structures for modify operations */
struct _modify_context {
- int new_entry_in_cache;
struct backentry *old_entry;
struct backentry *new_entry;
Slapi_Mods *smods;
diff --git a/ldap/servers/slapd/back-ldbm/cache.c b/ldap/servers/slapd/back-ldbm/cache.c
index a98cf0c..4746204 100644
--- a/ldap/servers/slapd/back-ldbm/cache.c
+++ b/ldap/servers/slapd/back-ldbm/cache.c
@@ -1506,10 +1506,12 @@ int cache_add_tentative(struct cache *cache, struct backentry *e,
{
return entrycache_add_int(cache, e, ENTRY_STATE_CREATING, alt);
}
+
void cache_lock(struct cache *cache)
{
PR_EnterMonitor(cache->c_mutex);
}
+
void cache_unlock(struct cache *cache)
{
PR_ExitMonitor(cache->c_mutex);
@@ -2095,9 +2097,9 @@ cache_has_otherref(struct cache *cache, void *ptr)
return hasref;
}
bep = (struct backcommon *)ptr;
- /* slows down too much? PR_Lock(cache->c_mutex); */
+ cache_lock(cache);
hasref = bep->ep_refcnt;
- /* PR_Unlock(cache->c_mutex); */
+ cache_unlock(cache);
return (hasref>1)?1:0;
}
@@ -2111,8 +2113,8 @@ cache_is_in_cache(struct cache *cache, void *ptr)
return in_cache;
}
bep = (struct backcommon *)ptr;
- /* slows down too much? PR_Lock(cache->c_mutex); */
+ cache_lock(cache);
in_cache = (bep->ep_state & (ENTRY_STATE_DELETED|ENTRY_STATE_NOTINCACHE))?0:1;
- /* PR_Unlock(cache->c_mutex); */
+ cache_unlock(cache);
return in_cache;
}
9 years, 7 months
- 1
- 0
Branch '389-ds-base-1.2.11' - 2 commits - ldap/servers
by Noriko Hosoi
ldap/servers/slapd/back-ldbm/back-ldbm.h | 3
ldap/servers/slapd/back-ldbm/cache.c | 183 +++++++++++++++----------
ldap/servers/slapd/back-ldbm/ldbm_add.c | 134 +++++++++---------
ldap/servers/slapd/back-ldbm/ldbm_delete.c | 112 +++++----------
ldap/servers/slapd/back-ldbm/ldbm_modify.c | 84 +++++------
ldap/servers/slapd/back-ldbm/ldbm_modrdn.c | 147 +++++++-------------
ldap/servers/slapd/back-ldbm/proto-back-ldbm.h | 2
7 files changed, 328 insertions(+), 337 deletions(-)
New commits:
commit 189eb8a0b6cf876e6bc39d0cb8cb4c08b29c9ce1
Author: Noriko Hosoi <nhosoi(a)redhat.com>
Date: Mon Sep 22 14:19:35 2014 -0700
Ticket 47750 - Entry cache part 2
Description: One line fix in the previous patch.
entrycache_add_int is supposed to return 1 instead of -1 for the
"entry already exists in cache" case.
diff --git a/ldap/servers/slapd/back-ldbm/cache.c b/ldap/servers/slapd/back-ldbm/cache.c
index 202386e..13064d0 100644
--- a/ldap/servers/slapd/back-ldbm/cache.c
+++ b/ldap/servers/slapd/back-ldbm/cache.c
@@ -1352,7 +1352,7 @@ entrycache_add_int(struct cache *cache, struct backentry *e, int state,
LOG("the entry %s already exists. returning existing entry %s (state: 0x%x)\n",
ndn, backentry_get_ndn(my_alt), state);
cache_unlock(cache);
- return -1;
+ return 1;
} else {
LOG("the entry %s already exists. Not returning existing entry %s (state: 0x%x)\n",
ndn, backentry_get_ndn(my_alt), state);
commit 2c16d7d536481687b39f0d72c235aa8b7e7ef2d6
Author: Mark Reynolds <mreynolds(a)redhat.com>
Date: Thu Sep 18 10:52:07 2014 -0400
Ticket 47750 - Entry cache part 2
Description: replacing PRLock for cache->c_mutex with PRMonitor.
Introducing cache_is_in_cache and replacing in_cache local variables
(e.g., e_in_cache) with the function call.
diff --git a/ldap/servers/slapd/back-ldbm/back-ldbm.h b/ldap/servers/slapd/back-ldbm/back-ldbm.h
index d27a664..ec0e2dc 100644
--- a/ldap/servers/slapd/back-ldbm/back-ldbm.h
+++ b/ldap/servers/slapd/back-ldbm/back-ldbm.h
@@ -402,7 +402,7 @@ struct cache {
Slapi_Counter *c_tries;
struct backcommon *c_lruhead; /* add entries here */
struct backcommon *c_lrutail; /* remove entries here */
- PRLock *c_mutex; /* lock for cache operations */
+ PRMonitor *c_mutex; /* lock for cache operations */
PRLock *c_emutexalloc_mutex;
};
@@ -694,7 +694,6 @@ typedef struct _import_subcount_stuff import_subcount_stuff;
/* Handy structures for modify operations */
struct _modify_context {
- int new_entry_in_cache;
struct backentry *old_entry;
struct backentry *new_entry;
Slapi_Mods *smods;
diff --git a/ldap/servers/slapd/back-ldbm/cache.c b/ldap/servers/slapd/back-ldbm/cache.c
index 5510a9a..202386e 100644
--- a/ldap/servers/slapd/back-ldbm/cache.c
+++ b/ldap/servers/slapd/back-ldbm/cache.c
@@ -543,8 +543,8 @@ int cache_init(struct cache *cache, size_t maxsize, long maxentries, int type)
cache->c_lruhead = cache->c_lrutail = NULL;
cache_make_hashes(cache, type);
- if (((cache->c_mutex = PR_NewLock()) == NULL) ||
- ((cache->c_emutexalloc_mutex = PR_NewLock()) == NULL)) {
+ if (((cache->c_mutex = PR_NewMonitor()) == NULL) ||
+ ((cache->c_emutexalloc_mutex = PR_NewLock()) == NULL)) {
LDAPDebug(LDAP_DEBUG_ANY, "ldbm: cache_init: PR_NewLock failed\n",
0, 0, 0);
return 0;
@@ -633,13 +633,13 @@ static void entrycache_clear_int(struct cache *cache)
void cache_clear(struct cache *cache, int type)
{
- PR_Lock(cache->c_mutex);
+ cache_lock(cache);
if (CACHE_TYPE_ENTRY == type) {
entrycache_clear_int(cache);
} else if (CACHE_TYPE_DN == type) {
dncache_clear_int(cache);
}
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
}
static void erase_cache(struct cache *cache, int type)
@@ -663,7 +663,7 @@ void cache_destroy_please(struct cache *cache, int type)
slapi_counter_destroy(&cache->c_cursize);
slapi_counter_destroy(&cache->c_hits);
slapi_counter_destroy(&cache->c_tries);
- PR_DestroyLock(cache->c_mutex);
+ PR_DestroyMonitor(cache->c_mutex);
PR_DestroyLock(cache->c_emutexalloc_mutex);
}
@@ -687,7 +687,7 @@ static void entrycache_set_max_size(struct cache *cache, size_t bytes)
"WARNING -- Minimum cache size is %lu -- rounding up\n",
MINCACHESIZE, 0, 0);
}
- PR_Lock(cache->c_mutex);
+ cache_lock(cache);
cache->c_maxsize = bytes;
LOG("entry cache size set to %lu\n", bytes, 0, 0);
/* check for full cache, and clear out if necessary */
@@ -706,7 +706,7 @@ static void entrycache_set_max_size(struct cache *cache, size_t bytes)
erase_cache(cache, CACHE_TYPE_ENTRY);
cache_make_hashes(cache, CACHE_TYPE_ENTRY);
}
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
if (! dblayer_is_cachesize_sane(&bytes)) {
LDAPDebug(LDAP_DEBUG_ANY,
"WARNING -- Possible CONFIGURATION ERROR -- cachesize "
@@ -724,7 +724,7 @@ void cache_set_max_entries(struct cache *cache, long entries)
* was given in # entries instead of memory footprint. hopefully,
* we can eventually drop this.
*/
- PR_Lock(cache->c_mutex);
+ cache_lock(cache);
cache->c_maxentries = entries;
if (entries >= 0) {
LOG("entry cache entry-limit set to %lu\n", entries, 0, 0);
@@ -735,7 +735,7 @@ void cache_set_max_entries(struct cache *cache, long entries)
/* check for full cache, and clear out if necessary */
if (CACHE_FULL(cache))
eflush = entrycache_flush(cache);
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
while (eflush)
{
eflushtemp = BACK_LRU_NEXT(eflush, struct backentry *);
@@ -748,9 +748,9 @@ size_t cache_get_max_size(struct cache *cache)
{
size_t n = 0;
- PR_Lock(cache->c_mutex);
+ cache_lock(cache);
n = cache->c_maxsize;
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
return n;
}
@@ -758,9 +758,9 @@ long cache_get_max_entries(struct cache *cache)
{
long n;
- PR_Lock(cache->c_mutex);
+ cache_lock(cache);
n = cache->c_maxentries;
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
return n;
}
@@ -786,14 +786,14 @@ void cache_get_stats(struct cache *cache, PRUint64 *hits, PRUint64 *tries,
long *nentries, long *maxentries,
size_t *size, size_t *maxsize)
{
- PR_Lock(cache->c_mutex);
+ cache_lock(cache);
if (hits) *hits = slapi_counter_get_value(cache->c_hits);
if (tries) *tries = slapi_counter_get_value(cache->c_tries);
if (nentries) *nentries = cache->c_curentries;
if (maxentries) *maxentries = cache->c_maxentries;
if (size) *size = slapi_counter_get_value(cache->c_cursize);
if (maxsize) *maxsize = cache->c_maxsize;
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
}
void cache_debug_hash(struct cache *cache, char **out)
@@ -804,7 +804,7 @@ void cache_debug_hash(struct cache *cache, char **out)
Hashtable *ht = NULL;
char *name = "unknown";
- PR_Lock(cache->c_mutex);
+ cache_lock(cache);
*out = (char *)slapi_ch_malloc(1024);
**out = 0;
@@ -840,7 +840,7 @@ void cache_debug_hash(struct cache *cache, char **out)
sprintf(*out + strlen(*out), "%d[%d] ", j, slot_stats[j]);
slapi_ch_free((void **)&slot_stats);
}
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
}
@@ -946,14 +946,14 @@ int cache_remove(struct cache *cache, void *ptr)
}
e = (struct backcommon *)ptr;
- PR_Lock(cache->c_mutex);
+ cache_lock(cache);
if (CACHE_TYPE_ENTRY == e->ep_type) {
ASSERT(e->ep_refcnt > 0);
ret = entrycache_remove_int(cache, (struct backentry *)e);
} else if (CACHE_TYPE_DN == e->ep_type) {
ret = dncache_remove_int(cache, (struct backdn *)e);
}
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
return ret;
}
@@ -1011,7 +1011,7 @@ static int entrycache_replace(struct cache *cache, struct backentry *olde,
newuuid = slapi_entry_get_uniqueid(newe->ep_entry);
#endif
newndn = slapi_sdn_get_ndn(backentry_get_sdn(newe));
- PR_Lock(cache->c_mutex);
+ cache_lock(cache);
/*
* First, remove the old entry from all the hashtables.
@@ -1031,7 +1031,7 @@ static int entrycache_replace(struct cache *cache, struct backentry *olde,
}
/* If fails, we have to make sure the both entires are removed from the cache,
* otherwise, we have no idea what's left in the cache or not... */
- if (!entry_same_dn(newe, (void *)oldndn) && (newe->ep_state & ENTRY_STATE_NOTINCACHE) == 0) {
+ if (cache_is_in_cache(cache, newe)) {
/* if we're doing a modrdn or turning an entry to a tombstone,
* the new entry can be in the dn table already, so we need to remove that too.
*/
@@ -1039,6 +1039,7 @@ static int entrycache_replace(struct cache *cache, struct backentry *olde,
{
slapi_counter_subtract(cache->c_cursize, newe->ep_size);
cache->c_curentries--;
+ newe->ep_refcnt--;
LOG("entry cache replace remove entry size %lu\n", newe->ep_size, 0, 0);
}
}
@@ -1061,7 +1062,7 @@ static int entrycache_replace(struct cache *cache, struct backentry *olde,
LOG("entry cache replace (%s): cache index tables out of sync - found dn [%d] id [%d]\n",
oldndn, found_in_dn, found_in_id);
#endif
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
return 1;
}
}
@@ -1072,7 +1073,7 @@ static int entrycache_replace(struct cache *cache, struct backentry *olde,
if (!add_hash(cache->c_dntable, (void *)newndn, strlen(newndn), newe, (void **)&alte)) {
LOG("entry cache replace (%s): can't add to dn table (returned %s)\n",
newndn, alte?slapi_entry_get_dn(alte->ep_entry):"none", 0);
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
return 1;
}
if (!add_hash(cache->c_idtable, &(newe->ep_id), sizeof(ID), newe, (void **)&alte)) {
@@ -1081,7 +1082,7 @@ static int entrycache_replace(struct cache *cache, struct backentry *olde,
if(remove_hash(cache->c_dntable, (void *)newndn, strlen(newndn)) == 0){
LOG("entry cache replace: failed to remove dn table\n", 0, 0, 0);
}
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
return 1;
}
#ifdef UUIDCACHE_ON
@@ -1094,7 +1095,7 @@ static int entrycache_replace(struct cache *cache, struct backentry *olde,
if(remove_hash(cache->c_idtable, &(newe->ep_id), sizeof(ID)) == 0){
LOG("entry cache replace: failed to remove id table(uuid cache)\n", 0, 0, 0);
}
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
return 1;
}
#endif
@@ -1107,7 +1108,7 @@ static int entrycache_replace(struct cache *cache, struct backentry *olde,
slapi_counter_subtract(cache->c_cursize, olde->ep_size - newe->ep_size);
}
newe->ep_state = 0;
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
LOG("<= entrycache_replace OK, cache size now %lu cache count now %ld\n",
slapi_counter_get_value(cache->c_cursize), cache->c_curentries, 0);
return 0;
@@ -1144,7 +1145,7 @@ entrycache_return(struct cache *cache, struct backentry **bep)
LOG("=> entrycache_return (%s) entry count: %d, entry in cache:%ld\n",
backentry_get_ndn(e), e->ep_refcnt, cache->c_curentries);
- PR_Lock(cache->c_mutex);
+ cache_lock(cache);
if (e->ep_state & ENTRY_STATE_NOTINCACHE)
{
backentry_free(bep);
@@ -1163,7 +1164,7 @@ entrycache_return(struct cache *cache, struct backentry **bep)
}
}
}
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
while (eflush)
{
eflushtemp = BACK_LRU_NEXT(eflush, struct backentry *);
@@ -1182,22 +1183,22 @@ struct backentry *cache_find_dn(struct cache *cache, const char *dn, unsigned lo
LOG("=> cache_find_dn (%s)\n", dn, 0, 0);
/*entry normalized by caller (dn2entry.c) */
- PR_Lock(cache->c_mutex);
+ cache_lock(cache);
if (find_hash(cache->c_dntable, (void *)dn, ndnlen, (void **)&e)) {
/* need to check entry state */
if (e->ep_state != 0) {
/* entry is deleted or not fully created yet */
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
LOG("<= cache_find_dn (NOT FOUND)\n", 0, 0, 0);
return NULL;
}
if (e->ep_refcnt == 0)
lru_delete(cache, (void *)e);
e->ep_refcnt++;
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
slapi_counter_increment(cache->c_hits);
} else {
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
}
slapi_counter_increment(cache->c_tries);
@@ -1213,22 +1214,22 @@ struct backentry *cache_find_id(struct cache *cache, ID id)
LOG("=> cache_find_id (%lu)\n", (u_long)id, 0, 0);
- PR_Lock(cache->c_mutex);
+ cache_lock(cache);
if (find_hash(cache->c_idtable, &id, sizeof(ID), (void **)&e)) {
/* need to check entry state */
if (e->ep_state != 0) {
/* entry is deleted or not fully created yet */
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
LOG("<= cache_find_id (NOT FOUND)\n", 0, 0, 0);
return NULL;
}
if (e->ep_refcnt == 0)
lru_delete(cache, (void *)e);
e->ep_refcnt++;
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
slapi_counter_increment(cache->c_hits);
} else {
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
}
slapi_counter_increment(cache->c_tries);
@@ -1244,22 +1245,22 @@ struct backentry *cache_find_uuid(struct cache *cache, const char *uuid)
LOG("=> cache_find_uuid (%s)\n", uuid, 0, 0);
- PR_Lock(cache->c_mutex);
+ cache_lock(cache);
if (find_hash(cache->c_uuidtable, uuid, strlen(uuid), (void **)&e)) {
/* need to check entry state */
if (e->ep_state != 0) {
/* entry is deleted or not fully created yet */
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
LOG("<= cache_find_uuid (NOT FOUND)\n", 0, 0, 0);
return NULL;
}
if (e->ep_refcnt == 0)
lru_delete(cache, (void *)e);
e->ep_refcnt++;
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
slapi_counter_increment(cache->c_hits);
} else {
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
}
slapi_counter_increment(cache->c_tries);
@@ -1285,7 +1286,7 @@ entrycache_add_int(struct cache *cache, struct backentry *e, int state,
LOG("=> entrycache_add_int( \"%s\", %ld )\n", backentry_get_ndn(e),
e->ep_id, 0);
- PR_Lock(cache->c_mutex);
+ cache_lock(cache);
if (! add_hash(cache->c_dntable, (void *)ndn, strlen(ndn), e,
(void **)&my_alt)) {
LOG("entry \"%s\" already in dn cache\n", ndn, 0, 0);
@@ -1320,7 +1321,7 @@ entrycache_add_int(struct cache *cache, struct backentry *e, int state,
* to prevent that the caller accidentally thinks the existing
* entry is not the same one the caller has and releases it.
*/
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
return 1;
}
}
@@ -1330,7 +1331,7 @@ entrycache_add_int(struct cache *cache, struct backentry *e, int state,
{
LOG("the entry %s is reserved (ep_state: 0x%x, state: 0x%x\n", ndn, e->ep_state, state);
e->ep_state |= ENTRY_STATE_NOTINCACHE;
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
return -1;
}
else if (state != 0)
@@ -1338,7 +1339,7 @@ entrycache_add_int(struct cache *cache, struct backentry *e, int state,
LOG("the entry %s already exists. cannot reserve it. (ep_state: 0x%x, state: 0x%x\n",
ndn, e->ep_state, state);
e->ep_state |= ENTRY_STATE_NOTINCACHE;
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
return -1;
}
else
@@ -1350,12 +1351,14 @@ entrycache_add_int(struct cache *cache, struct backentry *e, int state,
(*alt)->ep_refcnt++;
LOG("the entry %s already exists. returning existing entry %s (state: 0x%x)\n",
ndn, backentry_get_ndn(my_alt), state);
+ cache_unlock(cache);
+ return -1;
} else {
LOG("the entry %s already exists. Not returning existing entry %s (state: 0x%x)\n",
ndn, backentry_get_ndn(my_alt), state);
+ cache_unlock(cache);
+ return -1;
}
- PR_Unlock(cache->c_mutex);
- return 1;
}
}
}
@@ -1385,14 +1388,14 @@ entrycache_add_int(struct cache *cache, struct backentry *e, int state,
* fine (i think).
*/
LOG("<= entrycache_add_int (ignoring)\n", 0, 0, 0);
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
return 0;
}
if(remove_hash(cache->c_dntable, (void *)ndn, strlen(ndn)) == 0){
LOG("entrycache_add_int: failed to remove %s from dn table\n", 0, 0, 0);
}
e->ep_state |= ENTRY_STATE_NOTINCACHE;
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
LOG("entrycache_add_int: failed to add %s to cache (ep_state: %x, already_in: %d)\n",
ndn, e->ep_state, already_in);
return -1;
@@ -1411,7 +1414,7 @@ entrycache_add_int(struct cache *cache, struct backentry *e, int state,
LOG("entrycache_add_int: failed to remove id table(uuid cache)\n", 0, 0, 0);
}
e->ep_state |= ENTRY_STATE_NOTINCACHE;
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
return -1;
}
}
@@ -1437,7 +1440,7 @@ entrycache_add_int(struct cache *cache, struct backentry *e, int state,
if (CACHE_FULL(cache))
eflush = entrycache_flush(cache);
}
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
while (eflush)
{
@@ -1489,11 +1492,11 @@ int cache_add_tentative(struct cache *cache, struct backentry *e,
}
void cache_lock(struct cache *cache)
{
- PR_Lock(cache->c_mutex);
+ PR_EnterMonitor(cache->c_mutex);
}
void cache_unlock(struct cache *cache)
{
- PR_Unlock(cache->c_mutex);
+ PR_ExitMonitor(cache->c_mutex);
}
/* locks an entry so that it can be modified (you should have gotten the
@@ -1527,14 +1530,14 @@ int cache_lock_entry(struct cache *cache, struct backentry *e)
PR_EnterMonitor(e->ep_mutexp);
/* make sure entry hasn't been deleted now */
- PR_Lock(cache->c_mutex);
+ cache_lock(cache);
if (e->ep_state & (ENTRY_STATE_DELETED|ENTRY_STATE_NOTINCACHE)) {
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
PR_ExitMonitor(e->ep_mutexp);
LOG("<= cache_lock_entry (DELETED)\n", 0, 0, 0);
return RETRY_CACHE_LOCK;
}
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
LOG("<= cache_lock_entry (FOUND)\n", 0, 0, 0);
return 0;
@@ -1600,7 +1603,7 @@ dncache_set_max_size(struct cache *cache, size_t bytes)
"WARNING -- Minimum cache size is %lu -- rounding up\n",
MINCACHESIZE, 0, 0);
}
- PR_Lock(cache->c_mutex);
+ cache_lock(cache);
cache->c_maxsize = bytes;
LOG("entry cache size set to %lu\n", bytes, 0, 0);
/* check for full cache, and clear out if necessary */
@@ -1620,7 +1623,7 @@ dncache_set_max_size(struct cache *cache, size_t bytes)
erase_cache(cache, CACHE_TYPE_DN);
cache_make_hashes(cache, CACHE_TYPE_DN);
}
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
if (! dblayer_is_cachesize_sane(&bytes)) {
LDAPDebug1Arg(LDAP_DEBUG_ANY,
"WARNING -- Possible CONFIGURATION ERROR -- cachesize "
@@ -1684,7 +1687,7 @@ dncache_return(struct cache *cache, struct backdn **bdn)
LOG("=> dncache_return (%s) reference count: %d, dn in cache:%ld\n",
slapi_sdn_get_dn((*bdn)->dn_sdn), (*bdn)->ep_refcnt, cache->c_curentries);
- PR_Lock(cache->c_mutex);
+ cache_lock(cache);
if ((*bdn)->ep_state & ENTRY_STATE_NOTINCACHE)
{
backdn_free(bdn);
@@ -1704,7 +1707,7 @@ dncache_return(struct cache *cache, struct backdn **bdn)
}
}
}
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
while (dnflush)
{
dnflushtemp = BACK_LRU_NEXT(dnflush, struct backdn *);
@@ -1725,22 +1728,22 @@ dncache_find_id(struct cache *cache, ID id)
LOG("=> dncache_find_id (%lu)\n", (u_long)id, 0, 0);
- PR_Lock(cache->c_mutex);
+ cache_lock(cache);
if (find_hash(cache->c_idtable, &id, sizeof(ID), (void **)&bdn)) {
/* need to check entry state */
if (bdn->ep_state != 0) {
/* entry is deleted or not fully created yet */
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
LOG("<= dncache_find_id (NOT FOUND)\n", 0, 0, 0);
return NULL;
}
if (bdn->ep_refcnt == 0)
lru_delete(cache, (void *)bdn);
bdn->ep_refcnt++;
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
slapi_counter_increment(cache->c_hits);
} else {
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
}
slapi_counter_increment(cache->c_tries);
@@ -1765,7 +1768,7 @@ dncache_add_int(struct cache *cache, struct backdn *bdn, int state,
LOG("=> dncache_add_int( \"%s\", %ld )\n", slapi_sdn_get_dn(bdn->dn_sdn),
bdn->ep_id, 0);
- PR_Lock(cache->c_mutex);
+ cache_lock(cache);
if (! add_hash(cache->c_idtable, &(bdn->ep_id), sizeof(ID), bdn,
(void **)&my_alt)) {
@@ -1800,7 +1803,7 @@ dncache_add_int(struct cache *cache, struct backdn *bdn, int state,
* to prevent that the caller accidentally thinks the existing
* entry is not the same one the caller has and releases it.
*/
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
return 1;
}
}
@@ -1810,14 +1813,14 @@ dncache_add_int(struct cache *cache, struct backdn *bdn, int state,
{
LOG("the entry is reserved\n", 0, 0, 0);
bdn->ep_state |= ENTRY_STATE_NOTINCACHE;
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
return -1;
}
else if (state != 0)
{
LOG("the entry already exists. cannot reserve it.\n", 0, 0, 0);
bdn->ep_state |= ENTRY_STATE_NOTINCACHE;
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
return -1;
}
else
@@ -1828,7 +1831,7 @@ dncache_add_int(struct cache *cache, struct backdn *bdn, int state,
lru_delete(cache, (void *)*alt);
(*alt)->ep_refcnt++;
}
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
return 1;
}
}
@@ -1857,7 +1860,7 @@ dncache_add_int(struct cache *cache, struct backdn *bdn, int state,
dnflush = dncache_flush(cache);
}
}
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
while (dnflush)
{
@@ -1885,7 +1888,7 @@ dncache_replace(struct cache *cache, struct backdn *olddn, struct backdn *newdn)
* where the entry isn't in all the table yet, so we don't care if any
* of these return errors.
*/
- PR_Lock(cache->c_mutex);
+ cache_lock(cache);
/*
* First, remove the old entry from the hashtable.
@@ -1897,7 +1900,7 @@ dncache_replace(struct cache *cache, struct backdn *olddn, struct backdn *newdn)
found = remove_hash(cache->c_idtable, &(olddn->ep_id), sizeof(ID));
if (!found) {
LOG("dn cache replace: cache index tables out of sync\n", 0, 0, 0);
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
return 1;
}
}
@@ -1908,7 +1911,7 @@ dncache_replace(struct cache *cache, struct backdn *olddn, struct backdn *newdn)
*/
if (!add_hash(cache->c_idtable, &(newdn->ep_id), sizeof(ID), newdn, NULL)) {
LOG("dn cache replace: can't add id\n", 0, 0, 0);
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
return 1;
}
/* adjust cache meta info */
@@ -1923,7 +1926,7 @@ dncache_replace(struct cache *cache, struct backdn *olddn, struct backdn *newdn)
}
olddn->ep_state = ENTRY_STATE_DELETED;
newdn->ep_state = 0;
- PR_Unlock(cache->c_mutex);
+ cache_unlock(cache);
LOG("<= dncache_replace OK, cache size now %lu cache count now %ld\n",
slapi_counter_get_value(cache->c_cursize), cache->c_curentries, 0);
return 0;
@@ -2006,3 +2009,37 @@ dn_lru_verify(struct cache *cache, struct backdn *dn, int in)
ASSERT(is_in == in);
}
#endif
+
+int
+cache_has_otherref(struct cache *cache, void *ptr)
+{
+ struct backcommon *bep;
+ int hasref = 0;
+
+ if (NULL == ptr) {
+ return hasref;
+ }
+ bep = (struct backcommon *)ptr;
+ cache_lock(cache);
+ hasref = bep->ep_refcnt;
+ cache_unlock(cache);
+
+ return (hasref>1)?1:0;
+}
+
+int
+cache_is_in_cache(struct cache *cache, void *ptr)
+{
+ struct backcommon *bep;
+ int in_cache = 0;
+
+ if (NULL == ptr) {
+ return in_cache;
+ }
+ bep = (struct backcommon *)ptr;
+ cache_lock(cache);
+ in_cache = (bep->ep_state & (ENTRY_STATE_DELETED|ENTRY_STATE_NOTINCACHE))?0:1;
+ cache_unlock(cache);
+
+ return in_cache;
+}
diff --git a/ldap/servers/slapd/back-ldbm/ldbm_add.c b/ldap/servers/slapd/back-ldbm/ldbm_add.c
index e1ae66e..f27e78d 100644
--- a/ldap/servers/slapd/back-ldbm/ldbm_add.c
+++ b/ldap/servers/slapd/back-ldbm/ldbm_add.c
@@ -84,6 +84,7 @@ ldbm_back_add( Slapi_PBlock *pb )
struct backentry *addingentry = NULL;
struct backentry *parententry = NULL;
struct backentry *originalentry = NULL;
+ struct backentry *tmpentry = NULL;
ID pid;
int isroot;
char *errbuf= NULL;
@@ -103,12 +104,11 @@ ldbm_back_add( Slapi_PBlock *pb )
int ruv_c_init = 0;
int rc;
int addingentry_id_assigned= 0;
- int addingentry_in_cache= 0;
- int tombstone_in_cache= 0;
Slapi_DN *sdn = NULL;
Slapi_DN parentsdn;
Slapi_Operation *operation;
int dblock_acquired= 0;
+ int is_remove_from_cache= 0;
int is_replicated_operation= 0;
int is_resurect_operation= 0;
int is_tombstone_operation= 0;
@@ -118,6 +118,7 @@ ldbm_back_add( Slapi_PBlock *pb )
entry_address addr = {0};
int parent_switched = 0;
int noabort = 1;
+ const char *dn = NULL;
slapi_pblock_get( pb, SLAPI_PLUGIN_PRIVATE, &li );
slapi_pblock_get( pb, SLAPI_ADD_ENTRY, &e );
@@ -425,7 +426,6 @@ ldbm_back_add( Slapi_PBlock *pb )
ldap_result_code= -1;
goto error_return; /* error result sent by find_entry2modify() */
}
- tombstone_in_cache = 1;
addingentry = backentry_dup( tombstoneentry );
if ( addingentry==NULL )
@@ -684,14 +684,13 @@ ldbm_back_add( Slapi_PBlock *pb )
/* Tentatively add the entry to the cache. We do this after adding any
* operational attributes to ensure that the cache is sized correctly. */
- if ( cache_add_tentative( &inst->inst_cache, addingentry, NULL )!= 0 )
+ if ( cache_add_tentative( &inst->inst_cache, addingentry, NULL ) < 0 )
{
LDAPDebug1Arg(LDAP_DEBUG_CACHE, "cache_add_tentative concurrency detected: %s\n",
slapi_entry_get_dn_const(addingentry->ep_entry));
ldap_result_code= LDAP_ALREADY_EXISTS;
goto error_return;
}
- addingentry_in_cache = 1;
/*
* Before we add the entry, find out if the syntax of the aci
@@ -740,33 +739,32 @@ ldbm_back_add( Slapi_PBlock *pb )
noabort = 1;
slapi_pblock_set(pb, SLAPI_TXN, parent_txn);
- if (addingentry_in_cache) {
+ /* must duplicate addingentry before returning it to cache,
+ * which could free the entry. */
+ if ( (tmpentry = backentry_dup( addingentry )) == NULL ) {
+ ldap_result_code= LDAP_OPERATIONS_ERROR;
+ goto error_return;
+ }
+ if (cache_is_in_cache(&inst->inst_cache, addingentry)) {
/* addingentry is in cache. Remove it once. */
retval = CACHE_REMOVE(&inst->inst_cache, addingentry);
if (retval) {
LDAPDebug1Arg(LDAP_DEBUG_CACHE, "ldbm_add: cache_remove %s failed.\n",
slapi_entry_get_dn_const(addingentry->ep_entry));
}
- CACHE_RETURN(&inst->inst_cache, &addingentry);
- } else {
- backentry_free(&addingentry);
}
+ CACHE_RETURN(&inst->inst_cache, &addingentry);
slapi_pblock_set( pb, SLAPI_ADD_ENTRY, originalentry->ep_entry );
addingentry = originalentry;
- if ( (originalentry = backentry_dup( addingentry )) == NULL ) {
- ldap_result_code= LDAP_OPERATIONS_ERROR;
+ originalentry = tmpentry;
+ tmpentry = NULL;
+ /* Adding the resetted addingentry to the cache. */
+ if (cache_add_tentative(&inst->inst_cache, addingentry, NULL) < 0) {
+ LDAPDebug1Arg(LDAP_DEBUG_CACHE, "cache_add_tentative concurrency detected: %s\n",
+ slapi_entry_get_dn_const(addingentry->ep_entry));
+ ldap_result_code = LDAP_ALREADY_EXISTS;
goto error_return;
}
- if (addingentry_in_cache) {
- /* Adding the resetted addingentry to the cache. */
- if (cache_add_tentative(&inst->inst_cache, addingentry, NULL) != 0) {
- LDAPDebug1Arg(LDAP_DEBUG_CACHE, "cache_add_tentative concurrency detected: %s\n",
- slapi_entry_get_dn_const(addingentry->ep_entry));
- ldap_result_code = LDAP_ALREADY_EXISTS;
- addingentry_in_cache = 0;
- goto error_return;
- }
- }
if (ruv_c_init) {
/* reset the ruv txn stuff */
modify_term(&ruv_c, be);
@@ -1038,10 +1036,6 @@ ldbm_back_add( Slapi_PBlock *pb )
retval = -1;
goto error_return;
}
- if (addingentry_in_cache) { /* decrease the refcnt added by tentative */
- CACHE_RETURN( &inst->inst_cache, &addingentry );
- }
- addingentry_in_cache = 1; /* reset it to make it sure... */
/*
* The tombstone was locked down in the cache... we can
* get rid of the entry in the cache now.
@@ -1056,9 +1050,6 @@ ldbm_back_add( Slapi_PBlock *pb )
CACHE_RETURN(&inst->inst_dncache, &bdn);
}
}
- cache_unlock_entry( &inst->inst_cache, tombstoneentry );
- CACHE_RETURN( &inst->inst_cache, &tombstoneentry );
- tombstone_in_cache = 0;
}
if (parent_found)
{
@@ -1116,20 +1107,6 @@ error_return:
{
next_id_return( be, addingentry->ep_id );
}
- if ( addingentry )
- {
- if ( addingentry_in_cache )
- {
- CACHE_REMOVE(&inst->inst_cache, addingentry);
- }
- else
- {
- if (!is_resurect_operation) { /* if resurect, tombstoneentry is dupped. */
- backentry_clear_entry(addingentry); /* e is released in the frontend */
- }
- backentry_free( &addingentry ); /* release the backend wrapper, here */
- }
- }
if (rc == DB_RUNRECOVERY) {
dblayer_remember_disk_filled(li);
ldbm_nasty("Add",80,rc);
@@ -1149,6 +1126,21 @@ error_return:
diskfull_return:
if (disk_full) {
+ if ( addingentry )
+ {
+ if (inst && cache_is_in_cache(&inst->inst_cache, addingentry)) {
+ CACHE_REMOVE(&inst->inst_cache, addingentry);
+ /* tell frontend not to free this entry */
+ slapi_pblock_set(pb, SLAPI_ADD_ENTRY, NULL);
+ }
+ else if (!cache_has_otherref(&inst->inst_cache, addingentry))
+ {
+ if (!is_resurect_operation) { /* if resurect, tombstoneentry is dupped. */
+ backentry_clear_entry(addingentry); /* e is released in the frontend */
+ }
+ }
+ CACHE_RETURN( &inst->inst_cache, &addingentry );
+ }
rc = return_on_disk_full(li);
} else {
/* It is safer not to abort when the transaction is not started. */
@@ -1188,38 +1180,57 @@ diskfull_return:
}
/* txn is no longer valid - reset the txn pointer to the parent */
slapi_pblock_set(pb, SLAPI_TXN, parent_txn);
+ } else {
+ if ( addingentry ) {
+ if (inst && cache_is_in_cache(&inst->inst_cache, addingentry)) {
+ CACHE_REMOVE(&inst->inst_cache, addingentry);
+ /* tell frontend not to free this entry */
+ slapi_pblock_set(pb, SLAPI_ADD_ENTRY, NULL);
+ }
+ else if (!cache_has_otherref(&inst->inst_cache, addingentry))
+ {
+ if (!is_resurect_operation) { /* if resurect, tombstoneentry is dupped. */
+ backentry_clear_entry(addingentry); /* e is released in the frontend */
+ }
+ }
+ CACHE_RETURN( &inst->inst_cache, &addingentry );
+ }
}
rc = SLAPI_FAIL_GENERAL;
}
common_return:
if (inst) {
- if(tombstone_in_cache && tombstoneentry) {
+ if (tombstoneentry && cache_is_in_cache(&inst->inst_cache, tombstoneentry)) {
cache_unlock_entry(&inst->inst_cache, tombstoneentry);
CACHE_RETURN(&inst->inst_cache, &tombstoneentry);
}
- }
- if (addingentry_in_cache && addingentry) {
- if ((0 == retval) && entryrdn_get_switch()) { /* subtree-rename: on */
- /* since the op was successful, add the addingentry's dn to the dn cache */
- struct backdn *bdn = dncache_find_id(&inst->inst_dncache,
- addingentry->ep_id);
- if (bdn) { /* already in the dncache */
- CACHE_RETURN(&inst->inst_dncache, &bdn);
- } else { /* not in the dncache yet */
- Slapi_DN *addingsdn = slapi_sdn_dup(slapi_entry_get_sdn(addingentry->ep_entry));
- if (addingsdn) {
- bdn = backdn_init(addingsdn, addingentry->ep_id, 0);
- if (bdn) {
- CACHE_ADD( &inst->inst_dncache, bdn, NULL );
- CACHE_RETURN(&inst->inst_dncache, &bdn);
- slapi_log_error(SLAPI_LOG_CACHE, "ldbm_back_add",
- "set %s to dn cache\n", slapi_sdn_get_dn(sdn));
+ if (addingentry) {
+ if ((0 == retval) && entryrdn_get_switch()) { /* subtree-rename: on */
+ /* since adding the entry to the entry cache was successful,
+ * let's add the dn to dncache, if not yet done. */
+ struct backdn *bdn = dncache_find_id(&inst->inst_dncache,
+ addingentry->ep_id);
+ if (bdn) { /* already in the dncache */
+ CACHE_RETURN(&inst->inst_dncache, &bdn);
+ } else { /* not in the dncache yet */
+ Slapi_DN *addingsdn = slapi_sdn_dup(slapi_entry_get_sdn(addingentry->ep_entry));
+ if (addingsdn) {
+ bdn = backdn_init(addingsdn, addingentry->ep_id, 0);
+ if (bdn) {
+ CACHE_ADD( &inst->inst_dncache, bdn, NULL );
+ CACHE_RETURN(&inst->inst_dncache, &bdn);
+ slapi_log_error(SLAPI_LOG_CACHE, "ldbm_back_add",
+ "set %s to dn cache\n", dn);
+ }
}
}
}
+ if (is_remove_from_cache) {
+ CACHE_REMOVE(&inst->inst_cache, addingentry);
+ }
+ CACHE_RETURN( &inst->inst_cache, &addingentry );
}
- CACHE_RETURN( &inst->inst_cache, &addingentry );
}
/* bepost op needs to know this result */
slapi_pblock_set(pb, SLAPI_RESULT_CODE, &ldap_result_code);
@@ -1241,6 +1252,7 @@ common_return:
slapi_send_ldap_result( pb, ldap_result_code, ldap_result_matcheddn, ldap_result_message, 0, NULL );
}
backentry_free(&originalentry);
+ backentry_free(&tmpentry);
slapi_sdn_done(&parentsdn);
slapi_ch_free( (void**)&ldap_result_matcheddn );
slapi_ch_free( (void**)&errbuf );
diff --git a/ldap/servers/slapd/back-ldbm/ldbm_delete.c b/ldap/servers/slapd/back-ldbm/ldbm_delete.c
index 728bc1f..a9530ec 100644
--- a/ldap/servers/slapd/back-ldbm/ldbm_delete.c
+++ b/ldap/servers/slapd/back-ldbm/ldbm_delete.c
@@ -60,6 +60,7 @@ ldbm_back_delete( Slapi_PBlock *pb )
struct ldbminfo *li = NULL;
struct backentry *e = NULL;
struct backentry *tombstone = NULL;
+ struct backentry *tmptombstone = NULL;
struct backentry *original_tombstone = NULL;
const char *dn = NULL;
back_txn txn;
@@ -89,8 +90,6 @@ ldbm_back_delete( Slapi_PBlock *pb )
int delete_tombstone_entry = 0; /* We must remove the given tombstone entry from the DB */
int create_tombstone_entry = 0; /* We perform a "regular" LDAP delete but since we use */
/* replication, we must create a new tombstone entry */
- int tombstone_in_cache = 0;
- int e_in_cache = 0;
int remove_e_from_cache = 0;
entry_address *addr;
int addordel_flags = 0; /* passed to index_addordel */
@@ -99,6 +98,8 @@ ldbm_back_delete( Slapi_PBlock *pb )
Slapi_DN parentsdn;
int opreturn = 0;
int free_delete_existing_entry = 0;
+ ID ep_id = 0;
+ ID tomb_ep_id = 0;
slapi_pblock_get( pb, SLAPI_BACKEND, &be);
slapi_pblock_get( pb, SLAPI_PLUGIN_PRIVATE, &li );
@@ -194,7 +195,7 @@ ldbm_back_delete( Slapi_PBlock *pb )
LDAPDebug0Args(LDAP_DEBUG_BACKLDBM, "ldbm_back_delete: Deleting entry is already deleted.\n");
goto error_return; /* error result sent by find_entry2modify() */
}
- e_in_cache = 1; /* e is cached */
+ ep_id = e->ep_id;
retval = slapi_entry_has_children(e->ep_entry);
if (retval) {
@@ -472,6 +473,7 @@ ldbm_back_delete( Slapi_PBlock *pb )
parentuniqueid= slapi_entry_get_uniqueid(parent_modify_c.old_entry->ep_entry);
}
tombstone = backentry_dup( e );
+ tomb_ep_id = tombstone->ep_id;
slapi_entry_set_dn(tombstone->ep_entry,tombstone_dn); /* Consumes DN */
if (entryrdn_get_switch()) /* subtree-rename: on */
{
@@ -534,25 +536,20 @@ ldbm_back_delete( Slapi_PBlock *pb )
/* reset tombstone entry */
if (original_tombstone) {
- if (tombstone_in_cache) {
- CACHE_REMOVE(&inst->inst_cache, tombstone);
- CACHE_RETURN(&inst->inst_cache, &tombstone);
- tombstone = NULL;
- tombstone_in_cache = 0;
- } else {
- backentry_free(&tombstone);
- }
- tombstone = original_tombstone;
- if ( (original_tombstone = backentry_dup( tombstone )) == NULL ) {
+ /* must duplicate tombstone before returning it to cache,
+ * which could free the entry. */
+ if ( (tmptombstone = backentry_dup( original_tombstone )) == NULL ) {
ldap_result_code= LDAP_OPERATIONS_ERROR;
goto error_return;
}
+ if (cache_is_in_cache(&inst->inst_cache, tombstone)) {
+ CACHE_REMOVE(&inst->inst_cache, tombstone);
+ }
+ CACHE_RETURN(&inst->inst_cache, &tombstone);
+ tombstone = original_tombstone;
+ original_tombstone = tmptombstone;
+ tmptombstone = NULL;
}
- /* reset original entry in cache */
- if (!e_in_cache) {
- CACHE_ADD(&inst->inst_cache, e, NULL);
- e_in_cache = 1;
- }
if (ruv_c_init) {
/* reset the ruv txn stuff */
modify_term(&ruv_c, be);
@@ -647,13 +644,10 @@ ldbm_back_delete( Slapi_PBlock *pb )
* entry is removed from the cache.
*/
retval = cache_add_tentative(&inst->inst_cache, tombstone, NULL);
- if (0 == retval) {
- tombstone_in_cache = 1;
- } else {
+ if (0 > retval) {
LDAPDebug2Args(LDAP_DEBUG_ANY,
"tombstone entry %s failed to add to the cache: %d\n",
slapi_entry_get_dn(tombstone->ep_entry), retval);
- tombstone_in_cache = 0;
if (LDBM_OS_ERR_IS_DISKFULL(retval)) disk_full = 1;
DEL_SET_ERROR(ldap_result_code,
LDAP_OPERATIONS_ERROR, retry_count);
@@ -672,13 +666,6 @@ ldbm_back_delete( Slapi_PBlock *pb )
DEL_SET_ERROR(ldap_result_code, LDAP_OPERATIONS_ERROR, retry_count);
goto error_return;
}
- if (tombstone_in_cache) {
- /* tombstone was already added to the cache via cache_add_tentative (to reserve its spot in the cache)
- and/or id2entry_add - so it already had one refcount - cache_replace adds another refcount -
- drop the extra ref added by cache_replace */
- CACHE_RETURN( &inst->inst_cache, &tombstone );
- }
- tombstone_in_cache = 1;
}
else
{
@@ -1129,22 +1116,22 @@ ldbm_back_delete( Slapi_PBlock *pb )
/* delete from cache and clean up */
if (e) {
- if (entryrdn_get_switch()) { /* subtree-rename: on */
+ if (cache_is_in_cache(&inst->inst_cache, e)) {
+ ep_id = e->ep_id;
+ CACHE_REMOVE(&inst->inst_cache, e);
+ }
+ cache_unlock_entry(&inst->inst_cache, e);
+ CACHE_RETURN(&inst->inst_cache, &e);
+ e = NULL;
+
+ if (entryrdn_get_switch() && ep_id) { /* subtree-rename: on */
/* since the op was successful, delete the tombstone dn from the dn cache */
- struct backdn *bdn = dncache_find_id(&inst->inst_dncache, e->ep_id);
+ struct backdn *bdn = dncache_find_id(&inst->inst_dncache, ep_id);
if (bdn) { /* in the dncache, remove it. */
CACHE_REMOVE(&inst->inst_dncache, bdn);
CACHE_RETURN(&inst->inst_dncache, &bdn);
}
}
- if (e_in_cache) {
- CACHE_REMOVE(&inst->inst_cache, e);
- cache_unlock_entry(&inst->inst_cache, e);
- CACHE_RETURN(&inst->inst_cache, &e);
- } else {
- cache_unlock_entry(&inst->inst_cache, e);
- }
- e = NULL;
}
if (ruv_c_init) {
@@ -1168,36 +1155,23 @@ ldbm_back_delete( Slapi_PBlock *pb )
error_return:
if (tombstone) {
- if (entryrdn_get_switch()) { /* subtree-rename: on */
+ if (cache_is_in_cache(&inst->inst_cache, tombstone)) {
+ tomb_ep_id = tombstone->ep_id;
+ }
+
+ if (entryrdn_get_switch() && tomb_ep_id) { /* subtree-rename: on */
/* since the op was successful, add the addingentry's dn to the dn cache */
- struct backdn *bdn = dncache_find_id(&inst->inst_dncache, tombstone->ep_id);
+ struct backdn *bdn = dncache_find_id(&inst->inst_dncache, tomb_ep_id);
if (bdn) { /* already in the dncache. Delete it. */
CACHE_REMOVE(&inst->inst_dncache, bdn);
CACHE_RETURN(&inst->inst_dncache, &bdn);
- }
+ }
}
- if (tombstone_in_cache) { /* successfully replaced */
+ if (cache_is_in_cache(&inst->inst_cache, tombstone)) {
CACHE_REMOVE( &inst->inst_cache, tombstone );
- CACHE_RETURN( &inst->inst_cache, &tombstone );
- tombstone = NULL;
- tombstone_in_cache = 0;
- } else {
- backentry_free( &tombstone );
- }
- }
-
- /* Need to return to cache after post op plugins are called */
- if (e) {
- if (e_in_cache) {
- if (remove_e_from_cache) {
- /* The entry is already transformed to a tombstone. */
- CACHE_REMOVE( &inst->inst_cache, e );
- }
- cache_unlock_entry( &inst->inst_cache, e );
- CACHE_RETURN( &inst->inst_cache, &e );
- } else {
- cache_unlock_entry( &inst->inst_cache, e );
}
+ CACHE_RETURN( &inst->inst_cache, &tombstone );
+ tombstone = NULL;
}
if (retval == DB_RUNRECOVERY) {
@@ -1258,7 +1232,7 @@ common_return:
for the post op plugins */
slapi_pblock_set( pb, SLAPI_DELETE_BEPREOP_ENTRY, orig_entry );
}
- if (tombstone) {
+ if (inst && tombstone) {
if ((0 == retval) && entryrdn_get_switch()) { /* subtree-rename: on */
/* since the op was successful, add the addingentry's dn to the dn cache */
struct backdn *bdn = dncache_find_id(&inst->inst_dncache, tombstone->ep_id);
@@ -1277,13 +1251,8 @@ common_return:
}
}
}
- if (tombstone_in_cache) { /* successfully replaced */
- CACHE_RETURN( &inst->inst_cache, &tombstone );
- tombstone = NULL;
- tombstone_in_cache = 0;
- } else {
- backentry_free( &tombstone );
- }
+ CACHE_RETURN( &inst->inst_cache, &tombstone );
+ tombstone = NULL;
}
/* result code could be used in the bepost plugin functions. */
@@ -1297,7 +1266,7 @@ common_return:
}
if (e) {
- if (e_in_cache) {
+ if (cache_is_in_cache(&inst->inst_cache, e)) {
if (remove_e_from_cache) {
/* The entry is already transformed to a tombstone. */
CACHE_REMOVE( &inst->inst_cache, e );
@@ -1342,6 +1311,7 @@ diskfull_return:
slapi_pblock_set(pb, SLAPI_DELETE_EXISTING_ENTRY, NULL);
}
backentry_free(&original_tombstone);
+ backentry_free(&tmptombstone);
slapi_ch_free((void**)&errbuf);
slapi_sdn_done(&nscpEntrySDN);
slapi_ch_free_string(&e_uniqueid);
diff --git a/ldap/servers/slapd/back-ldbm/ldbm_modify.c b/ldap/servers/slapd/back-ldbm/ldbm_modify.c
index a40b5c4..69bf246 100644
--- a/ldap/servers/slapd/back-ldbm/ldbm_modify.c
+++ b/ldap/servers/slapd/back-ldbm/ldbm_modify.c
@@ -65,7 +65,6 @@ void modify_init(modify_context *mc,struct backentry *old_entry)
PR_ASSERT(NULL == mc->new_entry);
mc->old_entry = old_entry;
- mc->new_entry_in_cache = 0;
mc->attr_encrypt = 1;
}
@@ -96,16 +95,13 @@ int modify_term(modify_context *mc,struct backend *be)
slapi_mods_free(&mc->smods);
/* Unlock and return entries */
- if (NULL != mc->old_entry) {
+ if (mc->old_entry) {
cache_unlock_entry(&inst->inst_cache, mc->old_entry);
CACHE_RETURN( &(inst->inst_cache), &(mc->old_entry) );
mc->old_entry= NULL;
}
- if (mc->new_entry_in_cache) {
- CACHE_RETURN( &(inst->inst_cache), &(mc->new_entry) );
- } else {
- backentry_free(&(mc->new_entry));
- }
+
+ CACHE_RETURN( &(inst->inst_cache), &(mc->new_entry) );
mc->new_entry= NULL;
return 0;
}
@@ -115,11 +111,9 @@ int modify_switch_entries(modify_context *mc,backend *be)
{
ldbm_instance *inst = (ldbm_instance *) be->be_instance_info;
int ret = 0;
- if (mc->old_entry!=NULL && mc->new_entry!=NULL) {
+ if (mc->old_entry && mc->new_entry) {
ret = cache_replace(&(inst->inst_cache), mc->old_entry, mc->new_entry);
- if (ret == 0) {
- mc->new_entry_in_cache = 1;
- } else {
+ if (ret){
LDAPDebug(LDAP_DEBUG_CACHE, "modify_switch_entries: replacing %s with %s failed (%d)\n",
slapi_entry_get_dn(mc->old_entry->ep_entry),
slapi_entry_get_dn(mc->new_entry->ep_entry), ret);
@@ -140,13 +134,19 @@ modify_unswitch_entries(modify_context *mc,backend *be)
ldbm_instance *inst = (ldbm_instance *) be->be_instance_info;
int ret = 0;
- if (mc->old_entry!=NULL && mc->new_entry!=NULL) {
+ if (mc->old_entry && mc->new_entry &&
+ cache_is_in_cache(&inst->inst_cache, mc->new_entry)) {
/* switch the entries, and reset the new, new, entry */
tmp_be = mc->new_entry;
mc->new_entry = mc->old_entry;
mc->new_entry->ep_state = 0;
- mc->new_entry->ep_refcnt = 0;
- mc->new_entry_in_cache = 0;
+ if (cache_has_otherref(&(inst->inst_cache), mc->new_entry)) {
+ /* some other thread refers the entry */
+ CACHE_RETURN(&(inst->inst_cache), &(mc->new_entry));
+ } else {
+ /* don't call CACHE_RETURN, that frees the entry! */
+ mc->new_entry->ep_refcnt = 0;
+ }
mc->old_entry = tmp_be;
ret = cache_replace(&(inst->inst_cache), mc->old_entry, mc->new_entry);
@@ -157,9 +157,7 @@ modify_unswitch_entries(modify_context *mc,backend *be)
* "old" one. modify_term() will then return the "new" entry.
*/
cache_unlock_entry(&inst->inst_cache, mc->new_entry);
- CACHE_RETURN( &(inst->inst_cache), &(mc->old_entry) );
- mc->new_entry_in_cache = 1;
- mc->old_entry = NULL;
+ cache_lock_entry(&inst->inst_cache, mc->old_entry);
} else {
LDAPDebug(LDAP_DEBUG_CACHE, "modify_unswitch_entries: replacing %s with %s failed (%d)\n",
slapi_entry_get_dn(mc->old_entry->ep_entry),
@@ -362,7 +360,8 @@ ldbm_back_modify( Slapi_PBlock *pb )
backend *be;
ldbm_instance *inst = NULL;
struct ldbminfo *li;
- struct backentry *e = NULL, *ec = NULL, *original_entry = NULL;
+ struct backentry *e = NULL, *ec = NULL;
+ struct backentry *original_entry = NULL, *tmpentry = NULL;;
Slapi_Entry *postentry = NULL;
LDAPMod **mods = NULL;
LDAPMod **mods_original = NULL;
@@ -382,7 +381,6 @@ ldbm_back_modify( Slapi_PBlock *pb )
Slapi_Operation *operation;
int dblock_acquired= 0;
entry_address *addr;
- int ec_in_cache = 0;
int is_fixup_operation= 0;
int is_ruv = 0; /* True if the current entry is RUV */
CSN *opcsn = NULL;
@@ -551,14 +549,21 @@ ldbm_back_modify( Slapi_PBlock *pb )
slapi_pblock_get(pb, SLAPI_MODIFY_MODS, &mods);
ldap_mods_free(mods, 1);
slapi_pblock_set(pb, SLAPI_MODIFY_MODS, copy_mods(mods_original));
- /* ec is not really added to the cache until cache_replace, so we
- don't have to worry about the cache here */
- backentry_free(&ec);
- slapi_pblock_set( pb, SLAPI_MODIFY_EXISTING_ENTRY, original_entry->ep_entry );
- ec = original_entry;
- if ( (original_entry = backentry_dup( ec )) == NULL ) {
- ldap_result_code= LDAP_OPERATIONS_ERROR;
- goto error_return;
+ /* reset ec set cache in id2entry_add_ext */
+ if (ec) {
+ /* must duplicate ec before returning it to cache,
+ * which could free the entry. */
+ if ( (tmpentry = backentry_dup( ec )) == NULL ) {
+ ldap_result_code= LDAP_OPERATIONS_ERROR;
+ goto error_return;
+ }
+ if (cache_is_in_cache(&inst->inst_cache, ec)) {
+ CACHE_REMOVE(&inst->inst_cache, ec);
+ }
+ CACHE_RETURN(&inst->inst_cache, &ec);
+ ec = original_entry;
+ original_entry = tmpentry;
+ tmpentry = NULL;
}
if (ruv_c_init) {
@@ -740,7 +745,6 @@ ldbm_back_modify( Slapi_PBlock *pb )
/* lock new entry in cache to prevent usage until we are complete */
cache_lock_entry( &inst->inst_cache, ec );
- ec_in_cache = 1;
postentry = slapi_entry_dup( ec->ep_entry );
slapi_pblock_set( pb, SLAPI_ENTRY_POST_OP, postentry );
@@ -842,11 +846,11 @@ error_return:
}
/* if ec is in cache, remove it, then add back e if we still have it */
- if (ec_in_cache) {
+ if (inst && cache_is_in_cache(&inst->inst_cache, ec)) {
CACHE_REMOVE( &inst->inst_cache, ec );
/* if ec was in cache, e was not - add back e */
if (e) {
- if (CACHE_ADD( &inst->inst_cache, e, NULL )) {
+ if (CACHE_ADD( &inst->inst_cache, e, NULL ) < 0) {
LDAPDebug1Arg( LDAP_DEBUG_CACHE, "ldbm_modify: CACHE_ADD %s failed\n",
slapi_entry_get_dn(e->ep_entry));
}
@@ -856,20 +860,17 @@ error_return:
common_return:
slapi_mods_done(&smods);
- if (ec_in_cache)
- {
- cache_unlock_entry( &inst->inst_cache, ec);
- CACHE_RETURN( &inst->inst_cache, &ec );
- }
- else
- {
- backentry_free(&ec);
- /* if ec was not in cache, cache_replace was not done.
- * i.e., e was not unlocked. */
- if (e) {
+ if(inst){
+ if (cache_is_in_cache( &inst->inst_cache, ec))
+ {
+ cache_unlock_entry( &inst->inst_cache, ec);
+ } else if (e) {
+ /* if ec was not in cache, cache_replace was not done.
+ * i.e., e was not unlocked. */
cache_unlock_entry( &inst->inst_cache, e);
CACHE_RETURN( &inst->inst_cache, &e);
}
+ CACHE_RETURN(&inst->inst_cache, &ec);
}
/* result code could be used in the bepost plugin functions. */
@@ -895,6 +896,7 @@ common_return:
/* free our backups */
ldap_mods_free(mods_original, 1);
backentry_free(&original_entry);
+ backentry_free(&tmpentry);
slapi_ch_free_string(&errbuf);
return rc;
diff --git a/ldap/servers/slapd/back-ldbm/ldbm_modrdn.c b/ldap/servers/slapd/back-ldbm/ldbm_modrdn.c
index 3e5f686..8e52e0e 100644
--- a/ldap/servers/slapd/back-ldbm/ldbm_modrdn.c
+++ b/ldap/servers/slapd/back-ldbm/ldbm_modrdn.c
@@ -50,7 +50,7 @@ static void moddn_unlock_and_return_entry(backend *be,struct backentry **targete
static int moddn_newrdn_mods(Slapi_PBlock *pb, const char *olddn, struct backentry *ec, Slapi_Mods *smods_wsi, int is_repl_op);
static IDList *moddn_get_children(back_txn *ptxn, Slapi_PBlock *pb, backend *be, struct backentry *parententry, Slapi_DN *parentdn, struct backentry ***child_entries, struct backdn ***child_dns, int is_resurect_operation);
static int moddn_rename_children(back_txn *ptxn, Slapi_PBlock *pb, backend *be, IDList *children, Slapi_DN *dn_parentdn, Slapi_DN *dn_newsuperiordn, struct backentry *child_entries[]);
-static int modrdn_rename_entry_update_indexes(back_txn *ptxn, Slapi_PBlock *pb, struct ldbminfo *li, struct backentry *e, struct backentry **ec, Slapi_Mods *smods1, Slapi_Mods *smods2, Slapi_Mods *smods3, int *e_in_cache, int *ec_in_cache);
+static int modrdn_rename_entry_update_indexes(back_txn *ptxn, Slapi_PBlock *pb, struct ldbminfo *li, struct backentry *e, struct backentry **ec, Slapi_Mods *smods1, Slapi_Mods *smods2, Slapi_Mods *smods3);
static void mods_remove_nsuniqueid(Slapi_Mods *smods);
#define MOD_SET_ERROR(rc, error, count) \
@@ -67,8 +67,6 @@ ldbm_back_modrdn( Slapi_PBlock *pb )
struct ldbminfo *li;
struct backentry *e= NULL;
struct backentry *ec= NULL;
- int ec_in_cache= 0;
- int e_in_cache= 0;
back_txn txn;
back_txnid parent_txn;
int retval = -1;
@@ -83,8 +81,7 @@ ldbm_back_modrdn( Slapi_PBlock *pb )
struct backentry *parententry= NULL;
struct backentry *newparententry= NULL;
struct backentry *original_entry = NULL;
- struct backentry *original_parent = NULL;
- struct backentry *original_newparent = NULL;
+ struct backentry *tmpentry = NULL;
modify_context parent_modify_context = {0};
modify_context newparent_modify_context = {0};
modify_context ruv_c = {0};
@@ -361,7 +358,6 @@ ldbm_back_modrdn( Slapi_PBlock *pb )
ldap_result_code= -1;
goto error_return; /* error result sent by find_entry2modify() */
}
- e_in_cache = 1; /* e is in the cache and locked */
if (slapi_entry_flag_is_set(e->ep_entry, SLAPI_ENTRY_FLAG_TOMBSTONE) ) {
if (!is_resurect_operation) {
ldap_result_code = LDAP_UNWILLING_TO_PERFORM;
@@ -600,8 +596,7 @@ ldbm_back_modrdn( Slapi_PBlock *pb )
}
/* create it in the cache - prevents others from creating it */
- if (( cache_add_tentative( &inst->inst_cache, ec, NULL ) != 0 ) ) {
- ec_in_cache = 0; /* not in cache */
+ if (( cache_add_tentative( &inst->inst_cache, ec, NULL ) < 0 ) ) {
/* allow modrdn even if the src dn and dest dn are identical */
if ( 0 != slapi_sdn_compare((const Slapi_DN *)&dn_newdn,
(const Slapi_DN *)sdn) ) {
@@ -616,46 +611,42 @@ ldbm_back_modrdn( Slapi_PBlock *pb )
}
/* so if the old dn is the same as the new dn, the entry will not be cached
until it is replaced with cache_replace */
- } else {
- ec_in_cache = 1;
}
/* Build the list of modifications required to the existing entry */
+ slapi_mods_init(&smods_generated,4);
+ slapi_mods_init(&smods_generated_wsi,4);
+ ldap_result_code = moddn_newrdn_mods(pb, slapi_sdn_get_ndn(sdn),
+ ec, &smods_generated_wsi, is_replicated_operation);
+ if (ldap_result_code != LDAP_SUCCESS) {
+ if (ldap_result_code == LDAP_UNWILLING_TO_PERFORM)
+ ldap_result_message = "Modification of old rdn attribute type not allowed.";
+ goto error_return;
+ }
+ if (!entryrdn_get_switch()) /* subtree-rename: off */
{
- slapi_mods_init(&smods_generated,4);
- slapi_mods_init(&smods_generated_wsi,4);
- ldap_result_code = moddn_newrdn_mods(pb, slapi_sdn_get_ndn(sdn),
- ec, &smods_generated_wsi, is_replicated_operation);
- if (ldap_result_code != LDAP_SUCCESS) {
- if (ldap_result_code == LDAP_UNWILLING_TO_PERFORM)
- ldap_result_message = "Modification of old rdn attribute type not allowed.";
- goto error_return;
- }
- if (!entryrdn_get_switch()) /* subtree-rename: off */
- {
- /*
- * Remove the old entrydn index entry, and add the new one.
- */
- slapi_mods_add( &smods_generated, LDAP_MOD_DELETE, LDBM_ENTRYDN_STR,
- strlen(backentry_get_ndn(e)), backentry_get_ndn(e));
- slapi_mods_add( &smods_generated, LDAP_MOD_REPLACE, LDBM_ENTRYDN_STR,
- strlen(backentry_get_ndn(ec)), backentry_get_ndn(ec));
- }
-
/*
- * Update parentid if we have a new superior.
+ * Remove the old entrydn index entry, and add the new one.
*/
- if(slapi_sdn_get_dn(dn_newsuperiordn)!=NULL) {
- char buf[40]; /* Enough for an ID */
-
- if (parententry != NULL) {
- sprintf( buf, "%lu", (u_long)parententry->ep_id );
- slapi_mods_add_string(&smods_generated, LDAP_MOD_DELETE, LDBM_PARENTID_STR, buf);
- }
- if (newparententry != NULL) {
- sprintf( buf, "%lu", (u_long)newparententry->ep_id );
- slapi_mods_add_string(&smods_generated, LDAP_MOD_REPLACE, LDBM_PARENTID_STR, buf);
- }
+ slapi_mods_add( &smods_generated, LDAP_MOD_DELETE, LDBM_ENTRYDN_STR,
+ strlen(backentry_get_ndn(e)), backentry_get_ndn(e));
+ slapi_mods_add( &smods_generated, LDAP_MOD_REPLACE, LDBM_ENTRYDN_STR,
+ strlen(backentry_get_ndn(ec)), backentry_get_ndn(ec));
+ }
+
+ /*
+ * Update parentid if we have a new superior.
+ */
+ if(slapi_sdn_get_dn(dn_newsuperiordn)!=NULL) {
+ char buf[40]; /* Enough for an ID */
+
+ if (parententry != NULL) {
+ sprintf( buf, "%lu", (u_long)parententry->ep_id );
+ slapi_mods_add_string(&smods_generated, LDAP_MOD_DELETE, LDBM_PARENTID_STR, buf);
+ }
+ if (newparententry != NULL) {
+ sprintf( buf, "%lu", (u_long)newparententry->ep_id );
+ slapi_mods_add_string(&smods_generated, LDAP_MOD_REPLACE, LDBM_PARENTID_STR, buf);
}
}
@@ -873,26 +864,22 @@ ldbm_back_modrdn( Slapi_PBlock *pb )
slapi_sdn_free(&dn_newsuperiordn);
slapi_pblock_set(pb, SLAPI_MODRDN_NEWSUPERIOR_SDN, orig_dn_newsuperiordn);
orig_dn_newsuperiordn = slapi_sdn_dup(orig_dn_newsuperiordn);
- if (ec_in_cache) {
- /* New entry 'ec' is in the entry cache.
- * Remove it from the cache . */
+ /* must duplicate ec before returning it to cache,
+ * which could free the entry. */
+ if ( (tmpentry = backentry_dup( ec )) == NULL ) {
+ ldap_result_code= LDAP_OPERATIONS_ERROR;
+ goto error_return;
+ }
+ if (cache_is_in_cache(&inst->inst_cache, ec)) {
CACHE_REMOVE(&inst->inst_cache, ec);
- CACHE_RETURN(&inst->inst_cache, &ec);
-#ifdef DEBUG_CACHE
- PR_ASSERT(ec == NULL);
-#endif
- ec_in_cache = 0;
- } else {
- backentry_free(&ec);
}
- /* make sure the original entry is back in the cache if it was removed */
- if (!e_in_cache) {
- if (CACHE_ADD(&inst->inst_cache, e, NULL)) {
+ CACHE_RETURN(&inst->inst_cache, &ec);
+ if (!cache_is_in_cache(&inst->inst_cache, e)) {
+ if (CACHE_ADD(&inst->inst_cache, e, NULL) < 0) {
LDAPDebug1Arg(LDAP_DEBUG_CACHE,
"ldbm_back_modrdn: CACHE_ADD %s to cache failed\n",
slapi_entry_get_dn_const(e->ep_entry));
}
- e_in_cache = 1;
}
slapi_pblock_get( pb, SLAPI_MODRDN_EXISTING_ENTRY, &ent );
if (ent && (ent != original_entry->ep_entry)) {
@@ -900,16 +887,13 @@ ldbm_back_modrdn( Slapi_PBlock *pb )
slapi_pblock_set( pb, SLAPI_MODRDN_EXISTING_ENTRY, NULL );
}
ec = original_entry;
- if ( (original_entry = backentry_dup( ec )) == NULL ) {
- ldap_result_code= LDAP_OPERATIONS_ERROR;
- goto error_return;
- }
+ original_entry = tmpentry;
+ tmpentry = NULL;
slapi_pblock_set( pb, SLAPI_MODRDN_EXISTING_ENTRY, original_entry->ep_entry );
free_modrdn_existing_entry = 0; /* owned by original_entry now */
- if (!ec_in_cache) {
+ if (!cache_is_in_cache(&inst->inst_cache, ec)) {
/* Put the resetted entry 'ec' into the cache again. */
- if (cache_add_tentative( &inst->inst_cache, ec, NULL ) != 0) {
- ec_in_cache = 0; /* not in cache */
+ if (cache_add_tentative( &inst->inst_cache, ec, NULL ) < 0) {
/* allow modrdn even if the src dn and dest dn are identical */
if ( 0 != slapi_sdn_compare((const Slapi_DN *)&dn_newdn,
(const Slapi_DN *)sdn) ) {
@@ -921,8 +905,6 @@ ldbm_back_modrdn( Slapi_PBlock *pb )
}
/* so if the old dn is the same as the new dn, the entry will not be cached
until it is replaced with cache_replace */
- } else {
- ec_in_cache = 1;
}
}
@@ -979,7 +961,7 @@ ldbm_back_modrdn( Slapi_PBlock *pb )
/*
* Update the indexes for the entry.
*/
- retval = modrdn_rename_entry_update_indexes(&txn, pb, li, e, &ec, &smods_generated, &smods_generated_wsi, &smods_operation_wsi, &e_in_cache, &ec_in_cache);
+ retval = modrdn_rename_entry_update_indexes(&txn, pb, li, e, &ec, &smods_generated, &smods_generated_wsi, &smods_operation_wsi);
if (DB_LOCK_DEADLOCK == retval)
{
/* Retry txn */
@@ -1413,16 +1395,13 @@ common_return:
}
/* remove the new entry from the cache if the op failed -
otherwise, leave it in */
- if (ec_in_cache && ec && retval) {
- CACHE_REMOVE( &inst->inst_cache, ec );
- }
- if (ec_in_cache) {
+ if (inst && ec){
+ if (retval && cache_is_in_cache(&inst->inst_cache, ec)) {
+ CACHE_REMOVE( &inst->inst_cache, ec );
+ }
CACHE_RETURN( &inst->inst_cache, &ec );
- } else {
- backentry_free( &ec );
}
ec = NULL;
- ec_in_cache = 0;
}
/* put e back in the cache if the modrdn failed */
@@ -1469,8 +1448,7 @@ common_return:
slapi_ch_free_string(&original_newrdn);
slapi_sdn_free(&orig_dn_newsuperiordn);
backentry_free(&original_entry);
- backentry_free(&original_parent);
- backentry_free(&original_newparent);
+ backentry_free(&tmpentry);
slapi_entry_free(original_targetentry);
if(dblock_acquired)
@@ -1744,7 +1722,9 @@ mods_remove_nsuniqueid(Slapi_Mods *smods)
* mods contains the list of attribute change made.
*/
static int
-modrdn_rename_entry_update_indexes(back_txn *ptxn, Slapi_PBlock *pb, struct ldbminfo *li, struct backentry *e, struct backentry **ec, Slapi_Mods *smods1, Slapi_Mods *smods2, Slapi_Mods *smods3, int *e_in_cache, int *ec_in_cache)
+modrdn_rename_entry_update_indexes(back_txn *ptxn, Slapi_PBlock *pb, struct ldbminfo *li,
+ struct backentry *e, struct backentry **ec,
+ Slapi_Mods *smods1, Slapi_Mods *smods2, Slapi_Mods *smods3)
{
backend *be;
ldbm_instance *inst;
@@ -1752,7 +1732,6 @@ modrdn_rename_entry_update_indexes(back_txn *ptxn, Slapi_PBlock *pb, struct ldbm
char *msg;
Slapi_Operation *operation;
int is_ruv = 0; /* True if the current entry is RUV */
- int orig_ec_in_cache = 0;
int cache_rc = 0;
slapi_pblock_get( pb, SLAPI_BACKEND, &be );
@@ -1760,7 +1739,6 @@ modrdn_rename_entry_update_indexes(back_txn *ptxn, Slapi_PBlock *pb, struct ldbm
is_ruv = operation_is_flag_set(operation, OP_FLAG_REPL_RUV);
inst = (ldbm_instance *) be->be_instance_info;
- orig_ec_in_cache = *ec_in_cache;
/*
* Update the ID to Entry index.
* Note that id2entry_add replaces the entry, so the Entry ID stays the same.
@@ -1782,7 +1760,6 @@ modrdn_rename_entry_update_indexes(back_txn *ptxn, Slapi_PBlock *pb, struct ldbm
LDAPDebug( LDAP_DEBUG_ANY, "modrdn_rename_entry_update_indexes: id2entry_add failed, err=%d %s\n", retval, (msg = dblayer_strerror( retval )) ? msg : "", 0 );
goto error_return;
}
- *ec_in_cache = 1; /* id2entry_add adds to cache if not already in */
if(smods1!=NULL && slapi_mods_get_num_mods(smods1)>0)
{
/*
@@ -1870,12 +1847,7 @@ modrdn_rename_entry_update_indexes(back_txn *ptxn, Slapi_PBlock *pb, struct ldbm
retval= -1;
goto error_return;
}
- if (orig_ec_in_cache) {
- /* ec was already added to the cache via cache_add_tentative (to reserve its spot in the cache)
- and/or id2entry_add - so it already had one refcount - cache_replace adds another refcount -
- drop the extra ref added by cache_replace */
- CACHE_RETURN( &inst->inst_cache, ec );
- }
+
error_return:
return retval;
}
@@ -1910,8 +1882,6 @@ moddn_rename_child_entry(
int olddncomps= 0;
int need= 1; /* For the '\0' */
int i;
- int e_in_cache = 1;
- int ec_in_cache = 0;
olddn = slapi_entry_get_dn((*ec)->ep_entry);
if (NULL == olddn) {
@@ -1974,8 +1944,7 @@ moddn_rename_child_entry(
* Update all the indexes.
*/
retval = modrdn_rename_entry_update_indexes(ptxn, pb, li, e, ec,
- smodsp, NULL, NULL,
- &e_in_cache, &ec_in_cache);
+ smodsp, NULL, NULL);
/* JCMREPL - Should the children get updated modifiersname and lastmodifiedtime? */
slapi_mods_done(&smods);
}
diff --git a/ldap/servers/slapd/back-ldbm/proto-back-ldbm.h b/ldap/servers/slapd/back-ldbm/proto-back-ldbm.h
index 65cafea..688f293 100644
--- a/ldap/servers/slapd/back-ldbm/proto-back-ldbm.h
+++ b/ldap/servers/slapd/back-ldbm/proto-back-ldbm.h
@@ -87,6 +87,8 @@ int cache_add_tentative(struct cache *cache, struct backentry *e,
int cache_lock_entry(struct cache *cache, struct backentry *e);
void cache_unlock_entry(struct cache *cache, struct backentry *e);
int cache_replace(struct cache *cache, void *oldptr, void *newptr);
+int cache_has_otherref(struct cache *cache, void *ptr);
+int cache_is_in_cache(struct cache *cache, void *ptr);
Hashtable *new_hash(u_long size, u_long offset, HashFn hfn,
HashTestFn tfn);
9 years, 7 months
- 1
- 0
src/com
by Mark Reynolds
src/com/netscape/admin/dirserv/DSContentPage.java | 42 +++++++++++++++++++++-
1 file changed, 41 insertions(+), 1 deletion(-)
New commits:
commit af957c5bdf0a68c60446fef2a5da42181c21b20f
Author: Mark Reynolds <mreynolds(a)redhat.com>
Date: Fri Sep 19 16:17:34 2014 -0400
Ticket 135 - DS console - right clicking an object does not select that object
Bug Description: "right" clicking an object in the suffix tree, or the child
list on the right, does not select that object. This can
lead to accidental operations, e.g. deleting the entire suffix
when you only wanted to delete a user.
Fix Description: For the JTree(suffix trees) simply set the row from the mouse
location. For the Jlist (child list) we need to set the last
focused component to the JList so we can get the correct
child node.
https://fedorahosted.org/389/ticket/135
Reviewed by: rmeggins(Thanks!)
diff --git a/src/com/netscape/admin/dirserv/DSContentPage.java b/src/com/netscape/admin/dirserv/DSContentPage.java
index 6de20a7..bb6de7b 100644
--- a/src/com/netscape/admin/dirserv/DSContentPage.java
+++ b/src/com/netscape/admin/dirserv/DSContentPage.java
@@ -984,12 +984,52 @@ implements IPage,
*/
public void mousePressed(MouseEvent e) {
if ((_contextMenu != null) && (e.isPopupTrigger())) {
+ //
+ // Allow the right click to select the object
+ //
+ int list_index = _list.locationToIndex(e.getPoint());
+ int row = _tree.getRowForLocation(e.getX(), e.getY());
+ boolean tree = false;
+ boolean list = false;
+
+ if (e.getSource() instanceof JTree){
+ tree = true;
+ }
+ if (e.getSource() instanceof JList){
+ list = true;
+ }
+ if(tree && row >= 0){
+ // Select the "clicked" tree node
+ _tree.setSelectionRow(row);
+ } else if (list && list_index >= 0){
+ // Things get a little trickier when dealing with the child list
+ if (_list.getCellBounds(list_index, list_index).contains(e.getPoint())){
+ // Select the "clicked" list node
+ _list.setSelectedIndex( list_index );
+ //
+ // Next, set the lastFocusComponent to the JList so we get the proper
+ // node, otherwise it could be the JTree and that would be bad.
+ //
+ _lastFocusComponent = _list;
+ IBrowserNodeInfo node = getSelectedNodeInfo();
+ if (node != null) {
+ String dn = Helper.getNodeInfoDN(node);
+ if (dn == null || dn.equals("")) {
+ _selectedDnLabel.setText(NO_SELECTED_DN);
+ } else {
+ _selectedDnLabel.setText(findDisplayNameFromNode(node));
+ }
+ _menuController.updateMenuState();
+ }
+ }
+ }
+
if (_contextMenu.getComponentCount() > 0) {
Point p = _treePanel.getViewport().getViewPosition();
_contextMenu.show((Component)e.getSource(), e.getX() - p.x,
e.getY() - p.y);
}
- }
+ }
}
/**
9 years, 7 months
- 1
- 0
lib/libdsa
by Mark Reynolds
lib/libdsa/dsalib_updown.c | 40 ++++++++++++++++++++++------------------
1 file changed, 22 insertions(+), 18 deletions(-)
New commits:
commit d077f9a3b04998c28d0071b7656c34ca7f07e532
Author: Mark Reynolds <mreynolds(a)redhat.com>
Date: Mon Sep 15 12:19:12 2014 -0400
Ticket 47697 - Resource leak in lib/libdsa/dsalib_updown.c
Bug Description: Windows resource leak in StartNetscapeProgram() where
the FILE handle is not closed.
Fix Description: Close FILE handle.
https://fedorahosted.org/389/ticket/47697
Reviewed by: rmeggins(Thanks!)
diff --git a/lib/libdsa/dsalib_updown.c b/lib/libdsa/dsalib_updown.c
index 0bef3ab..f83719b 100644
--- a/lib/libdsa/dsalib_updown.c
+++ b/lib/libdsa/dsalib_updown.c
@@ -526,10 +526,9 @@ StartNetscapeProgram()
{
char line[BIG_LINE], cmd[BIG_LINE];
char *tmp = ds_get_instance_dir();
-
- CHAR ErrorString[512];
- STARTUPINFO siStartInfo;
- PROCESS_INFORMATION piProcInfo;
+ CHAR ErrorString[512];
+ STARTUPINFO siStartInfo;
+ PROCESS_INFORMATION piProcInfo;
FILE *CmdFile;
ZeroMemory(line, sizeof(line));
@@ -538,7 +537,7 @@ StartNetscapeProgram()
CmdFile = fopen(line, "r");
if (!CmdFile)
- {
+ {
PR_snprintf(ErrorString, sizeof(ErrorString), "Error:Tried to start server %s "
": Could not open the startup script %s :Error %d. Please "
"run startsrv.bat from the server's root directory.",
@@ -549,34 +548,39 @@ StartNetscapeProgram()
ZeroMemory(cmd, sizeof(cmd));
if (!fread(cmd, 1, BIG_LINE, CmdFile))
- {
+ {
PR_snprintf(ErrorString, sizeof(ErrorString), "Error:Tried to start server %s "
": Could not read the startup script %s :Error %d. Please "
"run startsrv.bat from the server's root directory.",
ds_get_server_name(), line, errno);
ds_send_error(ErrorString, 0);
+ fclose(CmdFile);
return(DS_SERVER_DOWN);
}
- ZeroMemory(&siStartInfo, sizeof(STARTUPINFO));
- siStartInfo.cb = sizeof(STARTUPINFO);
- siStartInfo.lpReserved = siStartInfo.lpReserved2 = NULL;
- siStartInfo.cbReserved2 = 0;
- siStartInfo.lpDesktop = NULL;
-
- if (!CreateProcess(NULL, cmd, NULL, NULL, FALSE,
- 0, NULL, NULL, &siStartInfo, &piProcInfo))
- {
+ /* We're done with the file handle, close it */
+ fclose(CmdFile);
+
+ ZeroMemory(&siStartInfo, sizeof(STARTUPINFO));
+ siStartInfo.cb = sizeof(STARTUPINFO);
+ siStartInfo.lpReserved = siStartInfo.lpReserved2 = NULL;
+ siStartInfo.cbReserved2 = 0;
+ siStartInfo.lpDesktop = NULL;
+
+ if (!CreateProcess(NULL, cmd, NULL, NULL, FALSE,
+ 0, NULL, NULL, &siStartInfo, &piProcInfo))
+ {
PR_snprintf(ErrorString, sizeof(ErrorString), "Error:Tried to start server %s "
": Could not start up the startup script %s :Error %d. Please "
"run startsrv.bat from the server's root directory.",
ds_get_server_name(), line, GetLastError());
ds_send_error(ErrorString, 0);
return(DS_SERVER_DOWN);
- }
+ }
+
+ CloseHandle(piProcInfo.hProcess);
+ CloseHandle(piProcInfo.hThread);
- CloseHandle(piProcInfo.hProcess);
- CloseHandle(piProcInfo.hThread);
return(DS_SERVER_UP);
}
9 years, 7 months
- 1
- 0
Changes to 'refs/tags/389-ds-base-1.3.3.3'
by Richard Allen Megginson
Changes since 389-ds-base-1.2.6.a1:
Anupam Jain (9):
Ticket 123 - Enhancement request:"whoami" extended operation
Ticket 123 - Enhancement request:"whoami" extended operation
Ticket 123 - Enhancement request:"whoami" extended operation
Ticket #47423 - 7-bit check plugin does not work for userpassword attribute
Ticket #47363 - 7-bit checking is not necessary for userPassword
Ticket #47431 - Duplicate values for the attribute nsslapd-pluginarg are not handled correctly
Ticket #47370 - DS crashes with some 7-bit check plugin configurations
Ticket #617 - Possible to add invalid ACI value
Ticket #626 - Possible to add nonexistent target to ACI
Carsten Grzemba (2):
Ticket #555 - add fixup-memberuid.pl script
Ticket #555 - add fixup-memberuid.pl script
Charles Lopes (1):
Bug #361: Bad DNs in ACIs can segfault ns-slapd
Endi S. Dewata (168):
Bug 545620 - Password cannot start with minus sign
Bug 538525 - Ability to create instance as non-root user
Bug 570542 - Root password cannot contain matching curly braces
Bug 470684 - Pam_passthru plugin doesn't verify account activation
Bug 573375 - MODRDN operation not logged
Bug 520151 - Error when modifying userPassword with proxy user
Bug 455489 - Address compiler warnings about strict-aliasing rules
Bug 566320 - RFE: add exception to removal of attributes in cn=config for aci
Bug 566043 - startpid file is only cleaned by initscript runs
Bug 584109 - Slapd crashes while parsing DNA configuration
Bug 542570 - Directory Server port number is not validated in the beginning.
Bug 145181 - Plugin target/bind subtrees only take 1 value.
Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891
Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891
Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891
Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891
Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891
Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891
Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891
Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891
Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891
Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891
Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891
Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891
Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891
Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891
Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891
Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891
Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891
Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891
Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891
Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891
Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891
Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136
Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136
Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136
Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136
Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136
Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136
Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136
Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136
Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136
Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136
Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136
Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136
Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136
Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136
Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136
Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136
Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136
Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166
Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166
Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166
Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166
Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166
Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166
Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166
Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166
Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166
Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166
Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166
Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166
Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166
Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166
Bug 628096 - spurious error message from /sbin/service when doing a stop on no instances
Bug 573889 - Migration does not remove deprecated schema
Bug 606545 - core schema should include numSubordinates
Bug 643979 - Strange byte sequence for attribute with no values (nsslapd-referral)
Endi Sukma Dewata (16):
Bug 630092 - Coverity #12117: Resource leaks issues
Bug 630092 - Coverity #15478: Resource leaks issues
Bug 630092 - Coverity #15479: Resource leaks issues
Bug 630092 - Coverity #15481: Resource leaks issues
Bug 630092 - Coverity #15482: Resource leaks issues
Bug 630092 - Coverity #15483: Resource leaks issues
Bug 630092 - Coverity #15484: Resource leaks issues
Bug 630092 - Coverity #15485: Resource leaks issues
Bug 630092 - Coverity #15487: Resource leaks issues
Bug 630092 - Coverity #15490: Resource leaks issues
Bug 630092 - Coverity #15497: Resource leaks issues
Bug 630092 - Coverity #11991: Resource leaks issues
Bug 630092 - Coverity #12000: Resource leaks issues
Bug 630092 - Coverity #12003: Resource leaks issues
Bug 630092 - Coverity #11985: Resource leaks issues
Bug 630092 - Coverity #11992,11993: Resource leaks issues
Jeroen van Meeuwen (Kolab Systems) (1):
Suppress alert on unavailable port with forced setup
Jonathan \"Duke\" Leto (1):
fix for trac #173; update ds-logpipe.py docs about -t option
Ken Rossato (8):
Factorize into new isPosixGroup function
Change "return"s in modGroupMembership to "break"s to avoid leaking
Memory leaks: unmatched slapi_attr_get_valueset and slapi_value_new
Simplify program flow: eliminate unnecessary continue
Simplify program flow: make adduids/moduids/deluids action blocks all similar
Fix logic errors: del_mod should be latched (might not be last mod), and avoid skipping add-mods (int value 0)
Simplify program flow: change while loops to for
Ticket #481 - expand nested posix groups
Ludwig Krispenz (64):
Fix for ticket 510
Fix for ticket 465: cn=monitor showing stats for other db instances
Fix for ticket 504
Ticket 349 - nsViewFilter syntax issue in 389DS 1.2.5
Ticket 518 - dse.ldif is 0 length after server kill or machine kill
Ticket 505 - use lock-free access name2asi and oid2asi table
Fix optimization issue introduced with fix for ticket #561,
modify operations without values need to be written to the changelog
Reduce replication meta data stored in entry, cf ticket 569
Fix compiler warnings introduced by fix for #569
removing an unused variable, did also remove an assigment
Ticket 568 - make usage of transaction batch flush durable
fix hang related to ticket 568
Ticket 47358 - implement backend optimazation levels
Ticket 47396 - crash on modrdn of tombstone
Ticket 47395 47397 v2 correct behaviour of account policy if only stateattr
fix compiler warnings, caused by fix for 47395,47397
Ticket 47399 - RHDS denies MODRDN access if ACI list contains any DENY rule
Ticket 47369 version2 - provide default syntax plugin
Fix compiler warning
Ticket 346 - version 4 Slow ldapmodify operation time
fix compiler warnings
CVE-2013-2219 ACLs inoperative in some search scenarios
fix compiler warning
Ticket 47502 - updates to ruv entry are written to retro changelog
Fix regression from fix for 569, when the last value of an attribute was explicitely deleted
Ticket 47505 - Get rid of valueset_add_valuearray_ext
Ticket 47487 - enhance retro changelog
Ticket 314 - ChaiOnUpdate for root handling
Use defines for backend error handling
Ticket 601 - multi master replication allows schema violation
Ticket 47388 - RFE to implement RFC4533 -ver2
Fix for coverty issues 12028,12029,12030
Ticket 47577 - crash when removing entries from cache
Ticket 47521 - Complex filter in a search request doen't work as expected.
Ticket 47591 - entries with empty objectclass attribute value can be hidden
Ticket 47527 - Allow referential integrity suffixes to be configurable
Ticket 47526 - Allow memberof suffixes to be configurable
Ticket 47612 - ns-slapd eats all the memory
simplify fix for 47612
Ticket 47621 - v2 make referential integrity configuration more flexible
Ticket 47629 - random crashes related to sync repl
Ticket 47704 - invalid sizelimits in aci group evaluation
Ticket 47732 - ds logs many "SLAPI_PLUGIN_BE_TXN_POST_DELETE_FN plugin returned error" messages
Ticket 47733 - ds logs many "Operation error fetching Null DN" messages
Ticket 47667 - Allow nsDS5ReplicaBindDN to be a group DN
Ticket 47712 - betxn: retro changelog broken after cancelled transaction
fix assertion failure introduced with fix for ticket 47667
Ticket 47761 - Return all attributes in rootdse without explicit request
fix jenkins warning
Ticket 47806 - Failed deletion of aci: no such attribute
Ticket 47805 - syncrepl doesn't send notification when attribute in search filter changes
Ticket 47803 - syncrepl crash if attribute list is non-empty
fix coverity issue 12621
fix compiler error with alst coverity commit
Ticket 47821 - deref plugin cannot handle complex acis
Ticket #47750 - Creating a glue fails if one above level is a conflict or missing
Ticket 47846 - server crashes deleting a replication agreement
Ticket 47872 - Filter AND with only one clause should be optimized
Ticket 47877 - check_and_add_entry fails for changetype: add and existing entry
Ticket 47816 -v2- internal syncrepl searches are flagged as unindexed
Ticket 47866 - Errors after upgrading related to attribute "dnaremotebindmethod"
Ticket 47885 - deref plugin should not return references with noc access rights
fix for 47885 did not always return a response control
Mark Reynolds (360):
Ticket #71 - unable to delete managed entry config
Ticket #159 - Managed Entry Plugin runs against managed entries upon any update without validating
Ticket #177 - logconv.pl doesn't detect restarts
Merge branch 'ticket159'
Ticket #49 - better handling for server shutdown while long running tasks are active
Ticket #50 - server should not call a plugin after the plugin close function is calle
Updated for ticket#50
Ticket #55 - Limit of 1024 characters for nsMatchingRule
Ticket #140 - incorrect memset parameters
Revert "Ticket #140 - incorrect memset parameters"
Revert "Ticket #55 - Limit of 1024 characters for nsMatchingRule"
Ticket #38 - nisDomain schema is incorrect
Ticket #6 - protocol error from proxied auth operation
Ticket #55 - Limit of 1024 characters for nsMatchingRule
Ticket #39 - Account Policy Plugin does not work for simple binds when PAM Pass Through Auth plugin is enabled
Ticket 175 - logconv.pl improvements
Ticket 175 - minor fixes
Ticket #17 - Replication optimizations
Ticket #17 - new replication optimizations
Ticket #129 - Should only update modifyTimestamp/modifiersName on MODIFY ops
Ticket #111 - ability to control behavior of modifyTimestamp/modifiersName
Ticket #211 - dnaNextValue gets incremented even if the user addition fails
Ticket #74 - Add schema for DNA plugin (RFE)
Ticket #306 - void function cannot return value
Ticket #302 - use thread local storage for internalModifiersName & internalCreatorsName
Schema Reload crash fix
Ticket #291 - cannot use & in a sasl map search filter
Ticket #305 - Certain CMP operations hang or cause ns-slapd to crash
Ticket #191 - Implement SO_KEEPALIVE in network calls
Config changes fail because of unknown attribute "internalModifiersname"
Ticket #292 - logconv.pl reporting unindexed search with different search base than shown in access logs
Ticket #308 - Automembership plugin fails if data and config area mixed in the plugin configuration
Ticket #271 - replication code cleanup
TIcket #285 - compilation fixes for '--format-security'
Ticket #271 - Slow shutdown when you have 100+ replication agreements
Ticket #24 - Add nsTLS1 to the DS schema
Ticket #319 - ldap-agent crashes on start with signal SIGSEGV
Ticket #20 - Allow automember to work on entries that have already been added
Ticket #315 - ns-slapd exits/crashes if /var fills up
Ticket #315 - small fix to libglobs
Ticket #183 - passwordMaxFailure should lockout password one sooner - and should be configurable to avoid regressions
Coverity Fixes
Ticket #325 - logconv.pl : use of getopts to parse command line options
Ticket #183 - passwordMaxFailure should lockout password one sooner
Ticket #207 - [RFE] enable attribute that tracks when a password was last set
Ticket #214 - Adding Replication agreement should complain if required nsds5ReplicaCredentials not supplied
Ticket #337 - Improve CLEANRUV task
Ticket #356 - RFE - Track bind info
Ticket #196 - RFE: Interpret IPV6 addresses for ACIs, replication, and chaining
Ticket #218 - Make RI Plugin worked with replicated updates
Ticket 367 - Invalid chaining config triggers a disk full error and shutdown
Ticket 365 - passwords in clear text in the audit log
Ticket #321 - krbExtraData is being null modified and replicated on each ssh login
Ticket #110 - RFE limiting root DN by host, IP, time of day, day of week
Ticket 368 - Make the cleanAllRUV task one step
Ticket #28 - MOD operations with chained delete/add get back error 53 on backend config
Ticket #369 - restore of replica ldif file on second master after deleting two records shows only 1 deletion
Update the slapi-plugin documentation on new slapi functions, and added a slapi function for checking on shutdowns
Ticket #388 - Improve replication agreement status messages
COVERITY FIXES
Coverity Fix
Ticket 366 - Change DS to purge ticket from krb cache in case of authentication error
Ticket 399 - slapi_ldap_bind() doesn't check bind results
Ticket 328 - make sure all internal search filters are properly escaped
Ticket 413 - "Server is unwilling to perform" when running ldapmodify on nsds5ReplicaStripAttrs
Ticket 403 - CLEANALLRUV feature
Ticket 407 - memory leak in dna plugin
Ticket 403 - cleanallruv coverity fixes
Misc Coverity Fixes
Ticket 407 - dna memory leak
Ticket 403 - CLEANALLRUV amendment
Ticket 403 - CLEANALLRUV - revision to last amendment
Ticket 403 - fix CLEANALLRUV regression from last commit
Ticket 429 - Add nsslapd-readonly to schema
CLEANALLRUV coverity fixes
Ticket 436 - nsds5ReplicaEnabled can be set with any invalid values.
Ticket 386 - Overconsumption of memory with large cachememsize and heavy use of ldapmodify
Ticket 450 - CLEANALLRUV task gets stuck on winsync replication agreement
Ticket 452 - automember rebuild task adds users to groups that do not match the configuration scope
Ticket 408 - create a normalized dn cache
Ticket 467 - CLEANALLRUV abort task should be able to ignore down replicas
Ticket 747 - Root DN Access Control - days allowed not working correctly
Ticket 475 - Root DN Access Control - improve value checking for config
Ticket 473 - change VERSION.sh to have console version be major.minor
Coverity issue 13091
Ticket 457 - dirsrv init script returns 0 even when few or all instances fail to start
Ticket 477 - CLEANALLRUV if there are only winsync agmts task will hang
Ticket 478 - passwordTrackUpdateTime stops working with subtree password policies
Ticket #446 - anonymous limits are being applied to directory manager
Ticket 488 - Doc: DS error log messages with typo
Ticket 486 - nsslapd-enablePlugin should not be multivalued
Ticket 468 - if pam_passthru is enabled, need to AC_CHECK_HEADERS([security/pam_appl.h])
Ticket 495 - internalModifiersname not updated by DNA plugin
Revert "Ticket 495 - internalModifiersname not updated by DNA plugin"
Ticket 495 - internalModifiersname not updated by DNA plugin
Ticket 147 - Internal Password Policy usage very inefficient
Ticket 517 - crash in DNA if no dnaMagicRegen is specified
Ticket 507 - use mutex for FrontendConfig lock instead of rwlock
Ticket 394 - modify-delete userpassword
Ticket 337 - improve CLEANRUV functionality
Coverity Fixes
Ticket 20 - Allow automember to work on entries that have already been added
Ticket 393 - Change in winSyncInterval does not take immediate effect
Ticket 216 - disable replication agreements
Ticket 395 - RFE: 389-ds shouldn't advertise in the rootDSE that we can handle a sasl mech if we really can't
Ticket 527 - ns-slapd segfaults if it cannot rename the logs
Ticket 509 - lock-free access to be->be_suffixlock
Merge branch 'ticket509'
Ticket 456 - improve entry cache sizing
Ticket 509 - lock-free access to be->be_suffixlock
Ticket 511 - allow turning off vattr lookup in search entry return
Ticket 541 - RootDN Access Control plugin is missing after upgrade
Ticket 541 - need to set plugin as off in ldif template
Ticket 534 - RFE: Add SASL mappings fallback
Ticket 534 - sasl mapping fallback
Ticket 532 - RUV is not getting updated for both Master and consumer
Ticket 534 - Add SASL mappings fallback
Ticket 534 - SASL Mapping Fallback
Ticket 539 - logconv.pl should handle microsecond timing
Ticket 471 - logconv.pl tool removes the access logs contents if "-M" is not correctly used
Ticket 552 - Adding rootdn-open-time without rootdn-close-time to RootDN Acess Control results in inconsistent configuration
Ticket 551 - Multivalued rootdn-days-allowed in RootDN Access Control plugin always results in access control violation
TIcket 419 - logconv.pl - improve memory management
Ticket 419 - logconv.pl - improve memory management
Ticket 558 - Replication - make timeout for protocol shutdown configurable
Ticket 417 - RFE - forcing passwordmustchange attribute by non-cn=directory manager
Ticket 562 - Crash when deleting suffix
Merge branch 'master' of ssh://git.fedorahosted.org/git/389/ds
Ticket 532 - RUV is not getting updated for both Master and consumer
Ticket 433 - multiple bugs in start-dirsrv, stop-dirsrv, restart-dirsrv scripts
Ticket 433 - multiple bugs in start-dirsrv, stop-dirsrv, restart-dirsrv scripts
Ticket 570 - DS returns error 20 when replacing values of a multi-valued attribute (only when replication is enabled)
Ticket 528 - RFE - get rid of instance specific scripts
Coverity Fixes
Ticket 528 - RFE - get rid of instance specific scripts (part 2)
Ticket 332 - Command line perl scripts should attempt most secure connection type first
Ticket 332 - Fix usage in scripts
Ticket 332 - minor quoting issue in a few scripts.
Ticket 588 - Create MAN pages for command line scripts
Ticket 332 - wrong argument count in ldif2db
Ticket 571 - server does not accept 0 length LDAP Control sequence
Ticket 583 - dirsrv fails to start on reboot due to /var/run/dirsrv permissions
Ticket 574 - problems with dbcachesize disk space calculation
Ticket 623 - cleanAllRUV task fails to cleanup config upon completion
Ticket 574 - problems with dbcachesize disk space calculation
Ticket 458 - RFE - Make it possible for privileges to be provided to an admin user
Ticket 611 - logconv.pl missing stats for StartTLS, LDAPI, and AUTOBIND
Ticket 622 - DS logging errors "libdb: BDB0171 seek: 2147483648: (262144 * 8192) + 0: No such file or directory
Ticket 525 - Introducing a user visible configuration variable for controlling replication retry time
Ticket 632 - 389-ds-base cannot handle Kerberos tickets with PAC
Ticket 587 - Replication error messages in the DS error logs
Ticket 458 - Need to properly check if the password admin dn is set
Ticket 628 - crash in aci evaluation
Ticket 620 - Better logging of error messages for 389-ds-base
Ticket 534 - RFE: Add SASL mappings fallback
Ticket 550 - posix winsync will not create memberuid values if group entry become posix group in the same sync interval
Ticket 631 - Replication: "Incremental update started" status message without consumer initialized
Ticket 47311 - segfault in db2ldif(trigger by a cleanallruv task)
Ticket 47304 - reinitialization of a master with a disabled agreement hangs
Ticket 47315 - filter option in fixup-memberof requires more clarification
Ticket 77 - [RFE] Add ACI support for ldapi
Ticket 47317 - should set LDAP_OPT_X_SASL_NOCANON to LDAP_OPT_ON by default
Ticket 205 - Fix compiler warning
Ticket 153 - use openldap's schema parser
Ticket 47299 - fix config file and server id processing
Ticket 580 - Wrong error code return when using EXTERNAL SASL and no client certificate
Fix coverity issues
Ticket 47317 - should set LDAP_OPT_X_SASL_NOCANON to LDAP_OPT_ON by default - revision
Ticket 47355 - dse.ldif doesn't replicate update to nsslapd-sasl-mapping-fallback
Ticket 511 - Revision - allow turning off vattr lookup in search entry return
Ticket 47337 - mep_pre_op: Unable to fetch origin entry
Ticket 283 - Expose slapi_eq_* API
Ticket 47340 - Deleting a separator ',' in 7-bit check plugin arguments makes the
Ticket 47326 - idl switch does not work
Merge branch 'ticket47326'
Ticket 589 - RFE - Support RFC 4527 Read Entry Controls
Ticket 47372 - make old-idl tunable
Coverity Fixes (part 1)
Coverity Fixes (Part 2)
Coverity Fixes (Part 3)
Coverity Fixes (Part 4)
Coverity Fixes (Part 5)
Ticket 47385 - DS not shutting down when disk monitoring threshold is reached
Fri Jun 7 10:41:00 2013 -0400
Ticket 47383 - connections attribute in cn=snmp,cn=monitor is counted twice
Ticket 47376 - DESC should not be empty as per RFC 2252 (ldapv3)
Ticket 47379 - DNA plugin failed to fetch replication agreement
Coverity (Part 7) + Jenkins fix
Ticket 47389 - Non-directory manager can change the individual userPassword's storage scheme
Ticket 47329 - Improve slapi_back_transaction_begin() return code when transactions are not available
Coverity Fixes
Ticket 47381 - nsslapd-db-transaction-batch-val turns to -1
Ticket 47385 - Disk Monitoring is not triggered as expected.
Ticket 47427 - Overflow in nsslapd-disk-monitoring-threshold
Ticket 47416 - SASL encrypted packet length exceeds maximum allowed limit
Ticket 47421 - memory leaks in set_krb5_creds
Ticket 47427 - Overflow in nsslapd-disk-monitoring-threshold
Ticket 47441 - Disk Monitoring not checking filesystem with logs
Ticket 47382 - Add a warning message when a connection hits the max number of threads
Ticket 47449 - deadlock after adding and deleting entries
Ticket 47427 - Overflow in nsslapd-disk-monitoring-threshold
Ticket 47450 - Fix compiler formatting warning errors for 32/64 bit arch
Ticket 47447 - logconv.pl man page missing -m,-M,-B,-D
Ticket 47323 - resurrected entry is not correctly indexed
Ticket 47440 - Fix compilation warnings and header files
Ticket 47440 - Fix runtime errors caused by last patch.
Ticket 47411 - Replace substring search with plain search in referint plugin
Ticket 47425 - should only call windows_update_done if repl agmt type is windows
Ticket 47426 - move compute_idletimeout out of handle_pr_read_ready
Ticket47426 - Coverity issue with last commit(move compute_idletimeout out of handle_pr_read_ready)
Ticket 47473 - setup-ds.pl doesn't lookup the "root" group correctly
Ticket 47461 - logconv.pl - Use of comma-less variable list is deprecated
Ticket 47384 - Plugin path validation returntext not set correctly
Ticket 47394 - remove-ds.pl should remove /var/lock/dirsrv
Ticket 47371 - Some updates of "passwordgraceusertime" are useless when updating "userpassword"
Ticket 47306 - execute index_add_mods only for indexed attributes
Ticket 47500 - start-dirsrv/restart-dirsrv/stop-disrv do not register with systemd correctly
Ticket 411 - [RFE] mods optimizer
Ticket 47507 - automember rebuild task not working as expected
Ticket 47512 - backend txn plugin fixup tasks should be done in a txn
Coverity fix - 11952
Ticket 47401 - report unindexed internal searches
Ticket 47520 - Fix various issues with logconv.pl
Ticket 47509 - CLEANALLRUV doesnt run across all replicas
Ticket 47509 - Cleanallruv jenkins error
Ticket 47513 - tmpfiles.d references /var/lock when they should reference /run/lock
Ticket 47528 - 389-ds-base built with mozldap can crash from invalid free
Ticket 47510 - 389-ds-base does not compile against MozLDAP libraries
Ticket 47532 - 1.3.1 with mozldap crashes in new operation work_q code
Ticket 47510 - Repl Sync does not compile against MozLDAP libraries
Ticket 47510 - remove unnecessary typedef
Ticket 47513 - Refine the check for @localrundir@
Ticket 47513 - Set localrundir outside of the "with-fhs" block
Ticket 47543 - Mozldap - fix compiler warnings
Ticket 47531 - Mozldap - need to rewrite sasl_io_recv
Ticket 47510 - Additional mozldap failures with Repl Sync
Ticket 47522 - Password adminstrators should be able to voilate password policy
Ticket 47491 - Update systemd service file to use PartOf directive
Ticket 47517 - memory leak in range searches and other various leaks
Ticket 47535 - Logconv.pl - RFE - add on option for a minimum etime for unindexed search stats
Ticket 47535 - update man page
Ticket 47499 - if nsslapd-cachememsize set to the number larger than
Ticket 47436 - 389-ds-base - shebang with /usr/bin/env
Coverity Issue 12033
Ticket 47538 - RFE: repl-monitor.pl plain text output, cmdline config options
Ticket 47519 - memory leaks in access control
Ticket 47368 - IPA server dirsrv RUV entry data excluded from replication
Ticket 47368 - Fix Jenkins errors
Ticket 47368 - Fix coverity issues
Ticket 47582 - agmt_count in Replica could become (PRUint64)-1
Ticket 47541 - Replication of the schema may overwrite consumer 'attributetypes' even
Ticket 47541 - Fix Jenkins errors
Ticket 47597 - Convert retro changelog plug-in to betxn
Ticket 47598 - Convert ldbm_back_seq code to be transaction aware
Ticket 47529 - Automember plug-in should treat MODRDN operations as ADD operations
Ticket 47599 - Reduce lock scope in retro changelog plug-in
Revert "Ticket 47599 - Reduce lock scope in retro changelog plug-in"
Ticket 47599 - Reduce lock scope in retro changelog plug-in
Ticket 47525 - Allow memberOf to use an alternate config area
Ticket 47525 - Fix memory leak
Ticket 47599 - fix memory leak
Ticket 47593 - Update plugin API for OTP plugin
Ticket 47457 - default nsslapd-sasl-max-buffer-size should be 2MB
Ticket 47592 - automember plugin task memory leaks
Ticket 47525 - Need to add locking around config area access
Ticket 47613 - Impossible to configure nsslapd-allowed-sasl-mechanisms
Ticket 47614 - Possible to specify invalid SASL mechanism in nsslapd-allowed-sasl-mechanisms
Ticket 47603 - Allow RI plugin to use alternate config area
Ticket 47587 - hard coded limit of 64 masters in agreement and changelog code
Ticket 47368 - fix memory leaks
Ticket 47620 - 389-ds rejects nsds5ReplicaProtocolTimeout attribute
Ticket 47622 - Automember betxnpreoperation - transaction not aborted when group entry does not exist
Ticket 47627 - changelog iteration should ignore cleaned rids when getting the minCSN
Ticket 47601 - Plugin library path validation prevents intentional loading of out-of-tree modules
Ticket 47617 - allow configuring changelog trim interval
Ticket 47613 - Issues setting allowed mechanisms
Ticket 47603 - should not modify pre op entry during config validation
Ticket 47620 - Config value validation improvement
Ticket 47620 - Fix logically dead code.
Ticket 47627 - Fix replication logging
Ticket 47620 - Fix dereferenced NULL pointer in agmtlist_modify_callback()
Ticket 47620 - Fix missing left bracket
Ticket 47653 - Need a way to allow users to create entries assigned to themselves
Ticket 47654 - Cleanup old memory leaks reported from valgrind
Ticket 47654 - fix double free
Ticket 408 - Fix crash when disabling/enabling the setting
Ticket 47620 - Unable to delete protocol timeout attribute
Ticket 47641 - 7-bit check plugin not checking MODRDN operation
Ticket 47638 - Overflow in nsslapd-disk-monitoring-threshold on 32bit platform
Ticket 47618 - Enable normalized DN cache by default
Ticket 47437 - Some attributes in cn=config should not be multivalued
Ticket 47615 - Failed to compile the DS 389 1.3.2.3 version against Berkeley DB 4.2 version
Ticket 47552 - logconv: unindexed report should list bind dn
Ticket 525 - Replication retry time attributes cannot be added
Ticket 47453 - configure SASL/GSSAPI/Kerberos without server restart
Ticket 47727 - Updating nsds5ReplicaHost attribute in a replication agreement fails with error 53
Ticket 47637 - rsa_null_sha should not be enabled by default
Ticket 47729 - Directory Server crashes if shutdown during a replication initialization
Ticket 47700 - Fix compiler warnings
Ticket 47722 - rsearch filter error on any search filter
Ticket47722 - Fixed filter not correctly identified
Ticket 47740 - Coverity Fixes (Mark - part 1)
Ticket 47740 - Fix sync plugin resource leaks
Ticket 47640 - Fix coverity issues - part 3
Ticket 47740 - Fix coverity erorrs - Part 4
Ticket 47740 - Fix coverity issues - Part 5
Ticket 47740 - Fix coverity issues: null deferences - Part 6
Ticket 47740 - Crash caused by changes to certmap.c
Revert "Ticket 47700 - Fix compiler warnings"
Ticket 47743 - Memory leak with proxy auth control
Ticket 47451 - add/enable/disable/remove plugins without server restart
Ticket 47740 - Fix coverity issues(part 7)
Ticket 47756 - Improve import logging and abort processing
Ticket 47759 - Crash in replication when server is under write load
Ticket 47655 - Improve replication total update logging
Ticket 47766 - Tombstone purging can crash the server if the backend is stopped/disabled
Ticket 47767 - Nested tombstones become orphaned after purge
Ticket 47771 - Performing deletes during tombstone purging results in operation errors
Ticket 47782 - Parent numbordinate count can be incorrectly updated if an error occurs
Ticket 47779 - Part of DNA shared configuration is deleted after server restart
Ticket 47771 - Move parentsdn initialization to avoid crash
Ticket 477779 - Need to lock server list when removing list
Ticket 47792 - code cleanup
Ticket 47792 - database plugins need a way to call betxn
Ticket 47793 - Server crashes if uniqueMember is invalid syntax and memberOf
Ticket 47756 - fix coverity issues
Ticket 47772 - fix coverity issue
Ticket 47451 - Remove old code from linked attr plugin
Ticket 47670 - Aci warnings in error log
Ticket 47636 - errorlog-level 16384 is listed as 0 in cn=config
Ticket 47713 - Logconv.pl with an empty access log gives lots of errors
Ticket 47446 - logconv.pl memory continually grows
Ticket 47791 - Negative value of nsSaslMapPriority is not
Ticket 47644 - Managed Entry Plugin - transaction not aborted upon failure to create managed entry
Ticket 47466 - Fix coverity issue
Ticket 47813 - managed entry plugin fails to update member
Ticket 47602 - txn commit being performed too early
Ticket 47815 - Add operations rejected by betxn plugins remain in cache
Ticket 47810 - investigate betxn plugins to ensure they
Ticket 47817 - The error result text message should be obtained just prior to sending result
Ticket 47827 - online import crashes server if using verbose error logging
Ticket 47815 - add lib389 test
Ticket 47827 - Fix coverity issue 12695
Ticket 47779 - Potential deadlock after startup if a dna configuration change is made
Ticket 47781 - Server deadlock if online import started while
Ticket 47781 - Add CI test
Ticket 47781 - CI test - use predefined property name variables
Ticket 47654 - Fix regression (deadlock/crash)
Ticket 47858 - Internal searches using OP_FLAG_REVERSE_CANDIDATE_ORDER can crash the server
Ticket 47819 - Improve tombstone purging performance
Ticket 47855 - clear tmp directory at the start of each test
Ticket 47855 - Fix previous commit
Ticket 47853 - client hangs in add if memberof fails
Ticket 437853 - Missing newline at end of the error log messages in memberof
Ticket 47710 - Missing warning for invalid replica backoff configuration
Ticket 47790 - Integer config attributes accept invalid
Ticket 47812 - logconv.pl missing -U option from usage
Ticket 47861 - Certain schema files are not replaced during upgrade
Ticket 47819 - Fix memory leak
Ticket 47862 - repl-monitor fails to convert "*" to default values
Matthew Via (1):
Ticket #47428 - Memory leak in 389-ds-base 1.2.11.15
Nathan Kinder (212):
Bug 549554 - Trim single-valued attributes before sending to AD
Improve search for pcre header file
Bug 434735 - Allow SASL ANONYMOUS mech to work
Bug 570912 - Avoid selinux context conflict with httpd
Allow instance name to be parsed from start-slapd
Add managed entries plug-in
Bug 572355 - Label instance files and ports during upgrade.
Bug 578863 - Password modify extop needs to send referrals on replicas
Bug 584156 - Remove ldapi socket file during upgrade
Fix rsearch usage of name files for random filters
Bug 584497 - Allow DNA plugin to set same value on multiple attributes
Add replication session hooks
Correct function prototype for repl session hook
Bug 592389 - Set anonymous resource limits properly
Bug 601433 - Add man pages for start-dirsrv and related commands
Bug 604263 - Fix memory leak when password change is rejected
Bug 612242 - membership change on DS does not show on AD
Bug 613833 - Allow dirsrv_t to bind to rpc ports
Bug 594745 - Get rid of dirsrv_lib_t label
Bug 620927 - Allow multiple membership attributes in memberof plugin
Bug 612264 - ACI issue with (targetattr='userPassword')
Bug 630098 - fix coverity Defect Type: Code maintainability issues
Bug 630098 - fix coverity Defect Type: Code maintainability issues
Bug 630093 - (cov#15511) Don't use unintialized search_results in refint plugin
Bug 630093 - (cov#15518) Need to intialize fd in ldbm2ldif code
Bug 630096 - (cov#11778) check return value of ldap_parse_result
Bug 630096 - (cov#15446) check return value of ber_scanf()
Bug 630096 - (cov#15449,15450) Check return value of stat()
Bug 630096 - (cov#15448) Check return value of cache_replace()
Bug 630096 - (cov#15447) - Check return value of idl_append_extend()
Bug 630090 - (cov#11974) Remove unused ACL functions
Bug 630090 - (cov#15445) Fix illegal free in archive code
Bug 630094 - (cov#11818) Fix unreachable return in snmp subagent
Bug 630094 - (cov#15451) Get rid of unreachable free statements
Bug 630094 - (cov#15452) Remove NULL checking for op_string
Bug 630094 - (cov#15453) Eliminate NULL check for local_newentry
Bug 630094 - (cov#15454) Fix deadcode issue in mapping tree code
Bug 630094 - (cov#15455) Remove deadcode in attr_index_config()
Bug 630094 - (cov#15456) Remove NULL check for srdn in import code
Bug 630094 - (cov#15457) Remove deadcode in import code
Bug 630094 - (cov#15458) Fix deadcode issue in moddn code
Bug 630094 - (cov#15459) Remove NULL check for srdn in ldif2ldbm code
Bug 630094 - (cov#15520) Fix unreachable code issue if perfctrs code
Bug 630094 - (cov#15581) Add missing breaks in agt_mopen_stats()
Bug 690090 - (cov#11974) Remove additional unused ACL functions
Bug 630091 - (cov#15512) Fix usage of uninitialized bervals
Bug 630091 - (cov#15513) Fix usage of uninitialized bervals
Bug 630091 - (cov#15514) Initialize DBT in entryrdn_get_parent()
Bug 630091 - (cov#15515) Use of uninitialized array in index config code
Bug 630091 - (cov#15516,15517) Initialize pointers before attempting to free
Bug 630091 - (cov#15519) Initialize bervals in search_easter_egg()
Bug 630091 - (cov#15582) Free of uninitialized pointer in attr_index_config()
Bug 630097 - (cov#11933) Fix NULL dereference in schema code
Bug 630097 - (cov#11938) NULL dereference in mmldif
Bug 630097 - (cov#11946) NULL dereference in ResHashCreate()
Bug 630097 - (cov#11964) Remove dead code from libaccess
Bug 630097 - (cov#12143) NULL dereference in cos cache code
Bug 630097 - (cov#12148) NULL dereference in ruvInit()
Bug 630097 - (cov#12182,12183) NULL dereference in import code
Bug 630097 - (cov#15460) NULL deference in ACL URL code
Bug 630097 - (cov#15461) Remove unnecessary NULL check in DNA
Bug 630097 - (cov#15462) NULL dereference in mep_modrdn_post_op()
Bug 630097 - (cov#15463) Remove NULL check in referint plugin
Bug 630097 - (cov#15464) NULL dereference in repl code
Bug 630097 - (cov#15465) Null dereference in USN code
Bug 630097 - (cov#15473) NULL dereference in ResHashCreate()
Bug 630097 - (cov#15505) NULL dereference in memberOf code
Bug 630097 - (cov#15506) NULL dereference in dblayer code
Bug 630097 - (cov#15507,15508) NULL dereference in entryrdn code
Bug 630097 - (cov#15509) NULL dereference in idsktune
Bug 630097 - (cov#11938) NULL dereference in mmldif
Bug 630097 - (cov#15477) NULL dereference in ACL plug-in code
Bug 630091 - (cov#12209) Use of uninitialized pointer in libaccess
Bug 630092 - (cov#12116) Resource leak in ldclt code
Bug 630092 - (cov#12105) Resource leak in pwdscheme config code
Bug 630092 - (cov#12068) Resource leak in certmap code
Bug 630091 - (cov#11973) Array overrun in libaccess
Bug 522055 - Scope check for managed attribute fails
Bug 625335 - Self-write aci has permission to invalid attribute
Bug 631993 - Log authzid when proxy auth control is used
Cov #16300 - Unused variable in account policy plugin
Bug 544321 - remove-ds.pl should not throw error unlabelling port
Bug 555955 - Allow CoS values to be merged
Bug 643937 - Initialize replication version flags
Bug 305131 - Allow empty modify operation
Bug 619633 - Make attribute uniqueness obey requiredObjectClass
Bug 619623 - attr-unique-plugin ignores requiredObjectClass on modrdn operations
Bug 189985 - Improve attribute uniqueness error message
Bug 647932 - multiple memberOf configuration adding memberOf where there is no member
Bug 521088 - DNA should check ACLs before getting a value from the range
Bug 635009 - Add one-way AD sync capability
Bump VERSION.sh to 1.2.8.a1
Bug 648949 - Move selinux policy into base OS
Bug 648949 - Update configure
Roll back VERSION.sh for 1.2.7 release
Bug 625950 - hash nsslapd-rootpw changes in audit log
Bug 656392 - Remove calls to ber_err_print()
Bug 656515 - Allow Name and Optional UID syntax for grouping attributes
Bug 197886 - Avoid overflow of UUID generator
Bug 658312 - Allow mapped attribute types to be quoted
Bug 197886 - Initialize return value for UUID generation code
Bug 658309 - Process escaped characters in managed entry mappings
Bug 659456 - Incorrect usage of ber_printf() in winsync code
Bug 641944 - Don't normalize non-DN RDN values
Bug 658312 - Invalid free in Managed Entry plug-in
Bug 661792 - Valid managed entry config rejected
Bug 588791 - Allow anonymous rootDSE access only
Bug 606439 - Creating server instance with LDAPI takes too long
Bug 632670 - Chain-on-update logs managed-entries-plugin errors
Bug 621008 - parsing purge RUV from changelog at startup fails
Bug 663191 - Don't use $USER in DSCreate.pm
Bug 663597 - Memory leaks in normalization code
Bug 659131 - Incorrect RDN values added with multi-valued RDN
Bug 661102 - Rename of managed entries not handled correctly
Bug 193297 - Call pre-bind plug-ins for all SASL bind steps
Bug 201652 - LDAPv2 bind with expired password doesn't unbind correctly
Bug 470576 - Migration could do addition checks before commiting actions
Bug 481195 - Missing op type in log when password change required
Bug 509897 - Validate dnaScope to ensure it is a legal DN
Bug 505722 - Allow ntGroup to have mail attribute present
Bug 543633 - replication problems if supplier is killed under update load
Bug 671033 - range sharing between server breaks with SASL/GSSAPI auth
Bug 527912 - setup-ds.pl appears to hang when DNS is unreachable
Bug 252249 - Add pkg-config file for plug-in developers
Bug 670616 - Allow SSF to be set for local (ldapi) connections
Bug 668862 - init scripts return wrong error code
Bug 674430 - Improve error messages for attribute uniqueness
Bug 675853 - dirsrv crash segfault in need_new_pw()
Bug 678646 - Ignore tombstone operations in managed entry plug-in
Bug 671199 - Don't allow other to write to rundir
Bug 672468 - Don't use empty path elements in LD_LIBRARY_PATH
Bug 674852 - crash in ldap-agent when using OpenLDAP
Bug 681345 - setup-ds.pl should set SuiteSpotGroup automatically
Bug 680558 - Winsync plugin fails to restrain itself to the configured subtree
Bug 504803 - Allow maxlogsize to be set if logmaxdiskspace is -1
Bug 687974 - (cov#10715) Fix Coverity uninitialized variables issues
Bug 688341 - (cov#10709) Fix Coverity code maintainability issues
Bug 688341 - (cov#10708) Fix Coverity code maintainability issues
Bug 688341 - (cov#10706,10707) Fix Coverity code maintainability issues
Bug 688341 - (cov#10704,10705) Fix Coverity code maintainability issues
Bug 688341 - (cov#10703) Fix Coverity code maintainability issues
Bug 688341 - (cov#10702) Fix Coverity code maintainability issues
Bug 688341 - (cov#10709) Fix Coverity code maintainability issues
Bug 689537 - (cov#10699) Fix Coverity NULL pointer dereferences
Bug 689537 - (cov#10610) Fix Coverity NULL pointer dereferences
Bug 689537 - (cov#10608) Fix Coverity NULL pointer dereferences
Bug 689952 - (cov#10581) Incorrect bit check in replication connection code
Bug 690526 - (cov#10734) Double free in dse_add()
Bug 690649 - (cov#10731) Use of free'd pointer in indexing code
Bug 690882 - (cov#10571) Incorrect sizeof use in uuid code
Bug 690882 - (cov#10636,10637) Useless comparison in attrcrypt
Bug 690882 - (cov#10703) Incorrect sizeof use in vattr code
Bug 690882 - (cov#10572,10710) Incorrect sizeof use in uuid code
Bug 691574 - (cov#10579) Check return value of ber_scanf() in sort code
Bug 691574 - (cov#10577) Check return types when adding RDN CSNs
Bug 691574 - (cov#10573) check return value in GER code
Bug 691574 - (cov#10575) Check return value of ldap_get_option
Bug 691574 - (cov#10573) Fix syntax error
Bug 693868 - Add managed entry config during in-place upgrade
Add Auto Membership Plug-in
Bug 698428 - Make auto membership use Slapi_DN for DN comparisons
Bug 695779 - windows sync can lose old values when a new value is added
Bug 700557 - Linked attrs callbacks access free'd pointers after close
Bug 700557 - Leak at shutdown in DNA plug-in
Bug 703304 - Auto membership alternate config area should override default area
Bug 703304 - Auto membership alternate config area should override default area
Bug 703530 - Allow Managed Entry config to be relocated
Bug 697961 - memberOf needs to be triggered by internal operations
Bug 710377 - Import with chain-on-update crashes ns-slapd
Split automember regex rules into separate entries
Bug 713209 - Update sudo schema
Bug 691313 - Need TLS/SSL error messages in repl status and errors log
Bug 723937 - Slapi_Counter API broken on 32-bit F15
Bug 725743 - Make memberOf use PRMonitor for it's operation lock
Bug 729717 - Fatal error messages when syncing deletes from AD
Bug 728510 - Run dirsync after sending updates to AD
Bug 730387 - Add slapi_rwlock API and use POSIX rwlocks
Bug 611438 - Add Account Usability Control support
Bug 728592 - Allow ns-slapd to start with an invalid server cert
Bug 732541 - Ignore error 32 when adding automember config
Bug 722292 - Entries in DS are not updated properly when using WinSync API
Bug 722292 - (cov#11030) Leak of mapped_sdn in winsync rename code
Bug 735114 - renaming a managed entry does not update mepmanagedby
Bug 739172 - Allow separate fractional attrs for incremental and total protocols
Bug 743966 - Compiler warnings in account usability plugin
Bug 744946 - (cov#11046) NULL dereference in IDL code
Bug 752155 - Use restorecon after creating init script lock file
Ticket 284 - Remove unnecessary SNMP MIB files
ticket 304 - Fix kernel version checking in dsktune
ticket 211 - Use of uninitialized variables in ldbm_back_modify()
ticket 181 - Allow PAM passthru plug-in to have multiple config entries
coverity 12563 Read from pointer after free (fix 2)
Ticket 211 - Avoid preop range requests non-DNA operations
Ticket #503 - Improve AD version in winsync log message
Ticket 549 - DNA plugin no longer reports additional info when range is depleted
Ticket 556 - Don't overwrite certmap.conf during upgrade
Add make rpms build target
Allow rpm builds to be run without configure
Add git commit hash to developer rpm build names
Add hardened build option and correct changelog dates
Revert "Ticket #47431 - Duplicate values for the attribute nsslapd-pluginarg are not handled correctly"
Ticket 449 - Allow macro aci keywords to be case-insensitive
Ticket 47539 - Disabling DNA plug-in throws error 53
Ticket 47513 - tmpfiles.d references /var/lock when they should reference /run/lock
Ticket 47565 - Content Sync update file needs extensibleObject
Ticket 47569 - ACIs do not allow attribute subtypes in targetattr keyword
Ticket 47569 - Fix build warnings
Ticket 47588 - Compiler warnings building on F19
Ticket 47611 - Add script to build patched RPMs
Ticket 47525 - Don't modify preop entry in memberOf config
Ticket 47752 - Don't add unhashed password mod if we don't have an unhashed value
Ticket 47753 - Add switch to disable pre-hashed password checking
Noriko Hosoi (594):
544089 - Referential Integrity Plugin does not take into account the attribute
557224 - subtree rename breaks the referential integrity plug-in
247413 - Incorrect error on multiple identical value add
559016 - Attempting to rename suffix returns inappropriate errors
555577 - Syntax validation fails for "ou=NetscapeRoot" tree
Undo - 555577 - Syntax validation fails for "ou=NetscapeRoot" tree
560827 - Admin Server templates: DistinguishName validation fails
548535 - memory leak in attrcrypt
563365 - Error handling problems in the backend functions
565664 - Incorrect parameter for CACHE_RETURN()
565987 - redhat-ds-base fails to build due to undefined struct
527848 - make sure db upgrade to 4.7 and later works correctly
539618 - Replication bulk import reports Invalid read/write
567370 - dncache: assertion failure in id2entry_delete
548115 - memory leak in schema reload
555970 - missing read lock in the combination of cos and nsview
539618 - Replication bulk import reports Invalid read/write
570667 - MMR: simultaneous total updates on the masters cause
Merge branch '547503'
Revert "Merge branch '547503'"
Bug 554573 - ACIs use bind DN from bind req rather than cert mapped DN from sasl/external
199923 - subtree search fails to find items under a db
570107 - The import of LDIFs with base-64 encoded DNs fails,
572649 - DS8.2 crashes on RHEL 4 (corresponding to bob, ber_2 test case)
573060 - DN normalizer: ESC HEX HEX is not normalized (
573896 - initializing subtree with invalid syntax crashes ns-slapd
515805 - Stop "initialize Database" crashes the server
548533 - memory leak in Repl_5_Inc_Protocol_new
Fixing a syntax error
Update to New DN Format
585905 - ACL with targattrfilters error crashes the server
574167 - An escaped space at the end of the RDN value is not
590931 - rhds81 import - hardcoded pages_limit for nsslapd-import-cache-autosize
591336 - Implementing upgrade DN format tool
593453 - Creating password policy with ns-newpolicy.pl on Replicated
593110 - backup-restore does not ALWAYS work
593899 - adding specific ACI causes very large mem allocate request
588867 - entryusn plugin fails on solaris
593899 - adding specific ACI causes very large mem allocate request
595893 - Base DN in SASL mapping is not normalized
511112 - Password history limited to 25 values
597375 - Deleting LDBM database causes backup/restore problem
574101 - MODRDN request never returns - possible deadlock
606920 - anonymous resource limit - nstimelimit -
605827 - In-place upgrade: upgrade dn format should not run in setup-ds-admin.pl
578296 - Attribute type entrydn needs to be added when subtree
609256 - Selinux: pwdhash fails if called via Admin Server CGI
609255 - fix coverity Defect Type: Memory - illegal accesses issues
609255 - fix coverity Defect Type: Memory - illegal accesses issues
609255 - fix coverity Defect Type: Memory - illegal accesses issues
609255 - fix coverity Defect Type: Memory - illegal accesses issues
609255 - fix coverity Defect Type: Memory - illegal accesses issues
609255 - fix coverity Defect Type: Memory - illegal accesses issues
609255 - fix coverity Defect Type: Memory - illegal accesses issues
609255 - fix coverity Defect Type: Memory - illegal accesses issues
609255 - fix coverity Defect Type: Memory - illegal accesses issues
609255 - fix coverity Defect Type: Memory - illegal accesses issues
609255 - fix coverity Defect Type: Memory - illegal accesses issues
609255 - fix coverity Defect Type: Memory - illegal accesses issues
609255 - fix coverity Defect Type: Memory - illegal accesses issues
609255 - fix coverity Defect Type: Memory - illegal accesses issues
609255 - fix coverity Defect Type: Memory - illegal accesses issues
609255 - fix coverity Defect Type: Memory - illegal accesses issues
616618 - 389 v1.2.5 accepts 2 identical entries with different DN formats
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
610281 - fix coverity Defect Type: Control flow issues
616608 - SIGBUS in RDN index reads on platforms with strict alignments
619595 - Upgrading sub suffix under non-normalized suffix disappears
513166 - Simple Paged result doesn't provide the server's estimate
621928 - Unable to enable replica (rdn problem?) on 1.2.6 rc6
Bug 194531 - db2bak is too noisy
Bug 622628 - fix coverity Defect Type: Integer handling issues
Bug 622628 - fix coverity Defect Type: Integer handling issues
Bug 622628 - fix coverity Defect Type: Integer handling issues
Bug 622903 - fix coverity Defect Type: Code maintainability issues
Bug 622903 - fix coverity Defect Type: Code maintainability issues
Bug 622903 - fix coverity Defect Type: Code maintainability issues
Bug 622903 - fix coverity Defect Type: Code maintainability issues
Bug 622903 - fix coverity Defect Type: Code maintainability issues
Bug 622903 - fix coverity Defect Type: Code maintainability issues
Bug 622903 - fix coverity Defect Type: Code maintainability issues
Bug 622903 - fix coverity Defect Type: Code maintainability issues
Bug 622903 - fix coverity Defect Type: Code maintainability issues
Bug 622903 - fix coverity Defect Type: Code maintainability issues
Bug 622903 - fix coverity Defect Type: Code maintainability issues
Bug 622903 - fix coverity Defect Type: Code maintainability issues
Bug 622903 - fix coverity Defect Type: Code maintainability issues
Bug 622903 - fix coverity Defect Type: Code maintainability issues
Bug 622903 - fix coverity Defect Type: Code maintainability issues
Bug 623118 - Simplepaged results going in infinite loop
Bug 614511 - fix coverity Defect Type: Null pointer dereferences issues 11846 - 11891
Bug 619122 - fix coverity Defect Type: Resource leaks issues CID 11975 - 12051
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
Bug 617630 - fix coverity Defect Type: Resource leaks issues CID 12052 - 12093
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 616500 - fix coverity Defect Type: Resource leaks issues CID 12094 - 12136
Bug 616500 - fix coverity Defect Type: Resource leaks issues CID 12094 - 12136
Bug 616500 - fix coverity Defect Type: Resource leaks issues CID 12094 - 12136
Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892
Bug 616500 - fix coverity Defect Type: Resource leaks issues
Bug 623507 - fix coverity Defect Type: Incorrect expression issues
Bug 623507 - fix coverity Defect Type: Incorrect expression issues
Bug 613056 - fix coverify Defect Type: Null pointer dereferences
Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166
Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166
Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166
Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166
Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166
Removed redundant code in agmt_new_from_entry
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
Bug 628300 - DN is not normalized in dn/entry cache when an entry is added, entrydn is not present in search results
Bug 531642 - EntryUSN: RFE: a configuration option to make entryusn "global"
Bug 627738 - The cn=monitor statistics entries for the dnentry cache do not change or change very rarely
DN normalizer should check the invalid type
Bug 627738 - The cn=monitor statistics entries for the dnentry cache
Bug 629710 - escape_string does not check '\<HEX><HEX>'
agmtlist_shutdown (repl5_agmtlist.c) had an illegal access defect.
Bug 633168 - Share backend dbEnv with the replication changelog
Bug 633168 - Share backend dbEnv with the replication changelog
Bug 631862 - crash - delete entries not in cache + referint
Bug 625014 - SubTree Renames: ModRDN operation fails and the server hangs if the entry is moved to "under" the same DN.
Bug 558099 - Enhancement request: Log more information about the search result being a paged one
Bug 635987 - Incorrect sub scope search result with
Bug 606920 - anonymous resource limit- nstimelimit -
Bug 635987 - Incorrect sub scope search result with ACL containing ldap:///self
Bug 639289 - Adding a new CN entry with UpperCase UTF-8 Character
Bug 640027 - Naming attribute with a special char sequence parsing bug
Bug 640854 - changelog db: _cl5WriteOperation: failed to
Bug 637852 - sasl_io_start_packet: failed - read only 3 bytes
Bug 586966 - Sample update script has syntax errors
Bug 586973 - Sample update ldif points to non-existent directory
Bug 602456 - Allow to add any cn=config attributes;
Bug 244229 - targetattr not verified against schema when setting an aci
Bug 643532 - Incorrect DNs sometimes returned on searches
Bug 592397 - Upgrade tool dn2rdn: it does not clean up
Bug 645061 - Upgrade: 06inetorgperson.ldif and 05rfc4524.ldif
Bug 629681 - Retro Changelog trimming does not behave as expected
Bug 644608 - RHDS 8.1->8.2 upgrade fails to properly migrate ACIs
Bug 644608 - RHDS 8.1->8.2 upgrade fails to properly migrate ACIs
Bug 644608 - RHDS 8.1->8.2 upgrade fails to properly migrate ACIs
Bug 638773 - permissions too loose on pid and lock files
Bug 491733 - dbtest crashes
Bug 329751 - "nested" filtered roles searches candidates more
Bug 567282 - server can not abandon searchRequest of "simple paged results"
Bug 572018 - Upgrading from 1.2.5 to 1.2.6.a2 deletes userRoot
Bug 651571 - When attrcrypt is on, entrydn is stored in the backend db
Bug 661918 - 389-ds MMR plugin's changelogdb path logic is incorrect
Bug 182507 - clear-password mod from replica is discarded before changelogged
Bug 602456 - Allow to add any cn=config attributes;
Bug 489379 - passwordExpirationTime in entry being added
Bug 663484 - Entry usn plugin fails to properly tag entries on initialization
Bug 664563 - GER: ger for non-present entry is not correct
Bug 653007 - db2ldif export of clear text passwords lacks storage scheme
Bug 667488 - Cannot recreate numsubordinates index with db2index
Bug 663752 - Cert renewal for attrcrypt and encchangelog
Bug 615100 - log rotationinfo always recreated at startup,
Bug 624442 - MMR: duplicate replica ID
Bug 669205 - db2bak: backed up changelog should include RUVs
Bug 616850 - ldapmodify failed to reject the replace operation
Bug 627993 - Inconsistent storage of password expiry times
Bug 627993 - Inconsistent storage of password expiry times
dn2rdn should respect the DB version info
Bug 646381 - Faulty password for nsmultiplexorcredentials does not give any error message in logs
Bug 624547 - attrcrypt should query the given slot/token for
Bug 668619 - slapd stops responding
Bug 151705 - Need to update Console Cipher Preferences with new ciphers
Bug 615052 - intrinsics and 64-bit atomics code fails to compile
Bug 616213 - insufficient stack size for HP-UX on PA-RISC
Bug 675265 - preventryusn gets added to entries on a failed delete
Bug 604881 - admin server log files have incorrect permissions/ownerships
Bug 676053 - export task followed by import task causes cache assertion
Bug 676053 - export task followed by import task causes cache assertion
Bug 676053 - export task followed by import task causes cache assertion
Bug 450016 - RFE- Console display values in KB/MB/GB
Cancelling commit aef19508c4f618285116d2068655183658f564d9
Bug 625424 - repl-monitor.pl doesn't work in hub node
Bug 679978 - modifying attr value crashes the server, which is supposed to
Bug 681015 - RFE: allow fine grained password policy duration attributes in days, hours, minutes, as well
Bug 668909 - Can't modify replication agreement in some cases
Bug 684996 - Exported tombstone cannot be imported correctly
Bug 681015 - RFE: allow fine grained password policy duration attributes in days, hours, minutes, as well
Bug 689866 - ns-newpwpolicy.pl needs to use the new DN format
Bug 690955 - Mrclone fails due to the replica generation id mismatch
Bug 696407 - If an entry with a mixed case RDN is turned to be
Bug 697027 - 1 - minor memory leaks found by Valgrind + TET
Bug 697027 - 2 - minor memory leaks found by Valgrind + TET
Bug 697027 - 3 - minor memory leaks found by Valgrind + TET
Bug 697027 - 4 - minor memory leaks found by Valgrind + TET
Bug 697027 - 5 - minor memory leaks found by Valgrind + TET
Bug 697027 - 6 - minor memory leaks found by Valgrind + TET
Bug 697027 - 7 - minor memory leaks found by Valgrind + TET
Bug 697027 - 8 - minor memory leaks found by Valgrind + TET
Bug 697027 - 9 - minor memory leaks found by Valgrind + TET
Bug 697027 - 10 - minor memory leaks found by Valgrind + TET
Bug 697027 - 11 - minor memory leaks found by Valgrind + TET
Bug 697027 - 12 - minor memory leaks found by Valgrind + TET
Bug 697027 - 13 - minor memory leaks found by Valgrind + TET
Bug 697027 - 14 - minor memory leaks found by Valgrind + TET
Bug 697027 - 15 - minor memory leaks found by Valgrind + TET
Bug 697027 - 16 - minor memory leaks found by Valgrind + TET
Bug 697027 - 3 - minor memory leaks found by Valgrind + TET
Bug 697027 - 3 - minor memory leaks found by Valgrind + TET
Bug 700215 - ldclt core dumps
Bug 668619 - slapd stops responding
Bug 709826 - Memory leak: when extra referrals configured
Bug 706179 - DS can not restart after create a new objectClass has entryusn attribute
Bug 663752 - Cert renewal for attrcrypt and encchangelog
Bug 663752 - Cert renewal for attrcrypt and encchangelog
Bug 711679 - unresponsive LDAP service when deleting vlv on replica
Bug 711679 - unresponsive LDAP service when deleting vlv on replica
Bug 718303 - Intensive updates on masters could break the consumer's cache
Merge branch '718303'
Bug 719069 - clean up compiler warnings in 389-ds-base 1.2.9
Bug 712855 - Directory Server 8.2 logs "Netscape Portable
Bug 663752 - Cert renewal for attrcrypt and encchangelog
Bug 732153 - subtree and user account lockout policies implemented?
Introducing an environment variable USE_VALGRIND to clean up the entry cache and dn cache on exit.
Bug 744945 - nsslapd-counters attribute value cannot be set to "off"
Keep unhashed password psuedo-attribute in the adding entry
Reduce the number of DN normalization
Bug 745259 - Incorrect entryUSN index under high load
Bug 750622 - Fix Coverity (11104) Resource leak:
Bug 750624 - Fix Coverity (11053) Explicit null dereferenced:
Bug 750625 - Fix Coverity (11066) Unused pointer value
Bug 750625 - Fix Coverity (11065) Uninitialized pointer read
Bug 750625 - Fix Coverity (11064) Dereference before null check
Bug 750625 - Fix Coverity (11061) Resource leak
Bug 750625 - Fix Coverity (11060) Dereference null return value
Bug 750625 - Fix Coverity (11058, 11059) Dereference null return value
Bug 750625 - Fix Coverity (11057) Dereference null return value
Bug 750625 - Fix Coverity (11055) Explicit null dereferenced
Bug 750625 - Fix Coverity (11054) Dereference after null check
Bug 750625 - Fix Coverity (11117) Uninitialized pointer read
Bug 750625 - Fix Coverity (11116) Uninitialized pointer read
Bug 750625 - Fix Coverity (11114, 11115) Uninitialized value use
Bug 750625 - Fix Coverity (11113) Uninitialized pointer read
Bug 750625 - Fix Coverity (11112) Uninitialized pointer read
Bug 750625 - Fix Coverity (11109, 11110, 11111) Uninitialized pointer read
Bug 750625 - Fix Coverity (11108) Sizeof not portable
Bug 750625 - Fix Coverity (11107) Dereference before null check
Bug 750625 - Fix Coverity (11096) Explicit null dereferenced
Bug 750625 - Fix Coverity (11095) Explicit null dereferenced
Bug 750625 - Fix Coverity (11094) Dereference after null check
Bug 750625 - Fix Coverity (11091) Unchecked return value
Bug 750625 - Fix Coverity (11055-2) Explicit null dereferenced
Bug 750625 - Fix Coverity (11062) Resource leak
Bug 750625 - Fix Coverity (11066-2) Unused pointer value
Bug 750625 - Fix Coverity (12195) Dereference after null check
Bug 750625 - Fix Coverity (12196) Dereference before null check
Bug 750625 - Fix Coverity (11066-3) Unused pointer value
Bug 745259 - Incorrect entryUSN index under high load in
Trac Ticket 2 - If node entries are tombstone'd,
Trac Ticket 2 - If node entries are tombstone'd,
Trac Ticket 26 - Please support setting
Trac Ticket 75 - Unconfigure plugin opperations are being called.
Trac Ticket 168 - minssf should not apply to rootdse
Trac Ticket #18 - Data inconsitency during replication
Trac Ticket #52 - FQDN set to nsslapd-listenhost
Trac Ticket 139 - eliminate the use of char *dn in favor of Slapi_DN *dn
Trac Ticket 35 - Log not clear enough on schema errors
Trac Ticket #274 - Reindexing entryrdn fails if
Trac Ticket #275 - Invalid read reported by valgrind
Trac Ticket 51 - memory leaks in 389-ds-base-1.2.8.2-1.el5?
Trac Ticket #27 - SASL/PLAIN binds do not work
Trac Ticket #84 - 389 Directory Server Unnecessary Checkpoints
Trac Ticket #169 - allow 389 to use db5
Trac Ticket #34 - remove-ds.pl does not remove everything
Trac Ticket #26 - Please support setting defaultNamingContext in the rootdse.
Trac Ticket #298 - crash when replicating orphaned tombstone entry
Trac Ticket #290 - server hangs during shutdown if betxn pre/post op fails
Trac Ticket #290 - server hangs during shutdown if betxn pre/post op fails
Minor bug fix introcuded by commit 69c9f3bf7dd9fe2cadd5eae0ab72ce218b78820e
Trac Ticket #260 - 389 DS does not support multiple
Fixing compiler warnings
Trac Ticket #303 - make DNA range requests work with transactions
coverity 12606 Logically dead code
Trac Ticket #46 - setup-ds-admin.pl does not like ipv6 only hostnames
Trac Ticket #46 (revised) - setup-ds-admin.pl does not like ipv6 only hostnames
Trac Ticket #46 - (take 3) setup-ds-admin.pl does not like ipv6 only hostnames
Trac Ticket #46 - (additional) setup-ds-admin.pl does not
Trac Ticket #45 - Fine Grained Password policy:
Trac Ticket #46 - (additional 2) setup-ds-admin.pl does not like ipv6 only hostnames
Trac Ticket #335 - transaction retries need to be cache aware
Trac Ticket #338 - letters in object's cn get converted to
Trac Ticket #310 - Avoid calling escape_string() for logged DNs
Trac Ticket #19 - Convert entryUSN plugin to transaction aware type
Trac Ticket #345 - db deadlock return should not log error
Trac Ticket #359 - Database RUV could mismatch the one in changelog under the stress
Trac Ticket #359 - Database RUV could mismatch the one
Trac Ticket #338 - letters in object's cn get converted to
Trac Ticket #335 - transaction retries need to be cache aware
Bug 829213 - unhashed#user#password visible after changing password https://bugzilla.redhat.com/show_bug.cgi?id=829213
Bug 829213 - unhashed#user#password visible after changing password https://bugzilla.redhat.com/show_bug.cgi?id=829213
Bug 829213 - unhashed#user#password visible after changing password https://bugzilla.redhat.com/show_bug.cgi?id=829213
audit log does not log unhashed password: enabled, by default.
Trac Ticket 396 - Account Usability Control Not Working [Bug 835238]
Trac Ticket #402 - nhashed#user#password in entry extension
Trac Ticket #346 - Slow ldapmodify operation time for large
Trac Ticket #346 - Slow ldapmodify operation time for large
Coverity defects
Conflict definition in SLAPI_ATTR_FLAG macros
Trac Ticket #412 - memberof performance enhancement
Trac Ticket #409 - Report during startup if nsslapd-cachememsize is too small
Ticket 328 - make sure all internal search filters are properly escaped
Ticket 328 - make sure all internal search filters are properly escaped
Trac Ticket #346 - Slow ldapmodify operation time for large
Trac Ticket #437 - variable dn should not be used in ldbm_back_delete
Coverity defects
Trac Ticket #340 - Change on SLAPI_MODRDN_NEWSUPERIOR is not
Trac Ticket #466 - entry_apply_mod - ADD: Failed to set
Coverity defects
Trac Ticket #470 - 389 prevents from adding a posixaccount
Coverity defects
Trac Ticket #453 - db2index with -tattrname:type,type fails
Trac Ticket #351 - use betxn plugins by default
Bug 863576 - Dirsrv deadlock locking up IPA
Trac Ticket #455 - Insufficient rights to unhashed#user#password
Trac Ticket #451 - Allow db2ldif to be quiet
Coverity defects
Fixing compiler warnings in the posix-winsync plugin
Trac Ticket #494 - slapd entered to infinite loop during new index addition
Coverity defects
Trac Ticket #498 - Cannot abaondon simple paged result search
Trac Ticket #448 - Possible to set invalid macros in Macro ACIs
Trac Ticket #391 - Slapd crashes when deleting backends
Coverity fixes
Trac Ticket #190 - Un-resolvable server in replication
Trac Ticket #443 - Deleting attribute present in
Trac Ticket #447 - Possible to add invalid attribute
Trac Ticket #311 - IP lookup failing with multiple DNS
Trac Ticket #500 - Newly created users with
Trac Ticket #519 - Search with a complex filter including range search is slow
Trac Ticket #520 - RedHat Directory Server crashes (segfaults) when moving ldap entry
Coverity defect: Resource leak 13110
Trac Ticket #276 - Multiple threads simultaneously working on
Trac Ticket #531 - loading an entry from the database should use str2entry_fast
Trac Ticket #536 - Clean up compiler warnings for 1.3
Trac Ticket #531 - loading an entry from the database should use str2entry_f
Trac Ticket #499 - Handling URP results is not corrrect
bump version to 1.3.0.rc1
Trac Ticket #522 - betxn: upgrade is not implemented yet
Ticket 509 - lock-free access to be->be_suffixlock
Trac Ticket #497 - Escaped character cannot be used in the substring search filter
Ticket #422 - 389-ds-base - Can't call method "getText"
Ticket #547 - Incorrect assumption in ndn cache
Ticket #545 - Segfault during initial LDIF import: str2entry_dupcheck()
Ticket #542 - Cannot dynamically set nsslapd-maxbersize
Ticket #537 - Improvement of range search
Ticket #342 - better error message when cache overflows
Ticket #505 - use lock-free access name2asi and oid2asi tables (additional)
Ticket #529 - dn normalization must handle multiple space characters in attributes
Ticket #502 - setup-ds.pl script should wait if "semanage.trans.LOCK" presen
Ticket #563 - DSCreate.pm: Error messages cannot be used in the if expression since they could be localized.
Ticket #533 - only scan for attributes to decrypt if there are encrypted attrs configured
Ticket #543 - Sorting with attributes in ldapsearch gives incorrect result
Ticket #572 - PamConfig schema not updated during upgrade
Ticket #576 - DNA: use event queue for config update only at the start up
Ticket #579 - Error messages encountered when using POSIX winsync
Ticket #584 - Existence of an entry is not checked when its password is to be deleted
bump version to 1.3.1.pre.a1
Ticket #561 - disable writing unhashed#user#password to changelog
Coverity Fix
Ticket #490 - Slow role performance when using a lot of roles
Ticket #603 - A logic error in str2simple
Ticket #604 - Required attribute not checked during search operation
Ticket #585 - Behaviours of "db2ldif -a <filename>" and "db2ldif.pl -a <filename>" are inconsistent
Fixing a compiler warning introduced by Ticket #561 - disable writing unhashed#user#password to changelog
Ticket #634 - Deadlock in DNA plug-in
Ticket #627 - ns-slapd crashes sporadically with segmentation fault in libslapd.so
Ticket #47308 - unintended information exposure when anonymous access is set to rootdse
Ticket 623 - cleanAllRUV task fails to cleanup config upon completion
Ticket #618 - Crash at shutdown while stopping replica agreements
Ticket 458 - Need to properly check if the password admin dn is set
Ticket #529 - dn normalization must handle multiple space characters in attributes
Ticket #608 - Posix Winsync plugin throws "posix_winsync_end_update_cb: failed to add task entry" error message
Ticket #529 - dn normalization must handle multiple space characters in attributes
Ticket 623 - cleanAllRUV task fails to cleanup config upon completion
bump version to 1.3.2.pre.a1
Ticket #529 - dn normalization must handle multiple space characters in attributes
Ticket 528 - RFE - get rid of instance specific scripts
Ticket #47330 - changelog db extension / upgrade is obsolete
Ticket #529 - dn normalization must handle multiple space characters in attributes
Ticket #47313 - Indexed search with filter containing '&' and "!" with attribute subtypes gives wrong result
Ticket #47330 - changelog db extension / upgrade is obsolete
Ticket #47347 - Simple paged results should support async search
Ticket #529 - dn normalization must handle multiple space characters in attributes
Ticket #47320 - put conn on work_q not poll list if conn has buffered more_data
Ticket 47331 - Self entry access ACI not working properly
Ticket #529 - dn normalization must handle multiple space characters in attributes
Coverity fix -- 13164: Logically dead code
Ticket #47343 - 389-ds-base: Does not support aarch64 in f19 and rawhide
Ticket #47327 - error syncing group if group member user is not synced
Ticket #428 - posix winsync should support ADD user/group entries from DS to AD
Trac Ticket #402 - nhashed#user#password in entry extension
Ticket #569 - examine replication code to reduce amount of stored state information
Ticket 47379 - DNA plugin failed to fetch replication agreement
Ticket #47391 - deleting and adding userpassword fails to update the password
Ticket #47391 - deleting and adding userpassword fails to update the password (additional fix)
Ticket #47400 - MMR stress test with dna enabled causes a deadlock
Ticket #47384 - Plugin library path validation
Ticket #47374 - flush.pl is not included in perl5
Ticket #47420 - An upgrade script 80upgradednformat.pl fails to handle a server instance name incuding '-'
Ticket #47419 - Unhashed userpassword can accidentally get removed from mods
Ticket #47384 - Plugin library path validation
Ticket #47367 - (phase 1) ldapdelete returns non-leaf entry error while trying to remove a leaf entry
Ticket #47367 - (phase 2) ldapdelete returns non-leaf entry error while trying to remove a leaf entry
Ticket #47435 - Very large entryusn values after enabling the USN plugin and the lastusn value is negative.
Ticket #521 - modrdn + NSMMReplicationPlugin - Consumer failed to replay change
Ticket #47378 - fix recent compiler warnings
Ticket #630 - The backend name provided to bak2db is not validated
Ticket #415 - winsync doesn't sync DN valued attributes if DS DN value doesn't exist
Ticket #47314 - Winsync should support range retrieval
Ticket #47310 - Attribute "dsOnlyMemberUid" not allowed when syncing nested posix groups from AD with posixWinsync
Ticket #48 - Active Directory has certain uids which are reserved and will cause a Directory Server replica initialization of an AD server to abort.
Ticket #609 - nsDS5BeginReplicaRefresh attribute accepts any value and it doesn't throw any error when server restarts.
Ticket #197 - BDB backend - clear free page files to reduce changelog size
Ticket #48 - Active Directory has certain uids which are reserved and will cause a Directory Server replica initialization of an AD server to abort.
Ticket #460 - support multiple subtrees and filters
coverity 11956 - Dereference after null check
Ticket #47492 - PassSync removes User must change password flag on the Windows side
Ticket #47523 - Set up replcation/agreement before initializing the sub suffix, the sub suffix is not found by ldapsearch
Ticket #47534 - RUV tombstone search with scope "one" doesn`t work
Ticket #47463 - IDL-style can become mismatched during partial restoration
Coverity fixes - 12023, 12024, and 12025
Ticket #54 - locale "nl" not supported by collation plugin
Ticket #53 - Need to update supported locales
Ticket #53 - Need to update supported locales
Ticket #53 - Need to update supported locales
Ticket #47530 - dbscan on entryrdn should show all matching values
Ticket #47422 - With 1.3.04 and subtree-renaming OFF, when a user is deleted after restarting the server, the same entry can't be added
Ticket #47530 - dbscan on entryrdn should show all matching values
Ticket #538 - hardcoded sasl2 plugin path in ldaputil.c, saslbind.c
Ticket #47555 - db2bak.pl issue when specifying non-default directory
Ticket #47581 - Winsync plugin segfault during incremental backoff
Ticket #47581 - Winsync plugin segfault during incremental backoff (phase 2)
Ticket #605 - support TLS 1.1
Ticket #605 - support TLS 1.1 - adding backward compatibility
Ticket #342 - better error message when cache overflows (phase 2)
Ticket #605 - support TLS 1.1 - lower the log level for the supported NSS version range
Ticket #605 - support TLS 1.1 - Fixing "Coverity 12415 - Logically dead code"
Ticket #47313 - Indexed search with filter containing '&' and "!" with attribute subtypes gives wrong result
Ticket #47606 - replica init/bulk import errors should be more verbose
Ticket #447 - Possible to add invalid attribute to nsslapd-allowed-to-delete-attrs
Ticket #47571 - targetattr ACIs ignore subtype
Revert "Ticket 47653 - Need a way to allow users to create entries assigned to themselves"
Ticket #47660 - config_set_allowed_to_delete_attrs: Valgrind reports Invalid read
Ticket #47571 - targetattr ACIs ignore subtype
Ticket #342 - better error message when cache overflows
Ticket #443 - Deleting attribute present in nsslapd-allowed-to-delete-attrs returns Operations error
Ticket #47649 - Server hangs in cos_cache when adding a user entry
Ticket #47659 - ldbm_usn_init: Valgrind reports Invalid read / SIGSEGV
Ticket #47570 - slapi_ldap_init unusable during independent plugin development
Ticket #47693 - Environment variables are not passed when DS is started via service
Ticket #47677 - Size returned by slapi_entry_size is not accurate
Ticket #47608 - change slapi_entry_attr_get_bool to handle "on"/"off" values, support default value
Ticket #47602 - Make ldbm_back_seq independently support transactions
Ticket #47642 - Windows Sync group issues
Ticket #47701 - Make retro changelog trim interval programmable
Ticket #47701 - Make retro changelog trim interval programmable
Ticket #47700 - Unresolved external symbol references break loading of the ACL plugin
Ticket #47709 - package issue in 389-ds-base
Ticket #47709 - package issue in 389-ds-base
Ticket #47709 - package issue in 389-ds-base
Ticket #47701 - Make retro changelog trim interval programmable
Ticket 525 - Replication retry time attributes cannot be added
Ticket 408 - create a normalized dn cache
Ticket 571 (dup 47361) - Empty control list causes LDAP protocol error is thrown
Ticket 408 - create a normalized dn cache
Ticket #47725 - compiler error on daemon.c
Ticket #47735 - e_uniqueid fails to set if an entry is a conflict entry
Ticket #47737 - Under heavy stress, failure of turning a tombstone into glue makes the server hung
Ticket #47739 - directory server is insecurely misinterpreting authzid on a SASL/GSSAPI bind
Ticket #47734 - Change made in resolving ticket #346 fails on Debian SPARC64
Ticket #47740 - Coverity issue in 1.3.3
Ticket #47735 - e_uniqueid fails to set if an entry is a conflict entry
Ticket #47748 - Simultaneous adding a user and binding as the user could fail in the password policy check
Ticket #346 - Slow ldapmodify operation time for large quantities of multi-valued attribute values
Ticket #47707 - 389 DS Server crashes and dies while handles paged searches from clients
Ticket #47750 - Creating a glue fails if one above level is a conflict or missing;
Ticket #47764 - Problem with deletion while replicated
Ticket #47780 - Some VLV search request causes memory leaks
Ticket #47804 - db2bak.pl error with changelogdb
Ticket #47720 - Normalization from old DN format to New DN format doesnt handel condition properly when there is space in a suffix after the seperator operator.
Ticket #47770 - #481 breaks possibility to reassemble memberuid list
Ticket #47808 - If be_txn plugin fails in ldbm_back_add, adding entry is double freed.
Ticket 47313 - CI test: add test case for ticket 47313
Ticket 47808 - CI test: add test case for ticket 47808
Ticket #47809 - find a way to remove replication plugin errors messages "changelog iteration code returned a dummy entry with csn %s, skipping ..."
Ticket #555 - add fixup-memberuid.pl script
Ticket #47750 - Creating a glue fails if one above level is a conflict or missing
Ticket #47750 - Creating a glue fails if one above level is a conflict or missing
Ticket #47763 - winsync plugin modify is broken
Ticket #47835 - Coverity: 12687..12692
Ticket #47835 - Coverity: 12687..12692
Ticket #47835 - Coverity: 12687..12692
Ticket #47835 - Coverity: 12687..12692
Ticket #47835 - Coverity: 12687..12692
Ticket #47835 - Coverity: 12687..12692
Ticket #47835 - Coverity: 12687..12692
Ticket #47839 - 389-ds production segfault: __memcpy_sse2_unaligned...
Revert "Ticket #47835 - Coverity: 12687..12692"
Revert "Ticket #47835 - Coverity: 12687..12692"
Revert "Ticket #47835 - Coverity: 12687..12692"
Revert "Ticket #47835 - Coverity: 12687..12692"
Revert "Ticket #47835 - Coverity: 12687..12692"
Revert "Ticket #47835 - Coverity: 12687..12692"
Revert "Ticket #47835 - Coverity: 12687..12692"
Ticket #47852 - Updating winsync one-way sync does not affect the behaviour dynamically
Ticket #47832 - attrcrypt_generate_key calls slapd_pk11_TokenKeyGenWithFlags with improper macro
Ticket #47843 - Fix various typos in manpages & code
Ticket #47844 - Fix hyphens used as minus signed and other manpage mistakes
Ticket #47834 - Tombstone_to_glue: if parents are also converted to glue, the target entry's DN must be adjusted.
Ticket #47834 - Tombstone_to_glue: if parents are also converted to glue, the target entry's DN must be adjusted.
Revert "Revert "Ticket #47835 - Coverity: 12687..12692""
Ticket #47859 - Coverity: 12692 & 12717
Ticket #47859 - Coverity: 12692 & 12717
Ticket #47711 - improve dbgen rdn generation, output and man page.
Ticket #47746 - ldap/servers/slapd/back-ldbm/dblayer.c: possible minor problem with sscanf
Ticket #47824 - paged results control is not working in some cases when we have a subsuffix.
Ticket 47824 - CI test: add test case for ticket 47824
Ticket #47664 - Page control does not work if effective rights control is specified
Ticket 47664 - CI test: add test case for ticket 47664
Ticket #47714 - [RFE] Update lastLoginTime also in Account Policy plugin if account lockout is based on passwordExpirationTime.
Ticket 47714 - CI test: add test case for ticket 47713
Ticket 47714 - CI test: add test case for ticket 47714
Ticket #346 - Fixing memory leaks
Ticket #47579 - add dbmon.sh
Ticket #47579 - add dbmon.sh
Ticket #47869 - unauthenticated information disclosure (Bug 1123477)
Ticket #47834 - Tombstone_to_glue: if parents are also converted to glue, the target entry's DN must be adjusted.
Ticket 47824 - CI test: add test case for ticket 47824
Ticket 47664 - CI test: add test case for ticket 47664
Ticket #47838 - harden the list of ciphers available by default
Ticket 47838 - CI test: add test case for ticket 47838
Ticket #47838 - harden the list of ciphers available by default
Ticket 47869 - CI test: add test case for ticket 47869
Ticket #47838 - harden the list of ciphers available by default
Ticket #47574 - start dirsrv after ntpd
Ticket #47874 - Performance degradation with scope ONE after some load
Ticket #47875 - dirsrv not running with old openldap
Ticket #47875 - dirsrv not running with old openldap
Ticket #47875 - dirsrv not running with old openldap
Ticket #47875 - dirsrv not running with old openldap
Revert "Ticket #47875 - dirsrv not running with old openldap"
Ticket #47834 - Tombstone_to_glue: if parents are also converted to glue, the target entry's DN must be adjusted.
Ticket #47876 - coverity defects in slapd/tools/mmldif.c
Ticket #47879 - coverity defects in plugins/replication/windows_protocol_util.c
bump version to 1.3.3.0
Ticket #47875 - dirsrv not running with old openldap
Ticket #47875 - dirsrv not running with old openldap
bump version to 1.3.3.1
Ticket #47748 - Simultaneous adding a user and binding as the user could fail in the password policy check
Ticket #47834 - Tombstone_to_glue: if parents are also converted to glue, the target entry's DN must be adjusted.
Ticket #47890 - minor memory leaks in utilities
Ticket #47838 - harden the list of ciphers available by default
Ticket 47838,47895 - CI test: add test cases for ticket 47838 and 47895
Ticket #47895 - If no effective ciphers are available, disable security setting.
bump version to 1.3.3.2
Rich Megginson (465):
Net::LDAP password modify extop breaks; msgid in response is 0xFF
Clean up assert for entrydn
Bug 543080 - Bitwise plugin fails to return the exact matched entries for Bitwise search filter
Bug 537466 - nsslapd-distribution-plugin should not require plugin name to begin with "lib"
bump version to 1.2.6.a2
Do not use syntax plugins directly for filters, indexing
wrap new style matching rule plugins for use in old style indexing code
change extensible filter code to use new syntax function style mr funcs
change syntax plugins to register required matching rule plugins
crash looking up compat syntax; numeric string syntax using integer; make octet string ordering work correctly
fix memory leak in attr replace when replacement fails
fix dso linking issues found by fedora 13 linking
problems linking with -z defs
389 DS segfaults on libsyntax-plugin.so - part 1
389 DS segfaults on libsyntax-plugin.so - part 2
389 DS segfaults on libsyntax-plugin.so - part 3
Bug 460162 - FedoraDS "with-FHS" installs init.d StartupScript in wrong location on non-RHEL/Fedora OS
Bug 568196 - Install DS8.2 on Solaris fails
Bug 568196 - Install DS8.2 on Solaris fails - part 2
Bug 551198 - LDAPI: incorrect logging to access log
bump version to 1.2.6.a3
fix various memory leaks
Bug 551198 - LDAPI: incorrect logging to access log - part 2
Bug 554573 - ACIs use bind DN from bind req rather than cert mapped DN from sasl/external
cleanup build warnings
Bug 571514 - upgrade to 1.2.6 should upgrade 05rfc4523.ldif (cert schema)
Bug 570905 - postalAddress syntax should allow empty lines (should allow $$)
Add support for additional schema/matching rules included with 389
Bug 572677 - Memory leak in searches including GER control
Bug 571677 - Busy replica on consumers when directly deleting a replication conflict
Bug 576074 - search filters with parentheses fail
Bug 567429 - slapd didn't close connection and get into CLOSE_WAIT state
Bug 578167 - repl. of mod/replace deletes multi-valued attrs
Bug 561575 - setup-ds-admin fails to supply nsds5ReplicaName when configuring via ConfigFile
Bug 572162 - the string "|*" within a search filter on a non-indexed attribute returns all elements.
Bug 576644 - segfault while multimaster replication (paired node won't find deleted entries)
start of 1.2.6.a4
Bug 572018 - Upgrading from 1.2.5 to 1.2.6.a2 deletes userRoot
Fix too few args for format warning in acllas
Bug 586571 - DS Console shows escaped DNs
Bug 591685 - Server instances Fail to Start on Solaris due to Library Path and pcre
bump console version to 1.2.3
Repl Session API needs to check for NULL api before init
Bug 593392 - setup-ds-admin.pl -k creates world readable file
Bug 595874 - 99user.ldif getting overpopulated
bump version to 1.2.6.a5
bump version to 1.2.6.rc1
bump version to 1.2.6.rc2
bump version to 1.2.6.rc3
Bug 604453 - SASL Stress and Server crash: Program quits with the assertion failure in PR_Poll
Bug 604453 - SASL Stress and Server crash: Program quits with the assertion failure in PR_Poll
Bug 603942 - null deref in _ger_parse_control() for subjectdn
bump version to 1.2.6.rc4
Bug 609590 - fix coverity Defect Type: Memory - corruptions issues
Bug 609590 - fix coverity Defect Type: Memory - corruptions issues
Bug 609590 - fix coverity Defect Type: Memory - corruptions issues
Bug 609590 - fix coverity Defect Type: Memory - corruptions issues
Bug 609590 - fix coverity Defect Type: Memory - corruptions issues
Bug 609590 - fix coverity Defect Type: Memory - corruptions issues
Bug 609590 - fix coverity Defect Type: Memory - corruptions issues
Bug 609590 - fix coverity Defect Type: Memory - corruptions issues
Bug 609590 - fix coverity Defect Type: Memory - corruptions issues
Bug 602530 - coverity: op_shared_modify: compare pre, post and original entries before freeing them
Bug 602531 - coverity: op_shared_delete: compare preop entry and GLUE_PARENT_ENTRY before freeing them
Bug 609590 - fix coverity Defect Type: Memory - corruptions issues
Bug 610177 - fix coverity Defect Type: Uninitialized variables issues
Bug 610276 - fix coverity Defect Type: API usage errors issues
Bug 611850 - fix coverity Defect Type: Error handling issues
Bug 614242 - C99/ANSI C++ related compile errors on HP-UX
Bug 547503 - replication broken again, with 389 MMR replication and TCP errors
Bug 617013 - repl-monitor.pl use cpu upto 90%
fix build failures due to libtool problems
Bug 617629 - Missing aliases in new schema files
Bug 617862 - Replication: Unable to delete tombstone errors
bump version to 1.2.7.a1
Bug 610281 - fix coverity Defect Type: Control flow issues - daemon.c:write_function()
Bug 610281 - fix coverity Defect Type: Control flow issues - last repl init status
postalAddress syntax does not accept empty values
ger should support both "dn" and "distinguishedName"
openldap - ldap_url_parse_ext is not part of the public api
fix memleak in ldbm_config_read_instance_entries
Add -x option to ldap tools when using openldap
openldap - add support for missing controls, add ldif api, fix NSS usage
port client tools to use openldap API
use the mozldap versions of the proxy auth control create function
document slapi wrappers for openldap/mozldap functions that differ
fix some compiler warnings
use strcasecmp with ptype and type->bv_val
ber_printf 'o' cannot handle NULL bv_val
fix the url_parse logic when looking for a missing suffix DN
openldap ldapsearch uses -LLL to suppress # version: N
add ldaptool_opts for the non BUNDLE case in Makefile.am
openldap ldapsearch returns empty line at end of LDIF output
have to use LDAP_OPT_X_TLS_NEVER to defeat cert hostname checking
openldap_read_function needs to set EWOULDBLOCK if the buffer is empty
do not terminate unwrapped LDIF line with another newline
slapi_ldap_url_parse must handle multiple host:port in url
convert mozldap host list to openldap uri list
move the out pointer back if continuation lines were removed
check src < *out only; only check for \nspace if src < *out - 2
use slapi_ldap_url_parse in the acl code
do not un-null-terminate normalized DN until new url is constructed
implement slapi_ldap_explode_dn and slapi_ldap_explode_rdn
use slapi_pblock_set to set the ldap result code for the be postop plugins
pass the string copy to slapi_dn_normalize_original
bug 614511 - fix coverity null reference - revert macro aci $dn logic
fix compiler warnings - unused vars/funcs, invalid casts
use slapi_mods_init_passin/get_ldapmods_passout if modifying the smods
Have to explicitly set protocol version to 3
Only check modrdn ops for backend/suffix correctness if not the default backend
Bug 634561 - Server crushes when using Windows Sync Agreement
openldap ber_init will assert if the bv->bv_val is NULL
add the account policy plugin and related server code, schema, and config
fix pblock memory leak
do not register pre/post op plugins if disabled
add support for global inactivity limit
fix typos in Makefile.am, acctpolicy schema
bump version to 1.2.7.a2
remove extra format argument; use %lu for size_t printf format
Bug 644013 - uniqueness plugin segfault bug
bump version to 1.2.7.a3
bump to 1.2.7.a4
bump version to 1.2.7.a5
put replication config entries in separate file
bump version to 1.2.7.a6
bump version to 1.2.7.1
bump version to 1.2.7.2
bump version to 1.2.7.3
bump version to 1.2.7.4
Bug 515329 - Multiple mods in one operation can result in an inconsistent replica
bump version to 1.2.8.a1
Bug 642046 - Segfault when using SASL/GSSAPI multimaster replication, possible krb5_creds doublefree
Bug 624485 - setup dsktune check step should default to "yes" if no problems found
Bug 622907 - support piped passwords to perl-based maintenance commands
Bug 624485 - setup dsktune check step should default to "yes" if no problems found
Bug 576534 - Password displayed on console when entered in command-line utilities
Bug 667935 - DS pipe log script's logregex.py plugin is not redirecting the log output to the text file
bump version to 1.2.8.a2
Bug 668385 - DS pipe log script is executed as many times as the dirsrv service is restarted
Bug 676689 - crash while adding a new user to be synced to windows
Bug 675113 - ns-slapd core dump in windows_tot_run if oneway sync is used
Bug 677440 - clean up compiler warnings in 389-ds-base 1.2.8
Bug 677774 - DS fails to start after reboot
Bug 666076 - dirsrv crash (1.2.7.5) with multiple simple paged result searches
Bug 675320 - empty modify operation with repl on or lastmod off will crash server
bump version to 1.2.9.a1 - console version to 1.2.4
Bug 677705 - ds-logpipe.py script is failing to validate "-s" and "--serverpid" options with "-t".
Bug 676655 - winsync stops working after server restart
Bug 680555 - ns-slapd segfaults if I have more than 100 DBs
Bug 514190 - setup-ds-admin.pl --debug does not log to file
Bug 518890 - setup-ds-admin.pl - improve hostname validation
Bug 644784 - Memory leak in "testbind.c" plugin
Bug 683250 - slapd crashing when traffic replayed
Bug 690584 - #10691 ldbm_back_init() - fix coverity resource leak issues
Bug 690584 - #10690 #10689 attrcrypt_get_ssl_cert_name() - fix coverity resource leak issues
Bug 690584 - #10688 - dblayer_make_env - fix coverity resource leak issues
Bug 690584 - #10669 #10668 cl5ImportLDIF - fix coverity resource leak issues
Bug 690584 - #10658 linked_attrs_pre_op - fix coverity resource leak issues
Bug 690584 - #10655 acllas__handle_group_entry - fix coverity resource leak issues
Bug 690584 - #10654 #10653 str2entry_dupcheck - fix coverity resource leak issues
Bug 690584 - #10652 #10651 #10650 #10649 #10648 #10647 send_specific_attrs send_all_attrs - fix coverity resource leak issues
Bug 690584 - #10643 hash_rootpw - fix coverity resource leak issues
Bug 690584 - #10641 reslimit_bv2int - fix coverity resource leak issues
Bug 691422 - sdt_destroy - fix coverity control flow issues
Bug 691422 - ldbm_back_upgradedb - fix coverity control flow issues
Bug 691422 - csnplFree - fix coverity control flow issues
Bug 691422 - SetUnicodeStringFromUTF_8 - fix coverity control flow issues
Bug 691422 - cl5DeleteRUV - fix coverity control flow issues
Bug 691422 - acl_read_access_allowed_on_entry - fix coverity control flow issues
Bug 691422 - search_internal_callback_pb - fix coverity control flow issues
Bug 691422 - cl5WriteRUV - fix coverity control flow issues
Bug 691422 - windows_replay_update - fix coverity control flow issues
Bug 690584 - #10691 ldbm_back_init() - fix coverity resource leak issues
Bug 690584 - #10652 #10651 #10650 #10649 #10648 #10647 send_specific_attrs send_all_attrs - fix coverity resource leak issues
Bug 668385 - DS pipe log script is executed as many times as the dirsrv service is restarted
Bug 692937 - Replica install fails after step for "enable GSSAPI for replication"
Bug 692331 - Segfault on index update during full replication push on 1.2.7.5
Bug 693451 - cannot use localized matching rules
Bug 693455 - nsMatchingRule does not work with multiple values
Bug 693503 - matching rules do not inherit from superior attribute type
Bug 693466 - Unable to change schema online
Bug 692991 - rhds82 - windows_tot_run: failed to obtain data to send to the consumer; LDAP error - -1
Bug 693473 - rhds82 rfe - windows_tot_run to log Sizelimit exceeded instead of LDAP error - -1
Bug 693962 - Full replica push loses some entries with multi-valued RDNs
Bug 694336 - Group sync hangs Windows initial Sync
Bug 700145 - userpasswd not replicating
Bug 703990 - Support upgrade from Red Hat Directory Server
bump console version to 1.2.5
Bug 703990 - Support upgrade from Red Hat Directory Server
Bug 703990 - Support upgrade from Red Hat Directory Server
Bug 707015 - Cannot disable SSLv3 and use TLS only
bump version to 1.2.9.a2
Bug 707384 - only allow FIPS approved cipher suites in FIPS mode
Bug 711906 - ns-slapd segfaults using suffix referrals
Bug 706209 - LEGAL: RHEL6.1 License issue for 389-ds-base package
Bug 703703 - setup-ds-admin.pl asks for legal agreement to a non-existant file
Bug 711679 - unresponsive LDAP service when deleting vlv on replica
bump console version to 1.2.6
Bug 697694 - rhds82 - incr update state stop_fatal_error "requires administrator action", with extop_result: 9
Bug 716980 - winsync uses old AD entry if new one not found
add support for ldif files with changetype: add
writing Inf file shows SchemaFile = ARRAY(0xhexnum)
look for separate openldap ldif library
bump version to 1.2.9.a3
Bug 709468 - RSA Authentication Server timeouts when using simple paged results on RHDS 8.2.
Bug 720059 - RDN with % can cause crashes or missing entries
bump version to 1.2.9.0
Bug 725542 - Instance upgrade fails when upgrading 389-ds-base package
Bug 725953 - Winsync: DS entries fail to sync to AD, if the User's CN entry contains a comma
Bug 723937 - replication failing on RUV errors
bump version to 1.2.9.1
Bug 727511 - ldclt SSL search requests are failing with "illegal error number -1" error
bump version to 1.2.9.2
Bug 727511 - ldclt SSL search requests are failing with "illegal error numbe
bump version to 1.2.9.3
Bug 727511 - ldclt SSL search requests are failing with "illegal error number -1" error
bump version to 1.2.9.4
Bug 727511 - ldclt SSL search requests are failing with "illegal error number -1" error
bump version to 1.2.9.5
Bug 729378 - delete user subtree container in AD + modify password in DS == DS crash
Bug 723937 - replication failing on RUV errors
Bug 729369 - upgrade DB to upgrade from entrydn to entryrdn format is not working.
make sure the DBVERSION file ends in a newline
bump version to 1.2.10.a1
Bug 633803 - passwordisglobalpolicy attribute brakes TLS chaining
Bug 733103 - large targetattr list with syntax errors cause server to crash or hang
Bug 703990 - cross-platform - Support upgrade from Red Hat Directory Server
Bug 735121 - simple paged search + ip/dns based ACI hangs server
Bug 695736 - Providing native systemd file for upcoming F15 Feature Systemd
Bug 590826 - Reloading database from ldif causes changelog to emit "data no longer matches" errors
Bug 736712 - Modifying ruv entry deadlocks server
Add support for pre/post db transaction plugins
Make all backend operations transaction aware
Bug 741744 - MOD operations with chained delete/add get back error 53 on backend config
Bug 742324 - allow nsslapd-idlistscanlimit to be set dynamically and per-user
Bug 741744 - part2 - MOD operations with chained delete/add get back error 53 on backend config
Bug 740942 - allow resource limits to be set for paged searches independently of limits for other searches/operations
bump version to 1.2.10.a2
bump version to 1.2.10.a3
fix transaction support in ldbm_delete
bump version to 1.2.10.a4
set the ENTRY_POST_OP for modrdn betxnpostoperation plugins
pass the plugin config entry to the plugin init function
make memberof transaction aware and able to be a betxnpostoperation plugin
Bug 741744 - part3 - MOD operations with chained delete/add get back error 53
bump version to 1.2.10.a5
Change referential integrity to be a betxnpostoperation plugin
Use new PLUGIN_CONFIG_ENTRY feature to allow switching between txn and regular
Bug 748575 - rhds81 modrn operation and 100% cpu use in replication
Bug 748575 - part 2 - rhds81 modrdn operation and 100% cpu use in replication
Bug 751495 - 'setup-ds.pl -u' fails with undefined routine 'updateSystemD'
bump version to 1.2.10.a6
Bug 751645 - crash when simple paged fails to send entry to client
csn_as_string - use slapi_uN_to_hex instead of sprintf
uniqueid formatting - use slapi_u8_to_hex instead of sprintf
fix member variable name error in slapi_uniqueIDFormat
reduce calls to csn_as_string and slapi_log_error
csn_init_as_string should not use sscanf
use slapi_hexchar2int and slapi_str_to_u8 everywhere
Bug 755754 - Unable to start dirsrv service using systemd
Bug 755725 - 389 programs linked against openldap crash during shutdown
Ticket 1 - pre-normalize filter and pre-compile substring regex - and other optimizations
Ticket #162 - Infinite loop / spin inside strcmpi_fast, acl_read_access_allowed_on_attr, server DoS
bak2db gets stuck in infinite loop
Ticket #256 - debug build assertion in ACL_EvalDestroy()
bump version to 1.2.10.a7
Ticket #167 - Mixing transaction and non-transaction plugins can cause deadlock
fix mep sdn compiler warnings
add a hack to disable sasl hostname canonicalization - helps with testing when you don't want to set up correct host name resolution and/or cannot set the default system hostname
Ticket #12 - 389 DS DNA Plugin / Replication failing on GSSAPI
Ticket #257 - repl-monitor doesn't work if leftmost hostnames are the same
fix recent compiler warnings
Ticket #15 - Get rid of rwlock.h/rwlock.c and just use slapi_rwlock instead
fix compiler warnings
Remove redundant code - make a global into a static
Ticket #262 - pid file not removed with systemd
fix mozldap build issues
Ticket #264 - upgrade needs better check for "server is running"
Ticket #263 - add systemd include directive
bump version to 1.2.10.rc1
change version to 1.2.10.a8
Ticket #272 - add tombstonenumsubordinates to schema
bump version to 1.2.10.rc1
Ticket #161 - Review and address latest Coverity issues
Ticket #22 - RFE: Support sendmail LDAP routing schema
Ticket #29 - Samba3-schema is missing sambaTrustedDomainPassword
Ticket #273 - ruv tombstone searches don't work after reindex entryrdn
Ticket #273 - ruv tombstone searches don't work after reindex entryrdn
fix a couple of minor coverity issues
Ticket #87 - Manpages fixes
Ticket #13 - slapd process exits when put the database on read only mode while updates are coming to the server
Ticket #55 - Limit of 1024 characters for nsMatchingRule
Ticket #277 - cannot set repl referrals or state
Ticket #278 - Schema replication update failed: Invalid syntax
Ticket #277 - cannot set repl referrals or state
Ticket #279 - filter normalization does not use matching rules
Ticket #280 - extensible binary filters do not work
Ticket #281 - TLS not working with latest openldap
coverity 12488 Resource leak In attr_index_config(): Leak of memory or pointers to system resources
bump version to 1.2.10.rc2
fix compiler warning in acct policy plugin
bump version to 1.2.11.a1
Ticket #294 - 389 DS Segfaults during replica install in FreeIPA
coverity uninit var and resource leak
Revert "Ticket #111 - ability to control behavior of modifyTimestamp/modifiersName"
Revert "Ticket #167 - Mixing transaction and non-transaction plugins can cause deadlock"
Revert "Change referential integrity to be a betxnpostoperation plugin"
Revert "make memberof transaction aware and able to be a betxnpostoperation plugin"
Revert "pass the plugin config entry to the plugin init function"
coverity 12559 Uninitialized pointer read In ldbm_back_modify(): Reads an uninitialized pointer or its target
Ticket #281 - TLS not working with latest openldap
Trac Ticket #298 - crash when replicating orphaned tombstone entry
Ticket #301 - implement transaction support using thread local storage
init txn thread private data for all database modes
handle null smods
memleak in mep_parse_config_entry
memleak in normalize_mods2bvals
destroy the entry cache and dn cache in the dse post op delete callback
Ticket #289 - allow betxn plugin config changes
coverity 12563 Read from pointer after free
Ticket 317 - RHDS fractional replication with excluded password policy attributes leads to wrong error messages.
Ticket #305 - Certain CMP operations hang or cause ns-slapd to crash
Ticket #320 - allow most plugins to be betxn plugins
Ticket #324 - Sync with group attribute containing () fails
Ticket #324 - redux: Sync with group attribute containing () fails
Ticket #316 and Ticket #70 - add post add/mod and AD add callback hooks
Ticket #261 - Add Solaris i386
Ticket #331 - transaction errors with db 4.3 and db 4.2
schema def must have DESC '' - close paren must be preceded by space
Ticket #336 - [abrt] 389-ds-base-1.2.10.4-2.fc16: index_range_read_ext: Process /usr/sbin/ns-slapd was killed by signal 11 (SIGSEGV)
Ticket #336 - [abrt] 389-ds-base-1.2.10.4-2.fc16: index_range_read_ext: Process /usr/sbin/ns-slapd was killed by signal 11 (SIGSEGV)
Ticket #347 - IPA dirsvr seg-fault during system longevity test
Ticket #348 - crash in ldap_initialize with multiple threads
Ticket #351 - use betxn plugins by default
Ticket #353 - coverity 12625-12629 - leaks, dead code, unchecked return
Ticket #348 - crash in ldap_initialize with multiple threads
Ticket #351 - use betxn plugins by default
bump version to 1.3.0.a1
Ticket #358 - managed entry doesn't delete linked entry
Trac Ticket #359 - Database RUV could mismatch the one in changelog under the stress
console .2 is still compatible with 389 .3 for now
Ticket #321 - krbExtraData is being null modified and replicated on each ssh login
Ticket #360 - ldapmodify returns Operations error
Ticket #382 - DS Shuts down intermittently
Ticket #383 - usn + mmr = deletions are not replicated
Ticket #389 - ADD operations not in audit log
Ticket #360 - ldapmodify returns Operations error - fix delete caching
fix coverity issues with uninit vals, no return checking
Ticket #360 - ldapmodify returns Operations error - fix delete caching
improve txn test index handling
Ticket #387 - managed entry sometimes doesn't delete the managed entry
Ticket #387 - managed entry sometimes doesn't delete the managed entry
Ticket 378 - unhashed#user#password visible after changing password
Ticket #405 - referint modrdn not working if case is different
Ticket #406 - Impossible to rename entry (modrdn) with Attribute Uniqueness plugin enabled
Ticket #410 - Referential integrity plug-in does not work when update interval is not zero
Ticket #425 - support multiple winsync plugins
Ticket #430 - server to server ssl client auth broken with latest openldap
Ticket #426 - support posix schema for user and group sync
coverity - mbo dead code - winsync leaks, deadcode, null check, test code
Ticket #355 - winsync should not delete entry that appears to be out of scope
Ticket #440 - periodic dirsync timed event causes server to loop repeatedly
fix mem leaks with parent dn log message, setting winsync windows domain
coverity - posix winsync mem leaks, null check, deadcode, null ref, use after free
fix coverity resource leak in windows_plugin_add
Ticket #426 - support posix schema for user and group sync
Ticket #374 - consumer can go into total update mode for no reason
Ticket #461 - fix build problem with mozldap c sdk
Ticket #462 - add test for include file mntent.h
Ticket #463 - different parameters of getmntent in Solaris
add eclipse generated files to the ignore list
fix compiler warnings in ticket 374 code
Ticket #491 - multimaster_extop_cleanruv returns wrong error codes
minor fixes for bdb 4.2/4.3 and mozldap
Ticket #322 - Create DOAP description for the 389 Directory Server project
Ticket #508 - part 1 - lock-free access to FrontendConfig structure
Ticket #508 - part 2 - lock-free access to FrontendConfig structure
Ticket #612 - improve dbgen rdn generation, output
Ticket #613 - ldclt: add timestamp, interval, nozeropad, other improvements
Ticket #47299 - allow cmdline scripts to work with non-root user
Ticket #47302 - get rid of sbindir start/stop/restart slapd scripts
Ticket #47303 - start/stop/restart dirsrv scripts should report and error if no instances
Ticket #47302 - get rid of sbindir start/stop/restart slapd scripts
Ticket #565 - turbo mode and replication - allow disable of turbo mode
Ticket #633 - allow nsslapd-nagle to be disabled, and also tcp cork
Ticket #613 - ldclt: add timestamp, interval, nozeropad, other improvements
Ticket #47312 - replace PR_GetFileInfo with PR_GetFileInfo64
Ticket #574 - problems with dbcachesize disk space calculation
Ticket #47312 - replace PR_GetFileInfo with PR_GetFileInfo64
Ticket #514 - investigate connection locking
Ticket #513 - recycle operation pblocks
Ticket #47319 - make connection buffer size adjustable
Ticket #47320 - put conn on work_q not poll list if conn has buffered more_data
Ticket #47299 - allow cmdline scripts to work with non-root user
Ticket #47336 - logconv.pl -m not working for all stats
Ticket #47341 - logconv.pl -m time calculation is wrong
Ticket #47348 - add etimes to per second/minute stats
Ticket #47349 - DS instance crashes under a high load
Ticket #47362 - ipa upgrade selinuxusermap data not replicating
Ticket #47359 - new ldap connections can block ldaps and ldapi connections
Ticket #47359 - new ldap connections can block ldaps and ldapi connections
Ticket #47359 - new ldap connections can block ldaps and ldapi connections
Ticket #47378 - fix recent compiler warnings
Ticket #47387 - improve logconv.pl performance with large access logs
Ticket #47377 - make listen backlog size configurable
Ticket #47375 - flush_ber error sending back start_tls response will deadlock
Ticket #47409 - allow setting db deadlock rejection policy
Ticket #47409 - allow setting db deadlock rejection policy
Ticket #47409 - allow setting db deadlock rejection policy
Ticket #47387 - improve logconv.pl performance with large access logs
Ticket #47410 - changelog db deadlocks with DNA and replication
Ticket #47392 - ldbm errors when adding/modifying/deleting entries
Ticket 47427 - Overflow in nsslapd-disk-monitoring-threshold
Ticket #47424 - Replication problem with add-delete requests on single-valued attributes
Ticket 47427 - Overflow in nsslapd-disk-monitoring-threshold
Ticket #47448 - Segfault in 389-ds-base-1.3.1.4-1.fc19 when setting up FreeIPA replication
Ticket #47455 - valgrind - value mem leaks, uninit mem usage
Ticket #47456 - delete present values should append values to deleted values
fix coverity 11895 - null deref - caused by fix to ticket 47392
fix coverity 11915 - dead code - introduced with fix for ticket 346
Ticket #47455 - valgrind - value mem leaks, uninit mem usage
Bug 999634 - ns-slapd crash due to bogus DN
Ticket #47455 - valgrind - value mem leaks, uninit mem usage
Ticket #47516 replication stops with excessive clock skew
Ticket #47504 idlistscanlimit per index/type/value
Ticket #47504 idlistscanlimit per index/type/value
Ticket #47504 idlistscanlimit per index/type/value
Ticket #47501 logconv.pl uses /var/tmp for BDB temp files
Ticket 47533 logconv: some stats do not work across server restarts
Ticket #47515 Fedora 20: setup-ds-admin.pl
Ticket #47551 logconv: -V does not produce unindexed search report
bump autoconf to 2.69, automake to 1.13.4, libtool to 2.4.2
ticket #47550 wip
Ticket #47550 logconv: failed logins: Use of uninitialized value in numeric comparison at logconv.pl line 949
Ticket #47559 hung server - related to sasl and initialize
Ticket #47585 Replication Failures related to skipped entries due to cleaned rids
Revert "Ticket #47559 hung server - related to sasl and initialize"
Ticket #47596 attrcrypt fails to find unlocked key
Ticket #47605 CVE-2013-4485: DoS due to improper handling of ger attr searches
bump version to 1.3.3.a1
Ticket #381 Recognize compressed log files
Ticket 47599 - Reduce lock scope in retro changelog plug-in
bump version to 1.3.3.a2
Ticket #47596 attrcrypt fails to find unlocked key
Ticket #47623 fix memleak caused by 47347
Ticket #47623 fix memleak caused by 47347
Ticket #47631 objectclass may, must lists skip rest of objectclass once first is found in sup
Ticket #47645 reset stack, op fields to NULL - clean up stacks at shutdown - free unused plugin config entries
Ticket #47634 support AttributeTypeDescription USAGE userApplications distributedOperation dSAOperation
Ticket #47647 remove bogus definition in 60rfc3712.ldif
Ticket #47657 add schema test suite and tests for Ticket #47634
Ticket #47675 logconv errors when search has invalid bind dn
Ticket #47516 replication stops with excessive clock skew
Ticket #47374 - flush.pl is not included in perl5
Ticket #471 logconv.pl tool removes the access logs contents if "-M" is not correctly used
Ticket #47692 single valued attribute replicated ADD does not work
Ticket #47773 - mem leak in do_bind when there is an error
Ticket #47774 mem leak in do_search - rawbase not freed upon certain errors
Ticket #47772 empty modify returns LDAP_INVALID_DN_SYNTAX
Ticket #47772 empty modify returns LDAP_INVALID_DN_SYNTAX
Ticket #47831 - server restart wipes out index config if there is a default index
Ticket #47692 single valued attribute replicated ADD does not work
Ticket 47446 - logconv.pl memory continually grows
Ticket #47892 coverity defects found in 1.3.3.1
bump version to 1.3.3.3
Thierry bordaz (tbordaz) (49):
Ticket #487 - Possible to add invalid attribute values to PAM PTA plugin configuration
Ticket 600 - Server should return unavailableCriticalExtension when processing a badly formed critical control
Ticket 616 - High contention on computed attribute lock
Ticket 618 - Crash at shutdown while stopping replica agreements
Ticket 512 - improve performance of vattr code
Ticket 205 - snmp counters index strings for multiple network interfaces with ip addr and tcp port pairs
Ticket 47325 - Crash at shutdown on a replica aggrement
Ticket 47331 - Self entry access ACI not working properly
Ticket 47361 - Empty control list causes LDAP protocol error is thrown
Ticket 47354 - Indexed search are logged with 'notes=U' in the access logs
Ticket 47350 - Allow search to look up 'in memory RUV'
Compilation warnings (ticket 47350)
Ticket 47350 - (Cont.) Allow search to look up 'in memory RUV'
Ticket 564 - Is ldbm_txn_ruv_modify_context still required
Ticket 47393 - Attribute are not encrypted on a consumer after a full initialization
Ticket 208 - [RFE] Roles with explicit scoping in RHDS
Ticket 47433 - With SeLinux, setup-ds.pl and setup-ds-admin.pl fail to detect already ranged labelled ports
Ticket 512 - improve performance of vattr code
Ticket 47489 - Under specific values of nsDS5ReplicaName, replication may get broken or updates missing
Ticket 47490 - Schema replication between DS versions may overwrite newer base schema
Ticket 47398 - memberOf on a user is converted to lowercase
Ticket 47560: fixup memberof task does not work: task entry not added
Ticket 47586 - CI tests: test case for 47490
Ticket 47586 - CI tests: follow up
Ticket 47586 - Need to rebind after a stop (fix to run direct python script)
Ticket 47575 - CI test: add test case for ticket47560
Ticket 47628: port testcases to new DirSrv interface
Ticket 47651 - Finaliser to remove instances backups
Ticket 47668 - test: port ticket47490_test to Replica/Agreement interface (47600)
Ticket 47653 - Need a way to allow users to create entries assigned to themselves.
Ticket 47676 : Replication of the schema fails 'master branch' -> 1.2.11 or 1.3.1
Ticket 47676 : (cont.) Replication of the schema fails 'master branch' -> 1.2.11 or 1.3.1
Ticket 47573: schema push can be erronously prevented
Update test cases due to new modules: Schema, tasks, plugins and index
Ticket 47619: cannot reindex retrochangelog
Ticket 47699: Propagate plugin precedence to all registered function types
Ticket 47553: Enhance ACIs to have more control over MODRDN operations
Ticket 47721 - Schema Replication Issue
Ticket 47721 - Schema Replication Issue (follow up + cleanup)
Ticket 47721 - Schema Replication Issue (follow up)
Ticket 47787 - A replicated MOD fails (Unwilling to perform) if it targets a tombstone
Ticket 47808 - If be_txn plugin fails in ldbm_back_add, adding entry is double freed
Ticket 47815 - Add operations rejected by betxn plugins remain in cache
Ticket 47829: memberof scope: allow to exclude subtrees
Ticket 47823 - attribute uniqueness enforced on all subtrees
Ticket 47797 - DB deadlock when two threads (on separated backend) try to record changes in retroCL
Ticket 47797 - fix the indentation
Ticket 47871 - 389-ds-base-1.3.2.21-1.fc20 crashed over the weekend
Ticket 47889 - DS crashed during ipa-server-install on test_ava_filter
nturpin (1):
Ticket #3: acl cache overflown problem
root (4):
Bug 480787 - Autoconf parameter --with and --without
Ticket #326 - MemberOf plugin should work on all backends
Ticket #337 - RFE - Improve CLEANRUV functionality
Ticket #216 - RFE - Disable replication agreements
---
.gitignore | 5
389-doap.rdf | 47
Makefile.am | 419
Makefile.in | 8316 +-
README | 11
VERSION.sh | 18
aclocal.m4 | 7477 --
autogen.sh | 108
compile | 245
config.guess | 615
config.h.in | 40
config.sub | 427
configure |40020 +++++-------
configure.ac | 273
depcomp | 637
dirsrv.pc.in | 7
dirsrvtests/data/README | 11
dirsrvtests/suites/schema/constants.py | 33
dirsrvtests/suites/schema/finalizer.py | 51
dirsrvtests/suites/schema/test_schema.py | 260
dirsrvtests/tickets/constants.py | 69
dirsrvtests/tickets/finalizer.py | 57
dirsrvtests/tickets/ticket47313_test.py | 226
dirsrvtests/tickets/ticket47490_test.py | 677
dirsrvtests/tickets/ticket47553_single_aci_test.py | 1190
dirsrvtests/tickets/ticket47560_test.py | 307
dirsrvtests/tickets/ticket47573_test.py | 418
dirsrvtests/tickets/ticket47619_test.py | 301
dirsrvtests/tickets/ticket47653MMR_test.py | 555
dirsrvtests/tickets/ticket47653_test.py | 435
dirsrvtests/tickets/ticket47664_test.py | 273
dirsrvtests/tickets/ticket47676_test.py | 488
dirsrvtests/tickets/ticket47714_test.py | 312
dirsrvtests/tickets/ticket47721_test.py | 495
dirsrvtests/tickets/ticket47781_test.py | 238
dirsrvtests/tickets/ticket47787_test.py | 633
dirsrvtests/tickets/ticket47808_test.py | 215
dirsrvtests/tickets/ticket47815_test.py | 230
dirsrvtests/tickets/ticket47819_test.py | 348
dirsrvtests/tickets/ticket47823_test.py | 1049
dirsrvtests/tickets/ticket47824_test.py | 313
dirsrvtests/tickets/ticket47829_test.py | 712
dirsrvtests/tickets/ticket47838_test.py | 657
dirsrvtests/tickets/ticket47869MMR_test.py | 416
dirsrvtests/tickets/ticket47871_test.py | 306
dirsrvtests/tmp/README | 10
include/base/dbtbase.h | 2
include/base/file.h | 5
include/base/lexer.h | 126
include/base/pool.h | 5
include/base/rwlock.h | 91
include/i18n.h | 121
include/ldaputil/ldaputil.h | 10
include/libaccess/acl.h | 4
include/libaccess/aclerror.h | 13
include/libaccess/acleval.h | 3
include/libaccess/aclproto.h | 25
include/libaccess/aclstruct.h | 2
include/libaccess/dbtlibaccess.h | 3
include/libaccess/las.h | 6
include/libaccess/nsautherr.h | 2
include/libaccess/nserror.h | 2
include/libaccess/symbols.h | 4
include/public/nsacl/aclapi.h | 18
include/public/nsacl/acldef.h | 2
include/public/nsacl/nserrdef.h | 2
install-sh | 538
ldap/admin/src/base-initconfig.in | 44
ldap/admin/src/initconfig.in | 37
ldap/admin/src/logconv.pl | 3455 -
ldap/admin/src/scripts/10cleanupldapi.pl | 23
ldap/admin/src/scripts/10fixrundir.pl | 11
ldap/admin/src/scripts/20betxn.pl | 74
ldap/admin/src/scripts/50acctusabilityplugin.ldif | 21
ldap/admin/src/scripts/50automemberplugin.ldif | 15
ldap/admin/src/scripts/50contentsync.ldif | 23
ldap/admin/src/scripts/50fixNsState.pl | 240
ldap/admin/src/scripts/50managedentriesplugin.ldif | 16
ldap/admin/src/scripts/50nstombstonecsn.ldif | 7
ldap/admin/src/scripts/50refintprecedence.ldif | 4
ldap/admin/src/scripts/50rootdnaccesscontrolplugin.ldif | 15
ldap/admin/src/scripts/50smd5pwdstorageplugin.ldif | 5
ldap/admin/src/scripts/50targetuniqueid.ldif | 7
ldap/admin/src/scripts/50updateconfig.ldif | 10
ldap/admin/src/scripts/60upgradeconfigfiles.pl | 69
ldap/admin/src/scripts/60upgradeschemafiles.pl | 2
ldap/admin/src/scripts/70upgradefromldif.pl | 108
ldap/admin/src/scripts/80upgradednformat.pl.in | 307
ldap/admin/src/scripts/81changelog.pl | 34
ldap/admin/src/scripts/82targetuniqueidindex.pl | 52
ldap/admin/src/scripts/90subtreerename.pl | 21
ldap/admin/src/scripts/91subtreereindex.pl | 148
ldap/admin/src/scripts/DSCreate.pm.in | 470
ldap/admin/src/scripts/DSDialogs.pm | 12
ldap/admin/src/scripts/DSMigration.pm.in | 49
ldap/admin/src/scripts/DSSharedLib.in | 227
ldap/admin/src/scripts/DSUpdate.pm.in | 52
ldap/admin/src/scripts/DSUtil.pm.in | 884
ldap/admin/src/scripts/DialogManager.pm | 241
ldap/admin/src/scripts/DialogManager.pm.in | 241
ldap/admin/src/scripts/Inf.pm | 67
ldap/admin/src/scripts/Migration.pm.in | 20
ldap/admin/src/scripts/Setup.pm.in | 20
ldap/admin/src/scripts/SetupDialogs.pm.in | 31
ldap/admin/src/scripts/SetupLog.pm | 8
ldap/admin/src/scripts/bak2db.in | 76
ldap/admin/src/scripts/bak2db.pl.in | 149
ldap/admin/src/scripts/cleanallruv.pl.in | 154
ldap/admin/src/scripts/db2bak.in | 76
ldap/admin/src/scripts/db2bak.pl.in | 178
ldap/admin/src/scripts/db2index.in | 83
ldap/admin/src/scripts/db2index.pl.in | 213
ldap/admin/src/scripts/db2ldif.in | 160
ldap/admin/src/scripts/db2ldif.pl.in | 293
ldap/admin/src/scripts/dbmon.sh | 221
ldap/admin/src/scripts/dbverify.in | 68
ldap/admin/src/scripts/dn2rdn.in | 58
ldap/admin/src/scripts/dnaplugindepends.ldif | 3
ldap/admin/src/scripts/ds-logpipe.py | 223
ldap/admin/src/scripts/exampleupdate.ldif | 2
ldap/admin/src/scripts/exampleupdate.sh | 10
ldap/admin/src/scripts/fixup-linkedattrs.pl.in | 140
ldap/admin/src/scripts/fixup-memberof.pl.in | 149
ldap/admin/src/scripts/ldif2db.in | 109
ldap/admin/src/scripts/ldif2db.pl.in | 243
ldap/admin/src/scripts/ldif2ldap.in | 173
ldap/admin/src/scripts/logregex.py | 16
ldap/admin/src/scripts/migrate-ds.pl.in | 13
ldap/admin/src/scripts/monitor.in | 170
ldap/admin/src/scripts/ns-accountstatus.pl.in | 708
ldap/admin/src/scripts/ns-activate.pl.in | 710
ldap/admin/src/scripts/ns-inactivate.pl.in | 712
ldap/admin/src/scripts/ns-newpwpolicy.pl.in | 217
ldap/admin/src/scripts/remove-ds.pl.in | 38
ldap/admin/src/scripts/repl-monitor.pl.in | 782
ldap/admin/src/scripts/restart-dirsrv.in | 28
ldap/admin/src/scripts/restoreconfig.in | 52
ldap/admin/src/scripts/saveconfig.in | 53
ldap/admin/src/scripts/schema-reload.pl.in | 139
ldap/admin/src/scripts/setup-ds.pl.in | 17
ldap/admin/src/scripts/setup-ds.res.in | 41
ldap/admin/src/scripts/start-dirsrv.in | 63
ldap/admin/src/scripts/stop-dirsrv.in | 65
ldap/admin/src/scripts/suffix2instance.in | 58
ldap/admin/src/scripts/syntax-validate.pl.in | 151
ldap/admin/src/scripts/template-bak2db.in | 44
ldap/admin/src/scripts/template-bak2db.pl.in | 102
ldap/admin/src/scripts/template-cleanallruv.pl.in | 54
ldap/admin/src/scripts/template-db2bak.in | 23
ldap/admin/src/scripts/template-db2bak.pl.in | 93
ldap/admin/src/scripts/template-db2index.in | 26
ldap/admin/src/scripts/template-db2index.pl.in | 192
ldap/admin/src/scripts/template-db2ldif.in | 79
ldap/admin/src/scripts/template-db2ldif.pl.in | 238
ldap/admin/src/scripts/template-dbverify.in | 41
ldap/admin/src/scripts/template-dn2rdn.in | 23
ldap/admin/src/scripts/template-fixup-linkedattrs.pl.in | 120
ldap/admin/src/scripts/template-fixup-memberof.pl.in | 131
ldap/admin/src/scripts/template-fixup-memberuid.pl.in | 180
ldap/admin/src/scripts/template-ldif2db.in | 23
ldap/admin/src/scripts/template-ldif2db.pl.in | 194
ldap/admin/src/scripts/template-ldif2ldap.in | 15
ldap/admin/src/scripts/template-monitor.in | 14
ldap/admin/src/scripts/template-ns-accountstatus.pl.in | 810
ldap/admin/src/scripts/template-ns-activate.pl.in | 810
ldap/admin/src/scripts/template-ns-inactivate.pl.in | 810
ldap/admin/src/scripts/template-ns-newpwpolicy.pl.in | 253
ldap/admin/src/scripts/template-restart-slapd.in | 12
ldap/admin/src/scripts/template-restoreconfig.in | 16
ldap/admin/src/scripts/template-saveconfig.in | 17
ldap/admin/src/scripts/template-schema-reload.pl.in | 120
ldap/admin/src/scripts/template-start-slapd.in | 12
ldap/admin/src/scripts/template-stop-slapd.in | 11
ldap/admin/src/scripts/template-suffix2instance.in | 15
ldap/admin/src/scripts/template-syntax-validate.pl.in | 131
ldap/admin/src/scripts/template-upgradedb.in | 17
ldap/admin/src/scripts/template-upgradednformat.in | 5
ldap/admin/src/scripts/template-usn-tombstone-cleanup.pl.in | 149
ldap/admin/src/scripts/template-verify-db.pl.in | 223
ldap/admin/src/scripts/template-vlvindex.in | 16
ldap/admin/src/scripts/upgradedb.in | 59
ldap/admin/src/scripts/upgradednformat.in | 71
ldap/admin/src/scripts/usn-tombstone-cleanup.pl.in | 155
ldap/admin/src/scripts/verify-db.pl.in | 267
ldap/admin/src/scripts/vlvindex.in | 64
ldap/admin/src/slapd.inf.in | 2
ldap/admin/src/template-initconfig.in | 18
ldap/docs/LICENSE.txt | 132
ldap/docs/README.txt | 11
ldap/include/ldaplog.h | 32
ldap/ldif/50posix-winsync-plugin.ldif | 21
ldap/ldif/50replication-plugins.ldif | 27
ldap/ldif/template-baseacis.ldif.in | 2
ldap/ldif/template-bitwise.ldif.in | 6
ldap/ldif/template-dnaplugin.ldif.in | 2
ldap/ldif/template-dse.ldif.in | 198
ldap/ldif/template-pampta.ldif.in | 2
ldap/ldif/template-suffix-db.ldif.in | 1
ldap/libraries/libavl/avl.c | 7
ldap/schema/00core.ldif | 72
ldap/schema/01core389.ldif | 229
ldap/schema/02common.ldif | 25
ldap/schema/05rfc4523.ldif | 14
ldap/schema/05rfc4524.ldif | 30
ldap/schema/06inetorgperson.ldif | 5
ldap/schema/10automember-plugin.ldif | 123
ldap/schema/10dna-plugin.ldif | 240
ldap/schema/10mep-plugin.ldif | 104
ldap/schema/30ns-common.ldif | 4
ldap/schema/50ns-directory.ldif | 4
ldap/schema/50ns-mail.ldif | 10
ldap/schema/60acctpolicy.ldif | 47
ldap/schema/60nis.ldif | 2
ldap/schema/60pam-plugin.ldif | 3
ldap/schema/60posix-winsync-plugin.ldif | 44
ldap/schema/60qmail.ldif | 24
ldap/schema/60radius.ldif | 132
ldap/schema/60rfc3712.ldif | 9
ldap/schema/60sabayon.ldif | 10
ldap/schema/60samba3.ldif | 36
ldap/schema/60sendmail.ldif | 54
ldap/schema/60sudo.ldif | 58
ldap/schema/slapd-collations.conf | 234
ldap/servers/plugins/acct_usability/acct_usability.c | 457
ldap/servers/plugins/acct_usability/acct_usability.h | 63
ldap/servers/plugins/acctpolicy/acct_config.c | 173
ldap/servers/plugins/acctpolicy/acct_init.c | 210
ldap/servers/plugins/acctpolicy/acct_plugin.c | 321
ldap/servers/plugins/acctpolicy/acct_util.c | 274
ldap/servers/plugins/acctpolicy/acctpolicy.h | 85
ldap/servers/plugins/acctpolicy/sampleconfig.ldif | 40
ldap/servers/plugins/acctpolicy/samplepolicy.ldif | 27
ldap/servers/plugins/acl/acl.c | 894
ldap/servers/plugins/acl/acl.h | 121
ldap/servers/plugins/acl/acl_ext.c | 240
ldap/servers/plugins/acl/aclanom.c | 75
ldap/servers/plugins/acl/acleffectiverights.c | 161
ldap/servers/plugins/acl/aclgroup.c | 32
ldap/servers/plugins/acl/aclinit.c | 6
ldap/servers/plugins/acl/acllas.c | 580
ldap/servers/plugins/acl/acllist.c | 204
ldap/servers/plugins/acl/aclparse.c | 939
ldap/servers/plugins/acl/aclplugin.c | 58
ldap/servers/plugins/acl/aclproxy.c | 232
ldap/servers/plugins/acl/aclutil.c | 139
ldap/servers/plugins/automember/automember.c | 2711
ldap/servers/plugins/automember/automember.h | 134
ldap/servers/plugins/bitwise/bitwise.c | 23
ldap/servers/plugins/chainingdb/cb.h | 15
ldap/servers/plugins/chainingdb/cb_add.c | 245
ldap/servers/plugins/chainingdb/cb_bind.c | 224
ldap/servers/plugins/chainingdb/cb_close.c | 78
ldap/servers/plugins/chainingdb/cb_compare.c | 101
ldap/servers/plugins/chainingdb/cb_config.c | 221
ldap/servers/plugins/chainingdb/cb_conn_stateless.c | 104
ldap/servers/plugins/chainingdb/cb_controls.c | 52
ldap/servers/plugins/chainingdb/cb_delete.c | 258
ldap/servers/plugins/chainingdb/cb_init.c | 6
ldap/servers/plugins/chainingdb/cb_instance.c | 646
ldap/servers/plugins/chainingdb/cb_modify.c | 301
ldap/servers/plugins/chainingdb/cb_modrdn.c | 305
ldap/servers/plugins/chainingdb/cb_monitor.c | 6
ldap/servers/plugins/chainingdb/cb_schema.c | 4
ldap/servers/plugins/chainingdb/cb_search.c | 548
ldap/servers/plugins/chainingdb/cb_utils.c | 30
ldap/servers/plugins/collation/collate.c | 49
ldap/servers/plugins/collation/orfilter.c | 19
ldap/servers/plugins/cos/cos.c | 85
ldap/servers/plugins/cos/cos_cache.c | 883
ldap/servers/plugins/cos/cos_cache.h | 1
ldap/servers/plugins/deref/deref.c | 164
ldap/servers/plugins/distrib/Makefile | 2
ldap/servers/plugins/dna/dna.c | 2481
ldap/servers/plugins/http/http_impl.c | 85
ldap/servers/plugins/linkedattrs/fixup_task.c | 200
ldap/servers/plugins/linkedattrs/linked_attrs.c | 440
ldap/servers/plugins/linkedattrs/linked_attrs.h | 5
ldap/servers/plugins/memberof/memberof.c | 1554
ldap/servers/plugins/memberof/memberof.h | 30
ldap/servers/plugins/memberof/memberof_config.c | 559
ldap/servers/plugins/mep/mep.c | 2883
ldap/servers/plugins/mep/mep.h | 130
ldap/servers/plugins/pam_passthru/pam_passthru.h | 50
ldap/servers/plugins/pam_passthru/pam_ptconfig.c | 735
ldap/servers/plugins/pam_passthru/pam_ptimpl.c | 90
ldap/servers/plugins/pam_passthru/pam_ptpreop.c | 659
ldap/servers/plugins/passthru/passthru.h | 9
ldap/servers/plugins/passthru/ptbind.c | 6
ldap/servers/plugins/passthru/ptconfig.c | 484
ldap/servers/plugins/passthru/ptconn.c | 8
ldap/servers/plugins/passthru/ptpreop.c | 32
ldap/servers/plugins/posix-winsync/README | 50
ldap/servers/plugins/posix-winsync/posix-group-func.c | 1027
ldap/servers/plugins/posix-winsync/posix-group-func.h | 25
ldap/servers/plugins/posix-winsync/posix-group-task.c | 494
ldap/servers/plugins/posix-winsync/posix-winsync-config.c | 326
ldap/servers/plugins/posix-winsync/posix-winsync.c | 2113
ldap/servers/plugins/posix-winsync/posix-wsp-ident.h | 58
ldap/servers/plugins/pwdstorage/smd5_pwd.c | 9
ldap/servers/plugins/referint/referint.c | 2155
ldap/servers/plugins/replication/cl4_api.c | 2
ldap/servers/plugins/replication/cl5.h | 5
ldap/servers/plugins/replication/cl5_api.c | 2955
ldap/servers/plugins/replication/cl5_api.h | 180
ldap/servers/plugins/replication/cl5_clcache.c | 177
ldap/servers/plugins/replication/cl5_clcache.h | 2
ldap/servers/plugins/replication/cl5_config.c | 282
ldap/servers/plugins/replication/cl5_init.c | 4
ldap/servers/plugins/replication/cl5_test.c | 4
ldap/servers/plugins/replication/cl_crypt.c | 203
ldap/servers/plugins/replication/cl_crypt.h | 53
ldap/servers/plugins/replication/csnpl.c | 74
ldap/servers/plugins/replication/legacy_consumer.c | 43
ldap/servers/plugins/replication/llist.c | 8
ldap/servers/plugins/replication/repl-session-plugin.h | 115
ldap/servers/plugins/replication/repl.h | 16
ldap/servers/plugins/replication/repl5.h | 212
ldap/servers/plugins/replication/repl5_agmt.c | 1132
ldap/servers/plugins/replication/repl5_agmtlist.c | 238
ldap/servers/plugins/replication/repl5_connection.c | 423
ldap/servers/plugins/replication/repl5_inc_protocol.c | 1510
ldap/servers/plugins/replication/repl5_init.c | 462
ldap/servers/plugins/replication/repl5_mtnode_ext.c | 19
ldap/servers/plugins/replication/repl5_plugins.c | 405
ldap/servers/plugins/replication/repl5_prot_private.h | 8
ldap/servers/plugins/replication/repl5_protocol.c | 189
ldap/servers/plugins/replication/repl5_protocol_util.c | 574
ldap/servers/plugins/replication/repl5_replica.c | 1830
ldap/servers/plugins/replication/repl5_replica_config.c | 3017
ldap/servers/plugins/replication/repl5_replica_dnhash.c | 26
ldap/servers/plugins/replication/repl5_replica_hash.c | 30
ldap/servers/plugins/replication/repl5_ruv.c | 775
ldap/servers/plugins/replication/repl5_ruv.h | 32
ldap/servers/plugins/replication/repl5_tot_protocol.c | 94
ldap/servers/plugins/replication/repl5_total.c | 30
ldap/servers/plugins/replication/repl5_updatedn_list.c | 126
ldap/servers/plugins/replication/repl_bind.c | 7
ldap/servers/plugins/replication/repl_compare.c | 18
ldap/servers/plugins/replication/repl_connext.c | 160
ldap/servers/plugins/replication/repl_controls.c | 2
ldap/servers/plugins/replication/repl_extop.c | 948
ldap/servers/plugins/replication/repl_globals.c | 23
ldap/servers/plugins/replication/repl_init.c | 1
ldap/servers/plugins/replication/repl_objset.c | 9
ldap/servers/plugins/replication/repl_session_plugin.c | 188
ldap/servers/plugins/replication/repl_shared.h | 20
ldap/servers/plugins/replication/replutil.c | 167
ldap/servers/plugins/replication/test_repl_session_plugin.c | 335
ldap/servers/plugins/replication/urp.c | 420
ldap/servers/plugins/replication/urp.h | 8
ldap/servers/plugins/replication/urp_glue.c | 51
ldap/servers/plugins/replication/urp_tombstone.c | 116
ldap/servers/plugins/replication/windows_connection.c | 398
ldap/servers/plugins/replication/windows_inc_protocol.c | 150
ldap/servers/plugins/replication/windows_private.c | 2890
ldap/servers/plugins/replication/windows_protocol_util.c | 2587
ldap/servers/plugins/replication/windows_tot_protocol.c | 221
ldap/servers/plugins/replication/windowsrepl.h | 83
ldap/servers/plugins/replication/winsync-plugin.h | 499
ldap/servers/plugins/retrocl/retrocl.c | 109
ldap/servers/plugins/retrocl/retrocl.h | 9
ldap/servers/plugins/retrocl/retrocl_cn.c | 59
ldap/servers/plugins/retrocl/retrocl_create.c | 13
ldap/servers/plugins/retrocl/retrocl_po.c | 237
ldap/servers/plugins/retrocl/retrocl_trim.c | 237
ldap/servers/plugins/rever/des.c | 72
ldap/servers/plugins/rever/rever.c | 8
ldap/servers/plugins/roles/roles_cache.c | 205
ldap/servers/plugins/roles/roles_cache.h | 2
ldap/servers/plugins/roles/roles_plugin.c | 74
ldap/servers/plugins/rootdn_access/rootdn_access.c | 710
ldap/servers/plugins/rootdn_access/rootdn_access.h | 55
ldap/servers/plugins/schema_reload/schema_reload.c | 96
ldap/servers/plugins/shared/plugin-utils.h | 112
ldap/servers/plugins/shared/utils.c | 508
ldap/servers/plugins/statechange/statechange.c | 125
ldap/servers/plugins/sync/sync.h | 199
ldap/servers/plugins/sync/sync_init.c | 177
ldap/servers/plugins/sync/sync_persist.c | 719
ldap/servers/plugins/sync/sync_refresh.c | 755
ldap/servers/plugins/sync/sync_util.c | 712
ldap/servers/plugins/syntaxes/bin.c | 142
ldap/servers/plugins/syntaxes/bitstring.c | 68
ldap/servers/plugins/syntaxes/ces.c | 172
ldap/servers/plugins/syntaxes/cis.c | 321
ldap/servers/plugins/syntaxes/deliverymethod.c | 32
ldap/servers/plugins/syntaxes/dn.c | 72
ldap/servers/plugins/syntaxes/facsimile.c | 38
ldap/servers/plugins/syntaxes/guide.c | 32
ldap/servers/plugins/syntaxes/int.c | 96
ldap/servers/plugins/syntaxes/nameoptuid.c | 73
ldap/servers/plugins/syntaxes/numericstring.c | 148
ldap/servers/plugins/syntaxes/sicis.c | 32
ldap/servers/plugins/syntaxes/string.c | 455
ldap/servers/plugins/syntaxes/syntax.h | 61
ldap/servers/plugins/syntaxes/syntax_common.c | 118
ldap/servers/plugins/syntaxes/tel.c | 94
ldap/servers/plugins/syntaxes/teletex.c | 32
ldap/servers/plugins/syntaxes/telex.c | 31
ldap/servers/plugins/syntaxes/validate.c | 17
ldap/servers/plugins/syntaxes/validate_task.c | 6
ldap/servers/plugins/syntaxes/value.c | 134
ldap/servers/plugins/uiduniq/7bit.c | 162
ldap/servers/plugins/uiduniq/plugin-utils.h | 96
ldap/servers/plugins/uiduniq/uid.c | 785
ldap/servers/plugins/uiduniq/utils.c | 249
ldap/servers/plugins/usn/usn.c | 424
ldap/servers/plugins/usn/usn.h | 2
ldap/servers/plugins/usn/usn_cleanup.c | 43
ldap/servers/plugins/views/views.c | 180
ldap/servers/plugins/whoami/whoami.c | 148
ldap/servers/slapd/abandon.c | 13
ldap/servers/slapd/add.c | 424
ldap/servers/slapd/agtmmap.c | 117
ldap/servers/slapd/agtmmap.h | 2
ldap/servers/slapd/apibroker.c | 60
ldap/servers/slapd/attr.c | 404
ldap/servers/slapd/attrlist.c | 50
ldap/servers/slapd/attrsyntax.c | 790
ldap/servers/slapd/auditlog.c | 87
ldap/servers/slapd/auth.c | 109
ldap/servers/slapd/ava.c | 2
ldap/servers/slapd/back-ldbm/ancestorid.c | 228
ldap/servers/slapd/back-ldbm/archive.c | 141
ldap/servers/slapd/back-ldbm/back-ldbm.h | 154
ldap/servers/slapd/back-ldbm/backentry.c | 7
ldap/servers/slapd/back-ldbm/cache.c | 511
ldap/servers/slapd/back-ldbm/dbhelp.c | 77
ldap/servers/slapd/back-ldbm/dblayer.c | 3156
ldap/servers/slapd/back-ldbm/dblayer.h | 18
ldap/servers/slapd/back-ldbm/dbsize.c | 7
ldap/servers/slapd/back-ldbm/dbtest.c | 349
ldap/servers/slapd/back-ldbm/dbverify.c | 6
ldap/servers/slapd/back-ldbm/dbversion.c | 82
ldap/servers/slapd/back-ldbm/dn2entry.c | 63
ldap/servers/slapd/back-ldbm/filterindex.c | 343
ldap/servers/slapd/back-ldbm/findentry.c | 147
ldap/servers/slapd/back-ldbm/id2entry.c | 199
ldap/servers/slapd/back-ldbm/idl.c | 172
ldap/servers/slapd/back-ldbm/idl_common.c | 42
ldap/servers/slapd/back-ldbm/idl_new.c | 554
ldap/servers/slapd/back-ldbm/idl_shim.c | 17
ldap/servers/slapd/back-ldbm/import-merge.c | 40
ldap/servers/slapd/back-ldbm/import-threads.c | 1875
ldap/servers/slapd/back-ldbm/import.c | 482
ldap/servers/slapd/back-ldbm/import.h | 57
ldap/servers/slapd/back-ldbm/index.c | 801
ldap/servers/slapd/back-ldbm/init.c | 89
ldap/servers/slapd/back-ldbm/instance.c | 178
ldap/servers/slapd/back-ldbm/ldbm_add.c | 1605
ldap/servers/slapd/back-ldbm/ldbm_attr.c | 892
ldap/servers/slapd/back-ldbm/ldbm_attrcrypt.c | 1027
ldap/servers/slapd/back-ldbm/ldbm_attrcrypt_config.c | 4
ldap/servers/slapd/back-ldbm/ldbm_bind.c | 42
ldap/servers/slapd/back-ldbm/ldbm_compare.c | 27
ldap/servers/slapd/back-ldbm/ldbm_config.c | 554
ldap/servers/slapd/back-ldbm/ldbm_config.h | 19
ldap/servers/slapd/back-ldbm/ldbm_delete.c | 1386
ldap/servers/slapd/back-ldbm/ldbm_entryrdn.c | 1848
ldap/servers/slapd/back-ldbm/ldbm_index_config.c | 699
ldap/servers/slapd/back-ldbm/ldbm_instance_config.c | 291
ldap/servers/slapd/back-ldbm/ldbm_modify.c | 832
ldap/servers/slapd/back-ldbm/ldbm_modrdn.c | 1817
ldap/servers/slapd/back-ldbm/ldbm_search.c | 874
ldap/servers/slapd/back-ldbm/ldbm_usn.c | 83
ldap/servers/slapd/back-ldbm/ldif2ldbm.c | 1006
ldap/servers/slapd/back-ldbm/matchrule.c | 50
ldap/servers/slapd/back-ldbm/misc.c | 322
ldap/servers/slapd/back-ldbm/monitor.c | 76
ldap/servers/slapd/back-ldbm/nextid.c | 17
ldap/servers/slapd/back-ldbm/parents.c | 148
ldap/servers/slapd/back-ldbm/perfctrs.c | 26
ldap/servers/slapd/back-ldbm/proto-back-ldbm.h | 115
ldap/servers/slapd/back-ldbm/seq.c | 115
ldap/servers/slapd/back-ldbm/sort.c | 196
ldap/servers/slapd/back-ldbm/start.c | 109
ldap/servers/slapd/back-ldbm/upgrade.c | 72
ldap/servers/slapd/back-ldbm/vlv.c | 408
ldap/servers/slapd/back-ldbm/vlv_srch.c | 17
ldap/servers/slapd/back-ldbm/vlv_srch.h | 3
ldap/servers/slapd/back-ldif/back-ldif.h | 2
ldap/servers/slapd/back-ldif/modify.c | 2
ldap/servers/slapd/back-ldif/modrdn.c | 12
ldap/servers/slapd/backend.c | 223
ldap/servers/slapd/backend_manager.c | 59
ldap/servers/slapd/bind.c | 457
ldap/servers/slapd/bulk_import.c | 39
ldap/servers/slapd/charray.c | 41
ldap/servers/slapd/compare.c | 43
ldap/servers/slapd/computed.c | 184
ldap/servers/slapd/config.c | 91
ldap/servers/slapd/configdse.c | 107
ldap/servers/slapd/connection.c | 1195
ldap/servers/slapd/conntable.c | 54
ldap/servers/slapd/control.c | 64
ldap/servers/slapd/csn.c | 89
ldap/servers/slapd/csngen.c | 75
ldap/servers/slapd/csnset.c | 4
ldap/servers/slapd/daemon.c | 955
ldap/servers/slapd/delete.c | 132
ldap/servers/slapd/dn.c | 2243
ldap/servers/slapd/dse.c | 1190
ldap/servers/slapd/dynalib.c | 36
ldap/servers/slapd/entry.c | 2172
ldap/servers/slapd/entrywsi.c | 807
ldap/servers/slapd/errormap.c | 18
ldap/servers/slapd/eventq.c | 4
ldap/servers/slapd/extendop.c | 39
ldap/servers/slapd/factory.c | 211
ldap/servers/slapd/fe.h | 33
ldap/servers/slapd/fedse.c | 194
ldap/servers/slapd/filter.c | 231
ldap/servers/slapd/filter.h | 1
ldap/servers/slapd/filtercmp.c | 26
ldap/servers/slapd/filterentry.c | 50
ldap/servers/slapd/generation.c | 1
ldap/servers/slapd/getfilelist.c | 4
ldap/servers/slapd/globals.c | 7
ldap/servers/slapd/index_subsystem.c | 33
ldap/servers/slapd/init.c | 2
ldap/servers/slapd/intrinsics.h | 7
ldap/servers/slapd/ldaputil.c | 1371
ldap/servers/slapd/lenstr.c | 6
ldap/servers/slapd/libglobs.c | 3354 -
ldap/servers/slapd/libslapd.def | 10
ldap/servers/slapd/log.c | 381
ldap/servers/slapd/log.h | 20
ldap/servers/slapd/main.c | 462
ldap/servers/slapd/mapping_tree.c | 646
ldap/servers/slapd/match.c | 96
ldap/servers/slapd/modify.c | 845
ldap/servers/slapd/modrdn.c | 377
ldap/servers/slapd/modutil.c | 77
ldap/servers/slapd/monitor.c | 8
ldap/servers/slapd/mozldap.h | 45
ldap/servers/slapd/ntperfdll/nsldapctr.cpp | 32
ldap/servers/slapd/ntperfdll/nsldapctrdef.h | 2
ldap/servers/slapd/ntperfdll/nsldapctrs.h | 10
ldap/servers/slapd/openldapber.h | 25
ldap/servers/slapd/operation.c | 217
ldap/servers/slapd/opshared.c | 546
ldap/servers/slapd/pagedresults.c | 787
ldap/servers/slapd/passwd_extop.c | 210
ldap/servers/slapd/pblock.c | 722
ldap/servers/slapd/plugin.c | 1920
ldap/servers/slapd/plugin_acl.c | 52
ldap/servers/slapd/plugin_internal_op.c | 204
ldap/servers/slapd/plugin_mr.c | 474
ldap/servers/slapd/plugin_syntax.c | 482
ldap/servers/slapd/protect_db.c | 24
ldap/servers/slapd/protect_db.h | 7
ldap/servers/slapd/proto-slap.h | 254
ldap/servers/slapd/proxyauth.c | 253
ldap/servers/slapd/psearch.c | 119
ldap/servers/slapd/pw.c | 1148
ldap/servers/slapd/pw.h | 30
ldap/servers/slapd/pw_mgmt.c | 177
ldap/servers/slapd/pw_retry.c | 124
ldap/servers/slapd/rdn.c | 293
ldap/servers/slapd/referral.c | 29
ldap/servers/slapd/regex.c | 35
ldap/servers/slapd/resourcelimit.c | 84
ldap/servers/slapd/result.c | 979
ldap/servers/slapd/rootdse.c | 12
ldap/servers/slapd/rwlock.c | 257
ldap/servers/slapd/rwlock.h | 65
ldap/servers/slapd/sasl_io.c | 352
ldap/servers/slapd/sasl_map.c | 278
ldap/servers/slapd/saslbind.c | 291
ldap/servers/slapd/schema.c | 4627 +
ldap/servers/slapd/schemaparse.c | 17
ldap/servers/slapd/search.c | 227
ldap/servers/slapd/security_wrappers.c | 36
ldap/servers/slapd/slap.h | 676
ldap/servers/slapd/slapi-plugin-compat4.h | 6
ldap/servers/slapd/slapi-plugin.h | 2267
ldap/servers/slapd/slapi-private.h | 218
ldap/servers/slapd/slapi2nspr.c | 79
ldap/servers/slapd/slapi_counter.c | 26
ldap/servers/slapd/snmp_collator.c | 114
ldap/servers/slapd/sort.c | 11
ldap/servers/slapd/ssl.c | 1312
ldap/servers/slapd/start_tls_extop.c | 230
ldap/servers/slapd/str2filter.c | 7
ldap/servers/slapd/task.c | 756
ldap/servers/slapd/test-plugins/Makefile.server | 2
ldap/servers/slapd/test-plugins/testbind.c | 1
ldap/servers/slapd/test-plugins/testdbinterop.c | 6
ldap/servers/slapd/test-plugins/testpostop.c | 3
ldap/servers/slapd/thread_data.c | 224
ldap/servers/slapd/time.c | 91
ldap/servers/slapd/tools/dbscan.c | 143
ldap/servers/slapd/tools/ldclt/data.c | 85
ldap/servers/slapd/tools/ldclt/ldapfct.c | 1211
ldap/servers/slapd/tools/ldclt/ldclt.c | 112
ldap/servers/slapd/tools/ldclt/ldclt.h | 22
ldap/servers/slapd/tools/ldclt/ldclt.man | 2
ldap/servers/slapd/tools/ldclt/ldclt.use | 2
ldap/servers/slapd/tools/ldclt/ldcltU.c | 28
ldap/servers/slapd/tools/ldclt/opCheck.c | 2
ldap/servers/slapd/tools/ldclt/parser.c | 19
ldap/servers/slapd/tools/ldclt/scalab01.c | 190
ldap/servers/slapd/tools/ldclt/threadMain.c | 24
ldap/servers/slapd/tools/ldclt/utils.c | 16
ldap/servers/slapd/tools/ldclt/utils.h | 1
ldap/servers/slapd/tools/ldclt/workarounds.c | 2
ldap/servers/slapd/tools/ldif.c | 9
ldap/servers/slapd/tools/migratecred.c | 15
ldap/servers/slapd/tools/mmldif.c | 35
ldap/servers/slapd/tools/pwenc.c | 25
ldap/servers/slapd/tools/rsearch/addthread.c | 51
ldap/servers/slapd/tools/rsearch/infadd.c | 7
ldap/servers/slapd/tools/rsearch/nametable.c | 14
ldap/servers/slapd/tools/rsearch/rsearch.c | 11
ldap/servers/slapd/tools/rsearch/scripts/dbgen.pl.in | 161
ldap/servers/slapd/tools/rsearch/sdattable.c | 64
ldap/servers/slapd/tools/rsearch/searchthread.c | 130
ldap/servers/slapd/unbind.c | 6
ldap/servers/slapd/uniqueid.c | 99
ldap/servers/slapd/utf8compare.c | 30
ldap/servers/slapd/util.c | 800
ldap/servers/slapd/uuid.c | 24
ldap/servers/slapd/value.c | 62
ldap/servers/slapd/valueset.c | 1223
ldap/servers/slapd/vattr.c | 169
ldap/servers/snmp/NETWORK-SERVICES-MIB.txt | 650
ldap/servers/snmp/RFC-1215.txt | 38
ldap/servers/snmp/RFC1155-SMI.txt | 119
ldap/servers/snmp/SNMPv2-CONF.txt | 322
ldap/servers/snmp/SNMPv2-SMI.txt | 344
ldap/servers/snmp/SNMPv2-TC.txt | 772
ldap/servers/snmp/ldap-agent.c | 38
ldap/servers/snmp/ldap-agent.h | 5
ldap/servers/snmp/main.c | 54
ldap/servers/snmp/netscape-ldap.mib | 759
ldap/servers/snmp/ntagt/nsldapagt_nt.c | 2
ldap/servers/snmp/ntagt/nsldapagt_nt.h | 2
ldap/servers/snmp/redhat-directory.mib | 41
ldap/systools/idsktune.c | 100
lib/base/crit.cpp | 6
lib/base/ereport.cpp | 2
lib/base/file.cpp | 28
lib/base/lexer.cpp | 1015
lib/base/plist.cpp | 3
lib/base/pool.cpp | 56
lib/base/rwlock.cpp | 168
lib/base/util.cpp | 25
lib/ldaputil/cert.c | 16
lib/ldaputil/certmap.c | 572
lib/ldaputil/dbconf.c | 14
lib/ldaputil/utest/Makefile | 149
lib/ldaputil/utest/auth.cpp | 611
lib/ldaputil/utest/authtest | 138
lib/ldaputil/utest/certmap.conf | 68
lib/ldaputil/utest/dblist.conf | 47
lib/ldaputil/utest/example.c | 153
lib/ldaputil/utest/plugin.c | 152
lib/ldaputil/utest/plugin.h | 57
lib/ldaputil/utest/stubs.c | 144
lib/ldaputil/utest/stubs.cpp | 139
lib/ldaputil/utest/test.ref | 480
lib/ldaputil/vtable.c | 2
lib/libaccess/acl.tab.cpp | 27
lib/libaccess/acl.yy.cpp | 5
lib/libaccess/aclcache.cpp | 131
lib/libaccess/aclerror.cpp | 4
lib/libaccess/acleval.cpp | 4
lib/libaccess/aclflush.cpp | 1
lib/libaccess/aclpriv.h | 1
lib/libaccess/aclscan.h | 1
lib/libaccess/aclspace.cpp | 4
lib/libaccess/acltext.y | 6
lib/libaccess/acltools.cpp | 2015
lib/libaccess/aclutil.cpp | 13
lib/libaccess/authdb.cpp | 112
lib/libaccess/lasdns.cpp | 299
lib/libaccess/lasgroup.cpp | 10
lib/libaccess/lasip.cpp | 413
lib/libaccess/lasip.h | 3
lib/libaccess/nsautherr.cpp | 12
lib/libaccess/nseframe.cpp | 3
lib/libaccess/oneeval.cpp | 286
lib/libaccess/permhash.h | 16
lib/libaccess/register.cpp | 106
lib/libaccess/symbols.cpp | 4
lib/libaccess/usrcache.cpp | 14
lib/libaccess/utest/.purify | 19
lib/libaccess/utest/Makefile | 147
lib/libaccess/utest/acl.dat | 44
lib/libaccess/utest/aclfile0 | 87
lib/libaccess/utest/aclfile1 | 43
lib/libaccess/utest/aclfile10 | 45
lib/libaccess/utest/aclfile11 | 43
lib/libaccess/utest/aclfile12 | 43
lib/libaccess/utest/aclfile13 | 43
lib/libaccess/utest/aclfile14 | 43
lib/libaccess/utest/aclfile15 | 43
lib/libaccess/utest/aclfile16 | 43
lib/libaccess/utest/aclfile17 | 43
lib/libaccess/utest/aclfile18 | 51
lib/libaccess/utest/aclfile19 | 46
lib/libaccess/utest/aclfile2 | 43
lib/libaccess/utest/aclfile3 | 43
lib/libaccess/utest/aclfile4 | 43
lib/libaccess/utest/aclfile5 | 43
lib/libaccess/utest/aclfile6 | 55
lib/libaccess/utest/aclfile7 | 43
lib/libaccess/utest/aclfile8 | 43
lib/libaccess/utest/aclfile9 | 43
lib/libaccess/utest/aclgrp0 | 42
lib/libaccess/utest/aclgrp1 | 42
lib/libaccess/utest/aclgrp2 | 42
lib/libaccess/utest/aclgrp3 | 42
lib/libaccess/utest/aclgrp4 | 42
lib/libaccess/utest/acltest.cpp | 794
lib/libaccess/utest/onetest.cpp | 77
lib/libaccess/utest/shexp.cpp | 331
lib/libaccess/utest/shexp.h | 168
lib/libaccess/utest/test.ref | 217
lib/libaccess/utest/testmain.cpp | 89
lib/libaccess/utest/twotest.cpp | 87
lib/libaccess/utest/ustubs.cpp | 331
lib/libadmin/error.c | 9
lib/libadmin/template.c | 2
lib/libadmin/util.c | 48
lib/libsi18n/coreres.c | 141
lib/libsi18n/coreres.h | 52
lib/libsi18n/getlang.c | 330
lib/libsi18n/getstrmem.c | 160
lib/libsi18n/getstrmem.h | 1
lib/libsi18n/getstrprop.c | 89
lib/libsi18n/makstrdb.c | 21
lib/libsi18n/propset.c | 442
lib/libsi18n/propset.h | 80
lib/libsi18n/reshash.c | 21
ltmain.sh |14878 ++--
m4/db.m4 | 27
m4/fhs.m4 | 4
m4/icu.m4 | 25
m4/kerberos.m4 | 4
m4/mozldap.m4 | 38
m4/netsnmp.m4 | 15
m4/nspr.m4 | 17
m4/nss.m4 | 17
m4/openldap.m4 | 30
m4/pcre.m4 | 28
m4/sasl.m4 | 25
m4/selinux.m4 | 13
m4/svrcore.m4 | 41
man/man1/cl-dump.1 | 20
man/man1/dbgen.pl.1 | 12
man/man1/dbscan.1 | 2
man/man1/ds-logpipe.py.1 | 14
man/man1/dsktune.1 | 2
man/man1/infadd.1 | 10
man/man1/ldap-agent.1 | 2
man/man1/ldclt.1 | 2
man/man1/ldif.1 | 2
man/man1/logconv.pl.1 | 47
man/man1/migratecred.1 | 8
man/man1/mmldif.1 | 6
man/man1/pwdhash.1 | 6
man/man1/repl-monitor.1 | 43
man/man1/rsearch.1 | 2
man/man8/bak2db.8 | 58
man/man8/bak2db.pl.8 | 82
man/man8/cleanallruv.pl.8 | 85
man/man8/db2bak.8 | 59
man/man8/db2bak.pl.8 | 78
man/man8/db2index.8 | 63
man/man8/db2index.pl.8 | 85
man/man8/db2ldif.8 | 102
man/man8/db2ldif.pl.8 | 124
man/man8/dbmon.sh.8 | 56
man/man8/dbverify.8 | 60
man/man8/dn2rdn.8 | 58
man/man8/fixup-linkedattrs.pl.8 | 76
man/man8/fixup-memberof.pl.8 | 80
man/man8/ldif2db.8 | 85
man/man8/ldif2db.pl.8 | 102
man/man8/ldif2ldap.8 | 62
man/man8/migrate-ds.pl.8 | 2
man/man8/monitor.8 | 67
man/man8/ns-accountstatus.pl.8 | 74
man/man8/ns-activate.pl.8 | 73
man/man8/ns-inactivate.pl.8 | 72
man/man8/ns-newpwpolicy.pl.8 | 79
man/man8/ns-slapd.8 | 12
man/man8/remove-ds.pl.8 | 8
man/man8/restart-dirsrv.8 | 50
man/man8/restoreconfig.8 | 48
man/man8/saveconfig.8 | 48
man/man8/schema-reload.pl.8 | 74
man/man8/setup-ds.pl.8 | 6
man/man8/start-dirsrv.8 | 50
man/man8/stop-dirsrv.8 | 50
man/man8/suffix2instance.8 | 51
man/man8/syntax-validate.pl.8 | 77
man/man8/upgradedb.8 | 56
man/man8/upgradednformat.8 | 55
man/man8/usn-tombstone-cleanup.pl.8 | 80
man/man8/verify-db.pl.8 | 49
man/man8/vlvindex.8 | 58
missing | 453
rpm.mk | 67
rpm/389-ds-base-devel.README | 4
rpm/389-ds-base-git.sh | 16
rpm/389-ds-base.spec.in | 1584
rpm/add_patches.sh | 55
rpm/rpmverrel.sh | 15
selinux/dirsrv.fc.in | 2
selinux/dirsrv.if | 41
selinux/dirsrv.te | 11
wrappers/cl-dump.in | 11
wrappers/dbscan.in | 10
wrappers/infadd.in | 12
wrappers/initscript.in | 247
wrappers/ldap-agent-initscript.in | 20
wrappers/ldap-agent.in | 12
wrappers/ldclt.in | 12
wrappers/ldif.in | 12
wrappers/migratecred.in | 14
wrappers/mmldif.in | 14
wrappers/pwdhash.in | 14
wrappers/repl-monitor.in | 11
wrappers/rsearch.in | 12
wrappers/systemd-snmp.service.in | 16
wrappers/systemd.group.in | 6
wrappers/systemd.template.service.in | 27
wrappers/systemd.template.sysconfig | 3
830 files changed, 168770 insertions(+), 94619 deletions(-)
---
9 years, 7 months
- 1
- 0
Branch '389-ds-base-1.3.3' - VERSION.sh
by Richard Allen Megginson
VERSION.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 9fe0713290da3988c3690da5d925ee0d288fef24
Author: Rich Megginson <rmeggins(a)redhat.com>
Date: Fri Sep 12 15:03:30 2014 -0600
bump version to 1.3.3.3
diff --git a/VERSION.sh b/VERSION.sh
index e23167e..2076749 100644
--- a/VERSION.sh
+++ b/VERSION.sh
@@ -10,7 +10,7 @@ vendor="389 Project"
# PACKAGE_VERSION is constructed from these
VERSION_MAJOR=1
VERSION_MINOR=3
-VERSION_MAINT=3.2
+VERSION_MAINT=3.3
# if this is a PRERELEASE, set VERSION_PREREL
# otherwise, comment it out
# be sure to include the dot prefix in the prerel
9 years, 7 months
- 1
- 0
ldap/servers lib/base lib/libaccess
by Richard Allen Megginson
ldap/servers/plugins/memberof/memberof.c | 6 +++---
ldap/servers/slapd/back-ldbm/ldif2ldbm.c | 2 +-
ldap/servers/slapd/tools/ldif.c | 5 ++++-
ldap/servers/slapd/tools/rsearch/nametable.c | 1 +
lib/base/pool.cpp | 10 +++++-----
lib/libaccess/aclcache.cpp | 2 +-
6 files changed, 15 insertions(+), 11 deletions(-)
New commits:
commit 66e43aee7151acf6939b1a646eb869c7ccf0f7a4
Author: Rich Megginson <rmeggins(a)redhat.com>
Date: Fri Sep 12 13:11:26 2014 -0600
Ticket #47892 coverity defects found in 1.3.3.1
https://fedorahosted.org/389/ticket/47892
Reviewed by: mreynolds, nkinder (Thanks!)
Branch: master
Fix Description:
9. 389-ds-base-1.3.3.1/ldap/servers/plugins/memberof/memberof.c:2079:var_compare_op – Comparing "group_norm_vals" to null implies that "group_norm_vals" might be null.
11. 389-ds-base-1.3.3.1/ldap/servers/plugins/memberof/memberof.c:2099:var_deref_model – Passing null pointer "group_norm_vals" to function "slapi_valueset_add_value_ext(Slapi_ValueSet *, Slapi_Value const *, unsigned long)", which dereferences it.
12. 389-ds-base-1.3.3.1/ldap/servers/slapd/valueset.c:896:2:deref_parm_in_call – Function "slapi_valueset_add_attr_valuearray_ext(Slapi_Attr const *, Slapi_ValueSet *, Slapi_Value **, int, unsigned long, int *)" dereferences "vs".
15. 389-ds-base-1.3.3.1/ldap/servers/slapd/valueset.c:1075:2:deref_parm – Directly dereferencing parameter "vs".
Added a check for group_norm_vals == NULL at beginning of function. I think this had a chain effect causing 11, 12, and 15 as well.
various - deprecated conversion from string constant - added const_cast<char *> as recommended by C++ guides.
2. 389-ds-base-1.3.3.1/ldap/servers/slapd/back-ldbm/ldif2ldbm.c:2198:78:warning – 'j' may be used uninitialized in this function [-Wmaybe-uninitialized]
Should have been using SLAPI_ATTR_TOMBSTONE_CSN
2. 389-ds-base-1.3.3.1/ldap/servers/plugins/acl/aclparse.c:538:28:warning – 'is_target_to' may be used uninitialized in this function [-Wmaybe-uninitialized]
2. 389-ds-base-1.3.3.1/ldap/servers/plugins/acl/acl.c:2493:26:warning – 'attrFilterArray' may be used uninitialized in this function [-Wmaybe-uninitialized]
These are false positives.
The minor memleaks were also fixed.
Platforms tested: Fedora 20
Flag Day: no
Doc impact: no
diff --git a/ldap/servers/plugins/memberof/memberof.c b/ldap/servers/plugins/memberof/memberof.c
index 6549718..bd87ee9 100644
--- a/ldap/servers/plugins/memberof/memberof.c
+++ b/ldap/servers/plugins/memberof/memberof.c
@@ -2044,10 +2044,10 @@ int memberof_get_groups_callback(Slapi_Entry *e, void *callback_data)
goto bail;
}
- if (!groupvals)
+ if (!groupvals || !group_norm_vals)
{
slapi_log_error( SLAPI_LOG_PLUGIN, MEMBEROF_PLUGIN_SUBSYSTEM,
- "memberof_get_groups_callback: NULL groupvals\n");
+ "memberof_get_groups_callback: NULL groupvals or group_norm_vals\n");
rc = -1;
goto bail;
@@ -2076,7 +2076,7 @@ int memberof_get_groups_callback(Slapi_Entry *e, void *callback_data)
* in config. We only need this attribute for it's syntax so the comparison can be
* performed. Since all of the grouping attributes are validated to use the Dinstinguished
* Name syntax, we can safely just use the first group_slapiattr. */
- if (group_norm_vals && slapi_valueset_find(
+ if (slapi_valueset_find(
((memberof_get_groups_data*)callback_data)->config->group_slapiattrs[0], group_norm_vals, group_ndn_val))
{
/* we either hit a recursive grouping, or an entry is
diff --git a/ldap/servers/slapd/back-ldbm/ldif2ldbm.c b/ldap/servers/slapd/back-ldbm/ldif2ldbm.c
index ab3a4a5..523da09 100644
--- a/ldap/servers/slapd/back-ldbm/ldif2ldbm.c
+++ b/ldap/servers/slapd/back-ldbm/ldif2ldbm.c
@@ -2195,7 +2195,7 @@ ldbm_back_ldbm2index(Slapi_PBlock *pb)
if (task) {
slapi_task_log_notice(task, "%s: ERROR: failed to begin txn for "
"update index '%s' (err %d: %s)",
- inst->inst_name, indexAttrs[j], rc,
+ inst->inst_name, SLAPI_ATTR_TOMBSTONE_CSN, rc,
dblayer_strerror(rc));
}
return_value = -2;
diff --git a/ldap/servers/slapd/tools/ldif.c b/ldap/servers/slapd/tools/ldif.c
index e8e6f9b..e4527ba 100644
--- a/ldap/servers/slapd/tools/ldif.c
+++ b/ldap/servers/slapd/tools/ldif.c
@@ -142,7 +142,8 @@ int main( int argc, char **argv )
}
if (( out = ldif_type_and_value( type, val, cur )) == NULL ) {
- perror( "ldif_type_and_value" );
+ perror( "ldif_type_and_value" );
+ free( val );
return( 1 );
}
@@ -166,6 +167,7 @@ int main( int argc, char **argv )
maxlen *= 2;
if( (buf = (char *)realloc(buf, maxlen)) == NULL ) {
perror( "realloc" );
+ free( buf );
return( 1 );
}
(void)fgets(buf+curlen, maxlen/2 + 1, stdin);
@@ -176,6 +178,7 @@ int main( int argc, char **argv )
if (( out = ldif_type_and_value( type, buf, strlen( buf ) ))
== NULL ) {
perror( "ldif_type_and_value" );
+ free( buf );
return( 1 );
}
fputs( out, stdout );
diff --git a/ldap/servers/slapd/tools/rsearch/nametable.c b/ldap/servers/slapd/tools/rsearch/nametable.c
index 03a6ae1..9d56a34 100644
--- a/ldap/servers/slapd/tools/rsearch/nametable.c
+++ b/ldap/servers/slapd/tools/rsearch/nametable.c
@@ -160,6 +160,7 @@ int nt_load(NameTable *nt, const char *filename)
free(s);
break;
}
+ free(s);
}
PR_Close(fd);
return nt->size;
diff --git a/lib/base/pool.cpp b/lib/base/pool.cpp
index 9ee1b8c..ab952d1 100644
--- a/lib/base/pool.cpp
+++ b/lib/base/pool.cpp
@@ -178,7 +178,7 @@ _create_block(int size)
crit_exit(freelist_lock);
if (((newblock = (block_t *)PERM_MALLOC(sizeof(block_t))) == NULL) ||
((newblock->data = (char *)PERM_MALLOC(bytes)) == NULL)) {
- ereport(LOG_CATASTROPHE, "%s", XP_GetAdminStr(DBT_poolCreateBlockOutOfMemory_));
+ ereport(LOG_CATASTROPHE, const_cast<char *>("%s"), XP_GetAdminStr(DBT_poolCreateBlockOutOfMemory_));
if (newblock)
PERM_FREE(newblock);
return NULL;
@@ -259,7 +259,7 @@ pool_create()
}
if ( (newpool->curr_block =_create_block(BLOCK_SIZE)) == NULL) {
- ereport(LOG_CATASTROPHE, "%s", XP_GetAdminStr(DBT_poolCreateOutOfMemory_));
+ ereport(LOG_CATASTROPHE, const_cast<char *>("%s"), XP_GetAdminStr(DBT_poolCreateOutOfMemory_));
PERM_FREE(newpool);
return NULL;
}
@@ -280,7 +280,7 @@ pool_create()
crit_exit(known_pools_lock);
}
else
- ereport(LOG_CATASTROPHE, "%s", XP_GetAdminStr(DBT_poolCreateOutOfMemory_1));
+ ereport(LOG_CATASTROPHE, const_cast<char *>("%s"), XP_GetAdminStr(DBT_poolCreateOutOfMemory_1));
return (pool_handle_t *)newpool;
}
@@ -386,7 +386,7 @@ pool_malloc(pool_handle_t *pool_handle, size_t size)
*/
blocksize = ( (size + BLOCK_SIZE-1) / BLOCK_SIZE ) * BLOCK_SIZE;
if ( (pool->curr_block = _create_block(blocksize)) == NULL) {
- ereport(LOG_CATASTROPHE, "%s", XP_GetAdminStr(DBT_poolMallocOutOfMemory_));
+ ereport(LOG_CATASTROPHE, const_cast<char *>("%s"), XP_GetAdminStr(DBT_poolMallocOutOfMemory_));
#ifdef POOL_LOCKING
crit_exit(pool->lock);
#endif
@@ -408,7 +408,7 @@ pool_malloc(pool_handle_t *pool_handle, size_t size)
void _pool_free_error()
{
- ereport(LOG_WARN, "%s", XP_GetAdminStr(DBT_freeUsedWherePermFreeShouldHaveB_));
+ ereport(LOG_WARN, const_cast<char *>("%s"), XP_GetAdminStr(DBT_freeUsedWherePermFreeShouldHaveB_));
return;
}
diff --git a/lib/libaccess/aclcache.cpp b/lib/libaccess/aclcache.cpp
index 52e019b..a96b0c9 100644
--- a/lib/libaccess/aclcache.cpp
+++ b/lib/libaccess/aclcache.cpp
@@ -133,7 +133,7 @@ ACL_ListHashInit()
&ACLPermAllocOps,
NULL);
if (ACLListHash == NULL) {
- ereport(LOG_SECURITY, "Unable to allocate ACL List Hash\n");
+ ereport(LOG_SECURITY, const_cast<char *>("Unable to allocate ACL List Hash\n"));
return;
}
9 years, 7 months
- 1
- 0
Branch '389-ds-base-1.3.3' - ldap/servers lib/base lib/libaccess
by Richard Allen Megginson
ldap/servers/plugins/memberof/memberof.c | 6 +++---
ldap/servers/slapd/back-ldbm/ldif2ldbm.c | 2 +-
ldap/servers/slapd/tools/ldif.c | 5 ++++-
ldap/servers/slapd/tools/rsearch/nametable.c | 1 +
lib/base/pool.cpp | 10 +++++-----
lib/libaccess/aclcache.cpp | 2 +-
6 files changed, 15 insertions(+), 11 deletions(-)
New commits:
commit 6dc23ec794cd5644a40c223e7b66066f195d8d7d
Author: Rich Megginson <rmeggins(a)redhat.com>
Date: Fri Sep 12 13:11:26 2014 -0600
Ticket #47892 coverity defects found in 1.3.3.1
https://fedorahosted.org/389/ticket/47892
Reviewed by: mreynolds, nkinder (Thanks!)
Branch: 389-ds-base-1.3.3
Fix Description:
9. 389-ds-base-1.3.3.1/ldap/servers/plugins/memberof/memberof.c:2079:var_compare_op – Comparing "group_norm_vals" to null implies that "group_norm_vals" might be null.
11. 389-ds-base-1.3.3.1/ldap/servers/plugins/memberof/memberof.c:2099:var_deref_model – Passing null pointer "group_norm_vals" to function "slapi_valueset_add_value_ext(Slapi_ValueSet *, Slapi_Value const *, unsigned long)", which dereferences it.
12. 389-ds-base-1.3.3.1/ldap/servers/slapd/valueset.c:896:2:deref_parm_in_call – Function "slapi_valueset_add_attr_valuearray_ext(Slapi_Attr const *, Slapi_ValueSet *, Slapi_Value **, int, unsigned long, int *)" dereferences "vs".
15. 389-ds-base-1.3.3.1/ldap/servers/slapd/valueset.c:1075:2:deref_parm – Directly dereferencing parameter "vs".
Added a check for group_norm_vals == NULL at beginning of function. I think this had a chain effect causing 11, 12, and 15 as well.
various - deprecated conversion from string constant - added const_cast<char *> as recommended by C++ guides.
2. 389-ds-base-1.3.3.1/ldap/servers/slapd/back-ldbm/ldif2ldbm.c:2198:78:warning – 'j' may be used uninitialized in this function [-Wmaybe-uninitialized]
Should have been using SLAPI_ATTR_TOMBSTONE_CSN
2. 389-ds-base-1.3.3.1/ldap/servers/plugins/acl/aclparse.c:538:28:warning – 'is_target_to' may be used uninitialized in this function [-Wmaybe-uninitialized]
2. 389-ds-base-1.3.3.1/ldap/servers/plugins/acl/acl.c:2493:26:warning – 'attrFilterArray' may be used uninitialized in this function [-Wmaybe-uninitialized]
These are false positives.
The minor memleaks were also fixed.
Platforms tested: Fedora 20
Flag Day: no
Doc impact: no
(cherry picked from commit 66e43aee7151acf6939b1a646eb869c7ccf0f7a4)
diff --git a/ldap/servers/plugins/memberof/memberof.c b/ldap/servers/plugins/memberof/memberof.c
index 6549718..bd87ee9 100644
--- a/ldap/servers/plugins/memberof/memberof.c
+++ b/ldap/servers/plugins/memberof/memberof.c
@@ -2044,10 +2044,10 @@ int memberof_get_groups_callback(Slapi_Entry *e, void *callback_data)
goto bail;
}
- if (!groupvals)
+ if (!groupvals || !group_norm_vals)
{
slapi_log_error( SLAPI_LOG_PLUGIN, MEMBEROF_PLUGIN_SUBSYSTEM,
- "memberof_get_groups_callback: NULL groupvals\n");
+ "memberof_get_groups_callback: NULL groupvals or group_norm_vals\n");
rc = -1;
goto bail;
@@ -2076,7 +2076,7 @@ int memberof_get_groups_callback(Slapi_Entry *e, void *callback_data)
* in config. We only need this attribute for it's syntax so the comparison can be
* performed. Since all of the grouping attributes are validated to use the Dinstinguished
* Name syntax, we can safely just use the first group_slapiattr. */
- if (group_norm_vals && slapi_valueset_find(
+ if (slapi_valueset_find(
((memberof_get_groups_data*)callback_data)->config->group_slapiattrs[0], group_norm_vals, group_ndn_val))
{
/* we either hit a recursive grouping, or an entry is
diff --git a/ldap/servers/slapd/back-ldbm/ldif2ldbm.c b/ldap/servers/slapd/back-ldbm/ldif2ldbm.c
index ab3a4a5..523da09 100644
--- a/ldap/servers/slapd/back-ldbm/ldif2ldbm.c
+++ b/ldap/servers/slapd/back-ldbm/ldif2ldbm.c
@@ -2195,7 +2195,7 @@ ldbm_back_ldbm2index(Slapi_PBlock *pb)
if (task) {
slapi_task_log_notice(task, "%s: ERROR: failed to begin txn for "
"update index '%s' (err %d: %s)",
- inst->inst_name, indexAttrs[j], rc,
+ inst->inst_name, SLAPI_ATTR_TOMBSTONE_CSN, rc,
dblayer_strerror(rc));
}
return_value = -2;
diff --git a/ldap/servers/slapd/tools/ldif.c b/ldap/servers/slapd/tools/ldif.c
index e8e6f9b..e4527ba 100644
--- a/ldap/servers/slapd/tools/ldif.c
+++ b/ldap/servers/slapd/tools/ldif.c
@@ -142,7 +142,8 @@ int main( int argc, char **argv )
}
if (( out = ldif_type_and_value( type, val, cur )) == NULL ) {
- perror( "ldif_type_and_value" );
+ perror( "ldif_type_and_value" );
+ free( val );
return( 1 );
}
@@ -166,6 +167,7 @@ int main( int argc, char **argv )
maxlen *= 2;
if( (buf = (char *)realloc(buf, maxlen)) == NULL ) {
perror( "realloc" );
+ free( buf );
return( 1 );
}
(void)fgets(buf+curlen, maxlen/2 + 1, stdin);
@@ -176,6 +178,7 @@ int main( int argc, char **argv )
if (( out = ldif_type_and_value( type, buf, strlen( buf ) ))
== NULL ) {
perror( "ldif_type_and_value" );
+ free( buf );
return( 1 );
}
fputs( out, stdout );
diff --git a/ldap/servers/slapd/tools/rsearch/nametable.c b/ldap/servers/slapd/tools/rsearch/nametable.c
index 03a6ae1..9d56a34 100644
--- a/ldap/servers/slapd/tools/rsearch/nametable.c
+++ b/ldap/servers/slapd/tools/rsearch/nametable.c
@@ -160,6 +160,7 @@ int nt_load(NameTable *nt, const char *filename)
free(s);
break;
}
+ free(s);
}
PR_Close(fd);
return nt->size;
diff --git a/lib/base/pool.cpp b/lib/base/pool.cpp
index 9ee1b8c..ab952d1 100644
--- a/lib/base/pool.cpp
+++ b/lib/base/pool.cpp
@@ -178,7 +178,7 @@ _create_block(int size)
crit_exit(freelist_lock);
if (((newblock = (block_t *)PERM_MALLOC(sizeof(block_t))) == NULL) ||
((newblock->data = (char *)PERM_MALLOC(bytes)) == NULL)) {
- ereport(LOG_CATASTROPHE, "%s", XP_GetAdminStr(DBT_poolCreateBlockOutOfMemory_));
+ ereport(LOG_CATASTROPHE, const_cast<char *>("%s"), XP_GetAdminStr(DBT_poolCreateBlockOutOfMemory_));
if (newblock)
PERM_FREE(newblock);
return NULL;
@@ -259,7 +259,7 @@ pool_create()
}
if ( (newpool->curr_block =_create_block(BLOCK_SIZE)) == NULL) {
- ereport(LOG_CATASTROPHE, "%s", XP_GetAdminStr(DBT_poolCreateOutOfMemory_));
+ ereport(LOG_CATASTROPHE, const_cast<char *>("%s"), XP_GetAdminStr(DBT_poolCreateOutOfMemory_));
PERM_FREE(newpool);
return NULL;
}
@@ -280,7 +280,7 @@ pool_create()
crit_exit(known_pools_lock);
}
else
- ereport(LOG_CATASTROPHE, "%s", XP_GetAdminStr(DBT_poolCreateOutOfMemory_1));
+ ereport(LOG_CATASTROPHE, const_cast<char *>("%s"), XP_GetAdminStr(DBT_poolCreateOutOfMemory_1));
return (pool_handle_t *)newpool;
}
@@ -386,7 +386,7 @@ pool_malloc(pool_handle_t *pool_handle, size_t size)
*/
blocksize = ( (size + BLOCK_SIZE-1) / BLOCK_SIZE ) * BLOCK_SIZE;
if ( (pool->curr_block = _create_block(blocksize)) == NULL) {
- ereport(LOG_CATASTROPHE, "%s", XP_GetAdminStr(DBT_poolMallocOutOfMemory_));
+ ereport(LOG_CATASTROPHE, const_cast<char *>("%s"), XP_GetAdminStr(DBT_poolMallocOutOfMemory_));
#ifdef POOL_LOCKING
crit_exit(pool->lock);
#endif
@@ -408,7 +408,7 @@ pool_malloc(pool_handle_t *pool_handle, size_t size)
void _pool_free_error()
{
- ereport(LOG_WARN, "%s", XP_GetAdminStr(DBT_freeUsedWherePermFreeShouldHaveB_));
+ ereport(LOG_WARN, const_cast<char *>("%s"), XP_GetAdminStr(DBT_freeUsedWherePermFreeShouldHaveB_));
return;
}
diff --git a/lib/libaccess/aclcache.cpp b/lib/libaccess/aclcache.cpp
index 52e019b..a96b0c9 100644
--- a/lib/libaccess/aclcache.cpp
+++ b/lib/libaccess/aclcache.cpp
@@ -133,7 +133,7 @@ ACL_ListHashInit()
&ACLPermAllocOps,
NULL);
if (ACLListHash == NULL) {
- ereport(LOG_SECURITY, "Unable to allocate ACL List Hash\n");
+ ereport(LOG_SECURITY, const_cast<char *>("Unable to allocate ACL List Hash\n"));
return;
}
9 years, 7 months
- 1
- 0