[389-commits] [389-ds-base] branch 389-ds-base-1.3.8 updated: Issue 49624 - modrdn silently fails if DB deadlock occurs

This is an automated email from the git hooks/post-receive script.

mreynolds pushed a commit to branch 389-ds-base-1.3.8
in repository 389-ds-base.

The following commit(s) were added to refs/heads/389-ds-base-1.3.8 by this push:
     new 2855482  Issue 49624 - modrdn silently fails if DB deadlock occurs
2855482 is described below

commit 2855482a6fa910db5037be4a19f4e7f6b207907b
Author: Mark Reynolds <mreynolds(a)redhat.com&gt;
AuthorDate: Thu Aug 22 10:26:24 2019 -0400

    Issue 49624 - modrdn silently fails if DB deadlock occurs
    
    Bug Description:
    
    If a DB Deadlock error occurs during a modrdn operation the entry
    cache gets updated (corrupted), but the update is not applied to
    the database.
    
    Fix Description:
    
    Looks like there was a copy & paste error, and the wrong attribute
    was updated during the retry of the modrdn operation.
    
    relates: https://pagure.io/389-ds-base/issue/49624
    
    Reviewed by: lkrispenz (Thanks!)
---
 ldap/servers/slapd/back-ldbm/ldbm_modrdn.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ldap/servers/slapd/back-ldbm/ldbm_modrdn.c
b/ldap/servers/slapd/back-ldbm/ldbm_modrdn.c
index 4fff35a..1be9a59 100644
--- a/ldap/servers/slapd/back-ldbm/ldbm_modrdn.c
+++ b/ldap/servers/slapd/back-ldbm/ldbm_modrdn.c
@@ -251,7 +251,7 @@ ldbm_back_modrdn(Slapi_PBlock *pb)
             slapi_pblock_get(pb, SLAPI_MODRDN_NEWSUPERIOR_SDN, &dn_newsuperiordn);
             slapi_sdn_free(&dn_newsuperiordn);
             slapi_pblock_set(pb, SLAPI_MODRDN_NEWSUPERIOR_SDN, orig_dn_newsuperiordn);
-            orig_dn_newsuperiordn = slapi_sdn_dup(orig_dn_newsuperiordn);
+            dn_newsuperiordn = slapi_sdn_dup(orig_dn_newsuperiordn);
             /* must duplicate ec before returning it to cache,
              * which could free the entry. */
             if ((tmpentry = backentry_dup(original_entry ? original_entry : ec)) == NULL)
{

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.