ldap/servers/slapd/value.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
New commits: commit b1972458e2a5d1756f4aed678ff3828535ea626f Author: Noriko Hosoi nhosoi@ponyo.sjc.redhat.com Date: Tue Feb 21 13:22:07 2012 -0800
Trac Ticket #290 - server hangs during shutdown if betxn pre/post op fails
https://fedorahosted.org/389/ticket/290
Fix description: If a dn type modify value is invalid, the modify operation could crash the server. This patch fixes it. (cherry picked from commit 69087b4eb886d25f3c20fce7170874103ff52001)
diff --git a/ldap/servers/slapd/value.c b/ldap/servers/slapd/value.c index 30301e2..0d2a29b 100644 --- a/ldap/servers/slapd/value.c +++ b/ldap/servers/slapd/value.c @@ -594,10 +594,11 @@ value_normalize_value(Slapi_Value *value) if (slapi_sdn_get_dn(sdn)) { value->bv.bv_val = slapi_ch_strdup(slapi_sdn_get_dn(sdn)); value->bv.bv_len = slapi_sdn_get_ndn_len(sdn); + slapi_sdn_free(&sdn); } else { rc = 1; + slapi_ch_free((void **)&sdn); /* free just Slapi_DN */ } - slapi_sdn_free(&sdn);
return rc; }
389-commits@lists.fedoraproject.org