This is an automated email from the git hooks/post-receive script.
mreynolds pushed a change to branch 389-ds-base-1.3.7 in repository 389-ds-base.
from f807b9b Ticket 49529 - Fix Coverity warnings: invalid deferences new a2df295 Ticket 49531 - coverity issues - fix memory leaks
The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "adds" were already present in the repository and have only been added to this reference.
Summary of changes: ldap/servers/plugins/replication/cl5_api.c | 1 + ldap/servers/plugins/replication/urp.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-)
This is an automated email from the git hooks/post-receive script.
mreynolds pushed a commit to branch 389-ds-base-1.3.7 in repository 389-ds-base.
commit a2df295cdb36c71a7ed857b86f950305277928b8 Author: Mark Reynolds mreynolds@redhat.com Date: Fri Jan 12 09:50:34 2018 -0500
Ticket 49531 - coverity issues - fix memory leaks
Description: There were two false positives around pwpolicy struct being leaked, but it is freed when the pblock is destroyed. The other two leaks were real, but they only occurred during error conditions.
https://pagure.io/389-ds-base/issue/49531
Reviewed by: lkrispen (Thanks!)
(cherry picked from commit 700d7422e6309d2d405961abbb805fbfe852e53c) --- ldap/servers/plugins/replication/cl5_api.c | 1 + ldap/servers/plugins/replication/urp.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/ldap/servers/plugins/replication/cl5_api.c b/ldap/servers/plugins/replication/cl5_api.c index dc28579..89ae995 100644 --- a/ldap/servers/plugins/replication/cl5_api.c +++ b/ldap/servers/plugins/replication/cl5_api.c @@ -4046,6 +4046,7 @@ _cl5WriteRUV(CL5DBFile *file, PRBool purge) slapi_log_err(SLAPI_LOG_ERR, repl_plugin_name_cl, "_cl5WriteRUV - changelog maxRUV not found in changelog for file %s\n", file->name); + ber_bvecfree(vals); return CL5_DB_ERROR; }
diff --git a/ldap/servers/plugins/replication/urp.c b/ldap/servers/plugins/replication/urp.c index 9534c03..d4556d7 100644 --- a/ldap/servers/plugins/replication/urp.c +++ b/ldap/servers/plugins/replication/urp.c @@ -861,7 +861,7 @@ urp_fixup_add_cenotaph (Slapi_PBlock *pb, char *sessionid, CSN *opcsn) Slapi_Entry *pre_entry = NULL; int ret = 0; Slapi_DN *pre_sdn = NULL; - Slapi_RDN *rdn = slapi_rdn_new(); + Slapi_RDN *rdn = NULL; char *parentdn = NULL; char *newdn; const char *entrydn; @@ -882,6 +882,7 @@ urp_fixup_add_cenotaph (Slapi_PBlock *pb, char *sessionid, CSN *opcsn) entrydn = slapi_entry_get_ndn (pre_entry);*/ uniqueid = slapi_entry_get_uniqueid (pre_entry); parentdn = slapi_dn_parent(entrydn); + rdn = slapi_rdn_new(); slapi_sdn_get_rdn(pre_sdn, rdn); slapi_rdn_remove_attr (rdn, SLAPI_ATTR_UNIQUEID ); slapi_rdn_add(rdn, "cenotaphID", uniqueid);
389-commits@lists.fedoraproject.org