ldap/servers/slapd/dl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 2674f5594a2eb088be34728c12c1169df36b1588
Author: Ludwig Krispenz <lkrispen(a)redhat.com>
Date: Tue Sep 22 17:51:35 2015 +0200
Ticket 48283 - many attrlist_replace errors in connection with cleanallruv
Bug Description: attrlist_replace error messages are logged because the
list of values contains duplicate attributes
Fix Description: the duplicate values can appear because when a replica
is removed from the ruv the array is compacted, but
memcpy is used instead of memmove
https://fedorahosted.org/389/ticket/48283
Reviewed by: Rich, Thanks
diff --git a/ldap/servers/slapd/dl.c b/ldap/servers/slapd/dl.c
index 8233519..c6858f3 100644
--- a/ldap/servers/slapd/dl.c
+++ b/ldap/servers/slapd/dl.c
@@ -219,7 +219,7 @@ void *dl_delete (DataList *dl, const void *element, CMPFN cmpfn,
FREEFN freefn)
if (i != dl->element_count - 1)
{
- memcpy (&dl->elements[i], &dl->elements[i+1], (dl->element_count - i
- 1) * sizeof (void*));
+ memmove (&dl->elements[i], &dl->elements[i+1], (dl->element_count -
i - 1) * sizeof (void*));
}
dl->element_count --;