[lib389] branch master updated (2da3366 -> 0fe0ea9)

[git repository hosting]

This is an automated email from the git hooks/post-receive script.

firstyear pushed a change to branch master
in repository lib389.

      from  2da3366   Issue 25 - Fix RUV __repr__ function
       new  0fe0ea9   Issue 24 - Join paths using os.path.join instead of string
concatenation

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 lib389/mit_krb5.py | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.

[lib389] 01/01: Issue 24 - Join paths using os.path.join instead of string concatenation

[git repository hosting]

This is an automated email from the git hooks/post-receive script.

firstyear pushed a commit to branch master
in repository lib389.

commit 0fe0ea908f9c293a20d8cb6e264952efb78b03c4
Author: Ilias Stamatis <stamatis.iliass(a)gmail.com&gt;
Date:   Wed Apr 26 02:19:53 2017 +0300

    Issue 24 - Join paths using os.path.join instead of string concatenation
    
    https://pagure.io/lib389/issue/24
    
    Author: Ilias95
    
    Review by: wibrown (Thanks Ilias!)
---
 lib389/mit_krb5.py | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/lib389/mit_krb5.py b/lib389/mit_krb5.py
index d5d5a8e..64ca24d 100644
--- a/lib389/mit_krb5.py
+++ b/lib389/mit_krb5.py
@@ -35,16 +35,15 @@ class MitKrb5(object):
         self.realm = realm.upper()
         # For the future if we have a non-os krb install.
         self.krb_prefix = ""
-        # Probably should be using os.path.join ...
-        self.kadmin = "%s/usr/sbin/kadmin.local" % self.krb_prefix
-        self.kdb5_util = "%s/usr/sbin/kdb5_util" % self.krb_prefix
-        self.krb5kdc = "%s/usr/sbin/krb5kdc" % self.krb_prefix
-        self.kdcconf = "%s/var/kerberos/krb5kdc/kdc.conf" % self.krb_prefix
-        self.kdcpid = "%s/var/run/krb5kdc.pid" % self.krb_prefix
-        self.krb5conf = "%s/etc/krb5.conf" % (self.krb_prefix)
-        self.krb5confrealm = ("%s/etc/krb5.conf.d/%s" %
-                              (self.krb_prefix,
-                               self.realm.lower().replace('.', '-')))
+        sep = os.path.sep
+        self.kadmin = os.path.join(sep, self.krb_prefix,
"usr/sbin/kadmin.local")
+        self.kdb5_util = os.path.join(sep, self.krb_prefix,
"usr/sbin/kdb5_util")
+        self.krb5kdc = os.path.join(sep, self.krb_prefix, "usr/sbin/krb5kdc")
+        self.kdcconf = os.path.join(sep, self.krb_prefix,
"var/kerberos/krb5kdc/kdc.conf")
+        self.kdcpid = os.path.join(sep, self.krb_prefix,
"var/run/krb5kdc.pid")
+        self.krb5conf = os.path.join(sep, self.krb_prefix, "etc/krb5.conf")
+        self.krb5confrealm = os.path.join(sep, self.krb_prefix,
"etc/krb5.conf.d",
+                                          self.realm.lower().replace('.',
'-'))
 
         self.krb_master_password = password_generate()
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.